Commit Graph

28373 Commits

Author SHA1 Message Date
Christopher Lam
d8ece96503 [gnc-engine-guile.cpp] plug runaway GSList* leak
The QofQuery param_list is a GSList of const char*. Every SCM Query
would typically leak the GSList. This change will store the params
into the string cache, and the cached string is passed onto the
QofQuery param.
2023-11-30 22:16:53 +08:00
Christopher Lam
ca3c09c5f6 [dialog-report-column-view.cpp] new/delete instead of g_new/g_free
because the struct has vector objects which would otherwise leak.
2023-11-27 22:02:03 +08:00
Christopher Lam
3863d6e8dc [engine-common.i] AccountList* arg must be g_list_freed
when used by gnc_accounts_and_all_descendants
2023-11-27 21:05:06 +08:00
John Ralls
92de074e49 Bug 799144 - Date Completion is broken after 5.4 upgrade
strptime will reasonable return false for an incomplete date but it
still fills in the parts of the struct tm that it understands, so bail
out of qof_scan_date_internal when it fails only if all three fields
are present.
2023-11-26 09:23:58 -08:00
John Ralls
c07e0890f2 Merge Jerry James's python-regex-raw into stable. 2023-11-25 16:35:57 -08:00
John Ralls
1d8c525afc Bug 799138 - Port to new Python C config API 2023-11-24 14:52:07 -08:00
John Ralls
ed4921271c Bug 799134 - Fails to build with GCC 14 (‘find_if’ is not a member...
of ‘std’; did you mean ‘find’)
2023-11-21 15:27:04 -08:00
Robert Fewell
46e47d44a0 Rename the scheduled edit/new/delete menus
There is a conflict when updating the tooltip menu entries for the
scheduled transaction 'edit' menu. To find the appropriate menu entry,
the list of menu entries is searched by name and this entry conflicts
with the main 'edit' menu which has no tooltip and so the scheduled
'edit' menu entry does not get the correct tooltip.

To fix this just change the entries to 'Edit Schedule'/'New Schedule'
and 'Delete Schedule', this also changes them to the same format as the
account menu options.
2023-11-20 09:51:24 +00:00
Robert Fewell
6315098723 Make it clearer for which SX's will be deleted
Add the SX names that will be deleted below the confirmation dialogue
question.
2023-11-20 09:51:24 +00:00
Robert Fewell
ceb21790b4 Bug 799090 - Right Clicking scheduled transaction
If you have a highlighted SX and you right click on another SX the new,
edit, delete popup uses the highlighted SX not the one you clicked on.
This is misleading because the box appears at the right clicked
location, and it looks like that is the SX it will affect.

To fix this, check to see if SX right clicked on is selected, if not
unselect all SX's and select the one clicked on before popup.
2023-11-20 09:51:24 +00:00
Robert Fewell
af48ab7cc2 Bug 798025 - SLR Value entry not tied to location
When you enter a value in the SLR tree view, the cell renderer text
entry box gets the focus ready for keyboard entry. In this state, the
tree view can be scrolled underneath by the mouse wheel or using the
vertical scrollbar, the row is still high lighted but still may be
confusing.

This commit disables the scrolling while an entry has focus and also
disables the horizontal scroll bar to be more effective.
2023-11-20 09:25:16 +00:00
Robert Fewell
78ab605e91 Bug 798760 - SLR change reminder with value entry
If the scheduled transaction state is 'Reminder' and also requires
values which have been entered but the state has not been changed to
'To Create' the values are lost when OK button pressed.

This change adds a check of state to the 'variable_value_changed_cb'
and if 'Reminder' changes it to 'To Create'.
2023-11-20 09:25:16 +00:00
Robert Fewell
5b8d29a7d0 Bug 798760 - SLR OK button to complete value entry
When in the SLR dialog and you are adding a value to a scheduled
transaction, if you do not complete the entry with a tab or enter but
press the 'OK' button the value changes back to 'Need Value'.

This change also completes the entry with the 'OK' button and will move
to the next value to be entered or if none complete the dialog.
2023-11-20 09:25:16 +00:00
Robert Fewell
16c1244a63 Bug 607000 - SLR visible transactions
Change the Since Last Run dialog to show only transactions with a
non-empty Status.
2023-11-20 09:25:16 +00:00
Robert Fewell
71feea06a9 Allow saving the sorting in the SLR 2023-11-20 09:25:16 +00:00
Robert Fewell
3deb49402c Bug 792241 - Allow sorting scheduled transactions
Allow sorting in the SLR by date and by status.
2023-11-20 09:25:16 +00:00
Jerry James
a967e05cce
Mark 2 regular expressions as raw strings 2023-11-18 21:52:14 -07:00
Frank H. Ellenberger
b032197395 Revert "Translation update by Petter Reinholdtsen
<pere-weblate@hungry.com> using Weblate"

This reverts commit c3799d3f48.
The only content change is wrong.
2023-11-19 05:43:01 +01:00
Szia Tomi
0f62da2244
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/glossary/hu.po: 100.0% (212 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/glossary/hu.po: 100.0% (212 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2023-11-19 00:02:00 +00:00
Petter Reinholdtsen
c3799d3f48
Translation update by Petter Reinholdtsen <pere-weblate@hungry.com> using Weblate
po/nb.po: 86.7% (4800 of 5532 strings; 725 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Norwegian Bokmål)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/nb_NO/

Co-authored-by: Petter Reinholdtsen <pere-weblate@hungry.com>
2023-11-19 00:01:58 +00:00
Christopher Lam
1d26d99ddb [gnc-budget] use std::optional<gnc_numeric> instead of bool+gnc_numeric
more expressive
2023-11-18 08:59:32 +08:00
John Ralls
2db3a6bad9 Use csv_price_imp_preview_sep_button_cb only as a callback.
Its error handling doesn't make sense in other contexts.
2023-11-17 09:00:48 -08:00
John Ralls
102304b38b Bug 799121 - Parse error on CSV import on MacOS
Use csv_tximp_preview_sep_button_cb solely as a callback, its error
handling doesn't make sense otherwise. All we want at the end of
preview_refresh is to attempt a tokenize.

In addition to not going into an infinite loop with the message box
this presents a more helpful message suggesting that the encoding is
wrong.
2023-11-16 20:30:20 -08:00
derxi
8d993e7332
Translation update by derxi <happycxin@163.com> using Weblate
po/zh_CN.po: 99.1% (5486 of 5532 strings; 42 fuzzy)
16 failing checks (0.2%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: derxi <happycxin@163.com>
2023-11-16 09:03:56 +01:00
Zdenko Podobný
eaa8a37b9d
Translation update by Zdenko Podobný <zdenop@gmail.com> using Weblate
po/sk.po: 90.1% (4986 of 5532 strings; 122 fuzzy)
27 failing checks (0.4%)
Translation: GnuCash/Program (Slovak)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/sk/

Co-authored-by: Zdenko Podobný <zdenop@gmail.com>
2023-11-15 21:03:47 +00:00
hades
e299d5eb1d
Translation update by hades <dev@hades.name> using Weblate
po/glossary/ru.po: 92.9% (197 of 212 strings; 7 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Russian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/ru/

Translation update  by hades <dev@hades.name> using Weblate

po/ru.po: 71.6% (3963 of 5532 strings; 1052 fuzzy)
318 failing checks (5.7%)
Translation: GnuCash/Program (Russian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ru/

Co-authored-by: hades <dev@hades.name>
2023-11-15 21:03:45 +00:00
Robert Fewell
8466efc06d Change default column for SX list tree view
As the tree view is based on the GNC_TREE_VIEW, if the pref_name of a
column is "name" it should also be the default sort column. This is
because the default column for GNC_TREE_VIEW is "name" and when saving
state information, 'gnc_tree_view_save_state' will only save non
default values where possible.

In this case if the name column is selected to be default, no entries
are saved in the gcm file and hence the on next load 'next occurrence'
will be used as the default.
2023-11-15 10:12:20 +00:00
Robert Fewell
5df19f4985 Realign source files gnc-tree-view-sx-list.* 2023-11-15 10:10:14 +00:00
Robert Fewell
631ac2b371 Realign source files gnc-sx-list-tree-model-adapter.* 2023-11-15 10:09:15 +00:00
Milo Ivir
c4ccde69c8
Translation update by Milo Ivir <mail@milotype.de> using Weblate
po/hr.po: 97.1% (5372 of 5532 strings; 61 fuzzy)
2 failing checks (0.1%)
Translation: GnuCash/Program (Croatian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hr/

Translation update  by Milo Ivir <mail@milotype.de> using Weblate

po/hr.po: 97.0% (5371 of 5532 strings; 61 fuzzy)
2 failing checks (0.1%)
Translation: GnuCash/Program (Croatian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hr/

Co-authored-by: Milo Ivir <mail@milotype.de>
2023-11-12 20:17:17 +01:00
John Ralls
6be12c57cd Qif Import assistant: Extract function mark_page_complete
and remove unnecessary calls to gtk_assistant_update_buttons_state
because gtk_assistant_set_page_complete does that.
2023-11-12 11:15:56 -08:00
John Ralls
b7f231030f Qif import assistant: Use Enter and Leave macros
Instead of "Visibility Page" and "Builder Page" which don't
communicate well what function is running.
2023-11-12 11:15:56 -08:00
John Ralls
dcb24a2460 Bug 799113 - "Start Import" button reports "Failed"
Because acting on the date format selection was in the skipped
gnc_ui_qif_import_account_prepare. Move the action to
gnc_ui_qif_import_date_valid_cb so that it's done every time the date
format page is visited.
2023-11-12 11:15:56 -08:00
Christopher Lam
fdcb8b46bd [sixtp-dom-generators.cpp] char* must be freed 2023-11-11 12:45:57 +08:00
Christopher Lam
8f7eecd3e9 Merge branch 'icu-list-formatter' into stable #1791 2023-11-10 18:58:35 +08:00
Christopher Lam
ae58c12601 [import-main-matcher] don't quote account fullnames 2023-11-10 18:57:03 +08:00
John Ralls
e6a30f7708 Merge Mark Browning's 'check-print-subacct' into stable. 2023-11-09 13:57:06 -08:00
hades
0650f56e96
Translation update by hades <dev@hades.name> using Weblate
po/ru.po: 71.5% (3959 of 5532 strings; 1056 fuzzy)
318 failing checks (5.7%)
Translation: GnuCash/Program (Russian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ru/

Co-authored-by: hades <dev@hades.name>
2023-11-07 22:56:01 +01:00
Pedro Albuquerque
575d5fc992
Translation update by Pedro Albuquerque <pmra@gmx.com> using Weblate
po/glossary/pt.po: 100.0% (212 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Portuguese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/pt/

Co-authored-by: Pedro Albuquerque <pmra@gmx.com>
2023-11-07 22:56:01 +01:00
Christopher Lam
b450d9a637 [gnc-plugin-page-report] re-enable actions after disabling
Otherwise Print, PDFExport, Report Options remain disabled after
modifying report options. Also restore nullptr sentinel in
disable_during_load_actions array.
2023-11-08 05:53:50 +08:00
Mark Browning
c2ef684b59 Correct check amount when printed from subaccount
Previously, GnuCash would include only a single split's amount as the check
amount. If a "bank" account has multiple subaccounts for budgeting reasons, and
a transaction involves both "internal" (e.g. from one bank subaccount to
another bank subaccount) and external transfers, then even when a "subaccount"
register showing the top-level bank account is printed from, the check will
have the amount of the first split rather than the total of all splits which
are from subaccounts.

This change communicates the parent account (when viewed from a "subccount"
register) to the check printing dialog so that the check amount matches the
amount displayed in the register.
2023-11-06 21:52:49 -06:00
Christopher Lam
9e47c297ba Merge branch 'plug-recurrence-to-string' into stable #1812 2023-11-07 06:28:39 +08:00
John Ralls
4da655d0f9 Merge Adam Wight's 'mem-fix' into stable. 2023-11-06 12:33:41 -08:00
John Ralls
4e937f55c5 Merge Hades's 'patch-1' into stable. 2023-11-06 12:20:59 -08:00
hades
e183d1d858
add a tip on keyboard shortcuts 2023-11-06 17:16:04 +01:00
hades
da6f20ddab
Translation update by hades <dev@hades.name> using Weblate
po/ru.po: 71.5% (3959 of 5532 strings; 1056 fuzzy)
318 failing checks (5.7%)
Translation: GnuCash/Program (Russian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ru/

Co-authored-by: hades <dev@hades.name>
2023-11-06 11:34:18 +01:00
Christopher Lam
12f4233396 recurrencePeriodTypeToString and recurrenceWeekendAdjustToString g_strdup only when necessary
... for sql use only. xml use assumes they return a const char*.
2023-11-06 17:37:17 +08:00
Adam Wight
fbc183a544 Always return an allocated gchar*
Returning the literal string will cause the caller to free unallocated
memory.
2023-11-05 23:58:01 +01:00
hades
4b6a9b8560
Translation update by hades <dev@hades.name> using Weblate
po/glossary/ru.po: 89.6% (190 of 212 strings; 12 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Russian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/ru/

Co-authored-by: hades <dev@hades.name>
2023-11-05 15:32:52 +01:00
mocsa
5937b5d542
Translation update by mocsa <csaba@feltoltve.hu> using Weblate
po/hu.po: 69.9% (3870 of 5532 strings; 599 fuzzy)
3 failing checks (0.1%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: mocsa <csaba@feltoltve.hu>
2023-11-04 19:34:42 +00:00