Ashley Harrison
11bc66a0e8
Chore: use React.PropsWithChildren to explicitly define the children prop ( #64433 )
...
* use React.PropsWithChildren to explicitly define the children prop
* fix ThemeDemo as well
* provide empty generics
2023-03-08 16:12:54 +00:00
Ashley Harrison
986a1c2a1b
Chore: group uLibrary updates in renovate, revert uplot update for now ( #64386 )
...
* group uLibrary updates in renovate, revert uplot update for now
* fix json
2023-03-08 11:48:51 +00:00
Ashley Harrison
0c0d63b830
Build: enable caching in eslint plugin ( #64325 )
...
enable caching in eslint plugin
2023-03-07 14:53:50 +00:00
Ashley Harrison
5b8c2f494d
Chore: convert VariableOptions to use emotion instead of scss ( #64135 )
...
convert VariableOptions to use emotion instead of scss
2023-03-07 11:13:57 +00:00
Ashley Harrison
d61bcdf4ca
Chore: Pass signed user_hash to Intercom via Rudderstack ( #63921 )
...
* move analytics identifiers to backend
* implement hash function
* grab secret from env
* expose and retrieve intercom secret from config
* concat email with appUrl to ensure uniqueness
* revert to just using email
* Revert "revert to just using email"
This reverts commit 8f10f9b1bc .
* add docstring
2023-03-03 14:39:53 +00:00
Ashley Harrison
4f01d55a3c
Profile: Fix session table overflowing page layout in mobile ( #63858 )
...
handle table overflowing in mobile layout
2023-03-01 17:08:04 +00:00
Ashley Harrison
a534119c44
Command Palette: Sign out link now works correctly ( #63742 )
...
* pass target to command palette urls so sign out link works correctly
* improve types
2023-03-01 15:59:32 +00:00
Ashley Harrison
8e9ccfc66e
Navigation: Fix broken layout at 544px ( #63793 )
...
* ensure media queries transition properly
* fix unit tests
2023-03-01 15:31:32 +00:00
Ashley Harrison
27635e6f7b
Command Palette: Display dashboard location ( #63807 )
...
* show folder for dashboard, adjust how ancestors are displayed, clamp to single line
* fix keys
* better responsiveness
* use subtitle consistently
* use span instead of div
2023-03-01 09:46:46 +00:00
Ashley Harrison
19d1a46f30
A11y: remove onClick from collapsed text ( #62495 )
...
remove onClick from collapsedText
2023-02-24 10:36:04 +00:00
Ashley Harrison
a48793b542
Accessibility: Make row actions keyboard accessible ( #63367 )
...
make row actions keyboard accessible
2023-02-23 15:20:59 +00:00
Ashley Harrison
f6e92da402
Navigation: Add plugin upgrade guide to docs ( #63449 )
...
* initial attempt at plugin upgrade guide
* fix link
* small tweaks based on feedback
* add basic skeleton for tabs documentation
2023-02-23 10:12:35 +00:00
Ashley Harrison
4a2695349d
Chore: more ts test fixes ( #63438 )
...
* replace anys in tests
* more test fixes
* clean up any's in tests
2023-02-23 10:07:44 +00:00
Ashley Harrison
bcaf4dc0b1
TimeRangeInput: Fix positioning of dropdown menu ( #63472 )
...
fix TimeRangeInput positioning
2023-02-23 09:53:32 +00:00
Ashley Harrison
f8d89eff56
Chore: fix type errors in tests ( #63270 )
...
* fix any's in tests
* fix more any's in tests
* more test type fixes
* fixing any's in tests part 3
* more test type fixes
* fixing test any's p5
* some tidy up
* fix template_srv
2023-02-14 16:46:42 +01:00
Ashley Harrison
36c090416a
Command palette: Enable folder searching ( #62663 )
...
search folders as well as dashboards in the command palette
2023-02-09 16:31:05 +00:00
Ashley Harrison
2a34293689
Chore: more type fixes ( #62952 )
...
* fix some more any/type assertions
* more any/type assertion fixes
* implement review comments
2023-02-09 09:03:13 +00:00
Ashley Harrison
fc2f7f90f8
Navigation: add a link to starred dashboards in the megamenu ( #62685 )
...
add a link to starred dashboards in the megamenu
2023-02-08 15:18:13 +00:00
Ashley Harrison
4181acec72
A11y: ignore rule since there's a button handling keyboard interaction ( #62856 )
...
ignore a11y rule since there's a button handling keyboard interaction
2023-02-08 14:29:30 +00:00
Ashley Harrison
6a720f96f7
A11y: ignore rule since keyboard interaction is already handled ( #62850 )
...
* Revert "Accessibility: Remove unnecessary onClick from title element (#59696 )"
This reverts commit f19b07c0bc .
* ignore eslint rule
2023-02-08 14:17:15 +00:00
Ashley Harrison
3a8f2bb726
Chore: ignore a11y rule since there's a button handling keyboard interaction ( #62853 )
...
ignore a11y rules since there's a button handling keyboard interaction anyway
2023-02-07 09:25:25 +00:00
Ashley Harrison
c819e95687
Navigation: move Connections plugin to be just after apps ( #62801 )
...
move connections plugin to be just after apps
2023-02-03 13:48:06 +00:00
Ashley Harrison
5795553353
Navigation: Fix command palette toggle removal ( #62809 )
...
command palette is always here
2023-02-02 16:32:34 +00:00
Ashley Harrison
5e7e026c0c
Navigation: Remove commandPalette feature toggle ( #62698 )
...
* remove command palette feature toggle
* undo irrelevant AppChrome changes
* update toggle description
2023-02-02 14:44:21 +00:00
Ashley Harrison
0a780d978e
Navigation: wrap dashboard settings actions in ToolbarButtonRow for responsiveness ( #62475 )
...
wrap dashboard actions in toolbarbuttonrow for responsiveness
2023-02-01 15:08:09 +00:00
Ashley Harrison
8d7e7693f2
Command palette: section styling tweaks ( #62671 )
...
section styling tweaks
2023-02-01 13:04:38 +00:00
Ashley Harrison
b6aedaa57d
Chore: improve some types ( #62363 )
...
* improve some types
* more tidy up
* better error message handling + update tests
* undo store changes
2023-02-01 10:50:34 +00:00
Ashley Harrison
029253d5f6
Navigation: add event tracking for dashboard save as events ( #62568 )
...
* add event tracking for dashboard save as events
* emit a grafana_dashboard_copied event instead
2023-01-31 13:54:24 +00:00
Ashley Harrison
77a186879d
Navigation: add event tracking for navigation elements ( #62563 )
...
add user tracking for navigation elements
2023-01-31 13:03:31 +00:00
Ashley Harrison
fd2641a542
Navigation: Sign in button now works correctly when served under a sub path ( #62504 )
...
make sure getUrlForPartial always includes the basePath + unit tests
2023-01-31 09:27:40 +00:00
Ashley Harrison
14dd1be244
Chore: update copy-webpack-plugin and remove from renovate ignore list ( #62459 )
...
update copy-webpack-plugin and remove from renovate ignore list
2023-01-30 16:01:44 +00:00
Ashley Harrison
f19b07c0bc
Accessibility: Remove unnecessary onClick from title element ( #59696 )
...
* remove unnecessary onClick from title element
* associate icon label with title + fix unit tests
* remove cursor: pointer;
* remove link color from title as it's no longer clickable
* remove useless aria-label
* stop incorrectly marking title as a ReactNode - it's just a string
2023-01-30 13:32:16 +00:00
Ashley Harrison
d9d103a2bf
Chore: remove node-fetch from dep + ignore list ( #62455 )
...
remove node-fetch from dep + ignore list
2023-01-30 11:47:32 +00:00
Ashley Harrison
1ef7cfda3f
Navigation: more command palette tweaks ( #62286 )
...
* update placeholder text, only create search keybindings if topNavCommandPalette is disabled
* make search input wider
2023-01-27 16:21:48 +00:00
Ashley Harrison
a344c88a01
Chore: don't create the npm-artifacts dir since yarn packages:pack does this… ( #62246 )
...
* don't create the npm-artifacts dir since yarn packages:pack does this already
* fix an any to trigger a canary build
2023-01-26 16:41:08 +00:00
Ashley Harrison
f7d92ab841
Navigation: only show the img for a section root if both img and icon are present ( #62127 )
...
only show an img for a section root if both img and icon are present
2023-01-26 12:07:43 +00:00
Ashley Harrison and joshhunt
a77c342764
Navigation: Add keyboard shortcut to search input ( #62116 )
...
* Show shortcut
* add icon to search bar, make same changes in search modal
* rename to modKey
Co-authored-by: joshhunt <josh@trtr.co >
2023-01-26 12:07:32 +00:00
Ashley Harrison
64352e8d08
Chore: Move to node 18 again ( #62079 )
...
move to node 18 again
2023-01-26 10:19:39 +00:00
Ashley Harrison
a3b396854a
Navigation: Command palette topnav tweaks ( #61991 )
...
stylings tweaks to command palette
2023-01-26 10:03:16 +00:00
Ashley Harrison
e6e560e3ed
Dropdown: Make escape close a dropdown ( #62098 )
...
* make escape close a dropdown
* make tab close the dropdown
2023-01-26 09:23:53 +00:00
Ashley Harrison
92a750a732
Chore: convert last test to RTL and remove Enzyme references ( #61918 )
...
convert last test to RTL and remove enzyme references
2023-01-24 09:20:47 +00:00
Ashley Harrison
6b53f927b2
Navigation: truncate landing page descriptions to 3 lines ( #61925 )
...
* truncate landing page descriptions to 3 lines
* use correct css prop names
2023-01-23 17:07:36 +00:00
Ashley Harrison
253f9657cb
Navigation: Change collapse icon + behaviour ( #61496 )
...
* adjust positioning and switch icon
* hide collapse button unless collapsed/focused
* use Button instead of IconButton
2023-01-23 09:30:28 +00:00
Ashley Harrison
a26bae45e1
Navigation: clean up colors in section nav ( #61240 )
...
* clean up colors in section nav
* just underline on hover/focus
2023-01-23 09:26:26 +00:00
Ashley Harrison
da969e7d48
Command Palette: don't register dashboards as actions in the command palette ( #61271 )
...
* don't register dashboards as actions in the command palette
* create ActionImpls in RenderResults, memoize some array creation
* extract dashboard results out into separate hook
* remove unnecessary memoization from useActions
* move useDashboardResults into dashboardActions
2023-01-13 11:41:23 +00:00
Ashley Harrison
4e00fbbd7f
Navigation: Allow overriding icons in nav settings ( #61160 )
...
expose k6 icon, allow overriding icon in nav settings, override connections + k6
2023-01-10 10:29:07 +00:00
Ashley Harrison and Michael Mandrus
a9e39a108c
RelativeTimeRangePicker: correctly trap focus in overlay ( #60984 )
...
* correctly trap focus in relativetimerangepicker overlay
* add underlay
Co-authored-by: Michael Mandrus <michael.mandrus@grafana.com >
2023-01-05 11:35:47 +00:00
Ashley Harrison
ebb34560a4
Navigation: use "Home" instead of "Grafana" as the default Breadcrumb text ( #60973 )
...
* use Home instead of Grafana as the default Breadcrumb text
* use translated text
2023-01-04 15:02:30 +00:00
Ashley Harrison
7005b7bf8a
Navigation: Update e2e tests to work with topnav ( #60910 )
...
* turn on topnav toggle in e2e tests
* fix variable e2e tests
* fix remaining tests + remove some hardcoded waits
* speculative fixes
* wait for error to disappear
* use new selector, turn toggle back off
2023-01-04 14:59:53 +00:00
Ashley Harrison
8149efc729
Chore: group visx updates together ( #60895 )
...
group visx updates together
2023-01-04 14:32:57 +00:00
Ashley Harrison
a16ca209fb
Segment: Individual segments are now keyboard accessible ( #60555 )
...
use <button> for keyboard accessibility
2022-12-21 17:26:18 +00:00
Ashley Harrison
44232569a8
ToolbarButtonRow: Overflow button now toggles visibility correctly ( #60635 )
...
* only close the overlay if we're interacting with something other than the overflow button/the overlay itself
* use a ref instead of a test id
2022-12-21 15:01:39 +00:00
Ashley Harrison
78e12b140e
TimePicker accessibility: remove stopPropagation from everywhere ( #60404 )
...
* remove stopPropagation from everywhere
* improve keyboard a11y in DateTimePicker
2022-12-21 13:04:47 +00:00
Ashley Harrison
793a3f8d32
Accessibility: clean up VisualizationSuggestions ( #60557 )
...
clean up VisualizationSuggestions
2022-12-21 10:40:25 +00:00
Ashley Harrison and Zoltán Bedi
ba6d2f2a82
Chore: improve some more types ( #60476 )
...
* improve some more types
* fixes
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com >
2022-12-20 13:07:57 +00:00
Ashley Harrison
9b21375d78
Chore: remove @storybook/addon-knobs package ( #60524 )
...
remove @storybook/addon-knobs package
2022-12-19 15:35:32 +00:00
Ashley Harrison
bc3d1fdd2a
Command Palette: Correctly clear button styles when changing theme ( #60511 )
...
add topnav feature toggle to new theme created when using 'c t'
2022-12-19 10:59:28 +00:00
Ashley Harrison
3c399ed943
Accessibility: Render gauge as a button when onClick is provided ( #60396 )
...
render gauge as a button when onClick is provided
2022-12-19 09:40:45 +00:00
Ashley Harrison
9bbc2c4cbb
Chore: fix some typings in @grafana/data ( #60009 )
...
fix some typings in @grafana/data
2022-12-16 09:59:00 +00:00
Ashley Harrison
b2da0d22af
Navigation: show section toggle if there are any react children ( #60336 )
...
show section toggle if there are children
2022-12-15 12:41:46 +00:00
Ashley Harrison
3a5c3b517c
Navigation: conditionally use actions in DataSourceListPage ( #60300 )
...
* conditionally use actions in DataSourceListPage
* fix unit tests
2022-12-14 13:19:29 +00:00
Ashley Harrison
bb2ecb1468
Influx: Query segment menus now position correctly near the bottom of the screen ( #60087 )
...
* only open the menu once options are loaded for better positioning
* use !loadState.loading instead of Boolean(loadState.value)
2022-12-14 09:51:04 +00:00
Ashley Harrison
535c4576f7
Command Palette: Fix not being able to type if triggered whilst another modal is open ( #59728 )
...
handle command palette in the same way as other modals
2022-12-13 14:44:32 +00:00
Ashley Harrison
c801f030fb
Navigation: use the branding menu logo in topnav ( #60227 )
...
use the branding menu logo in topnav
2022-12-13 14:44:18 +00:00
Ashley Harrison
4e7a316903
TimePicker: Fix time picker selection ( #60104 )
...
fix time picker selection
2022-12-13 14:11:15 +00:00
Ashley Harrison
75a11e92b2
Dropdown: Menu now closes correctly when selecting options on touch devices ( #60181 )
...
update the version of react-popper-tooltip in @grafana/ui
2022-12-13 13:23:46 +00:00
Ashley Harrison
39a4ba4396
Navigation: Fix some missing pages in admin section ( #60143 )
...
* add stats and licensing under admin -> general when topnav is enabled
* add ldap to users and access
* use ID instead of Id
* add enterprise licensing node
2022-12-12 15:23:49 +00:00
Ashley Harrison
8e77a42741
Chore: run toggles_gen_test.go to fix backend test ( #60164 )
...
run toggles_gen_test.go
2022-12-12 14:33:46 +00:00
Ashley Harrison
a09d9d68a8
Chore: fix glob pattern in renovate config ( #60146 )
...
fix glob pattern
2022-12-12 14:19:14 +00:00
Ashley Harrison
97fa63d14d
TimeZonePicker: Scroll menu correctly when using keyboard controls ( #60008 )
...
pass innerRef to TimeZoneOption so the menu scrolls properly
2022-12-12 12:30:02 +00:00
Ashley Harrison
1497ad4760
TimePicker: Prevent TimePicker overflowing viewport on small screens ( #59808 )
...
* render timepicker in a modal style on small screens
* remove top: -1
* apply styles
* prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded
* Revert "prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded"
This reverts commit 7090443c12 .
2022-12-09 15:02:26 +00:00
Ashley Harrison
a589929c92
Navigation: Prevent app crash when importing a dashboard with a uid of home ( #59874 )
...
* change home id to be more unique, refactor so that home circular reference is never created
* prefix starred dashboards
* update reducer
2022-12-09 12:54:00 +00:00
Ashley Harrison
0c9aed905a
Chore: normalize monaco colors to hex string ( #59784 )
...
normalize monaco colors to hex string
2022-12-09 10:07:32 +00:00
Ashley Harrison
c91c828c46
Renovate: use rebaseWhen: conflicted to try to speed up renovate runs ( #60028 )
2022-12-09 09:45:38 +00:00
Ashley Harrison
a3681a3353
Command Palette: Links now work when grafana is served under a subpath ( #60033 )
...
strip base when pushing urls to locationService
2022-12-08 15:00:07 +00:00
Ashley Harrison
5d0029c647
Navigation: handle case where navIndex is undefined ( #59826 )
...
handle case where navIndex is undefined
2022-12-07 10:16:55 +00:00
Ashley Harrison
2b3c86d201
Chore: Remove unused/deprecated @types definitions ( #59888 )
...
* remove @types/rc-tree, @types/classnames
* remove @types/rc-time-picker
* remove @types/reselect
* remove @types/testing-library__react-hooks
* only include known package.json's
2022-12-07 10:10:59 +00:00
Ashley Harrison
46adfb596d
Command Palette: Maintain page state when changing theme ( #59787 )
...
* use same function as the change theme keybindings
* rename toggleTheme service to just theme
2022-12-05 16:12:56 +00:00
Ashley Harrison
2ac235eaff
Chore: remove preloading roboto font ( #59664 )
...
remove preloading roboto font
2022-12-02 09:30:47 +00:00
Ashley Harrison
11a32bddbb
Accessibility: Add the correct role to the modal backdrop ( #59572 )
...
add the correct role to the modal backdrop
2022-12-02 09:30:30 +00:00
Ashley Harrison
94c5be8dfb
Navigation: Remember expanded sections in megamenu ( #59661 )
...
use local storage to remember which sections of megamenu are expanded
2022-12-01 16:04:36 +00:00
Ashley Harrison
dab83c6855
Theme: Use Inter font by default ( #59544 )
...
* Switch to using Inter font by default
* run toggles_gen_test
2022-12-01 11:59:37 +00:00
Ashley Harrison
a958b0be44
Accessibility: Use button instead of div in ColorPicker story ( #59581 )
...
use button instead of div in colorpicker story
2022-12-01 09:26:58 +00:00
Ashley Harrison
000de83eb4
Accessibility: Improve a11y in DataLinkSuggestions ( #59569 )
...
DataLinkSuggestions: Add role + ignore keyboard lint rule
2022-11-30 15:58:10 +00:00
Ashley Harrison
eaa4d19ed0
Navigation: Move k6 to top-level, rename to "Performance testing" ( #59481 )
...
Move k6 to top-level, rename to "Performance testing"
2022-11-30 10:27:41 +00:00
Ashley Harrison
191ca1df86
Chore: some type fixes ( #59030 )
...
some type fixes
2022-11-29 15:52:08 +00:00
Ashley Harrison
5e53582bb1
Navigation: change apps icon to differentiate from dashboards ( #59476 )
...
change apps icon to differentiate from dashboards
2022-11-29 12:02:58 +00:00
Ashley Harrison
5011b259c7
Chore: ignore eslint rules in Dropdown/TopNavBarMenu ( #59385 )
...
ignore eslint rules in dropdown/topnavbarmenu
2022-11-29 11:13:21 +00:00
Ashley Harrison
d33b4918cd
Chore: more any/type assertion improvements ( #59229 )
...
more any/type assertion improvements
2022-11-23 16:54:57 +00:00
Ashley Harrison
c2f31c2685
Navigation: always show GetStartedWithPlugin even if there's install control wa… ( #59127 )
...
always show `GetStartedWithPlugin` even if there's install control warnings
2022-11-23 11:34:00 +00:00
Ashley Harrison
8761a71da2
Navigation: use correct id to find cloud access policies page ( #59123 )
...
use correct id to find cloud access policies page
2022-11-23 10:01:57 +00:00
Ashley Harrison
824a562b03
Navigation: share logic between buildBreadcrumbs and usePageTitle ( #58819 )
...
* simplify usePageTitle logic a bit
* use buildBreadcrumbs logic in usePageTitle
* always add home item to navTree, fix some tests
* fix remaining unit tests
2022-11-22 16:48:07 +00:00
Ashley Harrison
26a7423151
Chore: add some unique keys to prevent warnings ( #59143 )
...
add some unique keys to prevent warnings
2022-11-22 16:42:21 +00:00
Ashley Harrison
6f26668a9f
Chore: Document theme toggle keybinding ( #59031 )
...
* make theme toggle keybinding dev only
* fix bug + add support for theme change keybinding
2022-11-22 14:01:51 +00:00
Ashley Harrison
19e97a1f31
Accessibility: Improve keyboard accessibility in Collapse ( #59022 )
...
fix keyboard accessibility in Collapse
2022-11-22 11:19:57 +00:00
Ashley Harrison
8aa74fe9ee
Accessibility: Improve keyboard accessibility of FilterPill ( #58976 )
...
fix keyboard a11y in FilterPill
2022-11-21 09:29:41 +00:00
Ashley Harrison
598935cb34
Accessibility: Improve keyboard accessibility in AnnoListPanel ( #58971 )
...
fix keyboard accessibility in AnnoListPanel
2022-11-21 09:25:56 +00:00
Ashley Harrison
e19957bbc8
Accessibility: Improve keyboard accessibility in GettingStarted panel ( #58966 )
...
fix keyboard a11y in `GettingStarted` panel
2022-11-18 15:29:50 +00:00
Ashley Harrison
5226a61f67
Navigation: Stop clearing search state when opening a result in a new tab ( #58880 )
...
search: only clear search state if not opening in a new tab
2022-11-18 14:17:59 +00:00
Ashley Harrison
d46e3916a1
Navigation: move connections + integrations to be a top level item ( #58902 )
...
* move connections + integrations to be a top level item
* add a test to check we can move apps to the root
* split out movePlugin logic into a separate function
* fix linting
* rename movePlugin -> addPluginToSection
2022-11-18 09:05:45 +00:00