Commit Graph
22077 Commits
Author SHA1 Message Date
Levente Balogh 17a3ec52b6 Plugin preloading: Fix performance measurement (#86855)
fix: measuring plugin preload performance
2024-04-24 15:37:22 +02:00
5dd8353ab1 Dashboards: Migrate from aria-label e2e selectors to data-testid (#78536)
* Dashboards: Migrate from aria-label e2e selectors to data-testid

* more changes

* addPanelwidget

* Test: Update .betterer.results

* refactor: fix e2e tests

* refactor: fix failing test

* refactor: update plugin-e2e after adding selector changes to the packege

---------

Co-authored-by: Laura Benz <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: Laura Benz <laura.benz@grafana.com>
2024-04-24 15:16:19 +02:00
Victor Marin 38917c4e79 Fix home breadcrumbs (#86786)
* fix home breadcrumbs

* fix homepage gap

* fix tests
2024-04-24 14:54:30 +03:00
Tobias Skarhed 3e450ec4bf Panel: Keyboard focus shortcuts prioritization (#86772)
* Panel: Keyboard shortcuts prio

* Remove redundant Array.from

* Simplify

* Handle Scenes use case
2024-04-24 13:46:40 +02:00
Jack WestbrookandLevente Balogh fd1bf66d86 Plugins: Selectively load plugins using script tags (#85750)
* feat(plugins): introduce logic to selectively load fe plugins via script tags

* feat(plugins): extend cache to store isAngular flag. use isAngular in shouldFetch

* revert(plugins): remove unused prepareImport from SystemJSWithLoaderHooks type

* fix(plugins): cache[path] maybe undefined if not registered or invalidated

* Update public/app/features/plugins/plugin_loader.ts

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>

---------

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
2024-04-24 12:27:28 +02:00
Esteban Beltran 1e1c62fef1 FE Sandbox: Get plugin module path from bootdata instead of plugin settings (#86702)
* FE Sandbox: Get plugin module path from bootdata instead of plugin settings

* Remove unnecessary async/await
2024-04-24 12:05:20 +02:00
Oscar Kilhed e7f40493e4 DashboardScene: Measure and report scene load time (#86267)
* measure scene load time

* Fix tests that fail due to performance not being the proper global performance object in jest

* add isScene parameter to tracking test
2024-04-24 11:45:32 +02:00
Piotr Jamróz f6e472f879 Explore: Show a drawer with tabs for the library and query history (#86279)
* Create basic feature toggle

* Rename context to reflect it contains query history and query library

* Update icons and variants

* Rename hooks

* Update tests

* Fix mock

* Add tracking

* Turn button into a toggle

* Make dropdown active as well

This is required to have better UI and an indication of selected state in split view

* Update Query Library icon

This is to make it consistent with the toolbar button

* Hide query history button when query library is available

This is to avoid confusing UX with 2 button triggering the drawer but with slightly different behavior

* Make the drawer bigger for query library

To avoid confusion for current users and test it internally a bit more it's behind a feature toggle. Bigger drawer may obstruct the view and add more friction in the UX.

* Fix tests

The test was failing because queryLibraryAvailable was set to true for tests. This change makes it more explicit what use case is being tested

* Remove active state underline from the dropdown

* Allow closing Query Library drawer from the toolbar

* Simplify dropdown design
2024-04-24 10:32:11 +02:00
Alexa V de589b98c7 Dashboard: Migration [Panel Edit] Missing Query Editor when datasource is not found (#86789)
* Return default datasource if datasource is not found

* Set query runner datasource state to default, else refreshing will not work
2024-04-24 10:21:01 +02:00
Sven Grossmann a8424f4831 LogContext: Fix structured metadata labels being added as stream selectors (#86825)
* LogContext: Fix structured metadata labels being added as stream selectors

* use row index
2024-04-24 10:00:39 +02:00
Marcus AnderssonandLevente Balogh 804c726413 PluginExtensions: Make the extensions registry reactive (#83085)
* feat: add a reactive extension registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: add hooks to work with the reactive registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: start using the reactive registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "command palette" extension point to use the hook

* feat: update the "alerting" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "explore" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "datasources config" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "panel menu" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "pyroscope datasource" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "user profile page" extension point to use the hooks

* chore: update betterer

* fix: update the hooks to not re-render unnecessarily

* chore: remove the old `createPluginExtensionRegistry` impementation

* chore: add "TODO" for `PanelMenuBehaviour` extension point

* feat: update the return value of the hooks to contain a `{ isLoading }` param

* tests: add more tests for the usePluginExtensions() hook

* fix: exclude the cloud-home-app from being non-awaited

* refactor: use uuidv4() for random ID generation (for the registry object)

* fix: linting issue

* feat: use the hooks for the new alerting extension point

* feat: use `useMemo()` for `AlertInstanceAction` extension point context

---------

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
2024-04-24 09:33:16 +02:00
Nathan MarrsandIhor Yeromin 5dea949433 Canvas: Match connection anchor points to elements (#85421)
Co-authored-by: Ihor Yeromin <yeryomin.igor@gmail.com>
2024-04-23 14:26:53 -07:00
Josh Hunt fc5007b0d5 Dashboards: Fix minor i18n papercuts that snuck through (#86802)
* fix two issues in dashboards i18n

* import

* fix another
2024-04-23 19:30:11 +01:00
Drew Slobodnjak 173ba73a8a Canvas: Ensure tangency for first segment (#86543) 2024-04-23 07:54:42 -07:00
Mihai Doarna 3dabc3ff5d SSO: filter out SAML from the SSO providers in UI (#86768)
* filter out saml from sso providers

* fix lint error
2024-04-23 16:55:01 +03:00
Torkel Ödegaard b28e6bc5d8 DashboardScene: Fixes issue with editing panels that uses instanceState (#86687)
* DashboardScene: Fixes issue with editing panels that uses instanceState

* Minor tweak

* Update

* Update
2024-04-23 15:25:16 +02:00
Sonia AguilarandGilles De Mey 68564b1940 Alerting: Gops labels integration (#85467)
* Show list of labels on the alert rule form in a more visual way, and use a modal for managing them

* fix test

* Fix more tests

* Show orange badge when no labels are selected

* Remove unused datasource property in LabelsField

* Remove unused div and add comment

* Use button instead of icon for editing labels

* Use subform for labels

* Move logic fetching labels from different places in a separate hook

* Fix tests

* remove unused getLabelInput const in test

* Add ellispis and tooltip for long labels and move labels list in modal to the bottom

* Use text instead of badge when no using labels

* Fix tests after adding ellipsis and tooltip to the labels

* simplify styles

* Fix fetching values from gops when new key is used

* Address pr review comments

* Address pr review comments part2

* Fix tag on rtkq

* Remove color for no labels selected text

* Disable already used keys in the labels sub form

* Fix typo

* use the UseFieldArrayRemove type from react-hook-form

* Update some styles and text in the labels modal

* Address some review comments (nits)

* Address review comments part1

* Move logic getting labels in useCombinedLabels hook

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2024-04-23 14:38:31 +02:00
Esteban Beltran 0ec9c3e01a FE Sandbox: Fix worker post message not handling proxy objects correctly (#86654)
* FE Sandbox: Fix worker post message not handling proxy objects correctly

* use expect error instead of ignore

* use assertion instead of ignore

* Fix formatting
2024-04-23 14:08:34 +02:00
Torkel Ödegaard 835b968b08 DashboardScene: Fixes deleting dirty dashboard (#86479)
* DashboardScene: Fixes deleting dirty dashboard

* refactor + unit test
2024-04-23 12:35:16 +02:00
Josh Hunt 467d4231f1 E2C: Remove ModalController from MigrationTokenPage (#86709)
* Remove ModalController from MigrationTokenPage

* Dont show modal or toast for error response

* better
2024-04-23 11:23:06 +01:00
Tom RatcliffeandAshley Harrison 08200bc533 Nav: Fix alerting links/special cases not selecting the right MegaMenu item (#85336)
* Render current MegaMenu link as `aria-current=page`

* Add overrides capability for mega menu links

* Pass pageNav into getActiveItem so we can use override capability

* Test MegaMenu special cases for starred & dashboards

* Test that overrides for megamenu util works correctly

* Alpha-sort megamenu overrides

* Refactor util for getting active item for megamenu

Update parameters to getActiveItem

Update tests for getActiveItem

* Fix test for starred dashboard and remove query param test

Query param case happens differently in real app and is fiddly to test here

* handle edge cases

* restore handling home page test

* fix dashboard settings

* handle starring properly

---------

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2024-04-23 11:04:53 +01:00
renovate[bot]andrenovate[bot] <29139614+renovate[bot]@users.noreply.github.com> 6c777519d8 Update dependency style-loader to v4 (#86749)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-23 09:08:46 +01:00
renovate[bot]andrenovate[bot] <29139614+renovate[bot]@users.noreply.github.com> 41617b174e Update dependency css-loader to v7 (#86711)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-23 07:28:32 +01:00
Oscar Kilhed dccad4e081 Dashboard scenes: fix textbox value only set to first character of default value (#86595)
Dashboard scene: fix textbox value only set to first character in default value
2024-04-23 06:52:26 +02:00
github-actions[bot]andgithub-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> 357276da01 I18n: Download translations from Crowdin (#86708)
New Crowdin translations by GitHub Action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-04-23 07:34:17 +03:00
Leon Sorokin 7754d0d4dc XYChart2: Remove common series name from tooltip items (#86739) 2024-04-23 05:24:39 +02:00
Ashley Harrison fc45b56d9d EmptyState: Apply call-to-action variant in core (#86448)
* apply empty state in a bunch of places

* fix unit tests

* put alert back on top

* add data-testids so e2e tests keep working

* remove info boxes

* fix annotations empty state alignment with new maxWidth
2024-04-22 17:01:24 +01:00
Misi 6ab9dcde8d LDAP: Fix listing all non-matching groups (#86682)
Fix getRowId in LdapUserGroups to list all non-matching groups
2024-04-22 15:34:16 +02:00
Oscar Kilhed 12771e49fc Dashboards: Check if dashboard.meta is undefined, if undefined handle redirect in dashboard scene. (#86674)
dashboard meta is not available if the dashboard response is a redirect
2024-04-22 15:02:40 +02:00
Alex Khomenko cad9e23e54 Login page: Fix button width (#86680)
* Fix login buttons width

* Login page: Fix button width

* Add todo
2024-04-22 15:31:11 +03:00
Konrad Lalik 7caa30bc2e Alerting: Add plugins extension point to alerting home page (#85725)
* Add basic extension point to alerting home page

* Remove home page scenes app. Improve plugins styles

* Remove unused code

* Fix home page rendering when no plugins registered

* Add row-based integrations component

* Add missing margins

* Rollback the Box component changes

* Remove unused import
2024-04-22 13:42:11 +02:00
Haris Rozajac a10dcf9661 Explore (bugfix): Expanded section state (#86594)
Fix
2024-04-22 12:47:05 +02:00
Konrad Lalik 1b930c341d Alerting: Fix max_alerts field handling (#86651)
Fix max_alerts field parsing
2024-04-22 12:25:04 +02:00
github-actions[bot]andgithub-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> cda0f53f7c I18n: Download translations from Crowdin (#86603)
New Crowdin translations by GitHub Action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-04-22 09:18:39 +00:00
Tobias Skarhed b399facf2c GeoMap: Pan and zoom keyboard support (#86573)
* Make GeoMap keyboards navigable

* Remove redundant interaction boolean

* Fix tabIndex error and set role to application

* Update docs
2024-04-22 10:53:32 +02:00
Andreas ChristouandAndrew Hackmann ec8dfc4dda CloudMonitoring: Correctly interpolate multi-valued template variables in PromQL queries (#86391)
* Interpolate promql queries appropriately

- Use pipes for multi-valued variables in PromQL queries
- Update tests

* Don't break betterer

* Another any

* Update public/app/plugins/datasource/cloud-monitoring/datasource.ts

Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com>

---------

Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com>
2024-04-19 22:07:15 +02:00
Andreas Christou 74ee675732 CloudMonitoring: Allow a custom group by value (#86288)
Allow a custom group by value
2024-04-19 20:56:12 +01:00
Andreas Christou d8a8db3750 CloudMonitoring: Ensure variables can be used in all variable queries (#86377)
* Allow specifying project when querying services

* Ensure metricType is interpolated
2024-04-19 20:52:39 +01:00
Jev Forsberg ad679c62c6 Docs: Update example docs for rename by regex (#86627)
* baldm0mma/update_regex/ update example docs

* baldm0mma/ push ts

* baldm0mma/update_regex with new exmaples

* baldm0mma/update_regex/ update images

* baldm0mma/regex_update/ update text
2024-04-19 21:04:54 +02:00
Santiago 9ed616a7b3 Alerting: Fix typo ('Alert manager' -> 'Alertmanager') (#86608)
* Alerting: Fix typo ('Alert manager' -> 'Alertmanager')

* fix front-end test
2024-04-19 20:53:51 +02:00
Laura Fernández b5335f0910 Chore: ChangePassword - Replace VerticalGroup with Stack (#86614) 2024-04-19 17:37:51 +02:00
Laura Fernández efa5e582cc Chore: UserProfileEditPage - Replace VerticalGroup with Stack (#86619) 2024-04-19 17:37:14 +02:00
Matias Chomicki aa73140564 Loki: Add label filters after label_format if present (#86124)
* Loki ad-hoc filters: add filters after label_format

* Chore: add comment explaining rationale

* Formatting

* Formatting
2024-04-19 17:31:38 +02:00
Joao Silva 8f38ef70ce Chore: Replace VerticalGroup in OrgDetailsPage and BenchmarksPage (#86621) 2024-04-19 16:28:51 +01:00
Laura Fernández db4f7cd21d Chore: UserSignup and LoginServiceButtons - Replace VerticalGroup with Stack (#86616) 2024-04-19 17:24:09 +02:00
Laura Fernández a057e8be06 Chore: AppNotificationList- Replace VerticalGroup with Stack (#86612) 2024-04-19 16:21:45 +02:00
Ashley Harrison 4a9e478a6b EmptyState: Apply completed empty state in Notifications page (#86504)
* add 'completed' variant

* apply completed empty state to notifications page
2024-04-19 13:46:03 +01:00
renovate[bot] c2f3bf677d Update dependency @types/react to v18.2.79 2024-04-19 11:39:32 +00:00
Ivan Ortega Alba 65afe90124 IntervalVariableEditor: Do not add current value as interval prop (#86446) 2024-04-19 13:04:01 +02:00
Ashley Harrison 63427ccd98 CommandPalette: Fix keyboard shortcut alignment (#86540)
* use full typography properties

* use Text component
2024-04-19 11:52:27 +01:00