Commit Graph
76 Commits
Author SHA1 Message Date
Darren Janeczek 763108ce10 datatrails: in Components, model.useState(), instead of model.state (#88432)
fix: in Components, `model.useState()`, instead of `model.state`

Generally, it is better practice. More succinct.
It could also eliminate subtle state bugs.
2024-05-29 10:29:57 -04:00
Darren JaneczekandNick Richmond 80a0de511f data trails: alternate legend display for missing label value (#88153)
* fix: alternate legend display for missing label value

* Update public/app/features/trails/ActionTabs/BreakdownScene.tsx

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>

* Update public/app/features/trails/ActionTabs/BreakdownScene.tsx

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>

---------

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>
2024-05-24 15:41:20 -04:00
Darren Janeczek a7d304a871 datatrails: on histogram breakdowns, show label value in legend (#88154)
fix: on histogram breakdowns, show label value in legend
2024-05-24 15:41:00 -04:00
Darren Janeczek 5c29052219 datatrails: refactor: move related code to trails/MetricSelect subdir (#88262)
refactor: move related code to trails/MetricSelect subdir
2024-05-24 13:45:21 -04:00
Darren Janeczek e9b932c8f6 datatrails: reloaded trail bugs related to no selected metric (#87344)
* fix: reloaded scene first step topScene

The top scene was not being initialized
when reloading trails, causing it to use
the top scene of whatever was selected
previously.

* fix: select new metric node not reloading right

On reloading trails, any metric node that
was 'green' with a undefined metric due to
clicking on the "select new metric" button,
was reloading with the metric of the step
directly before it (in index order).
2024-05-03 21:29:54 +03:00
Darren Janeczek f93c330b66 datatrails: only fetch metrics metadata when using the language provider, avoid redundant fetch of metric names (#87067)
* fix: only fetch metrics metadata, not metric names
2024-05-03 12:24:18 -04:00
Darren Janeczek 6524febbd4 datatrails: quick bugfix: handle undefined step (#87337)
fix: handle undefined step
2024-05-03 19:22:23 +03:00
Darren Janeczek 5b424ed6bb scenes: update to v4.14.0: opt-in to useQueriesAsFilterForOptions (#87244)
* fix: opt-in to `useQueriesAsFilterForOptions`

With updating the scenes library, dashboards must now explicitly
opt in to `useQueriesAsFilterForOptions`.
2024-05-03 18:47:57 +03:00
Darren Janeczek 046eedaa4c datatrails: recently loaded trails modify parent variables when making new steps (#87284)
* fix: loaded trails modified parent var on new step

This ensures that recently loaded trails won't have variable changes
which create new steps modify the previous step.
2024-05-03 11:38:47 -04:00
Darren Janeczek b1d98939e1 datatrails: include step index and number of steps when reporting trail step navigation usage (#87068)
* fix: include step index and number of steps
2024-05-02 09:55:58 -04:00
Darren Janeczek 9af4607e78 datatrails: fix bookmark/recent trail detection, prevent duplications, save trail on browser close/reload (#85677)
* fix: persistence trail detection, save on unload

- fixes detection on bookmarks and recents when current step isn't final
- now save current trail on browser close or reload (unload)
- refresh page or return to URL that corresponds to a recent trail will
   resume that trail instead of creating a duplicate recent trail
- do not create a recent trail out of an empty starting trail

* fix: bookmarks status after making new step

- clone bookmark trail state to prevent it from being changed by user
- re-evaluate bookmark status after creating new step
2024-04-26 11:35:38 -04:00
Darren JaneczekandLeon Sorokin ff761bb7d6 Tooltips: Ensure new viz tooltips are visible within modals (alternative solution) (#86716)
fix: ensure new viz tooltips are visible within modals

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2024-04-25 16:27:24 -04:00
Darren JaneczekandTorkel Ödegaard 53ead9904d datatrails: interpolate adhoc variables and datasource variables when opening "explore metrics" from dashboard panels (#86252)
* fix: interpolate "explore metrics" from panels

---------

Co-authored-by: Darren Janeczek <darren.janeczek@grafana.com>

* fix: remove support for legacy dashboard

- simplify code
- take advantage of scenes dashboard async and datasource api object

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2024-04-24 12:05:48 -04:00
Darren Janeczek 53d2714a18 Tooltips: Ensure new viz tooltips are visible within modals (#86258)
fix: ensure new viz tooltips are visible within modals
2024-04-17 13:54:10 -04:00
Darren Janeczek 2ed7eecf2d fix: datatrail link to "open in explore" prefix with config.appSubUrl (#86375)
* fix: datatrail link to explore needs appSubUrl
* fix: use `appUrl` when creating URL for sharing
2024-04-17 16:40:40 +02:00
Darren Janeczek ea90f0119c datatrails: track user interactions (#85909)
* chore: add interaction tracking
2024-04-16 15:55:07 -04:00
Darren JaneczekandTorkel Ödegaard 34875344ed datatrails: fix: clear undefined query params on history step change (#85607)
* fix: clear undefined query params on history step change

* Minor tweak

* fix: resolve CodeQL check: Client-side cross-site scripting

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2024-04-11 09:52:33 -04:00
Darren Janeczek 2e1e45bbb1 datatrails: ensure breakdown yaxis sync is maintained when layout changes (#85380)
fix: ensure breakdown yaxis sync is maintained when layout changes
2024-04-10 17:12:33 -04:00
Darren Janeczek 66c0fd4dcc chore: update datatrails feature flag and enable (#85508)
* chore: update datatrails feature flag and enable

* fix: rename `datatrails` feature flag to `exploreMetrics`
2024-04-09 14:15:18 -04:00
Darren Janeczek 18f3c7188b datatrails: handle "single" layout when switching to "all" labels (#85373)
* fix: handle "single" layout when switching to "all" labels
2024-03-28 18:13:43 +02:00
Darren Janeczek 137061d1d5 datatrails: fix stability issues between conflict between browser history, URL sync, and trail history (#85134)
* fix: conflict between browser history and trail history

- ensure the back button or url changes don't generate trail steps
- ensure label breakdown TextLinks which appear on the summary tab work in embedded mode
2024-03-28 09:59:16 -04:00
Darren Janeczek f850b00a92 datatrails: avoid double scrollbar with new viz tooltips (#85197)
fix: avoid double scrollbar
2024-03-27 12:50:02 -04:00
Darren Janeczek 2ecc1bb646 datatrails: hide "add to filter" button when there is no label value to add to filter (#85270)
fix: hide add to filters button when it won't work
2024-03-27 16:33:21 +02:00
Darren Janeczek 5d477d711a datatrails: do not show the "le" label (#85114)
fix: do not show the "le" label
2024-03-26 09:00:25 +01:00
Darren Janeczek 2e06677240 datatrails: throttle the resetting of yaxis (#85117)
fix: throttle the resetting of yaxis
2024-03-25 19:33:57 -04:00
Darren Janeczek 7c03cc83c6 Datatrails: hide empty breakdown panels, improve loading status (#85028)
feat: hide empty breakdown panels, improve loading status
2024-03-25 18:56:03 -04:00
Darren Janeczek 810c224039 datatrails: synchronize the range of the y axis for all breakdown panels (#84781)
feat: sync the yaxis of breakdown panels
2024-03-22 16:19:11 -04:00
Darren Janeczek 08c24e4133 datatrails: feat: metadata for metric panels (#84872)
* feat: metadata for metric panels

* fix: missing import?

* fix: async await to get description first

- also add description to metric-name-only panels

* fix: change description, remove from main viz

* fix: remove import
2024-03-22 10:05:20 -04:00
Darren Janeczek a2795f1291 datatrails: fix: only show datatrails link for timeseries dashboard panels (#84942)
fix: only show datatrails link for timeseries dashboard panels
2024-03-22 10:05:03 -04:00
Darren Janeczek 1eff5fb791 datatrails: lazy load the breakdown queries, reduce panels, reduce number of points (#84965)
fix: lazy load the breakdown queries, reduce panels
2024-03-22 08:26:35 -04:00
Darren Janeczek e233c963a3 datatrails: fix dark mode drawer background clashing with data trail backgrounds (#84941)
fix: drawer background clashed with data trail bgs
2024-03-21 19:49:32 +02:00
Darren Janeczek 7653da1870 datatrails: add ability to deselect currently metric (#84586)
* feat: ability to deselect currently metric
2024-03-20 21:51:47 -04:00
Darren Janeczek d58e652cc3 datatrails: include description of related metrics tab (#84525)
* fix: include description of related metrics tab
2024-03-21 00:20:23 +02:00
Darren Janeczek 5d5e22ae11 datatrails: fix: position of new metric exploration button (#84844)
fix: position of new metric exploration button
2024-03-20 18:08:13 -04:00
Darren Janeczek 63e8753aa0 datatrails: integrate dashboard panels with metrics explore (#84521)
* feat: integrate dashboard panels with metrics explore

- add dashboard panel menu items (in non-scenes dashboard) to open
  `metric{filters}` entries detected from queries to launch
  "metrics explorer" drawers for the selected `metric{filter}`

* fix: remove OpenEmbeddedTrailEvent

* fix: use modal manager dismiss capabilities instead
2024-03-18 17:16:38 +01:00
Darren Janeczek e96836d19e datatrails: Remove prefix filter (#84661)
* fix: use cascader's clear button

* fix: remove the prefix filter from metric select

* fix: remove supporting code in metric select scene

- For the removed prefix filter

* fix: spacing
2024-03-18 11:00:31 -04:00
Darren Janeczek 767608f3a6 Data trails: use description of data source to shorten label (#84665)
fix: use description of data source to shorten label
2024-03-18 16:23:19 +02:00
Darren Janeczek 59baa7a4a4 fix: data trails ignore usage syntax (#84610) 2024-03-15 21:27:31 +02:00
Darren Janeczek e93ba13f7a datatrails: style: update buttons to secondary solid format (#84526)
* fix: secondary solid buttons for selecting metrics

* fix: secondary solid buttons for selecting labels

* fix: secondary solid buttons for adding filters
2024-03-15 11:00:05 -04:00
Darren Janeczek 73d96b6d1f datatrails: fix: clearly identify unspecified label values (#84474)
fix: clearly identify unspecified label values
2024-03-14 10:39:01 -04:00
Darren Janeczek 88f5b62a23 VizTooltips: Tolerate missing annotation text (#83634) 2024-02-28 17:06:55 -06:00
Darren Janeczek 6e75584505 datatrails: improve label filter behavior (#83411) 2024-02-28 16:06:31 -05:00
Darren Janeczek d6b1aa6575 datatrails: standardize loading and blocking message indicators (#83560)
fix: standardize loading and blocking message indicators
2024-02-28 16:05:22 -05:00
Darren JaneczekandAndre Pereira fb324fc8ac datatrails: fix: indicate __ignore_usage__ for preview queries (#82291)
* fix: indicate __ignore_usage__ for preview queries

* fix: further remove var that shouldn't be there

* refactor: move previewPanel code and add tests

* fix: use simpler `AdHocFiltersVariable` state

Co-authored-by: Andre Pereira <adrapereira@gmail.com>

---------

Co-authored-by: Andre Pereira <adrapereira@gmail.com>
2024-02-26 10:01:54 -05:00
Darren Janeczek 11ff4e7b8c fix: datatrails: start step is "metric select" after reinitializing from URL (#83179)
fix: datatrails: start step is "metric select"

If restoring from a saved data trail, or URL,
the selection of metric becomes a second step.
The first step is always without a metric, and
displays the metric selection scene.
2024-02-25 12:54:10 -05:00
Darren Janeczek 18d1ced069 style: datatrails: indicate prometheus data source (#83199)
* style: indicate prometheus data source
2024-02-23 12:03:40 -05:00
Darren Janeczek b3c0f69576 style: datatrails: use Tag on cards (#83198)
* style: datatrails: use Tag on cards
2024-02-23 12:03:10 -05:00
Darren Janeczek 83c01f9711 datatrails: detect if current trail state is bookmarked (#83283)
* fix: detect if current trail state is bookmarked
2024-02-23 17:00:10 +02:00
Darren Janeczek db4b4c4b0a datatrails: refactor: auto query generator, use more suitable queries (#82494)
* refactor: datatrails auto query generator

* fix: use "per-second rate" instead
2024-02-21 10:52:49 -05:00
Darren Janeczek cd09c36448 datatrails: fix: improve performance of related metrics sort (#82285)
fix: improve performance of related metrics sort
2024-02-12 09:52:44 -05:00
Darren Janeczek 02c0f5929c prometheus: fix: use shallow clone of scopedVars (#82280)
fix: use shallow clone of scopedVars
2024-02-10 09:57:11 -05:00
Darren Janeczek a439ee46bf datatrails: fix: propagate unit to breakdown graphs (#82176)
fix: propagate unit to breakdown graphs
2024-02-08 12:02:03 -05:00
Darren Janeczek 71497c98e8 datatrails: style: improve panel display (#82017)
* style: improve panel display

- Show summary text in hover legends (no queries)
- Show additional description in main panel title
2024-02-08 10:36:20 -05:00
Darren Janeczek 312f8f0f69 datatrails: debounce search and prefix filter (#81842)
fix: debounce search and prefix filter
2024-02-08 10:35:09 -05:00
Darren Janeczek 9fb04be7ff enhancement: use SVG icon for cascader expand instead of > (#81844)
* feature: use icon for cascader expand
2024-02-07 10:26:39 -05:00
Darren Janeczek 16df04e260 datatrails: improve width responsiveness for breakdown label selector (#81838)
* fix: make datatrails breakdown label selector responsive
2024-02-06 08:08:57 -05:00
Darren Janeczek 96772e1a32 datatrails: improve handling of error states and disable states (#81669)
* fix: Cascader: allow disabled state

* fix: datatrails metrics selection scene stability
  - clear panels and filter data when datasource changes
  - detect metric names loading / error state and disable components accordingly
  - put all scene variable dependencies together
  - reset metric names without clearing panels when time range changes
2024-02-05 09:45:47 -05:00
Darren Janeczek bd0fd21852 fix: datatrails verify different time range before creating new history node (#81839)
fix: datatrails verify different time range
2024-02-03 10:20:04 -05:00
Darren Janeczek 7319a75110 feat: datatrails: include metric prefix filter (#81316)
* feat: datatrails: include metric prefix filter

* fix: remove current metric from related metrics list

* fix: Cascader issues

- handle empty items list when generating searchable options
- correct state management to ensure cascade shows cascade
  path of selection from search

* fix: remove custom value creation
2024-01-31 09:33:27 -05:00
Darren Janeczek c8f47e0c54 datatrails: UI improvements (#81427)
* fix: datatrails: limit width of metric description

* fix: datatrails: use vertical radio list for long label list

* fix: datatrails: reduce spacing between header items

* fix: datatrails: reduce gap in lower toolbar

* fix: change to use Select component for longer lists
2024-01-31 09:27:44 -05:00
Darren Janeczek 24a6e6a1b4 fix: datatrails: show a warning when search yields empty results (#81444)
* fix: datatrails: show a warning when search yields empty results
2024-01-29 16:54:56 -05:00
Darren Janeczek 329440cb1e fix: datatrails: hide graphs when previews disabled (#81423)
fix: datatrails: hide graph when previews disabled
2024-01-29 08:41:53 -05:00
Darren Janeczek 52550966af datatrails: allow multiple search terms to help select metric names (#81032)
* datatrails: allow multiple search terms help select metric names
2024-01-23 09:54:19 -05:00
Darren Janeczek fcc11c9290 fix: datatrails: setRecentTrail: remove equivalent entries to new recent trail (#80932)
* fix: datatrails: setRecentTrail: remove equivalent entries

* fix: use lodash to simplify code
2024-01-22 10:07:47 -05:00
Darren Janeczek 2210ed50b4 fix: data-trails get data source name for display (#80922) 2024-01-22 09:42:07 -05:00
Darren Janeczek dbae7ccd3f refactor: data trails auto query for buckets (#80170)
* refactor: data trails auto query for buckets

* refactor: vizBuilder function signature (#80178)

* fix: use closures for setting unit and title in vizBuilders
2024-01-16 12:46:12 -05:00
Darren Janeczek 796ef05e97 fix: data trails auto query use general generator for unconventional metrics (#80301) 2024-01-10 18:23:41 +01:00
Darren Janeczek 890d6a960f refactor: data-trails auto query logic (#79435)
* refactor: data-trails auto query logic for most currently identified metric suffixes (excluding `_bucket`)
2024-01-08 09:48:08 -05:00
Darren Janeczek ac1b9e44a2 data-trails: ability to (de)serialize parents and current index (#78782)
fix: ability to (de)serialize parents and current index

- refactored so only history stores parent relations and current index

- rounded indirect parent links
2023-12-04 10:04:58 -05:00
Darren Janeczek a5377f85ce data-trails: hightlight current node and its ancestry (#78660)
* feat: data-trails: show current node and ancestry
2023-11-28 13:16:22 -05:00
Darren JaneczekandTorkel Ödegaard 53e6182257 Data-trails: prevent creating new metrics node when clicking on historical metric node (#78569)
* fix: prevent creating new metrics node when clicking on historical metric node

* Adding some initial tests

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-11-24 11:21:19 -05:00
Darren Janeczek efdfa29fe2 fix: label_values w/ empty filters in prom datasource variable query (#78242)
* fix: handle empty filters in prometheus datasource variable query function `label_values`
2023-11-20 16:36:06 -05:00
Darren Janeczek e5c2e123ef Scenes: fix date range comparison (#78331)
* Scenes: fix date range comparison
2023-11-17 21:31:49 -05:00
Darren JaneczekandMarcus Andersson 7d2bfea777 Pyroscope: Added app integration for datasource (#75789)
* feat: integrate pyroscope query editor with link extensions

- allows plugin app extensions to register links based on
  the query and selected datasource

* fix: remove not-as-designed busy wait mechanism

* Apply suggestions from code review

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* fix: implement feedback

* fix: lint

---------

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
2023-10-27 08:09:05 +02:00
Darren Janeczek d61af3adde Dashboards: Data source template variable options now specify a current value using uid. (#69259)
* feat: template data source option current by uid

* fix: e2e with explicit uid for "slow-prometheus"

* revert: unrelated change

* revert: unreverted the actually related change

* chore: e2e support for testing ${variable:text}

* fix: use `:raw` instead of `:value` in e2e dashboard
2023-06-12 01:05:50 -07:00
Darren Janeczek 565430f297 Prometheus: Don't show errors from unsuccessful API checks like rules or exemplar checks (#52193)
The query inspector was experiencing some error pop-ups due
to errors encountered on metrics datasources configured with multiple
tenants.

e.g., team-a|team-b

This fix suppresses those errors so as to not mislead the user.
2022-07-21 15:45:02 +02:00