Commit Graph

25910 Commits

Author SHA1 Message Date
John Ralls
862848380c Bug 798681 - Previously imported investment income transactions may not be filtered.
Resequence process_investment_transaction so that the first split is
the primary asset account split (cash unless it's a reinvest) followed
by the security asset account if it's not income and finally the income
split for income or reinvest transactions.

Note that there's also a sign change on the income splits for
income and reinvest transactions: testing showed the signs to be
backwards.
2022-12-13 12:38:00 -08:00
John Ralls
6a9e1cb249 [ofx import] Don't set online-id on income accounts. 2022-12-13 12:38:00 -08:00
John Ralls
17eb739da3 [ofx import] Extract functions from ofx_proc_transaction_cb.
set_transaction_dates, fill_transaction_description,
fill_transaction_notes, process_bank_transaction,
process_investment_transaction, choose_investment_account,
choose_income_account, add_investment_split, add_currency_split,
create_investment_subaccount, continue_account_selection,
choose_investment_account_helper, choose_investment_account
2022-12-13 12:36:10 -08:00
John Ralls
0bc2d692c7 [ofx import] Typedef OfxTransactionData.
So we don't have to say struct on every use.
2022-12-13 12:35:37 -08:00
John Ralls
5519a9d788 [import matcher] Make related functions adjacent
gnc_gen_trans_list_add_trans just wraps
gnc_gen_trans_list_add_trans_with_ref_id.
2022-12-13 12:35:32 -08:00
John Ralls
e116a4f195 [import backend] Extract function hash_account_online_ids. 2022-12-13 12:35:32 -08:00
John Ralls
b4bab92da2 Bug 798664 - Result of 'gnucash --nofile' is marked dirty
Don't create a new book in the new-user dialog unless the user says to.
Don't automatically create a new book when retrieving default commodities
because the retrieve might be requested in a context like the Preferences
dialog when there is no book.

Some report tests relied on requesting the default commodity creating
the book, so in those tests ensure that the book is created first.
2022-12-12 11:30:59 -08:00
John Ralls
fae5de80d3 Undo unintended change in Bug 798679 commit. 2022-12-11 19:54:35 -08:00
John Ralls
fd2761bd68 Bug 798679 - Fullwidth characters cannot be pasted as-is in register fields
Control character check doesn't need normalization, the control character
codepoints aren't graphic and so can't be composed nor have compatible
equivalents.
2022-12-11 13:00:40 -08:00
YOSHINO Yoshihito
993697be7f
Translation update by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate
po/ja.po: 89.9% (4859 of 5401 strings; 276 fuzzy)
593 failing checks (10.9%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 89.8% (4851 of 5401 strings; 284 fuzzy)
601 failing checks (11.1%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Co-authored-by: YOSHINO Yoshihito <yy.y.ja.jp@gmail.com>
2022-12-10 19:48:52 +01:00
Milo Ivir
66025ae738
Translation update by Milo Ivir <mail@milotype.de> using Weblate
po/hr.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Croatian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hr/

Co-authored-by: Milo Ivir <mail@milotype.de>
2022-12-05 15:47:26 +01:00
Christopher Lam
36b33262ad [account-piecharts] drill-down piechart: tree-depth is at most 6 2022-12-05 14:49:57 +08:00
John Ralls
094a971c03 Fix missing trailing quote on project-id-version. 2022-12-04 20:34:21 -08:00
John Ralls
940446767d Merge potfile for 4.13 String Freesw. 2022-12-04 20:10:52 -08:00
Simon Arlott
add45021a8
Translation update by Simon Arlott <weblate.simon@arlott.org> using Weblate
po/en_NZ.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (English (New Zealand))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/en_NZ/

Translation update  by Simon Arlott <weblate.simon@arlott.org> using Weblate

po/en_AU.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (English (Australia))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/en_AU/

Translation update  by Simon Arlott <weblate.simon@arlott.org> using Weblate

po/en_GB.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (English (United Kingdom))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/en_GB/

Co-authored-by: Simon Arlott <weblate.simon@arlott.org>
2022-11-30 22:48:02 +01:00
Robert Fewell
df9a6b0309 Bug 798653 - Schedule Calendar event description pop up window does not track mouse position
The reporter was on Ubuntu 22.04.1 LTS which has wayland as the default
display server. When tested on a Fedora 37 VM which was also using
wayland the following message was seen on the terminal window...

Gdk-Message: 15:23:51.862: Window 0x28b0de0 is a temporary window
without parent, application will not be able to position it on screen.

This fix sets the transient parent for the dense calendar pop up.
2022-11-29 15:27:00 +00:00
Geert Janssens
98251d59a6 Bug 798672 - Preferences are not saved nor loaded, ERROR <GLib-GIO> g_settings_new_full: assertion 'schema != NULL' failed
Apparently it was a failure on our side to properly look up
requested gsettings schema.
2022-11-29 12:27:21 +01:00
Christopher Lam
5dc52459a1 Bug 798669 - Multicolumn Balance Sheet not printing exchange rates
include equity accounts in the exchange rate commodities list.
2022-11-27 12:55:17 +08:00
Vesna Micajkova
8cf137740b
Translation update by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate
po/mk.po: 1.9% (108 of 5401 strings; 0 fuzzy)
3 failing checks (0.1%)
Translation: GnuCash/Program (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/mk/

Translation update  by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate

po/glossary/mk.po: 100.0% (212 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/mk/

Translation update  by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate

po/mk.po: 1.6% (88 of 5401 strings; 0 fuzzy)
3 failing checks (0.1%)
Translation: GnuCash/Program (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/mk/

Co-authored-by: Vesna Micajkova <vmicajkova@institutpraktikum.mk>
2022-11-25 21:25:04 +01:00
John Ralls
4893d0b8d8 Merge Marco Scardovi's QofFakeQuery fix into maint. 2022-11-25 12:22:44 -08:00
Marco Scardovi
6fe2028bca
Fix test
Signed-off-by: Marco Scardovi <mscardovi@icloud.com>
2022-11-24 23:20:07 +01:00
Robert Fewell
59d95a4ce6 Bug 798545 - Crash when updating document link on vendor bill
There were two issues here, the first one was that the copied doclink
was pointing to the original doclink which lead to a double-free. The
second is the setting of the doclink on the copied invoice needs to be
done with gncInvoiceSetDocLink otherwise on closure the doclink value
will disappear.
2022-11-24 11:16:01 +00:00
Robert Fewell
80f1101447 Bug 760274 - The Statusbar "forgets" when register doesn't have focus
Only update the status bar if the current page is the same as the
register page.
2022-11-24 10:12:29 +00:00
Robert Fewell
f93da32dfc Add missing gtk_tree_path_free to gnucash-item-list.c 2022-11-24 10:02:28 +00:00
Robert Fewell
1554ec6c0f Add missing gtk_tree_path_free to gnc-plugin-budget.c 2022-11-24 10:01:43 +00:00
Christopher Lam
f13cfa2142 Merge branch 'maint-budget' into maint #1468 2022-11-23 08:30:34 +08:00
Kaligula
af34ee3f54
Translation update by Kaligula <kaligula.dev@gmail.com> using Weblate
po/pl.po: 71.2% (3846 of 5401 strings; 1096 fuzzy)
255 failing checks (4.7%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Co-authored-by: Kaligula <kaligula.dev@gmail.com>
2022-11-20 12:48:03 +01:00
Christopher Lam
120758f519 [assistant-stock-transaction] from Bug 798004 cash to offset fee 2022-11-20 18:16:10 +08:00
Christopher Lam
c6611a40bb [ifrs-report] From Bug 798004 allow Cr cash to offset Dr fee
and remove invalid "dividend reinvestment" during short.
2022-11-20 18:16:00 +08:00
Kaligula
13895e1734
Translation update by Kaligula <kaligula.dev@gmail.com> using Weblate
po/pl.po: 71.0% (3840 of 5401 strings; 1096 fuzzy)
255 failing checks (4.7%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Co-authored-by: Kaligula <kaligula.dev@gmail.com>
2022-11-19 22:47:46 +01:00
Christopher Lam
3d8a28898d [gnc-budget] gnc_budget_get_account_period_note returns a const
to harmonize with all other char getters
2022-11-19 10:35:49 +08:00
Christopher Lam
2ee0c98200 [gnc-budget] use operator[] instead of find() and insert()
- avoid hashing Account* twice. one call to operator[] is sufficient.
- don't need use std::move with better constructors
- sanity check - can't have a budget with num_periods = 0
- remove unused headers
2022-11-19 10:35:43 +08:00
Frank H. Ellenberger
7992fd0e9b Merge branch PR #1465 into maint 2022-11-18 01:01:29 +01:00
Vesna Micajkova
a04ee108ec
Translation update by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate
po/glossary/mk.po: 82.5% (175 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/mk/

Translation update  by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate

po/mk.po: 1.6% (87 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/mk/

Co-authored-by: Vesna Micajkova <vmicajkova@institutpraktikum.mk>
2022-11-17 11:47:08 +01:00
Vesna Micajkova
bddd603063
Translation update by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate
po/mk.po: 1.5% (85 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/mk/

Translation update  by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate

po/glossary/mk.po: 74.5% (158 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/mk/

Translation update  by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate

po/mk.po: 1.3% (72 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/mk/

Translation update  by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate

po/glossary/mk.po: 31.6% (67 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/mk/

Translation update  by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate

po/mk.po: 0.3% (18 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/mk/

Co-authored-by: Vesna Micajkova <vmicajkova@institutpraktikum.mk>
2022-11-15 16:48:07 +01:00
luz paz
0be8e05a1b Fix typos and whitespace in test 2022-11-14 12:57:50 -05:00
Kaligula
f8c5f51b75
Translation update by Kaligula <kaligula.dev@gmail.com> using Weblate
po/pl.po: 66.0% (3570 of 5401 strings; 1320 fuzzy)
401 failing checks (7.4%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Co-authored-by: Kaligula <kaligula.dev@gmail.com>
2022-11-13 03:15:29 +01:00
Kaligula
97df6aacab
Translation update by Kaligula <kaligula.dev@gmail.com> using Weblate
po/pl.po: 66.0% (3569 of 5401 strings; 1321 fuzzy)
402 failing checks (7.4%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Translation update  by Kaligula <kaligula.dev@gmail.com> using Weblate

po/pl.po: 63.3% (3419 of 5401 strings; 1471 fuzzy)
555 failing checks (10.2%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Translation update  by Kaligula <kaligula.dev@gmail.com> using Weblate

po/glossary/pl.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/pl/

Translation update  by Kaligula <kaligula.dev@gmail.com> using Weblate

po/pl.po: 63.3% (3419 of 5401 strings; 1471 fuzzy)
590 failing checks (10.9%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Co-authored-by: Kaligula <kaligula.dev@gmail.com>
2022-11-12 03:49:19 +01:00
Vesna Micajkova
e62eb5443e
Translation update by Vesna Micajkova <vmicajkova@institutpraktikum.mk> using Weblate
po/glossary/mk.po: 2.8% (6 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Macedonian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/mk/

Co-authored-by: Vesna Micajkova <vmicajkova@institutpraktikum.mk>
2022-11-12 03:49:18 +01:00
Christopher Lam
e30c1fce70 gtk_tree_model_get will allocate char* which must be g_freed. 2022-11-10 22:00:00 +08:00
Frank H. Ellenberger
aedc0cc196 L10N: Prepare macedonian (mk) 2022-11-08 03:11:08 +01:00
Christopher Lam
60c5e20084 [import-main-matcher] bug: test str from the string hash provided
...instead of the description string hash.
2022-11-07 11:49:51 +08:00
Christopher Lam
6f80c548e6 [gtest-qofevent.cpp] comprehensive tests for qofevent 2022-11-05 09:25:24 +08:00
Christopher Lam
b87aa004f9 [test-qofbook] add tests for unknown features
tests that gnc_features_test_unknown returns a suitable error message
2022-10-31 10:40:12 +08:00
John Ralls
b9077bccd3 Bug 798640 - Segfault when running saved report 2022-10-29 17:45:35 -07:00
Christopher Lam
f2354d6b2a [test-qofbook.c] add test for gnc_features_set_unused 2022-10-29 21:01:08 +08:00
Christopher Lam
1516bb18b0 [gnc-features.cpp] backport gnc_features_set_unused from master 2022-10-29 21:01:01 +08:00
Christopher Lam
a078921a33 [qofbook.cpp] backport qof_book_unset_feature from master 2022-10-29 21:00:54 +08:00
John Ralls
cf088f2a70 Merge John Ralls's 'Bug798614' into maint. 2022-10-28 15:27:28 -07:00
John Ralls
f5099b3d87 Bug 798649 - Crash when closing Edit Style Sheets dialog while...
Style Sheet Properties dialog is still open.

Because the style_sheet_dialog is already destroyed and nulled.
2022-10-28 11:37:18 -07:00