Commit Graph

24831 Commits

Author SHA1 Message Date
Christopher Lam
ac2afc7e13 [gncInvoice.c] GValue string must be unset 2021-08-29 15:38:16 +08:00
Christopher Lam
3bf49ed8d7 [Account.cpp] GValue string must be unset 2021-08-29 15:38:16 +08:00
Christopher Lam
e3af2f22f9 [gnc-commodity.c] cache user_symbol into commodity struct
Continuation of ff2ceb111 which introduced issue whereby user_symbol
returned could become stale, leading to invalid read fixed with
c398bef59. There are likely other user_symbol pointers becoming stale
without this commit.

This change will save the user_symbol into the commodity struct,
avoids gchar* becoming stale.
2021-08-29 15:38:16 +08:00
John Ralls
57f73d70c7 Merge Yordan Miladinov's denom_lcd into maint. 2021-08-27 12:34:07 -07:00
Romanos Skiadas
b42052464b fix spurious error about uninitialized have_end
in gnc_tree_view_account_select_subaccounts, gcc thinks have_end might
not be initialized, but since the function exits if num_children == 0,
the while (num_children) loop will always be entered. Silence the
warning.
2021-08-27 20:25:36 +08:00
Kaantaja
e3fd6bf4fe
Translation update by Kaantaja <ufdbvgoljrjkrkyyub@ianvvn.com> using Weblate
po/glossary/fi.po: 100.0% (208 of 208 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Finnish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/fi/

Co-authored-by: Kaantaja <ufdbvgoljrjkrkyyub@ianvvn.com>
2021-08-25 19:34:29 +02:00
Christopher Lam
37cb886de5 [engine.i] gnc_budget_get_account_period_note to be freed by the caller
amendment to last commit.

this pair of changes was necessary to allow the GValue to be unset.
2021-08-25 09:17:25 +08:00
Christopher Lam
c55ab50349 [gnc-budget.c] gnc_budget_get_account_period_note to be freed by the caller 2021-08-24 23:02:15 +08:00
Christopher Lam
9ddb9e8215 [gnc-module.c] free a GList* properly
g_list_free (current) was a NOP because current became NULL after the
preceding GList traversal.
2021-08-24 22:32:39 +08:00
Simon Arlott
0665208299
xml-backend: Lock file is deleted even if the lock is not acquired
The lock file is set in m_lockfile and then unlinked in session_end even if
the lock was not acquired.

Clear m_lockfile if locking was not successful.
2021-08-24 09:29:47 +01:00
Simon Arlott
e4619fdae6
xml-backend: Don't try to close m_lockfd if it's not open
m_lockfd is not initialised. If the file is locked then it will not be set
before session_end and close() will be called on an uninitialised int.

Initialise it to -1 in the class definition.
Consistently use -1 instead of "< 0" or "< 1" as the definition of invalid.
Always set it to -1 after closing it.
2021-08-24 09:29:45 +01:00
Frank H. Ellenberger
383276579e Update file extension in man pages
https://lists.gnucash.org/pipermail/gnucash-user/2021-August/097472.html
2021-08-24 01:20:32 +02:00
Yordan Miladinov
6cb509ea7d
fix an uncaught exception: denom_lcd may throw an overflow exception if casting lcm to int64_t fails 2021-08-24 00:58:31 +03:00
Christopher Lam
929cb3d0c1 [engine.i] free swigged GList* arg 2021-08-24 00:13:45 +08:00
TianXing_Yi
0f3da06723
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-08-22 13:32:23 +02:00
Avi Markovitz
34f42ec9b2
Translation update by Avi Markovitz <avi.markovitz@gmail.com> using Weblate
po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/glossary/he.po: 100.0% (209 of 209 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Avi Markovitz <avi.markovitz@gmail.com>
2021-08-22 13:32:23 +02:00
Yaron Shahrabani
71ad5c8383
Translation update by Yaron Shahrabani <sh.yaron@gmail.com> using Weblate
po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
2021-08-22 13:32:22 +02:00
Avi Markovitz
e513557011
Translation update by Avi Markovitz <avi.markovitz@gmail.com> using Weblate
po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/glossary/he.po: 100.0% (209 of 209 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Avi Markovitz <avi.markovitz@gmail.com>
2021-08-22 13:32:22 +02:00
Christopher Lam
c398bef597 [window-main-summarybar] move mnemonic to get_total_mode_label
avoiding static char* reassignment
2021-08-21 23:45:34 +08:00
Christopher Lam
7e41efc232 Merge branch 'maint-speedup-and-leaks' into maint #1109
Speedup xaccSplitGetOtherSplit
2021-08-20 21:23:35 +08:00
Christopher Lam
ff2ceb111d [gnc-commodity] GValue must be unset 2021-08-20 17:02:58 +08:00
Christopher Lam
9fc1ac6be1 Merge branch 'maint-guile-changes' into maint #1111 2021-08-20 17:02:19 +08:00
Christopher Lam
9bc44c62e6 [engine.i] free GSList* key_path arg to qof_book_get_option
Addendum to 6c8af6aab need to specify exact typemap target.
2021-08-20 17:01:42 +08:00
Christopher Lam
15b8545e2f Merge branch 'maint-leaks' into maint #1113 2021-08-20 09:24:33 +08:00
Christopher Lam
6c8af6aab1 [engine.i] free GSList* arg to qof_book_get_option 2021-08-20 09:03:37 +08:00
Christopher Lam
4cf25cb7be GList* from gtk_container_get_children must be freed
fix leaks
2021-08-20 09:03:37 +08:00
Christopher Lam
c442192bb4 [gnc-amount-edit] g_free char* empty string.
1 byte is allocated if filtered_string is the empty string. free it.
2021-08-20 09:03:36 +08:00
Christopher Lam
c4a0fb468b [srfi64-extras.scm] exit instead of return #t if no failures
due to change in guile-3.0.7 to fix srfi64 bug
2021-08-19 20:56:13 +08:00
Christian Wehling
57866eed88
Translation update by Christian Wehling <christian.wehling@web.de> using Weblate
po/de.po: 99.8% (5357 of 5364 strings; 7 fuzzy)
250 failing checks (4.6%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Christian Wehling <christian.wehling@web.de>
2021-08-17 13:34:16 +02:00
Avi Markovitz
2727259f59
Translation update by Avi Markovitz <avi.markovitz@gmail.com> using Weblate
po/glossary/he.po: 100.0% (209 of 209 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/glossary/he.po: 100.0% (209 of 209 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Avi Markovitz <avi.markovitz@gmail.com>
2021-08-17 13:34:16 +02:00
TianXing_Yi
a96024ca8f
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5351 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5351 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5351 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5351 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-08-17 13:34:15 +02:00
Christopher Lam
028bf9826b [Split] xaccSplitGetOtherSplit don't test book trading-accts
don't test trading-acct property when finding other split.
2021-08-17 13:04:34 +08:00
Christopher Lam
6bf5a618de qof_instance_get gchar* must be freed
A call to qof_instance_get expecting a gchar* receives a newly
allocated string which must be freed.
2021-08-15 09:49:06 +08:00
Christopher Lam
e4d808e674 [qofbook] qof_book_use_split_action_for_num_field: free a char*
qof_instance_get allocates a new char* which must be freed.
2021-08-13 08:58:07 +08:00
Christopher Lam
6fd19f2eea [dialog-lot-viewer] g_free a GList* properly
g_list_free requires the argument is the head of a GList. Calling
g_list_reverse makes the filtered_list points to the last
element. Assigning filtered_list to the result of g_list_reverse
ensures it still points to the head, allowing g_list_free to free the
list properly.
2021-08-13 08:56:34 +08:00
Christopher Lam
5ced0d932a Merge branch 'maint-account-cpp' into maint #1107 2021-08-12 17:39:45 +08:00
Frank H. Ellenberger
fa666e7367 L10N:sv:Update to PO-Revision-Date: 2021-08-03 from TP
5229 translated messages, 133 fuzzy translations.
2021-08-12 06:27:57 +02:00
Christopher Lam
40d886fa9d gnc_account_list_name_violations elements must be freed 2021-08-12 09:39:08 +08:00
Christopher Lam
4c37f6d4ef [account.cpp] gnc_g_list_stringjoin instead of repeated allocations 2021-08-12 09:19:34 +08:00
Christopher Lam
e84549926b [gnc-glib-utils] gnc_g_list_stringjoin to join a GList of strings
It traverses the GList twice (once to calculate the length) but
allocates only once.

Includes snippet from
https://www.joelonsoftware.com/2001/12/11/back-to-basics/
2021-08-12 09:19:34 +08:00
TianXing_Yi
8fc1563911
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5351 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-08-11 11:34:24 +02:00
Avi Markovitz
071bd209ac
Translation update by Avi Markovitz <avi.markovitz@gmail.com> using Weblate
po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Avi Markovitz <avi.markovitz@gmail.com>
2021-08-11 11:34:24 +02:00
Eric
6a8372affc
Translation update by Eric <spice2wolf@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5351 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: Eric <spice2wolf@gmail.com>
2021-08-11 11:34:23 +02:00
Christian Wehling
b1c1272f35
Translation update by Christian Wehling <christian.wehling@web.de> using Weblate
po/de.po: 99.8% (5357 of 5364 strings; 7 fuzzy)
250 failing checks (4.6%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Christian Wehling <christian.wehling@web.de>
2021-08-10 19:35:05 +02:00
TianXing_Yi
339f66810f
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5350 of 5364 strings; 1 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5350 of 5364 strings; 1 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5350 of 5364 strings; 1 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5350 of 5364 strings; 1 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5350 of 5364 strings; 1 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-08-10 19:35:05 +02:00
John Ralls
be6fb1abe2 Merge Chris Good's 'bug798205ImpOfx' into maint. 2021-08-07 14:39:57 -07:00
Christopher Lam
bedc85afa3 Merge branch 'maint-leaks' into maint #1101 2021-08-06 19:30:01 +08:00
Christopher Lam
0420ae6a66 [account.cpp] refactor gnc_account_list_name_violations 2021-08-06 17:31:36 +08:00
Christopher Lam
67bd513514 [account.cpp] rewrite gnc_account_foreach_descendant_until in C++ 2021-08-06 17:31:36 +08:00
Christopher Lam
17953441cb [account.cpp] refactor gnc_account_foreach_descendant 2021-08-06 17:31:36 +08:00