Andreas Lauser
2e75eaa0ac
Merge pull request #390 from joakim-hove/opm-rst-default-false
...
[Equinor internal]: Opm rst default false
2019-02-18 12:19:13 +01:00
Tor Harald Sandve
a86ee61bf6
Merge pull request #478 from andlaus/ebos_remove_mass_conservative_init
...
ebos: remove the code to calculate a mass conservative initial condtion if the specified condition is inconsistent
2019-02-18 11:18:12 +01:00
Andreas Lauser
3cd1252079
ebos: remove the code to calculate a mass conservative initial condtion if the specified condition is inconsistent
...
As far as I can see, this was always set to `false` anyway.
2019-02-15 13:45:23 +01:00
Andreas Lauser
0423676305
ebos: remove the DisableWells property
...
the purpose of this was a hack to be able to manipulate the Jacobian
matrix directly from outside code. Since `flow` has been converted to
the eWoms wells API, this is not required anymore.
2019-02-15 13:39:58 +01:00
Arne Morten Kvarving
c02ca868d6
Merge pull request #466 from atgeirr/handle-nnc
...
Use NNC support from CpGrid.
2019-02-14 10:22:42 +01:00
Arne Morten Kvarving
5da7b54047
remove unused local typedef
2019-02-13 11:55:09 +01:00
Andreas Lauser
0e761010a8
Merge pull request #472 from totto82/freeBC
...
Add support for using free boundary conditions in Flow
2019-02-08 20:50:02 +01:00
Tor Harald Sandve
a5463ed1a0
Add support for using free boundary conditions in Flow
...
The OPM spesific keywords FREEBC[XYZ[-]] can be used to specify
boundary cells that are open. Default is a closed boundary.
2019-02-07 14:56:55 +01:00
Atgeirr Flø Rasmussen
e926f557b8
Fix: indexInInside() and indexInOutside() return signed integers.
2019-02-07 12:00:49 +01:00
Atgeirr Flø Rasmussen
d087d7c41b
Use NNC support from CpGrid.
2019-02-07 12:00:49 +01:00
Andreas Lauser
51b24d33d5
EclWriter: remove obsolete writeOutput() overload
...
this has been unused for any simulator for a while. the only code
which called it was the ECL output test, but this one could be easily
ported.
2019-02-06 12:21:08 +01:00
Andreas Lauser
dc1b92521a
ebos: make it possible to account for external setup costs
2019-02-06 12:21:08 +01:00
Andreas Lauser
4ecda15b11
coding style fixes for the black-oil model and more style fixes for ebos
2019-02-01 17:33:30 +01:00
Andreas Lauser
7f27c4fb4b
fix coding style of the ECL tracer model
2019-02-01 17:33:30 +01:00
Andreas Lauser
9afa62b78b
fix some minor coding style issues in Ewoms::EclOutputBlackOilModule
2019-02-01 17:33:30 +01:00
Andreas Lauser
8b89e6ed97
unify coding style of Ewoms::AluCartesianIndexMapper
2019-02-01 17:33:30 +01:00
Andreas Lauser
c600d807b6
use the eWoms coding style conventions for Ewoms::TracerVdTable
2019-02-01 17:33:30 +01:00
Andreas Lauser
a9359602fc
fix some minor coding style inconsistencies in EclWriter
2019-02-01 17:33:30 +01:00
Andreas Lauser
80e04aa8b4
fix style issues in EclTransmissibility and make the editNnc handling a bit simpler
...
the new editNNC code might be slightly slower, but I doubt that the
difference is even measureable for real decks.
2019-02-01 17:33:30 +01:00
Andreas Lauser
0aa9a2c6b8
make the coding style of femcpgridcompat.hh consistent with the rest of eWoms/ebos
2019-02-01 17:33:30 +01:00
Tor Harald Sandve
fb34eb304c
Fix generic boundary conditions for blackoil model
...
Currently it doesn't allow for polymer or solvent influx
on the boundary with the free flow option
2019-01-31 15:41:47 +01:00
Andreas Lauser
70a7207578
Merge pull request #465 from GitPaean/fixing_single_precision_restart
...
each phase needs to be above certain value to be treated to be present
2019-01-22 16:11:53 +01:00
Kai Bao
56e829329f
each phase needs to be above certain value to be treated to be present
...
it helps to recover some RESTART running based on single precision
format.
2019-01-22 13:53:08 +01:00
Andreas Lauser
dc6de0c31a
Merge pull request #463 from totto82/convertFIPtoLAB
...
convert FIP values to LAB scale
2019-01-21 16:19:04 +01:00
Tor Harald Sandve
ee7b47e0f9
convert FIP values to LAB scale
2019-01-21 14:55:40 +01:00
Tor Harald Sandve
22097d4c10
Add trivial connection output to silence the output code
...
In this PR only trivial data is added.
2019-01-18 14:57:25 +01:00
Markus Blatt
3b8ef5f004
one line per variable as requested.
2019-01-16 13:16:45 +01:00
Markus Blatt
d87c5764b9
Use doxygen style suggested by reviewer.
2019-01-16 13:16:45 +01:00
Markus Blatt
ace49a2c22
Adhere to CamelCase for types, functions, and variables.
...
This seems to be covered for types and functions by our coding style
with room for interpretation. For variables the coding styles asks for
underlines though, but nevermind.
2019-01-16 13:16:45 +01:00
Markus Blatt
fb0f04d814
[bugfix] Cater for multiple EDITNNC entry for same cell pair.
2019-01-16 13:16:45 +01:00
Markus Blatt
64326dad53
[bugfix] Prevent accessing elements beyond end of NNC entries.
2019-01-16 13:16:45 +01:00
Markus Blatt
362476a494
[bugfix] Prevent double scaling of NNC with EDITNNC resembled trans
...
The former order resulted of first apply NCC to the grid
transmissibilities and then applying EDITNNC resulted in NNCs being
scaled twices. The reason is that applyNNCToGridTrans_ scales the NNC
with EDITNNC. With the patch the order of the function calls is
reversed to prevent double scaling.
2019-01-16 13:16:45 +01:00
Markus Blatt
5e83a26908
Process values from NNC keyword for those connection resembled by grid.
...
This is includes neighboring connection and NNCs due to faults. In both
cases the transmissibilities of specified via NNC are added to the set or
computed ones.
This is the first step for supporting NNC in flow.
2019-01-16 13:16:45 +01:00
Joakim Hove
c4c0d4ab9f
Set default value of parameter EnableOpmRstFile to false
2019-01-15 13:05:45 +01:00
Kai Bao
9e483bed45
updating more quantities when restart
...
lastRs_, lastRv_, maxDRs_, maxDRv_
to get better restart.
2019-01-12 17:20:44 +01:00
Tor Harald Sandve
f971caeae9
Merge pull request #428 from andlaus/EclNewtonMethod
...
ebos: introduce an EclNewtonMethod
2019-01-11 13:06:20 +01:00
Andreas Lauser
c2377e7b10
EclNewtonMethod: make the exponent of the tolerance scaling settable by a parameter
...
the parameter is called `EclNewtonSumToleranceExponent`. if it is set
to 1, the specified tolerance will be used directly. (this is not
desireable in the general case though, because at the same result
quality, the sum error for large reservoirs can be larger than for
small ones.)
2019-01-11 11:24:20 +01:00
Andreas Lauser
0492796e85
address review comments
2019-01-11 11:21:23 +01:00
Andreas Lauser
ec391f529d
make the ebos-Newton specific parameters setable from the command line
...
also, tweak them a bit: increase the sum tolerance before scaling to
1e-3 and reduce the default number of strict iterations to 4.
2019-01-11 11:21:23 +01:00
Andreas Lauser
c08f0008ad
EclNewtonMethod: tweak the parameters a bit
2019-01-11 11:21:23 +01:00
Andreas Lauser
85a9b75076
ebos: allow larger errors for larger reservoirs
...
albeit, we scale the error only to the cube root of the pore
volume. the rationale is that the same amount of mass can get lost
"along" a line for each timestep.
maybe it would be a good idea to do something like this for time step
size as well because taking multiple small time steps currently allows
a much larger error in the result than doing it in one big step.
2019-01-11 11:21:23 +01:00
Andreas Lauser
07e1b4ecde
ebos: introduce an EclNewtonMethod
...
this calculates the error and convergence differently from the
standard Newton method.
2019-01-11 11:21:23 +01:00
Joakim Hove
c223b4f4d4
Add StrictParsing commandline option
2019-01-11 09:01:30 +01:00
Andreas Lauser
18e64d0e7e
fix some masochistic compiler warnings for the GCC 9 pre-release
...
the flags which I used are
```
-pedantic \
-Wall \
-Wextra \
-Wformat-nonliteral \
-Wcast-align
-Wpointer-arith \
-Wmissing-declarations \
-Wcast-qual \
-Wshadow
-Wwrite-strings \
-Wchar-subscripts \
-Wredundant-decls \
-fstrict-overflow \
-O3 \
-march=native \
-DNDEBUG=1
```
note that some heavy filtering is not the worst idea because DUNE is
far from not emiting any warnings with these flags.
Also, there were some pesky warnings in test_ecl_output which I don't
know how to fix:
```
tests/test_ecl_output.cc:218:73: warning: missing initializer for member ‘Opm::data::Connection::effective_Kh’ [-Wmissing-field-initializers]
```
2019-01-09 09:34:26 +01:00
Andreas Lauser
5d581bab7e
ebos: fix explicit init for twophase cases
...
since OPM/opm-material#310 has been merged, data for deactivated
phases is not stored anymore and can thus no longer be accessed/set.
this fixes OPM/opm-simulators#1686
2019-01-08 11:18:17 +01:00
Joakim Hove
1706ae1ae4
Merge pull request #453 from joakim-hove/error-guard
...
Add ErrorGuard argument when parsing
2019-01-08 07:49:10 +01:00
Joakim Hove
c8564cfad3
Add ErrorGuard argument when parsing
2019-01-07 12:05:30 +01:00
Andreas Lauser
cf88834f67
Merge pull request #450 from totto82/add_support_for_multz_all
...
Add support for the Multz option ALL in PINCH
2019-01-07 10:04:09 +01:00
Tor Harald Sandve
227c0eab90
Merge pull request #452 from andlaus/recompute_old_storage
...
make it possible to explicitly compute the storage term of the previous time step
2019-01-04 13:11:40 +01:00
Tor Harald Sandve
625a4cd303
Merge pull request #433 from andlaus/conditional_temperature
...
ebos: only write out temperature in thermal runs
2018-12-21 12:48:54 +01:00