Kai Bao
c25e1392ba
ignoring analytical aquifers without valid connections
2022-08-23 15:50:50 +02:00
Arne Morten Kvarving
3faccb4a17
changed: reduce some code duplication
2022-08-23 09:31:27 +02:00
Arne Morten Kvarving
3ef07d7f62
changed: put ParallelOverlappingILU0 in separate compile unit
...
i chose to split in a separate _impl file because this code is so
generic that there may be downstream users who want to use on other
matrix types than what we use in opm-simulators.
2022-08-22 11:21:31 +02:00
Markus Blatt
c631a4ee63
Merge pull request #4018 from akva2/preconditionerfactory_separate
...
changed: split PreconditionerFactory in _impl file
2022-08-22 10:16:45 +02:00
Arne Morten Kvarving
ec089af048
changed: split PreconditionerFactory in _impl file
...
and put instances in separate cpp files.
2022-08-22 09:33:15 +02:00
Atgeirr Flø Rasmussen
04fe35a82e
Merge pull request #4013 from GitPaean/num_aquifer_construct_simpli
...
simplifying the constructor for AquiferNumerical
2022-08-22 08:20:34 +02:00
Markus Blatt
e7cc14de4c
Revert: Split PreconditionerFactory in _impl file
...
This reverts commit 7f8c88769e
.
Apparently the macros unconditionally use Classes that are only
there for parallel builds.
2022-08-19 14:42:55 +02:00
Arne Morten Kvarving
7f8c88769e
changed: split PreconditionerFactory in _impl file
...
and put instances in separate cpp files.
2022-08-19 12:43:28 +02:00
Tor Harald Sandve
0f969dd7a5
check ipr for wells prevented to change to thp
2022-08-19 10:48:56 +02:00
Tor Harald Sandve
7a8eed6a6c
adapt to renaming in opm-common
2022-08-19 10:33:19 +02:00
Tor Harald Sandve
96222f8afb
dont use explicit vfp lookup for newly opened wells
2022-08-19 10:33:19 +02:00
Tor Harald Sandve
9364d4c54b
Add option for wvfpexp item 2 plus minor fixes
2022-08-19 10:33:19 +02:00
Tor Harald Sandve
e875849497
Adapt test cases and vfpprint
2022-08-19 10:33:19 +02:00
Tor Harald Sandve
b1b23a57de
Add option for explicit vfp lookup for problmatic wells
2022-08-19 10:33:19 +02:00
Bård Skaflestad
b87154223b
Restore Non-MPI Builds
...
Commit 371b2592f
misordered the closing brace of a namespace and
the conditional declarations dependent upon MPI availability. This
commit restores the expected order and fixes non-MPI builds.
2022-08-18 16:08:41 +02:00
Kai Bao
d69c80b84a
simplifying the constructor for AquiferNumerical
...
removing the unused global_cell and avoid the unnecessary construction of cartesianToCompressed
2022-08-18 15:55:04 +02:00
Arne Morten Kvarving
371b2592f5
changed: put ParallelIstlInformation in separate compile unit
2022-08-18 09:15:28 +02:00
Atgeirr Flø Rasmussen
c94ff12e4c
Bugfix and simplification of cartesian mapping.
...
We already have the mapping available, and using the equilGrid() is only valid
on rank 0.
2022-08-17 14:13:13 +02:00
Bård Skaflestad
1ca731a388
Merge pull request #4007 from atgeirr/limit-terminal-warnings-during-deck-input
...
Limit warnings to terminal during deck input.
2022-08-16 18:20:05 +02:00
Atgeirr Flø Rasmussen
04180031e1
Limit warnings to terminal during deck input.
...
With this, the tag limit of 10 is used from the very start of the run,
and not only after the deck has been read.
2022-08-16 14:43:07 +02:00
Arne Morten Kvarving
a32a32649d
changed: put MILU in separate compile unit
2022-08-16 10:46:20 +02:00
Arne Morten Kvarving
d2ba2e75e8
remove include of Well header
2022-08-11 11:49:42 +02:00
Arne Morten Kvarving
4917c860fe
BlackOilAquiferModel: use aquifers through base interface
2022-08-11 10:04:49 +02:00
Arne Morten Kvarving
271d5bee3a
added: (re)introduce AquiferInterface
...
now a base class for both analytical and numerical aquifers
2022-08-11 09:59:49 +02:00
Arne Morten Kvarving
f166920e75
changed: rename AquiferInterface to AquiferAnalytical
2022-08-11 09:59:49 +02:00
Arne Morten Kvarving
66b4f1edb7
Aquiferxxx: some modernization
...
- typedef -> using
- use constexpr
2022-08-11 09:59:46 +02:00
Bård Skaflestad
e73d3368e0
Merge pull request #3989 from Tongdongq/tweak-opencl-launch-params
...
Tweak opencl launch params v2
2022-08-10 14:22:52 +02:00
Tong Dong Qiu
18d9f8cca7
Include missing header
2022-08-10 14:03:32 +02:00
Atgeirr Flø Rasmussen
a5c8d40cfa
Remove unneeded timeIdx arguments, also silence other warnings.
2022-08-10 10:01:54 +02:00
Tong Dong Qiu
58b20fe2fb
Tweak ILU opencl kernel launch params
2022-08-09 13:39:35 +02:00
Tong Dong Qiu
d0aa42e9e3
Reduce source code line lengths
2022-08-09 13:38:57 +02:00
Tong Dong Qiu
5607329b05
Backport to fix ChowPatelIlu
2022-08-09 11:49:47 +02:00
Atgeirr Flø Rasmussen
90e8a9af69
Do not change true impes weights.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
322dcbfb36
Make getWaterFlux() take const ref argument. Minor formatting cleanups.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
cabe64cc58
Further reduction of modifications.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
5fba14373b
Modification to reduce PR to minimal changes.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
5042b02138
Rename method and move to impl file.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
0da2b68e0b
Adapt to changed interface.
2022-08-09 11:11:36 +02:00
Atgeirr Flø Rasmussen
b1bcab31b9
Refactor addToSource to add interface not using element context.
2022-08-09 11:09:48 +02:00
Atgeirr Flø Rasmussen
66a1c46413
Remove unused code branch.
2022-08-09 11:09:48 +02:00
Atgeirr Flø Rasmussen
5d0ae333f4
Fix: add template argument.
2022-08-09 11:09:48 +02:00
hnil
f751279841
fixed true impes for new code
2022-08-09 11:09:48 +02:00
hnil
4f6755025c
-prototype on trueimpes in new system
...
-probably better threading
2022-08-09 11:09:48 +02:00
hnil
6d3b0a7c1f
tried to make openmp work
2022-08-09 11:09:48 +02:00
hnil
5a39724606
added functions for direct setting of well rates contribution to reservoir
2022-08-09 11:09:48 +02:00
hnil
8f5e0940fe
restructuring to be able to call without local indices
2022-08-09 11:09:48 +02:00
hnil
d53b6ad9fa
added spesialisation for using simple property updating
2022-08-09 11:09:48 +02:00
hnil
060877a08b
runs first steps of norne
2022-08-09 11:09:48 +02:00
hnil
95308d7d02
ensure intensive quantities is updated
2022-08-09 11:09:48 +02:00
Atgeirr Flø Rasmussen
93ce28e9a2
Merge pull request #3972 from ElyesAhmed/alugrid2
...
Alugrid2
2022-08-04 15:43:24 +02:00
Arne Morten Kvarving
36b167b451
remove use of Unused.hpp
2022-08-02 11:53:54 +02:00
Markus Blatt
af28030123
Merge pull request #3983 from blattms/fix-perf-all-zero
...
[bugfix] Fixes deadlocks with agressively distributed wells
2022-07-29 09:37:10 +02:00
Elyes Ahmed
5c2b60bcd0
rebasing
2022-07-28 20:40:34 +02:00
Markus Blatt
941957c13e
Fix shadowed variable warning.
2022-07-28 19:50:24 +02:00
Markus Blatt
c22114af41
Handle injection/producer targets correctly for distributed wells.
...
We should never return in a function if there are no local
perforations for a distributed well, but that is what we did before
this fix.
2022-07-28 17:52:26 +02:00
Arne Morten Kvarving
eeeeb283c5
remove unnecessary includes
2022-07-26 19:03:39 +02:00
Markus Blatt
f7dec58ee2
Fix deadlock for distributed wells when calculating densities/pressures
...
There was a check that is supposed that all rates are zero but for
distributed wells it only checked local perforations. Of course that
can lead to different outcome on processes for distributed wells.
2022-07-15 17:58:04 +02:00
Markus Blatt
412cf1d6cd
Merge pull request #3976 from blattms/well-fix-distributed-tw
...
[bugfix] Fix well transmissibility weights for distributed wells.
2022-07-15 10:39:48 +02:00
Markus Blatt
bfd1d3187a
[bugfix] Fix well transmissibility weights for distributed wells.
...
If we compute a sum over all perforations than we need to cater for the
case of distributed wells. That is we need to also sum up over all processes
involved after performing the local sum.
One of these global sums was missing in computeWellConnectionDensitesPressures
for producers when we compute the weights based on well transmissibilities.
2022-07-13 13:40:16 +02:00
Bård Skaflestad
bdfe58f500
Merge pull request #3975 from OPMUSER/Unsupported-Keywords
...
Unsupported keywords
2022-07-12 13:00:50 +02:00
OPMUSER
f9ba52e91b
Update UnsupportedFlowKeywords.cpp
...
Remove MINPORV from unsupported keyword list
2022-07-09 20:13:30 +08:00
Elyes Ahmed
cd169660e8
rewriting MaxWellConnections
2022-07-08 13:44:38 +02:00
OPMUSER
65addddb06
Update UnsupportedFlowKeywords.cpp
...
Remove TEMPVD from the unsupported key list, as tested as working.
2022-07-08 18:20:18 +08:00
OPMUSER
b784a6d78b
Update UnsupportedFlowKeywords.cpp
...
Remove RTEMPA from the unsupported keywords list as testing shows it is supported.
2022-07-08 17:36:12 +08:00
Bård Skaflestad
9d9ec6c522
Revert "Tweak opencl launch params"
2022-07-07 15:21:53 +02:00
Markus Blatt
f22d58a1d0
Merge pull request #3953 from Tongdongq/tweak-opencl-launch-params
...
Tweak opencl launch params
2022-07-07 10:43:15 +02:00
Tor Harald Sandve
04b0c3515d
Merge pull request #3957 from totto82/regStw
...
regularize equation for problematic std wells
2022-06-30 11:24:20 +02:00
Tor Harald Sandve
cf1abb086f
remove msw(ms) from regulariztion parameter
2022-06-29 15:39:51 +02:00
Kai Bao
1b3cee8088
using C++17 style for to reduce nesting level of for loop
2022-06-29 14:20:35 +02:00
Tor Harald Sandve
eef455106d
regularize equation for std wells
2022-06-29 12:47:44 +02:00
Kai Bao
64143cd417
when a valve is shut, the rate and pressure drop will be zero
2022-06-29 11:54:36 +02:00
Tong Dong Qiu
85776f528a
Tweak ILU opencl kernel launch params
2022-06-28 12:42:52 +02:00
Bård Skaflestad
5b2d1ca5ec
Merge pull request #3959 from blattms/warn-long-fault
...
Warn about fault names with more than 8 characters
2022-06-28 10:29:36 +02:00
Arne Morten Kvarving
133856b943
changed: avoid lambda capture
...
clang warns it's not necessary to use a capture for this.
i opted to make it constexpr and avoid the capture with gcc as well.
2022-06-27 14:47:56 +02:00
Arne Morten Kvarving
9751b78992
fixed: add virtual dtor to class with virtual members
2022-06-27 14:47:44 +02:00
Arne Morten Kvarving
1794934f0d
anonymize unused parameters
2022-06-27 14:47:44 +02:00
Markus Blatt
6aea0fab37
Added instantiations of OrderedMap with truncated keys for parallel.
2022-06-27 13:09:09 +02:00
Markus Blatt
ebb8fc7aae
Warn about about long fault -name
2022-06-27 13:09:08 +02:00
Markus Blatt
e14823c6d8
Merge pull request #3941 from akva2/remove_int_sim_config
...
Remove support for internal simulator configuration
2022-06-27 11:05:18 +02:00
Markus Blatt
25a92c2c2c
Merge pull request #3958 from Tongdongq/fix-gpu-well-apply
...
Fix stdwell apply on GPU
2022-06-24 16:02:34 +02:00
Arne Morten Kvarving
a4d254b749
changed: introduce EclGenericVanguard::setParams
...
this is used transferring ownership of setup structures to the
simulator. drop all the flowEbosXXX set deck methods and use the
generic vanguard. also means various structs that were only passed
in the blackoil simulator are now passed in all simulators.
2022-06-24 15:06:13 +02:00
Arne Morten Kvarving
00c374be5c
changed: remove support for internal summaryconfig handling in simulators
2022-06-24 15:06:13 +02:00
Arne Morten Kvarving
4510f40b6d
changed: remove support for internal schedule handling in simulators
2022-06-24 15:06:13 +02:00
Arne Morten Kvarving
1a35c5ac47
changed: remove support for internal eclstate handling in simulators
2022-06-24 15:06:13 +02:00
Arne Morten Kvarving
371c8058bc
changed: remove support for internal deck handling in simulators
2022-06-24 15:06:13 +02:00
Tong Dong Qiu
1f1fa10927
Fix stdwell apply on GPU
2022-06-24 13:48:59 +02:00
Tong Dong Qiu
842a9a9317
Reduce source code line lengths
2022-06-23 10:21:34 +02:00
Tong Dong Qiu
c4ebed1718
Backport to fix ChowPatelIlu
2022-06-23 10:17:14 +02:00
Markus Blatt
f3bf15ab2f
Merge pull request #3946 from Tongdongq/fix-gpu-verbose-timing
...
Fix: verbose timing for openclSolver
2022-06-22 16:13:57 +02:00
Arne Morten Kvarving
da57e15271
fixed: fix build with dune 2.6
2022-06-20 14:16:43 +02:00
Tong Dong Qiu
4384872f8e
Only use timers when printing their results,
...
and actually wait for kernels to finish when timing GPU
2022-06-17 16:02:56 +02:00
Atgeirr Flø Rasmussen
ffb09ee53e
Merge pull request #3937 from atgeirr/pressure-bhp-cpr
...
Pressure bhp cpr
2022-06-16 17:15:49 +02:00
Atgeirr Flø Rasmussen
c871e603f8
Do not insert unused options.
2022-06-16 16:24:41 +02:00
Atgeirr Flø Rasmussen
66ff942b2f
Move MatrixBlock specializations inside namespace.
...
This is necessary since the calls are ns-qualified in the
matrix market code.
2022-06-16 11:37:40 +02:00
Tor Harald Sandve
60d0fe0f87
Merge pull request #3879 from totto82/rsrvinj2
...
WIP implement rsrv item 10 WCONINJE
2022-06-16 08:30:31 +02:00
Bård Skaflestad
7512c0c247
Merge pull request #3906 from totto82/regMSW100
...
change default reg factor for MSW to 100
2022-06-13 20:15:33 +02:00
Atgeirr Flø Rasmussen
2992ec25d8
Address issues raised in review.
2022-06-10 15:59:45 +02:00
Atgeirr Flø Rasmussen
7fe3839500
Use MatrixBlock consistently, also whitespace cleanup.
2022-06-10 11:08:24 +02:00
Atgeirr Flø Rasmussen
16b1756339
Add necessary include statements.
2022-06-09 10:38:47 +02:00
hnil
98acda0977
- change FieldMatrix to MatrixBlock in Tracer model to not need extra initializations in linear solver
2022-06-08 17:03:27 +02:00
Atgeirr Flø Rasmussen
a0f16089f7
Re-add explicit instantiation of FlexibleSolver to reduce compile time.
2022-06-08 17:03:27 +02:00
hnil
06a8b0ee3d
fixed bug after changing duneD to invDuneD
2022-06-08 17:03:27 +02:00
hnil
4ead854b69
- taking pullrequest information into account
...
- Moving transfere level to be template of OwningTwolevelPrecontitioner
2022-06-08 17:03:27 +02:00
hnil
8f4cf8a952
removed compiler warnings
2022-06-08 17:03:27 +02:00
hnil
66c4a8c862
made resue interval separate paramter
2022-06-08 17:03:27 +02:00
hnil
3bed1ebbdb
fixed bug in default options for cprw
2022-06-08 17:03:27 +02:00
hnil
541edeaf67
- add default for CPRW
...
- cleanded code
2022-06-08 17:03:27 +02:00
hnil
8a757a4935
removed comments
2022-06-08 17:03:27 +02:00
hnil
6c407506a9
cleaning code
2022-06-08 17:03:27 +02:00
hnil
5a917dd11e
changed diagonal elements for cprw on multiscale wells
2022-06-08 17:03:27 +02:00
hnil
a8acd40f4a
Changes to make ms wells work with cprw
2022-06-08 17:03:27 +02:00
hnil
141a816e5d
new restart options
2022-06-08 17:03:25 +02:00
hnil
12fba38d99
Added maximum sparsity pattern which made full reuse possible. May degrade som of the performance fore not full reuse(not tested).
2022-06-08 17:02:02 +02:00
hnil
aba1d5047d
working with no resue on norne
2022-06-08 17:02:02 +02:00
hnil
c697e70a69
changed definition of extra equations. made norne go to step 27. HACK
2022-06-08 17:02:02 +02:00
hnil
4975d5d9e7
- fixed extended communicator
...
- fixed scaling of well cpr
2022-06-08 17:02:02 +02:00
hnil
da572d1f60
-Fixed buges related to cpr with wells.
...
- change interfaces to have access to pressureVarIndex
- added option in cmake files to propagate checking in dune-istl
2022-06-08 17:02:02 +02:00
Atgeirr Flø Rasmussen
fef06a77af
Updated for upstream changes.
2022-06-08 17:02:02 +02:00
hnil
f3acfcde0b
Adding functions for pressure system manipulation to well models.
...
Also add well-aware operator and transfer policy.
This will be used for CPR with custom operators.
2022-06-08 17:01:33 +02:00
Bård Skaflestad
e6dff88eb7
Temporarily Limit Block-Jacobi Partitioner to OpenCL Only
...
The block-Jacobi partitioner (commit e360c00b7
) uses grid interfaces
that are only available in CpGrid and this blocks introducing other
grid managers such as ALUGrid. Since the partitioner was only added
for OpenCL, guard special purposes accesses with HAVE_OPENCL.
This is a temporary measure and we will venture to restore the
partitioner later, although possibly restricted to CpGrid only.
2022-06-08 16:14:39 +02:00
Bård Skaflestad
b593baff2f
Merge pull request #3926 from totto82/fix_operability
...
Fix well operability
2022-06-08 16:09:02 +02:00
Tor Harald Sandve
1f876d1800
implement rsrv item 10 WCONINJE
...
MSW not supported yet
2022-06-08 13:55:29 +02:00
Tor Harald Sandve
46c8aa3306
fix hydrostatic correction for branched wells in IPR
2022-06-08 12:29:05 +02:00
Markus Blatt
ac59429e01
Merge pull request #3935 from Tongdongq/fix-replace-zero-diagonal
...
Fix: zeros were not replaced correctly in the diagonal for GPU
2022-06-08 12:28:30 +02:00
Tong Dong Qiu
91a54645fb
Fix: zeros were not replaced correctly in the diagonal
...
And minor changes
2022-06-08 10:00:22 +02:00
Tor Harald Sandve
3adaa1b987
fix component/phase mixup
2022-06-07 14:14:13 +02:00
Tor Harald Sandve
e965dac3ee
Only flag a bhp producer/injector operable if the sum of IPR are negative/positive
2022-06-07 10:47:22 +02:00
Tor Harald Sandve
147fe77779
Merge pull request #3934 from totto82/stopnocross
...
stopped wells where cross flow is not allowed are not added to the container
2022-06-07 10:36:07 +02:00
Tor Harald Sandve
cec8e7c724
Merge pull request #3924 from totto82/steeringBHPtoHighestRate
...
Steer bhp towards the solution with the highest production rate
2022-06-07 10:35:53 +02:00
Tor Harald Sandve
6cc71375b4
stopped wells where cross flow is not allowed are not added to the container
2022-06-07 10:01:02 +02:00
Bård Skaflestad
be4221ea92
Merge pull request #3869 from plgbrts/vapoilwat
...
adding three-phase simulator including water evaporation and salt precipitation
2022-05-25 15:33:53 +02:00
Tor Harald Sandve
6f410e7b03
Steer bhp towards the solution with the highest production rate
2022-05-25 15:30:36 +02:00
Tor Harald Sandve
cce9e2d0b3
Merge pull request #3910 from hakonhagland/python_rates2
...
Dynamically update Opm::Schedule from Python
2022-05-25 08:42:13 +02:00
Bård Skaflestad
252d0afe8e
Emit Actual Message on Input Failure
...
This gives more information to the user and hopefully aids them in
resolving the underlying issue.
2022-05-20 16:30:19 +02:00
Markus Blatt
02aaec82f7
Merge pull request #3815 from Tongdongq/subdomain-matrix-for-opencl
...
Subdomain matrix for opencl ILU preconditioner
2022-05-20 16:05:14 +02:00
Kai Bao
15bf35ffe0
removing unused well_state0 in iterateWellEqWithControl
...
for MSW.
2022-05-18 10:18:35 +02:00
Paul Egberts
a255613452
Merge branch 'master' into vapoilwat
2022-05-11 11:55:54 +02:00
Paul Egberts
6fe10a3e23
add throw for case msw is true and vapwat is true
2022-05-11 11:50:54 +02:00
Håkon Hægland
91ac3a2a32
Dynamically update schedule from Python
...
Adds some methods that enables Opm::Schedule to be dynamically modified
from Python. A test case in test_schedule.py illustrates the use case.
2022-05-05 13:10:39 +02:00
Tong Dong Qiu
b00d31042c
Check if memory for nnzs is contiguous
2022-05-04 16:15:57 +02:00
Tor Harald Sandve
ea82bebb3a
Merge pull request #3909 from totto82/fix_reg_msw
...
reset regularize_ before starting the inner iterations
2022-05-03 13:44:00 +02:00
Tor Harald Sandve
4150ec5f67
Merge pull request #3756 from osae/letRelperms
...
Support for LET-based saturation functions.
2022-05-03 13:39:32 +02:00
Paul Egberts
5a23084846
restored MultisegmentWellEval.cpp
2022-05-03 11:54:41 +02:00
Tor Harald Sandve
dfe0982286
reset regularize_ before starting the inner iterations
2022-05-03 08:25:26 +02:00
Kai Bao
57d8f1aa24
update primary variables in prepareTimeStep
...
it should not change running results.
2022-05-02 13:47:16 +02:00
Tor Harald Sandve
6bf90c9ebe
change default reg factor for MSW to 100
2022-05-02 09:41:43 +02:00
Tor Harald Sandve
74d8db36c5
Merge pull request #3859 from totto82/default_strict
...
use a relaxed (but not too relaxed) well tolerance when iter>6
2022-04-29 15:53:53 +02:00
Kai Bao
7145ec32ee
renaming function updateWellState
...
to updatePrimaryVariablesNewton
this should be a fallout during the well code refactoring
2022-04-29 12:55:54 +02:00
Arne Morten Kvarving
7edca13df6
fixed: add missing config.h include
2022-04-28 11:38:02 +02:00
Markus Blatt
51d8c9536e
Spelling fix geomtry -> geometry.
...
Actually one should rename the function used from opm-common, too.
But that is for later...
2022-04-27 20:52:30 +02:00
Markus Blatt
c66fb8a93d
Added support for water-only and water-only + thermal to flow.
...
Also run the onephase tests with flow now.
2022-04-26 17:07:09 +02:00
Tor Harald Sandve
52fca6c91d
use a relaxed (but not too relaxed) well tolerance when iter>6
...
also shut unsolvable wells during iterations as default
Note however that getWellConvergence return false if a well is unsolvable
i.e. it will cut the timestep and redo the iteration if the well is unsolvable
and only shut it completly if the time step is below the
MinTimeStepBeforeShuttingProblematicWellsInDays (default 0.01 days)
2022-04-26 10:55:22 +02:00
Tor Harald Sandve
4b5a53eaeb
Merge pull request #3887 from totto82/init_alt_eps
...
use alternative init for wells with all rates less than eps
2022-04-26 10:46:19 +02:00
Tor Harald Sandve
bd145913e8
use alternative init for wells with all rates less than eps
2022-04-26 09:32:18 +02:00
Atgeirr Flø Rasmussen
75ccd88f4f
Merge pull request #3888 from totto82/stop_tgr2
...
fix trivial group target
2022-04-26 08:34:06 +02:00
Atgeirr Flø Rasmussen
374b25639e
Merge pull request #3872 from totto82/fix_stop_inoperable
...
Fix STOP in combination with inoperable/unsolvable
2022-04-25 10:31:02 +02:00
Tor Harald Sandve
d00a2e2341
fix trivial group target
2022-04-25 08:10:19 +02:00
Markus Blatt
d58e11d591
Merge pull request #3875 from OPMUSER/Radial-Spider-Grid-Update-Backport-Candidate
...
Radial and Spider Grid Keywords Not Supported
2022-04-22 14:24:54 +02:00
Tor Harald Sandve
92175cf094
Fix STOP in combination with inoperable/unsolvable
2022-04-22 09:15:09 +02:00
Tor Harald Sandve
c8bef3bcd5
only check if wells has negative potentials if check_well_operabilty=true(default)
2022-04-22 08:19:33 +02:00
Tong Dong Qiu
cb1ee68967
Fix ILU0 creation for NONE reordering
2022-04-21 17:19:02 +02:00
Tong Dong Qiu
50d7c0f61d
Tweak verbosity for opencl
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
68b604c85f
Speed up reordering for opencl
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
fc298d8f9c
Allow cusparseSolver to use jacMatrix
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
4db112cafa
Use row_wise mode to build jacMatrix
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
1a1bc24bef
Delay creating sparsity pattern for jacobi Matrix
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
2683019280
Bugfix: set vector size for MSwells was removed during refactoring
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
448af67ce6
Merge duplicate functions
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
6ca5f167b2
Allow BISAI to use jacMatrix
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
6f89629f92
Fix wrong print, remove unused variables
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
1cec56fa68
Use implicit mode to build jacMatrix
...
Fix print variable
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
550ce92902
Faster copying to jacMatrix
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
3797b7297d
Merge some duplicate functions
2022-04-21 17:19:01 +02:00
Tong Dong Qiu
d963820e48
Pass BlockedMatrix to BdaSolvers
2022-04-21 17:19:00 +02:00
Tong Dong Qiu
7f5322f7d4
Store a BlockedMatrix in BdaBridge
2022-04-21 17:19:00 +02:00
Tong Dong Qiu
9dec714590
Allow to use jacobi matrix for ILU with CPR
...
Fix whitespace
2022-04-21 17:19:00 +02:00
Tong Dong Qiu
61f693dbaf
reenable normal opencl
...
Rebased
2022-04-21 17:18:54 +02:00
Tong Dong Qiu
dee5e16fb8
subdomain matrix for opencl
...
Rebased
2022-04-21 17:18:40 +02:00
Tong Dong Qiu
e360c00b73
add block-jacobi partitioner option. Add block-jacobi matrix for use in OpenCL preconditioner
...
Rebased
2022-04-21 17:18:32 +02:00
Tor Harald Sandve
969dff4ede
Merge pull request #3864 from totto82/regMSW
...
regularize MSW equation when iter > strict_inner_iter
2022-04-21 09:15:15 +02:00
Tor Harald Sandve
03c1884533
Merge pull request #3873 from totto82/aprox_thp
...
tighten approximated solution bhpFromThpLimit from 3 to 0.1 bar
2022-04-21 08:56:57 +02:00
Tor Harald Sandve
fd6cf1ccbd
regularize MSW equation when iter > strict_inner_iter
2022-04-21 08:44:50 +02:00
Håkon Hægland
9d04895ddb
Fix assertion error for 2p oil water
...
VFP calculations for two phase gas lift does not work unless the
rates are adpated to include a zero gas rate.
2022-04-20 21:47:15 +02:00
Håkon Hægland
11907495c1
Well testing of gas lift wells
...
Assign a maximum ALQ value to each GLIFT producer when doing well testing
in beginTimeStep(). This allows the well to be considered open. Then,
later in the timestep, when assemble() is called, the full gas lift
optimization procedure can adjust the ALQ to its correct value.
It is also observed that in some cases when gas lift is switched off by
setting ALQ to zero, and later in the schedule is switched back on again,
it might not be possible to determine bhp from thp for low small ALQ values.
Instead of aborting the gas lift optimization, we should try increasing
ALQ until we get convergence or until the maximum ALQ for the well is
reached.
2022-04-20 10:51:34 +02:00
OPMUSER
89461ed058
Radial and Spider Grid Keywords Not Supported
...
Add the DR, DTHETA and OUTRAD keywords as unsupported keywords with messages to enable the user to debug the input deck.
Back port candidate for release.
2022-04-20 14:19:56 +08:00
Tor Harald Sandve
a1d11540a6
tighten approximated solution bhpFromThpLimit from 3 to 0.1 bar
2022-04-19 14:21:20 +02:00
Paul Egberts
17f2365406
clean up comments
2022-04-11 22:15:35 +02:00
Paul Egberts
c2fa5fc5a8
adding three-phase simulator including water evaporation and saltpreciopitation
2022-04-11 21:56:44 +02:00
Tor Harald Sandve
edf8786a58
avoid throw for nan residuals instead return well as unconverged
2022-04-11 09:52:25 +02:00
Markus Blatt
ff410d268a
Merge pull request #3863 from totto82/unsolvable_fix
...
fix to --shut-unsolvable-wells=true option
2022-04-11 07:33:46 +02:00
Paul Egberts
ab3be6dce4
adjustments to account for vaporized water
2022-04-08 22:36:39 +02:00
Tor Harald Sandve
6f29bf715c
Merge pull request #3778 from GitPaean/always_inner
...
[testing] always using inner iterations for testing purpose.
2022-04-08 15:44:33 +02:00
Ove Sævareid
81249bccc4
Support for LET-based saturation functions.
2022-04-08 12:01:54 +02:00
Tor Harald Sandve
e501a84958
support item 4 wvfpexp
2022-04-08 08:43:13 +02:00
Tor Harald Sandve
0c9bb3990e
Merge pull request #3830 from plgbrts/vapwat
...
Adding explicit input specification of water-gas ratio (RVW) and RVW output plus simulator gas-water system with salt precipitation and water evaporation for
2022-04-07 09:03:26 +02:00
Markus Blatt
282951dc44
Merge pull request #3848 from blattms/binary-package-version-no-buildtime
...
Use empty string for buildtime if BUILD_TIMESTAMP is not set.
2022-04-05 14:54:58 +02:00
Tor Harald Sandve
e2e0ec9dd9
fix to --shut-unsolvable-wells=true option
2022-04-05 14:42:27 +02:00
Tor Harald Sandve
fba9046201
Some more clean-up based on review
2022-04-04 11:37:31 +02:00
Tor Harald Sandve
69ffed06de
Address comments from review
...
1) Add debug messages
2) Fix bug of missing else in the code
2022-04-04 08:24:32 +02:00
Tor Harald Sandve
5b53fcd8a6
guard against d = 0
2022-04-04 08:24:32 +02:00
Tor Harald Sandve
2e91d2f353
Do not throw when d = 0 instead continue with rs/rv = 0
2022-04-04 08:24:32 +02:00
Atgeirr Flø Rasmussen
245a87e296
Merge pull request #3851 from totto82/doublecheckecon
...
Avoid premature closing of wells due to econ limits
2022-04-01 10:01:47 +02:00
Kai Bao
aa633ff98f
reconstructing the if structure for has_energy
...
in StandardWell<TypeTag>::
calculateSinglePerf()
2022-03-31 22:38:55 +02:00
Tor Harald Sandve
8909b259d0
don't shut wells due to ratio when rate is negative
2022-03-28 10:50:15 +02:00
Tor Harald Sandve
71acf4e056
Double check econ potential limits
...
Sometimes the potentials are inaccurate as a safty measure we
also check that the rates are violated.
The rates are supposed to be less or equal to the potentials.
2022-03-28 10:50:15 +02:00
Bård Skaflestad
dfdfbbd7d7
Don't Process Corner-Point Data If No Valid Cell Geometry
...
If no cell has a valid corner-point geometry, typically caused by
using GDFILE to read non-finite data such as all ZCORN = -1.0E+20,
then we must not attempt to generate a grid structure. If we do, we
will typically just fail somewhere deep down in the corner-point
processing code and generate a diagnostic message that's hard to
decipher.
With this commit we instead output a diagnostic message of the form
Failed to create valid EclipseState object.
Exception caught: No active cell in input grid has valid/finite cell geometry
Please check geometry keywords, especially if grid is imported through GDFILE
This may not be a lot better than the original diagnostic
Processing grid
flow: ${ROOT}/opm-grid/opm/grid/cpgpreprocess/preprocess.c:768: is_lefthanded: Assertion `! searching' failed.
Aborted (core dumped)
but does at least suggest that the grid data may be faulty.
2022-03-25 14:35:55 +01:00
Bård Skaflestad
0cd2ce6589
Merge pull request #3824 from totto82/notswitchthp
...
Avoid switching to thp control if production is decreasing or injection is increasing
2022-03-25 14:34:30 +01:00
Tor Harald Sandve
f4d81e33f1
Avoid switching to thp control if it results in higher rates
2022-03-25 09:12:15 +01:00
Tor Harald Sandve
2d6794f077
Merge pull request #3849 from hakonhagland/glift_debug_rank
...
Cleanup gaslift debugging output code
2022-03-24 14:13:33 +01:00
Håkon Hægland
a3c131955f
Omit one redundant debugging message
2022-03-24 13:47:57 +01:00
Håkon Hægland
fbd6c03dd6
Cleanup glift debugging output code
2022-03-24 12:42:46 +01:00
Tor Harald Sandve
32dfdc6198
improve initialization msw new wells
2022-03-24 09:53:46 +01:00
Markus Blatt
08fd5da6a7
Use empty string for buildtime if BUILD_TIMESTAMP is not set.
...
In combination with the relevant changes in opm-common this
prevent flow in binary Linux packages from having a timestamp in the
executable that changes with every rebuild.
With the changes in opm-common one can now set the variable
OPM_BINARY_PACKAGE_VERSION to a meaningful version string (Debian
11.2: 2021.10-4). If that is done and flow is built from tarballs it
will now not have a time stamp and print the package version to the
PRT file. E.g.
Flow Version = 2021.10 (Debian 11.2: 2021.10-1)
2022-03-23 22:46:40 +01:00
Tor Harald Sandve
519b5dd8cc
Merge pull request #3810 from totto82/refactor_bhpFromThpLimit_1
...
Refactor bhp from thp limit
2022-03-22 13:57:52 +01:00
Tor Harald Sandve
c067e5fafd
Merge pull request #3834 from totto82/avoid_closing
...
Handle case where bhp target is violated
2022-03-22 11:56:21 +01:00
Tor Harald Sandve
7d5a0a74eb
Handle case where bhp target is violated
2022-03-21 09:52:41 +01:00
Kai Bao
e05a0b276e
fixing the scaling of segment rates
...
when initial segment rate is zero.
2022-03-14 14:01:24 +01:00
Kai Bao
6394c89f77
Merge pull request #3835 from GitPaean/scaling_segment_pressure
...
using addition to update segment pressure when bhp is changed
2022-03-11 10:24:54 +01:00
Markus Blatt
a7e2b25627
Merge pull request #3836 from blattms/spelling-fix
...
Fixes spelling shoule -> should
2022-03-09 17:59:45 +01:00
Markus Blatt
6e7e0098ce
Fixes spelling shoule -> should
2022-03-09 17:23:59 +01:00
Kai Bao
ccfd4152d3
using addition to update segment pressure
...
when bhp is changed. It is much safer and more reasonable.
using multiplication is more likely to result in dramatic values.
2022-03-09 14:23:59 +01:00
Håkon Hægland
3cf181b2ee
Throw exception instead of using assert
...
Throw an exception if two-phase gas lift optimization is used for
other phases than oil and water.
2022-03-07 15:58:11 +01:00
Håkon Hægland
438a712e54
Gas lift optimization for two-phase oil-water.
...
Add gas lift optimization support for two-phase oil-water flow.
2022-03-07 15:19:43 +01:00
Paul Egberts
390a5a4b82
clean up
2022-03-06 21:02:22 +01:00
Paul Egberts
797fdc278b
water-gas ratio input and output plus simulator for salt precipitation and water evaporation
2022-03-01 20:52:43 +01:00
Tor Harald Sandve
8cfbe1d791
Merge pull request #3816 from totto82/control_well_testing
...
Set well control to thp or bhp in well testing
2022-02-23 10:36:17 +01:00
Markus Blatt
1d44a4beac
Merge pull request #3817 from bska/fix-pedantic-warning
...
Remove Extraneous Semicolon
2022-02-18 10:10:44 +01:00
Bård Skaflestad
e1d55d4017
Remove Extraneous Semicolon
...
This generates warnings when using GCC's "-Wpedantic" option.
2022-02-17 23:13:31 +01:00
Tor Harald Sandve
b931c5ef97
Check if guiderate is violated
...
If guiderate is violated change to group controll.
Note that a factor 1.01 is added to minimize oscilations.
Fix missing multiplication with group efficiency when accumulating guiderates
2022-02-17 10:41:43 +01:00
Tor Harald Sandve
d8934ea7a9
Set well control to thp or bhp in well testing
2022-02-17 09:01:32 +01:00
Tor Harald Sandve
418880730e
cleanup2
2022-02-15 12:43:58 +01:00
Tor Harald Sandve
cb99a2fc74
check also the validity of the iterated solution
2022-02-15 12:39:42 +01:00
Tor Harald Sandve
650416c647
cleanup
2022-02-15 12:39:42 +01:00
Tor Harald Sandve
e0573e99b1
iterate in computeBhpAtThpLimitProdWithAlq if no solution or potentials are negative
2022-02-15 12:39:42 +01:00
Tor Harald Sandve
ec08f80405
Refactor out the solving algorithm of bhp from thp via VFP to make it usable for injectors
2022-02-15 12:39:42 +01:00
Tor Harald Sandve
1001d35418
Move computeBhpAtThpLimitProd MSW code to common and apply it for both MSW and STW
...
The computeBhpAtThpLimitProd for MSW is faster and sufficiently robust and should also be used by STW
2022-02-15 12:39:42 +01:00
Håkon Hægland
c7aa43a82b
Rename some methods and variables.
...
Renames some methods and variables to reflect that the well is no
longer necessarily a StandardWell. It can be either a MultisegmentWell
or a StandardWell. This should avoid confusion about the nature of
the variable.
2022-02-15 10:21:09 +01:00
Håkon Hægland
54160827de
Add gaslift optimization support for MSW.
...
Implements gas lift optimization support for multisegmented wells (MSW).
2022-02-14 21:38:50 +01:00
Markus Blatt
a520733d5b
Merge pull request #3774 from plgbrts/expli-salt
...
allow for explicit initialization of SALT and SALTP
2022-02-11 14:35:57 +01:00
Tor Harald Sandve
0c8d0764d6
update well potensials in well state along with alq and update guide rates accordingly
2022-02-08 15:46:08 +01:00
Bård Skaflestad
57cc18cf1b
Merge pull request #3797 from totto82/add_total_gas
...
Add support for maximum total gas (alq + gas rate) in GLIFTOPT
2022-02-04 10:33:38 +01:00
Bård Skaflestad
e6ad6ec496
Merge pull request #3801 from totto82/add_performa
...
Add more performance summary output
2022-02-03 17:15:05 +01:00
Tor Harald Sandve
ad799b3e80
Add more performance summary output
...
This commit ads: NEWTON, MLINEARS, MSUMLINS, MSUMNEWT, NLINEARS, NLINSMIN, NLINSMAX
2022-02-03 15:03:37 +01:00
Markus Blatt
3b8501469c
Merge pull request #3800 from Tongdongq/move-gpu-files
...
Move gpu files
2022-02-03 12:55:41 +01:00
Tor Harald Sandve
bb99d1437b
reduce alq when alq + gas production target is violated
2022-02-03 12:11:03 +01:00
Tong Dong Qiu
c1cbf7a00f
Fix ChowPatelIlu compilation errors,
...
introduced in recent PR
2022-02-03 10:42:27 +01:00
Tong Dong Qiu
6c8ada4cd2
Reduced header inclusion and updated comments
2022-02-03 10:42:22 +01:00
Tor Harald Sandve
0b923e505a
Add support for maximum total gas (alq + gas rate) in GLIFTOPT
...
Dont increase gaslift if the groups alq + gas production rate is above the given target
2022-02-02 10:54:32 +01:00
Tor Harald Sandve
009134d037
Limit well rates to honor group rates
...
If a well is under a group that is limited by a target, it should use as little gaslift as possible.
The reduction algorithm will reduce the gaslift of the well as long as the groups potential is above the groups target.
2022-02-02 10:30:48 +01:00
Tong Dong Qiu
275bfe2da4
Move cuda files to separate folder
2022-02-02 09:28:41 +01:00
Tong Dong Qiu
e81ca0526e
Move opencl files to separate folder
2022-02-01 16:51:32 +01:00
Tor Harald Sandve
29ec104bb6
Merge pull request #3780 from hakonhagland/glift_swg_fx8
...
Refactor code in GasLiftSingleWellGeneric.cpp (part 3)
2022-02-01 11:11:17 +01:00
Håkon Hægland
65c323e1a4
Replace assert with warning.
...
Replace assert with warning when group rates exceeds target.
2022-01-31 01:52:36 +01:00
Håkon Hægland
8810fa65af
Cleanup code in GasLiftSingleWellGeneric
...
Introduces two new data types BasicRates and LimitedRates to capture
oil, gas, and water rates, and whether they have been limited by well
or group targets. This reduces the number of variables that are passed
to and returned from various methods and thus makes the code easier to
read.
2022-01-31 01:39:20 +01:00
Markus Blatt
4407fdd3db
std::regex_replace use $n for referencing and not \n.
2022-01-27 17:22:09 +01:00
Markus Blatt
710d648eda
Prevent multiple *.?.dbg/prt files in production crashed parallel runs.
...
There was a fallout when skipping concating these files to the
default ones (PR #1708 ). We should also have deactivated creating
these files at all. As a result these files appeared in all parallel
runs that were aborted.
This change now prevents creating and logging to these files in
parallel in a default
run (--enable-parallel-logging-fallout-warning=false).
Developers can still activate logging and concating to see whether
everything is only logged on the io process by passing
--enable-parallel-logging-fallout-warning=true.
Closes 3725
2022-01-27 17:21:29 +01:00
Håkon Hægland
a14ed57921
Silence reorder warning in GasLiftCommon
2022-01-25 13:31:49 +01:00
Håkon Hægland
4970b0641e
Improve debugging tools in gaslift code.
...
Introduces a gaslift debugging variable in ALQState in WellState. This
variable will persist between timesteps in contrast to when debugging
variables are defined in GasLiftSingleWell, GasLiftGroupState, or GasLiftStage2.
Currently only an integer variable debug_counter is added to ALQState,
which can be used as follows: First debugging is switched on globally
for BlackOilWellModel, GasLiftSingleWell, GasLiftGroupState, and
GasLiftStage2 by setting glift_debug to a true value in BlackOilWellModelGeneric.
Then, the following debugging code can be added to e.g. one of
GasLiftSingleWell, GasLiftGroupState, or GasLiftStage2 :
auto count = debugUpdateGlobalCounter_();
if (count == some_integer) {
displayDebugMessage_("stop here");
}
Here, the integer "some_integer" is determined typically by looking at
the debugging output of a previous run. This can be done since the
call to debugUpdateGlobalCounter_() will print out the current value
of the counter and then increment the counter by one. And it will be
easy to recognize these values in the debug ouput. If you find a place
in the output that looks suspect, just take a note of the counter
value in the output around that point and insert the value for
"some_integer", then after recompiling the code with the desired value
for "some_integer", it is now easy to set a breakpoint in GDB at the
line
displayDebugMessage_("stop here").
shown in the above snippet. This should improve the ability to quickly
to set a breakpoint in GDB around at a given time and point in the simulation.
2022-01-23 20:37:26 +01:00
Tor Harald Sandve
2fdff5c1e4
Merge pull request #3758 from totto82/fixAssertInWECON
...
Handle case where no completions have ratio above the limit while the well has
2022-01-21 12:31:11 +01:00
Tor Harald Sandve
6fee9173c0
Remove assert in ratio check for completions
...
Handle special cases with injection or trivial completion rates and all completions have ratio below the limit while the well has
above
2022-01-21 10:51:40 +01:00
Kai Bao
086b8aab7d
only multisegment wells will alway inner iteration
2022-01-21 10:43:36 +01:00
Kai Bao
0000df18a4
always using inner iterations for testing purpose.
2022-01-21 10:43:36 +01:00
Bård Skaflestad
9fc9f5421c
Merge pull request #3771 from totto82/fixUpdateGR
...
Update guiderates after with new rates from newly opened wells
2022-01-21 10:33:00 +01:00
Tor Harald Sandve
d1c2032e73
Update guiderates after with new rates from newly opened wells
2022-01-21 09:15:00 +01:00
Atgeirr Flø Rasmussen
357ba55de5
Merge pull request #3773 from GitPaean/return_zero_thp_zero_rate_inj
...
return zero thp value for extremely small injection rate
2022-01-20 14:49:25 +01:00
Tor Harald Sandve
a57f92527f
Merge pull request #3777 from totto82/support_min_wait_glift
...
support none trivial item 3 in LIFTOPT.
2022-01-19 14:58:50 +01:00
Atgeirr Flø Rasmussen
9f7d4f2fc2
Merge pull request #3760 from GitPaean/thp_fixing_model_2
...
fixing the failure that bhp could not be calculated with thp limit
2022-01-19 12:48:39 +01:00
Tor Harald Sandve
c3571c50a3
support none trivial item 3 in LIFTOPT. i.e. not optimize gaslift every timestep
2022-01-19 10:14:47 +01:00
Markus Blatt
3db9a4e3e5
Merge pull request #3750 from ducbueno/isai-ilu
...
Adds IncompleteSAI preconditioner to openclSolver
2022-01-18 12:38:39 +01:00
Tor Harald Sandve
bf77bbbc10
Merge pull request #3759 from plgbrts/saltp
...
Enable salt precipitation/dissolution
2022-01-18 12:02:32 +01:00
Paul Egberts
590920db6b
allow for explicit initialization of SALT (salt concentration) and SALTP (precipitated salt)
2022-01-18 11:12:43 +01:00
Kai Bao
913ad21733
return zero thp value for extremely small injection rate
...
it is a finding from one of the test case.
2022-01-18 10:12:20 +01:00
Eduardo Bueno
1df9d2e51f
Adds BISAI preconditioner to openclSolver
2022-01-17 13:57:29 -03:00
Arne Morten Kvarving
a82ad816c7
add fallback return (control reaches end of non-void function)
2022-01-17 13:59:47 +01:00
Paul Egberts
98c8e691c3
Allow for brine and precipitation/dissolution of salt
2022-01-14 11:46:40 +01:00
Paul Egberts
f69aa171fe
removed some salt-precipitation related keywords from the unsupported keyword list
2022-01-14 11:46:39 +01:00
Bård Skaflestad
3317f10c4a
Merge pull request #3729 from goncalvesmachadoc/gaswater_brine
...
allow for gas-water + brine
2022-01-12 12:31:34 +01:00
Markus Blatt
790fa8044e
Merge pull request #3755 from blattms/fix-opencl-apply-stdwells-rebased
...
Fix opencl apply stdwells rebased (replaces #3746 )
2022-01-11 19:18:03 +01:00
goncalvesmachadoc
300f536a19
add exit_failure for water+brine case
2022-01-11 14:23:37 +01:00
Bård Skaflestad
abf92eed52
Accumulate Dissolved Gas and Vaporized Oil Flow Rates Across Ranks
...
This is needed to get consistent estimates for the summary vectors
* {F,G,W}OP{R,T}{F,S} -- Free/Vaporized Oil Production
* {F,G,W}GP{R,T}{F,S} -- Free/Dissolved Gas Production
in the case of distributed wells.
Thanks to [at]blattms for the suggested fix.
2022-01-10 14:14:39 +01:00
Kai Bao
2b9b6e5155
addressing reviewing comments for PR#3760
2022-01-10 11:33:11 +01:00
Kai Bao
dec3100247
fixing a bug in funcion bisectBracket
2022-01-09 00:21:31 +01:00
Kai Bao
3b7e62979c
refactoring to shorten the function computeBhpAtThpLimitProd
...
better readibility hopefully.
2022-01-07 15:49:48 +01:00
Kai Bao
5824acbf92
making bruteforce bracket as a function
...
for better readbility.
2022-01-07 15:13:33 +01:00
Kai Bao
3273f310e3
prototyping the brute force for bracketing bhp
...
to fix the situation the existing approach fails.
2022-01-07 14:32:16 +01:00
Tor Harald Sandve
3e4e62bc4f
Merge pull request #3751 from hakonhagland/glift_swg_fx3
...
Refactor some methods in `GasLiftSingleWellGeneric.cpp` (part 2)
2022-01-03 14:14:15 +01:00
Joakim Hove
6b92443cb4
Downstream filesystem reorganisation in opm-common
2022-01-02 14:33:34 +01:00
Tong Dong Qiu
f48fe632cb
Added comment to apply_stdwell kernels
2021-12-22 16:22:55 +01:00
Tong Dong Qiu
3decb73561
Fix stdwell_apply opencl kernel
2021-12-22 16:16:04 +01:00
Jose Eduardo Bueno
c7ac97e215
[OpenCL] Moves all OpenCL kernels to *.cl files.
...
Kernel files are located in opm/simulators/linalg/bda/opencl/kernels.
CMake will combine them for usage in
${PROJECT_BINARY_DIR}/clSources.cpp that becomes part of the library.
2021-12-22 12:43:18 +01:00
Håkon Hægland
4bdf7c1b58
Refactor methods getXyzRateWithLimit_()
...
Refactors getOilRateWithLimit_(), getGasRateWithLimit_(), and
getWaterRateWithLimit_() in GasLiftSingleWellGeneric.cpp. The
common part of the methods is split out into a new method called
getRateWithLimit_(). The purpose of the refactorization is to reduce
reptetive code and make the code easier to maintain.
2021-12-22 10:45:31 +01:00
Håkon Hægland
f28b906782
Made some methods in GasLiftGroupInfo const
...
This is in agreement with C++ Core Guidelines. A member function should
be marked const unless it changes the object’s observable state. This
gives a more precise statement of design intent, better readability, more
errors caught by the compiler, and sometimes more optimization opportunities.
2021-12-21 23:24:58 +01:00
Håkon Hægland
11ad879472
Make parameters to getLiquidRateWithGroupLimit_() const
...
To improve readability, we make the parameters of
getLiquidRateWithGroupLimit_() const as discussed in
https://github.com/OPM/opm-simulators/pull/3748
2021-12-20 23:19:40 +01:00
Håkon Hægland
837f33e679
Refactor some methods in GasLiftSingleWellGeneric.
...
Refactor getOilRateWithGroupLimit_(), getGasRateWithGroupLimit_(),
getWaterRateWithGroupLimit_(), and getLiquidRateWithGroupLimit_() into
a single generic method called getRateWithGroupLimit_().
2021-12-20 23:08:31 +01:00
Bård Skaflestad
f77d82a0e9
Merge pull request #3744 from OPMUSER/Validate-ROCKCOMP
...
Validate ROCKCOMP Update
2021-12-20 13:51:07 +01:00
Markus Blatt
0485c65d16
Merge pull request #3740 from atgeirr/make-split-comm-test-runtime-optional
...
Replace DEMONSTRATE_RUN_WITH_NONWORLD_COMM macro with runtime bool.
2021-12-20 12:46:49 +01:00
OPMUSER
d6f7cb59a7
Validate ROCKCOMP Upadate
2021-12-20 18:06:17 +08:00
Håkon Hægland
e388827d81
Fixup in GasLiftSingleWellGeneric
...
Consider all groups when reducing oil rate to group limits.
The current code just checks the first group limit in the set.
But there might be groups later in the set with more restrictive
limits, causing the oil rate to be reduced more than the first
limit.
2021-12-15 19:15:35 +01:00
OPMUSER
34652f2d5d
Remove NEXTSTEP from Unsupported List
2021-12-14 11:31:38 +08:00
Atgeirr Flø Rasmussen
e22d1177fd
Merge pull request #3738 from OPMUSER/WILL_STOP
...
Update PartiallySupportedFlowKeywords.cpp All STOP Version
2021-12-13 09:23:44 +01:00