Commit Graph

26927 Commits

Author SHA1 Message Date
John Ralls
0be0b7e5a8 Update Github checkout action
Resolves node.js V12 deprecation warning.
2023-03-02 17:36:41 -08:00
John Ralls
1eecb9f5c0 [c++ options] Fix locale dependency in test-gnc-option-scheme-output.
Created by using std::to_string() in GncOptionRangeValue::serialize.
It wraps sprintf that reads the locale. Use ostringstream instead.
2023-03-02 12:22:55 -08:00
John Ralls
e9f6bf7a5c Merge Richard Cohen's fix-scheme-tests into master. 2023-02-28 15:25:08 -08:00
Richard Cohen
be41bde58a Add missing MAKE_LINKS, and the local scm directory to %load-path
Before this change, "make check" would fail after
  rm -rf ${build}/share/guile/site/*/gnucash/
2023-02-28 11:51:23 +00:00
Richard Cohen
7cae61d97a Make the scheme tests fail immediately if they load an external gnucash file
This would be a mistake in the build, but can happen if there
is already a gnucash installed in the standard guile load path.
2023-02-28 11:48:57 +00:00
John Ralls
675d894128 Merge Richard Cohen's 'cleanup-options' into master. 2023-02-27 16:33:00 -08:00
John Ralls
ca73b00039 Merge Richard Cohen's 'cleanup-boost' into master. 2023-02-27 16:31:53 -08:00
John Ralls
3d5e27982f Merge branch 'maint' 2023-02-27 16:24:44 -08:00
John Ralls
7f0353adc4 Fix a missed g_value_dup_string and some no longer used variables. 2023-02-27 16:19:50 -08:00
John Ralls
8a7c539258 Bug 798748 - Transaction Notes field's value does not appear in...
reverse transaction.

The proximate cause was that xaccTransBeginEdit put the KVP cache
variable of the new transaction in a state that prevented the value
from being copied. More generally the KVP cache variables didn't
handle any invalidating events.

With the change to GValue usage in qof_instance_get_kvp it's now
a simple memory dereference with no copying except for POD types
so caching is no longer useful. This commit removes caching from
Transaction, eliminating the notes problem.
2023-02-27 14:54:46 -08:00
John Ralls
ddc3f28899 [kvp] Use static strings and boxed in gvalue_from_kvp_value.
Saves allocating and copying complex values, avoiding potential
memory leaks.
2023-02-27 14:54:02 -08:00
John Ralls
de9c0eb540 Bug 797903 - Transaction window: The 'blue line' is always...
(erroneously) topmost when t. sorting order is inverted.

Same problem for the 'red line'. Make register code aware of sort
order and flip the logic when reverse sorting.
2023-02-27 10:11:06 -08:00
Richard Cohen
9f06859390 Remove references to old boost versions
we already require 1.67
2023-02-27 11:48:09 +00:00
Richard Cohen
3d995de2ab Refactor: use default GncOptionValue copy constructor 2023-02-27 11:46:39 +00:00
Richard Cohen
1b0af4246a Refactor: remove extra template parameter from member functions 2023-02-27 11:46:34 +00:00
Richard Cohen
87c52f53fa Update some references to hello-world.scm 2023-02-27 11:36:04 +00:00
Richard Cohen
8e4c085e9f Fix memory leak 2023-02-27 11:33:32 +00:00
Richard Cohen
ec169e6e24 Fix some non-translatable typos 2023-02-27 11:32:12 +00:00
Szia Tomi
f483d7588e
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2023-02-27 02:18:53 +01:00
mocsa
6616ce1077
Translation update by mocsa <csaba@feltoltve.hu> using Weblate
po/hu.po: 64.1% (3464 of 5401 strings; 960 fuzzy)
199 failing checks (3.6%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 64.0% (3461 of 5401 strings; 963 fuzzy)
199 failing checks (3.6%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: mocsa <csaba@feltoltve.hu>
2023-02-27 02:18:53 +01:00
Christopher Lam
47b85d3b2f [gnc-xml-backend.cpp] g_free char* from g_path_get_dirname 2023-02-27 09:18:01 +08:00
John Ralls
ba12e31251 Bug 798753 - UX improvements in new import dialog
Rename the dialog to not mention export since we don't use it for that.
Change the key-column names to be specific to the listview.
Add tooltips to the listviews to explain what they're for
Persist the selected imexporter and profile in the book's state file.
Stop the inappropriate "there are transactions do you want to import
them?" dialog (missing AWAIT_TRANSACTIONS in gnc_ab_import_context call).
2023-02-26 12:17:09 -08:00
Christopher Lam
89e2bef427 Merge branch 'maint' 2023-02-26 13:51:33 +08:00
Christopher Lam
89e63ef672 Bug 798754 - Build fails with gcc 13 and glib > 2.76, ter 2023-02-26 08:30:14 +08:00
John Ralls
6ab7b16d62 [c++options] Restore the ability to set plot sizes in pixels.
Enable and fix the previously untested GtkOptionGtkUIItem::PLOTSIZE.

This has the potentially unfortunate side effect that integer range
options are assumed to be plot sizes. That's correct for now, but
if some report comes along that needs an integer range option for
something else it will have to be differentiated.
2023-02-25 16:25:36 -08:00
John Ralls
408b5ec216 [c++ options] Restore forward & backward compatibility, fix crash.
Store Number Range option values as a pair '(percentage . value) or '(pixels .
value) depending on the size of value as 4.x and earlier expect. When reading a
stored number range option handle the possibility that value is fixed
point (e.g. 50.0) as 4.x and earlier emit, avoiding a crash.
2023-02-25 16:25:36 -08:00
Christopher Lam
0780cfbfd2 [gnucash.cpp] quote_soures is a GList of char* to be g_freed 2023-02-25 20:02:54 +08:00
Christopher Lam
abcce5000c Bug 798754 - Build fails with gcc 13 and glib > 2.76, bis 2023-02-25 13:12:35 +08:00
Geert Janssens
26482f397b Bug 797033 - The CSV Importer should not obey with the "automatic digital point" setting
Expose variations of xaccParseAmount and
xaccParseAmountExtended that will ignore the
automatic decimal point user preference.
This preference is really only useful for manual number
entering in the register.

The xaccParseAmountImport variant replaces xaccParseAmountPosSign
which was used exclusively by the csv importers.
Like xaccParseAmountPosSign, this replacement has the flag
to ignore or parse the positive number indicator.
2023-02-24 23:02:15 +01:00
Frank H. Ellenberger
fcbda57a6b Merge branch 'maint' 2023-02-24 19:19:12 +01:00
Geert Janssens
9be232cd80 Bug 798572 - Parse numbers with two minus signs as a positive numbers 2023-02-24 14:22:16 +01:00
Szia Tomi
9b626af30d
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/hu.po: 63.8% (3449 of 5401 strings; 996 fuzzy)
290 failing checks (5.3%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2023-02-23 18:53:21 +01:00
Kryštof Černý
c7cce26869
Translation update by Kryštof Černý <cleverline1mc@gmail.com> using Weblate
po/glossary/cs.po: 0.9% (2 of 212 strings; 0 fuzzy)
7 failing checks (3.3%)
Translation: GnuCash/Glossary (Czech)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/cs/

Co-authored-by: Kryštof Černý <cleverline1mc@gmail.com>
2023-02-23 18:53:21 +01:00
mocsa
c9c7c0a984
Translation update by mocsa <csaba@feltoltve.hu> using Weblate
po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 63.8% (3449 of 5401 strings; 996 fuzzy)
323 failing checks (5.9%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 63.7% (3442 of 5401 strings; 1000 fuzzy)
308 failing checks (5.7%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 63.1% (3413 of 5401 strings; 1010 fuzzy)
258 failing checks (4.7%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 63.1% (3411 of 5401 strings; 1013 fuzzy)
254 failing checks (4.7%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 63.1% (3410 of 5401 strings; 1013 fuzzy)
252 failing checks (4.6%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 63.0% (3406 of 5401 strings; 1015 fuzzy)
241 failing checks (4.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: mocsa <csaba@feltoltve.hu>
2023-02-23 18:53:21 +01:00
John Ralls
184669f517 Bug 798754 - Build fails with gcc 13 and glib > 2.76
GLib 2.76 introduced a no-discard warning on g_string_free
if the second parameter is FALSE. This revealed a string
leak and a correct usage that didn't use the return value.
2023-02-23 09:47:37 -08:00
Geert Janssens
549c93e005 Fix test for import-backend
Another split function needed mocking
2023-02-23 12:33:31 +01:00
Geert Janssens
fa980fb1c6 Bug 798334 - Importing transactions from CSV with space as thousand separator
In addition to stripping currency symbols also strip
all whitespace from fields that are to be interpreted
as numbers.
2023-02-22 15:49:42 +01:00
Geert Janssens
8c0032efc2 Bug 798691 - Memo field not updated on CSV import using U+C 2023-02-22 14:46:02 +01:00
Geert Janssens
b2703d8a02 CsvTokenizer - add additional test case for escaped quotes
It simulates the case where csv fields are fully quoted and an escaped
quote ("") is found in some field. This case is handled correctly,
adding the test to guard this in potential future modifications.
2023-02-22 14:45:44 +01:00
Geert Janssens
7fbe42530f One more empty string test for PR#1527 2023-02-22 10:51:49 +01:00
Christopher Lam
45cdf40785 Merge branch 'master-progress' #1527 2023-02-22 09:08:28 +08:00
John Ralls
4666a426ed Merge Richard Cohen's 'warn-deprecated-gtk-glib' into master. 2023-02-21 15:39:01 -08:00
Christopher Lam
50e9e70592 [import-backend] don't search GHashTable twice
search acct_id_hash once for dest_acct
2023-02-21 23:32:56 +08:00
Christopher Lam
bf79d6fa58 gtk_entry_get_text instead of gtk_editable_get_chars 2023-02-21 23:32:56 +08:00
Christopher Lam
8d44c1c38c [dialog-customer|employee|job|vendor] harmonize title setter 2023-02-21 23:32:56 +08:00
Christopher Lam
03871c55cf [dialog-employee] toggle sensitivity instead of visibility of GncAccountSel 2023-02-21 23:18:05 +08:00
Christopher Lam
f170d1d54c [dialog-customer|employee|vendor] combine GtkCheckButton with label
UX: increase the target area for click.

Also move GtkCheckButton to left-column and its dependent GtkWidget to
right-column.
2023-02-21 23:18:05 +08:00
Christopher Lam
016f82cf8b [eguile-utilities.scm] remove fmtnumber
deprecated in maint.
2023-02-21 23:18:05 +08:00
Richard Cohen
6470319c88 Warn about deprecated gtk, glib
- G_DISABLE_DEPRECATED no longer exists (as of glib 2.61.2)
- Turn off aqbanking global deprecation

Spoilers:

- gtk
 - (3.22) gdk_screen_width
 - (3.22) gdk_screen_height

- glib
 - (2.68) g_binding_get_target -> g_binding_dup_target

- aqbanking
 - AB_Banking_LoadSharedConfig
2023-02-21 12:59:42 +00:00
Richard Cohen
bddb4468fa Import GLIB2 as a target, and use it to simplify the CMakeLists 2023-02-21 12:59:42 +00:00