Commit Graph

27568 Commits

Author SHA1 Message Date
Richard Cohen
848f4eb81d Remove unused GNCDateDelta 2023-05-17 10:25:20 +01:00
Richard Cohen
d36cf2177e Remove action callbacks that simply set the state
- it is the default behaviour
2023-05-17 10:25:16 +01:00
Richard Cohen
81fba56bbb Initialise guids in test-engine-kvp-properties.c
Valgrind: Conditional jump or move depends on uninitialised value(s)
2023-05-15 20:03:23 +01:00
Richard Cohen
bed43c7f3b Fix potential crash in test-engine
==515314== Invalid read of size 1
==515314==    at 0x484AD67: __strcmp_sse42 (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==515314==    by 0x171D36: do_test_list_handler (unittest-support.c:181)
==515314==    by 0x171DCE: test_list_handler (unittest-support.c:197)
==515314==    by 0x51BD4C1: g_logv (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==515314==    by 0x51BD7A2: g_log (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==515314==    by 0x4D5D0D9: xaccSplitEqualCheckBal (Split.c:753)
==515314==    by 0x4D5D841: xaccSplitEqual (Split.c:869)
==515314==    by 0x4D647A5: xaccTransEqual (Transaction.c:981)
==515314==    by 0x15C0E8: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:901)
...
==515314==  Address 0x8725260 is 0 bytes inside a block of size 59 free'd
==515314==    at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==515314==    by 0x15BDB1: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:883)
...
==515314==  Block was alloc'd at
==515314==    at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==515314==    by 0x5618677: __vasprintf_internal (vasprintf.c:116)
==515314==    by 0x520E8C1: g_vasprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==515314==    by 0x51DBBE0: g_strdup_vprintf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==515314==    by 0x51DBC9C: g_strdup_printf (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==515314==    by 0x15BBAC: test_xaccTransEqual(Fixture*, void const*) (utest-Transaction.cpp:879)
...

ok 78 /engine/Transaction/xaccTransEqual
2023-05-15 20:03:23 +01:00
Richard Cohen
dc62959553 Fix crash in test-engine on Arch
Thanks, Valgrind:

==515314== Invalid read of size 8
==515314==    at 0x4ED46F3: gncInvoiceRemoveEntries (gncInvoice.c:767)
==515314==    by 0x142B35: teardown_with_invoice (utest-Invoice.c:274)
...
==515314==  Address 0x8557b98 is 8 bytes inside a block of size 24 free'd
==515314==    at 0x484620F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==515314==    by 0x51B565D: g_list_remove (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==515314==    by 0x4ED42EF: gncInvoiceRemoveEntry (gncInvoice.c:688)
==515314==    by 0x4ED46A2: gncInvoiceRemoveEntries (gncInvoice.c:781)
==515314==    by 0x142B35: teardown_with_invoice (utest-Invoice.c:274)
...
==515314==  Block was alloc'd at
==515314==    at 0x4843828: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==515314==    by 0x51BD948: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==515314==    by 0x51B1CB9: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==515314==    by 0x4ED4271: gncInvoiceAddEntry (gncInvoice.c:676)
==515314==    by 0x142401: setup_with_invoice (utest-Invoice.c:142)
...

ok 57 /engine/gncInvoice/post trans - vendor bill
2023-05-15 20:03:23 +01:00
Richard Cohen
3c34a61776 Remove #pragma ... "-Wformat-nonliteral"
Seems to have been accidentally left behind when time64_to_string()
was (re)moved
2023-05-15 13:21:30 +01:00
Richard Cohen
1f43bbc798 Remove #pragma ..."-Wstrict-aliasing"
G_LOCK was fixed in glib 2.19.8

See https://bugzilla.gnome.org/show_bug.cgi?id=316221
2023-05-15 13:21:30 +01:00
Richard Cohen
80e9d9c35d scanf supports %lld since C++11, C99 2023-05-15 13:21:30 +01:00
Richard Cohen
7f1ce2b5e5 Remove references to cutecash 2023-05-15 13:21:29 +01:00
Richard Cohen
49d3862f72 Get the tooltip working on "Online Banking Setup"
"tt" -> "tooltip"
2023-05-14 14:10:19 +01:00
Richard Cohen
1fe097bd5f Update gnc-plugin-example-ui.xml 2023-05-14 14:09:59 +01:00
Richard Cohen
a61a691bb5 Fix validation failure in assistant-csv-trans-import.glade
- Redo change from 0d8640f703
 - (Glade bug?)

$ gtk-builder-tool validate gnucash/gtkbuilder/assistant-csv-trans-import.glade
Gtk-CRITICAL **: 21:57:40.154: gtk_assistant_set_page_has_padding: assertion 'child != NULL' failed
2023-05-13 16:22:19 +01:00
Richard Cohen
8067ba1d9d Remove duplicate object IDs in dialog-ab.glade
Found by gtk-builder-tool validate

.../dialog-ab.glade:1665:1 Duplicate object ID 'dialog-vbox3' (previously on line 573)
.../dialog-ab.glade:1670:1 Duplicate object ID 'dialog-action_area3' (previously on line 578)
2023-05-13 16:22:14 +01:00
Richard Cohen
ef95689d9b Use " for XML attributes 2023-05-13 16:07:19 +01:00
Richard Cohen
c45c25c7aa Use hyphens for property names
- "icon_size" -> "icon-size"
2023-05-13 16:06:51 +01:00
Richard Cohen
abd361dec4 Indent consistently, and remove EOL spaces 2023-05-13 16:06:19 +01:00
Richard Cohen
4df662afae Fix the typo in function name "new_query_for_addresss" 2023-05-13 13:08:07 +01:00
Richard Cohen
a63247ba49 Fix a typo in French Canadian account template 2023-05-13 13:03:51 +01:00
Richard Cohen
3957272ef0 Fix some typos in comments 2023-05-13 13:00:25 +01:00
John Ralls
9b95419608 Fix glib include. 2023-05-11 11:56:23 -07:00
John Ralls
d696f0cfcb Bug 798885 - Accented character in folder name on Account Export (bis)
Pass a boost::filesystem's c_str() rv to the ofstream constructor to
keep libstdc++ from transcoding it back to UTF8 and creating a broken
name or failing to match the directory name. Implemented in
gnc-filepath-utils to avoid spreading the boost::filesystem dependency
throughout the code base.

See https://github.com/boostorg/filesystem/issues/181 for why other
approaches don't work.
2023-05-08 13:35:21 -07:00
John Ralls
73337cff5a Merge updated gnucash.pot. 2023-05-05 15:07:17 -07:00
John Ralls
a6b295178f Merge latest translations from weblate. 2023-05-05 15:00:25 -07:00
Szia Tomi
b3b7b598b2
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/hu.po: 68.8% (3788 of 5502 strings; 626 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2023-05-05 23:59:18 +02:00
John Ralls
6be654c77d Bug 798597 - The word "Separators" needs two separate versions
Use "Character-separated" when it's a choice between that and fixed
field width and "Select Separator Character" when it's a heading.
2023-05-05 14:58:52 -07:00
John Ralls
5fda252444 Bug 798839 - Edit -> Preferences string not translatable (bis) 2023-05-05 13:51:53 -07:00
John Ralls
1b3c693d7d Bug 798862 - Merge identical strings (bis)
Ensure similar strings are identical and use double line view instead
of double line mode.
2023-05-05 12:57:58 -07:00
John Ralls
4e99731241 Merge latest translations from Weblate. 2023-05-05 12:32:20 -07:00
cjh
0eecebfef7
Translation update by cjh <cjh@cjh0613.com> using Weblate
po/zh_CN.po: 94.1% (5179 of 5502 strings; 201 fuzzy)
81 failing checks (1.4%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: cjh <cjh@cjh0613.com>
2023-05-05 21:30:17 +02:00
Szia Tomi
95670ea5bc
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/hu.po: 68.8% (3788 of 5502 strings; 626 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/hu.po: 68.8% (3788 of 5502 strings; 626 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2023-05-05 21:30:16 +02:00
Kaligula
4228ed0bf5
Translation update by Kaligula <kaligula.dev@gmail.com> using Weblate
po/pl.po: 69.9% (3850 of 5502 strings; 1111 fuzzy)
317 failing checks (5.7%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Co-authored-by: Kaligula <kaligula.dev@gmail.com>
2023-05-05 21:30:15 +02:00
Milo Ivir
1b5ec4d457
Translation update by Milo Ivir <mail@milotype.de> using Weblate
po/hr.po: 97.4% (5363 of 5502 strings; 40 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Croatian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hr/

Co-authored-by: Milo Ivir <mail@milotype.de>
2023-05-05 21:30:14 +02:00
mocsa
eb75cd2ef3
Translation update by mocsa <csaba@feltoltve.hu> using Weblate
po/hu.po: 68.8% (3788 of 5502 strings; 626 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 68.8% (3787 of 5502 strings; 627 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 68.4% (3764 of 5502 strings; 638 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 67.9% (3741 of 5502 strings; 651 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: mocsa <csaba@feltoltve.hu>
2023-05-05 21:30:13 +02:00
Pedro Albuquerque
5defc901f8
Translation update by Pedro Albuquerque <pmra@gmx.com> using Weblate
po/pt.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Portuguese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pt/

Co-authored-by: Pedro Albuquerque <pmra@gmx.com>
2023-05-05 21:30:13 +02:00
Geert Janssens
84b64233d7 Bug 798899 - Gnucash crashes during CSV import when using a template if the destination account is changed from one used in the template 2023-05-03 16:38:05 +02:00
Monson Shao
b183c39a95
cmake: check gdk only when building GUI 2023-05-01 22:37:04 +08:00
John Ralls
43eb36c311 Release GnuCash 5.1 2023-04-30 09:10:10 -07:00
YOSHINO Yoshihito
450a634f81 Fix Encoding on wrong line. 2023-04-30 09:10:10 -07:00
John Ralls
0ecafc93ed Correct CMake distribution.
Remove deleted gnc-fq-helper.1 and gnc-fq-dump.1 doc dependencies.
Add csv-exp/test to Dist.

add csv-exp/test
2023-04-30 09:10:10 -07:00
John Ralls
bb423e4484 Merge CrfzdPQM6's 'b_betterCurrencyBudgetReporting' into stable. 2023-04-29 12:04:45 -07:00
Daniel Johnson
04b0317119 Demonstrate fx handling in budget report 2023-04-29 12:01:36 -07:00
John Ralls
df878c6a3d Merge Maarten Bosmans's 'memleak-fixes' into stable. 2023-04-29 11:54:41 -07:00
Maarten Bosmans
71802b5627 [test] Fix memory leak in test-gnc-quotes
When the commodity table is registered, the current book will get
a default table assigned.  When later setting the table explicitly
using qof_book_set_data() the exisiting table gets overwritten and
is thus leaked.

There is no way of removing or freeing a currency table from a book,
so the best we can do here is to set our own table on the book before
calling gnc_commodity_table_register().
2023-04-29 11:52:12 -07:00
Maarten Bosmans
6be682b645 Store allocated temporaries in a variable so they can be freed
If a function that returns an allocated pointer is passed directly into
something that does not take ownership of the pointer, the allocation is
leaked.  This can be fixed by assigning the pointer to a new variable
and freeing it after operation on the memory.
2023-04-29 11:51:43 -07:00
John Ralls
168765cf77 Merge latest translations from Weblate. 2023-04-29 11:02:34 -07:00
YOSHINO Yoshihito
313d3ebe12
Translation update by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate
po/ja.po: 89.8% (4941 of 5502 strings; 225 fuzzy)
433 failing checks (7.8%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 89.7% (4939 of 5502 strings; 227 fuzzy)
435 failing checks (7.9%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 89.7% (4938 of 5502 strings; 228 fuzzy)
435 failing checks (7.9%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 89.5% (4929 of 5502 strings; 235 fuzzy)
436 failing checks (7.9%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Co-authored-by: YOSHINO Yoshihito <yy.y.ja.jp@gmail.com>
2023-04-29 19:53:51 +02:00
mocsa
cdd59d79d2
Translation update by mocsa <csaba@feltoltve.hu> using Weblate
po/hu.po: 67.9% (3741 of 5502 strings; 651 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 67.9% (3740 of 5502 strings; 651 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 67.9% (3739 of 5502 strings; 651 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: mocsa <csaba@feltoltve.hu>
2023-04-29 19:53:51 +02:00
Andi Chandler
bb68845e94
Translation update by Andi Chandler <andi@gowling.com> using Weblate
po/en_GB.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (English (United Kingdom))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/en_GB/

Co-authored-by: Andi Chandler <andi@gowling.com>
2023-04-29 19:53:51 +02:00
Arve Eriksson
ca87cc774f
Translation update by Arve Eriksson <031299870@telia.com> using Weblate
po/sv.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Swedish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/sv/

Co-authored-by: Arve Eriksson <031299870@telia.com>
2023-04-29 19:53:50 +02:00
Yuri Chornoivan
c904428916
Translation update by Yuri Chornoivan <yurchor@ukr.net> using Weblate
po/uk.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Ukrainian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/uk/

Co-authored-by: Yuri Chornoivan <yurchor@ukr.net>
2023-04-29 19:53:50 +02:00