Arne Morten Kvarving
0a1691fbba
bump to final
2021-05-04 10:08:35 +02:00
Arne Morten Kvarving
049394497b
bump packaging versions
2021-04-27 09:55:02 +02:00
Arne Morten Kvarving
ca27588d5a
fix cherry-picking error
2021-04-26 14:44:58 +02:00
Arne Morten Kvarving
678676484b
fixed: missing member initialization
...
if deck has no rockcomp keyword, variable is not written
2021-04-26 13:35:03 +02:00
Joakim Hove
1415d849de
Merge pull request #2434 from akva2/fix_serialize_valgrind
...
Fix some valgrind errors in test_ParallelRestart
2021-04-26 12:42:45 +02:00
Tor Harald Sandve
7f24108d09
Raise OPM Version to 2021.04-rc2
2021-04-20 10:30:59 +02:00
Bård Skaflestad
bcc96eda2c
Merge pull request #2432 from goncalvesmachadoc/welltemp_output
...
Fix Well Temperature Output
2021-04-19 08:37:29 +02:00
Joakim Hove
75b81a16a5
Merge pull request #2429 from blattms/fix-compile-g++10.2
...
Include stdexcept header to fix compilation with g++-10
2021-04-19 08:37:23 +02:00
Joakim Hove
7a372c2a43
Merge pull request #2423 from joakim-hove/export-volume
...
Store the active volume with a mutable in the grid
2021-04-13 07:14:09 +02:00
Markus Blatt
e215098122
Merge pull request #2418 from akva2/fix_lto_python
...
Fix some python bindings issues
2021-04-12 14:10:42 +02:00
Joakim Hove
97652c1313
Store the active volume with a mutable in the grid
2021-04-12 13:53:59 +02:00
Joakim Hove
877f82ef06
Merge pull request #2422 from joakim-hove/add-compile-guard
...
Add missing compile guard
2021-04-12 08:32:34 +02:00
Joakim Hove
524be4ca4f
Add missing compile guard
2021-04-12 00:10:23 +02:00
Joakim Hove
71a7af3cae
Merge pull request #2419 from joakim-hove/pass-affected-wells
...
Make sure the affected_wells variable is passed to applyWellopen()
2021-04-10 17:16:43 +02:00
Joakim Hove
8a96d9a8d1
Make sure the affected_wells variable is passed to applyWellopen()
2021-04-10 14:10:44 +02:00
Bård Skaflestad
989c3a8396
Merge pull request #2417 from joakim-hove/import-general
...
Refactor IMPORT handler to accept all data keywords
2021-04-09 14:49:59 +02:00
Arne Morten Kvarving
9402db2421
fix building python bindings (with lto)
...
need to set the define for header only library with internal libfmt,
and whatever flags are required by external libfmt
2021-04-09 11:56:25 +02:00
Arne Morten Kvarving
5d13b9ed59
fixed: built builtin_pybind11.cpp in python bindings
...
necessary with lto as symbols are not visible in main library
2021-04-09 11:56:25 +02:00
Joakim Hove
adc52eb870
Refactor IMPORT handler to accept all data keywords
2021-04-09 10:34:16 +02:00
Joakim Hove
88f284ecab
Merge pull request #2408 from joakim-hove/rst-test-eclipsestate
...
Add EclipseState comparison to rst_test application
2021-04-09 08:51:59 +02:00
Markus Blatt
9a0d26c398
Merge pull request #2386 from blattms/cmake-3.10
...
Stop pretending that we support CMake 2.8
2021-04-08 10:15:10 +02:00
Joakim Hove
b05da71c57
rst_test application will also compare EclipseState
2021-04-08 09:25:03 +02:00
Joakim Hove
d08d358e5d
Add EclipseState::rst_cmp
2021-04-08 09:25:03 +02:00
Joakim Hove
1a1aaa724b
Add comparison functions operator== and rst_cmp() to FieldProps
2021-04-08 09:25:03 +02:00
Joakim Hove
d75c704f26
Reformat #include
2021-04-08 09:15:16 +02:00
Joakim Hove
5e4e949d8d
Add IOConfig::rst_cmp
2021-04-08 09:15:16 +02:00
Joakim Hove
8214f36b61
Add InitConfig::rst_cmp
2021-04-08 09:15:16 +02:00
Joakim Hove
acae9728df
Add SimulationConfig::rst_cmp()
2021-04-08 09:15:16 +02:00
Joakim Hove
646e0cb60f
FieldPropsmanager will have a copy of the tables
2021-04-08 09:15:16 +02:00
Joakim Hove
fe5761096d
Add ThresholdPressure::rst_cmp()
2021-04-08 09:15:16 +02:00
Joakim Hove
6c71179fa1
Add UnitSystem::rst_cmp()
2021-04-08 09:15:16 +02:00
Joakim Hove
e1e1afccd4
Add Runspec::rst_cmp()
2021-04-08 09:15:16 +02:00
Arne Morten Kvarving
6058d2b4f2
Merge pull request #2415 from akva2/fix_redhat_man_pages
...
fix redhat packaging
2021-04-08 09:07:36 +02:00
Arne Morten Kvarving
b28eca17e8
fix redhat packaging
...
handle the new man pages
2021-04-08 09:06:38 +02:00
Joakim Hove
3a733bda6f
Add EclipseConfig::rst_cmp()
2021-04-08 09:01:19 +02:00
Joakim Hove
10c8b96fe0
Merge pull request #2414 from bska/write-active-network-only
...
Output Network Arrays Only if Network is Active
2021-04-07 22:37:51 +02:00
Joakim Hove
7c9fff256c
Add const to AquiferConfig::operator==()
2021-04-07 17:52:25 +02:00
Bård Skaflestad
8a72a34ba5
Output Network Arrays Only if Network is Active
...
This fixes a real field case in which the network is only activated
(keywords BRANPROP and NODEPROP) fairly late in the simulation run.
2021-04-07 16:46:00 +02:00
Atgeirr Flø Rasmussen
659580d749
Merge pull request #2412 from joakim-hove/ep-optional
...
Use std::optional and value objects instead of std::shared_ptr
2021-04-07 16:20:31 +02:00
Joakim Hove
be451c0ccd
Merge pull request #2413 from bska/fix-missing-initializer
...
Initialise All Well Table Dimensions
2021-04-07 15:22:05 +02:00
Markus Blatt
62b202e85c
Stop pretending that we support CMake 2.8
...
We actually already require at least CMake 2.8.12 due to the embedded
pybind11 (some tests of it are even at 3.0). Anyway as Ubuntu LTS has
3.10.2 I doubt that anything less is tested by us.
2021-04-07 13:56:03 +02:00
Bård Skaflestad
4d4a6b700d
Initialise All Well Table Dimensions
...
Including the maximum number of well lists per well and maximum
dynamic well lists added in commit 278cd0a24 (PR #2368 ).
2021-04-07 13:50:28 +02:00
Joakim Hove
ce5f0757df
Merge pull request #2411 from joakim-hove/jfunc-optional
...
Use std::optional instead of std::shared_ptr to manage JFunc
2021-04-07 13:40:44 +02:00
Joakim Hove
ec0ca7bd6d
Merge pull request #2410 from blattms/fixes-debian-1
...
Fixes from the debian packages
2021-04-07 10:29:19 +02:00
Joakim Hove
d33e6ba8ef
Remove TableManager copy constructor and operator=
2021-04-07 09:31:25 +02:00
Joakim Hove
c55f761905
Use std::optional and value objects instead of std::shared_ptr
2021-04-07 09:13:53 +02:00
Joakim Hove
0d4a514c90
Use std::optional instead of std::shared_ptr to manage JFunc
2021-04-07 08:37:12 +02:00
Markus Blatt
3fd76f9c26
Fixes include paths in pkg-config files (at least in Debian).
...
Previously we ended up with "-I -I/cjson" for
"/usr/include;/usr/include/cjson" in opm-common_INCLUDE_DIRS.
Gbp-Pq: Name 0008-Fixes-include-paths-in-pkg-config-files-at-least-in-.patch
2021-04-06 22:57:00 +02:00
Markus Blatt
6895ee4959
Install CMake files below share/opm with USE_SOURCE_PERMISSIONS.
...
Otherwise the scripts will not be executable.
Fixes lintian warning
script-not-executable usr/share/opm/cmake/Scripts/cppcheck-test.sh
Gbp-Pq: Name 0007-Install-CMake-files-below-share-opm-with-USE_SOURCE_.patch
2021-04-06 22:56:59 +02:00
Markus Blatt
3e22403cfe
Make SOVERSION change with every release.
...
Previously the SOVERSION was the year which indicated a stable ABI
within each year. It is highly unlikely that or ABI is that
stable. Hence we stop pretending that it is and change the version
with every release.
Gbp-Pq: Name 0006-Make-SOVERSION-change-with-every-release.patch
2021-04-06 22:56:59 +02:00
Markus Blatt
b24ca0519c
Added manpages for all executables.
...
Debian policy says that each executable should have a man page.
This should remove the lintian warning about missing man pages.
Man pages have been created by the following command:
declare -A short_desc
short_desc['compareECL']='Comparator for Eclipse files'
short_desc['convertECL']='Converter for Eclipse files (binary <-> formatted format)'
short_desc['opmhash']='Hasher for summary keywords in Eclipse files'
short_desc['opmpack']='Validator and printer of deck in Eclipse files without comments'
short_desc['summary']='Printer for summary keys in Eclipse summary files'
for key in "${!short_desc[@]}"; do
help2man -h "-h" --version-string="2020.04" --no-discard-stderr -n "${short_desc[$key]}" $key >\
$key.1
done
Gbp-Pq: Name 0005-Added-manpages-for-all-executables.patch
2021-04-06 22:56:59 +02:00
Markus Blatt
8e70bfb93b
Fix pkg-config files with imported targets.
...
They had imported target names (e.g. from OpenMP) in them which did not work.
Also linking std++fs was a bit strange. Hopefully fixed now.
Gbp-Pq: Name 0003-Fix-pkg-config-files-with-imported-targets.patch
2021-04-06 22:56:59 +02:00
Arne Morten Kvarving
ef47292a85
Merge pull request #2409 from akva2/enable_embedded_python_ubuntu
...
enable embedded python in ubuntu packages
2021-04-06 15:36:46 +02:00
Arne Morten Kvarving
df525c930a
enable embedded python in ubuntu packages
2021-04-06 15:34:11 +02:00
Joakim Hove
cfccc4c814
Merge pull request #2407 from joakim-hove/ecl-config-fix
...
Ecl config fix
2021-04-06 10:00:59 +02:00
Joakim Hove
975b6fd35e
Include IO config in EclipseConfig::operator==
2021-04-06 08:14:52 +02:00
Joakim Hove
dcfcd8fa41
Remove deprecated function
2021-04-06 08:14:52 +02:00
Joakim Hove
67e972a1fa
Merge pull request #2404 from joakim-hove/test-sched-deck
...
Add schedule deck member to Schedule::operator==()
2021-04-04 17:56:27 +02:00
Joakim Hove
0999637e58
Add schedule deck member to Schedule::operator==()
2021-04-04 16:08:26 +02:00
Joakim Hove
512110c258
Merge pull request #2406 from joakim-hove/optional-topup-phase
...
Use std::optional<Phase> instead of std::pair<Phase, bool>
2021-04-04 16:07:01 +02:00
Joakim Hove
43f62189ef
Merge pull request #2405 from joakim-hove/sched-state-reorder
...
Reorder members in ScheduleState
2021-04-03 15:33:24 +02:00
Joakim Hove
9281ef04d2
Merge pull request #2403 from joakim-hove/mv-rst-info
...
Move restart information to ScheduleStatic
2021-04-03 15:32:38 +02:00
Joakim Hove
9dc7e6fa11
Merge pull request #2402 from joakim-hove/welldims-data-equal
...
Add Welldims comparison ignoring location member
2021-04-03 11:48:50 +02:00
Joakim Hove
9a58358d9f
Use std::optional<Phase> instead of std::pair<Phase, bool>
2021-04-03 11:33:33 +02:00
Joakim Hove
4b6e0e1a3f
Reorder members in ScheduleState
2021-04-03 11:13:57 +02:00
Joakim Hove
6e10badb1b
Move restart information to ScheduleStatic
2021-04-03 08:40:06 +02:00
Joakim Hove
f2a8f6d6e6
Add Welldims comparison ignoring location member
2021-04-03 08:08:29 +02:00
Joakim Hove
58d900bd4b
Merge pull request #2400 from bska/remove-aquct-cellid
...
Remove Cell ID Member from CT Aquifer Representation
2021-04-02 09:58:26 +02:00
Bård Skaflestad
c94eb84efe
Remove Cell ID Member from CT Aquifer Representation
...
The data member 'cell_id' isn't actually used anywhere outside of
object serialization. Just remove it.
2021-04-01 14:16:50 +02:00
Joakim Hove
4014eb385c
Merge pull request #2390 from joakim-hove/import-container
...
Import container
2021-03-31 11:55:39 +02:00
Joakim Hove
f754ddebce
Merge pull request #2399 from joakim-hove/gconinje-rename
...
Rename GCONINJE item and use compiled constants
2021-03-31 09:51:44 +02:00
Joakim Hove
a051a3f736
Merge pull request #2398 from joakim-hove/plysher-json
...
Fix JSON scheme for PLYSHEAR table
2021-03-31 09:51:29 +02:00
Joakim Hove
20231af0db
Rename GCONINJE item and use compiled constants
2021-03-31 09:23:10 +02:00
Joakim Hove
4b0996585d
Fix JSON scheme for PLYSHEAR table
2021-03-31 08:16:17 +02:00
Joakim Hove
5edaf996d7
Merge pull request #2393 from joakim-hove/rst-bits
...
Add named constant IGroup::ExceedAction = 7
2021-03-30 22:11:21 +02:00
Joakim Hove
e6e041ca5e
Remove unused argument
2021-03-30 21:24:03 +02:00
Joakim Hove
c3e0575042
Slight refactor of Schedule::addGroup()
2021-03-30 21:24:03 +02:00
Joakim Hove
30659aaf5a
Remove group active control and rename gconprod_cmode -> prod_cmode
2021-03-30 21:24:03 +02:00
Joakim Hove
93b07c0519
Add named constant IGroup::ExceedAction = 7
2021-03-30 21:15:22 +02:00
Joakim Hove
b88a302f49
Merge pull request #2396 from joakim-hove/rm-defaults
...
Remove dummy default values for GCONPROD
2021-03-30 20:23:16 +02:00
Joakim Hove
3c33261ace
Remove dummy default values for GCONPROD
2021-03-30 18:35:45 +02:00
Joakim Hove
febfa9a47a
Integrate ImportContainer into the parser inner loop
2021-03-30 11:50:34 +02:00
Joakim Hove
6e888b9c87
Add class ImportContainer to load keywords from IMPORT file
2021-03-30 11:50:34 +02:00
Joakim Hove
02b02189de
Allow EclFile constructor to get formatted as input argument
2021-03-30 11:37:32 +02:00
Joakim Hove
19addd0fc6
DeckKeyword constructor does not mutate UnitSystem
2021-03-30 11:37:32 +02:00
Joakim Hove
0f59fe900b
Merge pull request #2392 from joakim-hove/schedule-prt
...
Make sure a confusing last report step message is not written out
2021-03-29 15:27:36 +02:00
Joakim Hove
eb2fb4c233
Make sure a confusing last report step message is not written out
2021-03-29 12:27:25 +02:00
Joakim Hove
c7200aa1af
Merge pull request #2347 from joakim-hove/ched-state-rst-config2
...
Internalize restart configuration in new schedule structure
2021-03-27 11:39:23 +01:00
Joakim Hove
e9890a1e13
Fix warning - unused variable
2021-03-27 07:51:41 +01:00
Joakim Hove
0eb1b95fc3
Handle commandline argument --output-interval
2021-03-27 07:51:41 +01:00
Joakim Hove
d14cd52a5e
Remove stale functionality RestartConfig / DynamicState
2021-03-27 07:51:41 +01:00
Joakim Hove
546523e229
Add new class RSTConfig for configuration of restart.
2021-03-27 07:51:41 +01:00
Joakim Hove
d25962ba80
Merge pull request #2378 from bska/configure-requisite-aquifer-summary-output
...
Configure Aquifer Summary Output Needed for Restart
2021-03-26 16:02:41 +01:00
Bård Skaflestad
621f0a443a
Configure Aquifer Summary Output Needed for Restart
...
The summary vectors
AAQP (pressure), AAQR (rate), AAQT (volume)
must be available for output to the restart file's "XAAQ" array for
all analytic aquifers. Additionally, the summary vectors
AAQTD (dimensionless time), AAQPD (dimensionless pressure)
must be available for restart output to "XAAQ" in the case of
Carter-Tracy aquifers.
This commit ensures that those values are always calculated and
stored in the SummaryState.
2021-03-26 15:24:23 +01:00
Bård Skaflestad
0f7d44ea13
Use Same Evaluation Factory for All Vectors
...
In particular, switch to using the Evaluator::Factory object for the
"required" restart vectors too. This is in preparation of including
aquifer-related summary vectors into the set of required restart
vectors.
2021-03-26 15:24:23 +01:00
Bård Skaflestad
d0855bd995
Harmonise Required Segment Vector Implementation
...
Use pattern from the well, group, and field-level implementation.
While here, also switch to passing a default-constructed optional
instead of an empty string for the "fip_region".
2021-03-26 15:24:23 +01:00
Atgeirr Flø Rasmussen
9a9efa50f3
Merge pull request #2388 from joakim-hove/update-license
...
Update license header to GPL V3
2021-03-26 14:52:40 +01:00
Joakim Hove
eeddd663a5
Uddate license header to GPL V3
2021-03-26 12:42:30 +01:00
Joakim Hove
12dd9d321b
Merge pull request #2384 from joakim-hove/actionx-affected-wells
...
Schedule::applyAction() will return a set of wells affected
2021-03-25 17:03:49 +01:00
Joakim Hove
9bfdf709b7
Schedule::applyAction() will return a set of wells affected
2021-03-25 12:00:08 +01:00
Joakim Hove
da8df340b2
Merge pull request #2383 from joakim-hove/remove-first-rst-step
...
Remove unused function first_rst_step()
2021-03-25 10:53:10 +01:00
Bård Skaflestad
19183bdd6c
Merge pull request #2379 from joakim-hove/aquifer-grid-order
...
Aquifer grid order
2021-03-25 09:41:29 +01:00
Bård Skaflestad
704b3edfe7
Merge pull request #2373 from joakim-hove/aggregate-conn-data
...
Aggregate conn data
2021-03-25 09:31:56 +01:00
Joakim Hove
cfc552f39c
Remove unused function first_rst_step()
2021-03-25 08:28:30 +01:00
Joakim Hove
2247b45872
Use SummaryState for connection rates in restart output
2021-03-25 07:21:31 +01:00
Joakim Hove
b6e739cd7e
Register connection variables as required for restart
2021-03-25 07:21:31 +01:00
Joakim Hove
39e5ca32c0
Add summary evaluation support for CPR
2021-03-25 07:21:31 +01:00
Joakim Hove
ee86cf0196
Register summary evaluator for COIR
2021-03-25 07:21:31 +01:00
Joakim Hove
04242353c7
Use {} for optional string instead of ""
2021-03-25 07:21:31 +01:00
Joakim Hove
14fe6a5700
Merge pull request #2382 from joakim-hove/move-rst-tests
...
Move restart tests and use Schedule::write_rst_file()
2021-03-25 07:18:08 +01:00
Joakim Hove
f31a080fb6
Merge pull request #2374 from bska/aquct-dimless-time-and-press-smry
...
Support CT-Aquifer Dimensionless P/T Summary Vectors
2021-03-25 07:17:23 +01:00
Joakim Hove
6eddc4c088
Move restart tests and use Schedule::write_rst_file()
2021-03-24 18:15:47 +01:00
Joakim Hove
7c1b5b8b21
Add warning about aquifers connected to inactive cells
2021-03-24 13:08:27 +01:00
Joakim Hove
e8d4d99e6b
Interleave ACTNUM modifications and Aquifer configuration
2021-03-24 13:08:27 +01:00
Bård Skaflestad
70457e1433
Support CT-Aquifer Dimensionless P/T Summary Vectors
...
This commit adds support for calculating and outputting the
CT-specific summary vectors "AAQTD" (dimensionless time, real time
divided by aquifer's time constant) and "AAQPD" (dimensionless
pressure-influence function evaluated at dimensionless time).
2021-03-24 11:43:25 +01:00
Joakim Hove
602dc07181
Merge pull request #2381 from joakim-hove/simplify-rst-test
...
Simplify test fixture
2021-03-24 10:27:57 +01:00
Markus Blatt
b7dc593092
Merge pull request #2359 from blattms/support-system-pybind
...
Support system pybind
2021-03-24 10:09:37 +01:00
Joakim Hove
e2ef6bc662
Simplify test fixture
2021-03-24 09:40:04 +01:00
Bård Skaflestad
37aee167eb
Merge pull request #2377 from joakim-hove/rst-test-fix
...
Fix test assert and temporarily disable
2021-03-23 15:51:06 +01:00
Joakim Hove
a62d73a424
Merge pull request #2376 from joakim-hove/rst-test-fixtures
...
Update test fixtures
2021-03-23 13:02:48 +01:00
Joakim Hove
227a07ed06
Fix test assert and temporarily disable
2021-03-23 11:40:32 +01:00
Joakim Hove
8258d65900
Update test fixtures
2021-03-23 09:33:06 +01:00
Joakim Hove
6609ca265c
Merge pull request #2372 from joakim-hove/summary-state-connections
...
Add special treatment of connection variables in SummaryState
2021-03-23 07:22:45 +01:00
Joakim Hove
5f91bfa7d0
Merge pull request #2375 from GitPaean/aquifer_cell_volumes
...
function to ouput the cell volume for numerical aquifer cells
2021-03-22 22:33:30 +01:00
Kai Bao
2a67eb44ed
function to ouput the cell volume for numerical aquifer cells
2021-03-22 15:18:47 +01:00
Joakim Hove
596c3a9db3
Merge pull request #2370 from joakim-hove/actionx-prt-prefix
...
Add prefix the schedule messages to highlight ACTIONX rerun
2021-03-22 10:54:27 +01:00
Joakim Hove
12c63f7346
Use Summarystate::update_conn_var from Summary
2021-03-21 15:21:41 +01:00
Joakim Hove
5b3787ec46
Add special treatment of connection variables in SummaryState
2021-03-21 15:20:45 +01:00
Joakim Hove
d2cb2eeec4
Add prefix the schedule messages to highlight ACTIONX rerun
2021-03-19 22:30:37 +01:00
Bård Skaflestad
77f058645f
Merge pull request #2368 from jalvestad/intehead_corrections
...
Corrections to InteHead to account for ROCKOPTS data and Well lists
2021-03-19 21:14:53 +01:00
Markus Blatt
1c311150a5
Prevent newline in PYTHON_INCLUDE_DIR.
...
It breaks the docker pypi build.
2021-03-19 20:18:58 +01:00
Markus Blatt
f8c6fabb2d
Use system's pybind11 if available.
2021-03-19 20:18:58 +01:00
Jostein Alvestad
278cd0a240
eliminated WellDims and used WellTableDims instead
2021-03-19 13:59:40 +01:00
Jostein Alvestad
d0f177d94c
corrections to inteHead - rockopts, well lists
2021-03-19 13:59:39 +01:00
Joakim Hove
70a658c91d
Merge pull request #2367 from joakim-hove/well-cmode
...
Add shortcuts to get injectorcontrols from Well
2021-03-19 12:48:42 +01:00
Tor Harald Sandve
61ad81b701
Merge pull request #2315 from bska/record-dynamic-status
...
Record Dynamic Well Status in Output Wells
2021-03-19 09:07:38 +01:00
Joakim Hove
f345d37dd1
Add shortcuts to get injectorcontrols from Well
2021-03-18 19:30:09 +01:00
Bård Skaflestad
89e3efb2e4
Record Dynamic Well Status in Output Wells
...
This commit adds a new data member
Well::Status dynamicStatus
to the data::Well object. This member records the simulator's
notion of a well's open/shut/stop status and is especially needed to
support WECON-type status changes once the simulator maintains both
open and shut wells.
While here, also change multiple summary primitives to not look up
the same values repeatedly.
2021-03-18 17:26:33 +01:00
Joakim Hove
27b4110314
Merge pull request #2355 from totto82/guideRateInj
...
Add guiderate for injection groups
2021-03-18 17:04:34 +01:00
Markus Blatt
77050e5042
Moved settings of CMake_STANDARD stuff to OPMInit.cmake
...
That makes it usable from *prereqs and helps preventing
multiple -std=c++xx options when compiling (at least for
pybind11)
2021-03-18 15:06:00 +01:00
Markus Blatt
55bdaaa9f9
Do not set unnecessary COMPILE_DEFINTIONS.
...
The ones set for DUNE are for very old unsupported versions.
2021-03-18 15:06:00 +01:00
Markus Blatt
18ccbcfa03
Merge pull request #2362 from blattms/use-add-compile-definitions
...
Use add_compile_definitions to add defintions
2021-03-18 15:04:34 +01:00
Joakim Hove
b206a7542e
Merge pull request #2365 from bska/ancon-accum-effective-face-area
...
Accumulate Effective Aquifer Connection Face Area
2021-03-18 11:00:34 +01:00
Bård Skaflestad
3c6c827a75
Accumulate Effective Aquifer Connection Face Area
...
We need this information to form part of the per-connection restart
output to the "SCAQ" array. The accumulation uses the same
procedure as for the total influx coefficient, but is always based
on the geometric face area instead of the tabulated aquifer influx
coefficient.
2021-03-17 21:04:30 +01:00
Markus Blatt
05128745cf
Some modules may still export definitions using -D, strip it.
2021-03-17 17:27:26 +01:00
Markus Blatt
213f0c0afa
Only add -D for older CMake versions.
2021-03-17 16:57:00 +01:00
Joakim Hove
a3984dbcb6
Merge pull request #2364 from blattms/remove-boost-python-include
...
Removes inclusion of boost-python header
2021-03-17 16:55:10 +01:00
Markus Blatt
6cf4250f18
Removes inclusion of boost-python header
2021-03-17 16:02:41 +01:00
Markus Blatt
6d9a924930
Add -D qualifier to DEFINITIONS if missing for old CMake.
2021-03-17 15:36:24 +01:00
Joakim Hove
fe99038df6
Merge pull request #2363 from joakim-hove/action-wells-specified
...
Make sure action results contain well for fully specified condition
2021-03-17 13:44:09 +01:00
Markus Blatt
a4f73a3a7c
Use add_compile_definitions for newer CMake versions.
...
add_definitions is deprecated.
Note the new command does not need the -D qualifier but will detect
if there is one and act accordingly. This helps with package
configuration files that have "-DVAR" in their COMPILE_DEFINTIONS
As some packages actually already add the -D qualifier we now detect
that to be able to support old CMake version without
add_compile_definitions. In this case we prevent adding another -D
and use add_definitions.
2021-03-17 11:16:13 +01:00
Joakim Hove
d02ae5e650
Make sure action results contain well for fully specified condition
2021-03-17 10:08:35 +01:00
Markus Blatt
66ed9bcf75
Merge pull request #2360 from blattms/fix-docker-pypi
...
Determine Python include directory to fix docker pypi builds
2021-03-16 22:05:00 +01:00
Markus Blatt
ee11a57b6c
Honor PYTHON_EXECUTABLE even if we use Python3.
2021-03-16 20:32:50 +01:00
Markus Blatt
9bc0536d13
Do not use the imported Python3 library directly.
...
It just a hassle (need to search for Python3 downstream,
cannot be backwards compatible).
2021-03-16 20:32:50 +01:00
Markus Blatt
1ed6166f1f
Determine Python include directory to fix docker pypi builds
...
Whenever OPM_ENABLE_PYTHON is on we need to set PYTHON_INCLUDE_DIRS
as it is needed to find Python.h (shouldn't we even need to link the
library?).
This could (in theory) be done by using by issuing
find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
or
find_package(PythonLibs REQUIRED).
Unfortunately, both do not work (for yet unknown reasons) when we
build pypi packages in docker (even with setting the PYTHON_EXECUTABLE
or Python3_EXECUTABLE correctly).
Hence we now use python manually to determine these.
2021-03-16 20:32:36 +01:00
Tor Harald Sandve
5f30a969f0
clean-up the interface of the guiderates
2021-03-16 15:53:35 +01:00
Joakim Hove
39a8233238
Merge pull request #2358 from joakim-hove/test-remove-special
...
Remove special mnemomics from testing
2021-03-16 14:01:03 +01:00
Joakim Hove
17639d821d
Remove special mnemomics from testing
2021-03-15 22:33:16 +01:00
Joakim Hove
b189cc907f
Merge pull request #2356 from atgeirr/minor-fixes
...
Minor fixes
2021-03-15 22:31:54 +01:00
Joakim Hove
eb652ac232
Merge pull request #2353 from joakim-hove/remove-unneeded-cmake-include
...
Remove cmake include of pybind11 CMakeLists.txt
2021-03-15 16:41:24 +01:00
Atgeirr Flø Rasmussen
675cb40dd4
Silence a few warnings.
2021-03-15 14:19:15 +01:00
Joakim Hove
ae7edda588
Merge pull request #2351 from joakim-hove/remove-find-cwrap
...
Removed cmake module FindCwrap
2021-03-15 13:39:52 +01:00
Markus Blatt
b7ce9c0fe2
Merge pull request #2348 from blattms/external-fmtlib-2
...
Enable usage of fmtlib on the system.
2021-03-15 13:26:23 +01:00
Atgeirr Flø Rasmussen
6518e5d905
Add missing <string> include.
2021-03-15 12:57:57 +01:00
Tor Harald Sandve
8941cc7c02
Add guiderate for injection groups
2021-03-15 12:29:20 +01:00
Joakim Hove
2a2ce8c826
Merge pull request #2354 from blattms/python-libs-only-for-embedded
...
Only search for Python libs if OPM_ENABLE_EMBEDDED_PYTHON is ON.
2021-03-15 12:28:04 +01:00
Markus Blatt
0455c48d2f
Only search for Python libs if OPM_ENABLE_EMBEDDED_PYTHON is ON.
...
Apparently it is not needed in the other cases.
Fixes an issue that arose from #2344 and restores the old behaviour
concerning the libraries.
2021-03-15 10:19:10 +01:00
Joakim Hove
52caefae34
Remove cmake include of pybind11 CMakeLists.txt
2021-03-15 09:27:19 +01:00
Joakim Hove
0ae020cb8b
Removed cmake module FindCwrap
2021-03-13 16:22:16 +01:00
Joakim Hove
8d11fc5458
Merge pull request #2344 from blattms/search-for-python3
...
Explictly search for python3 (CMake >= 3.12.0) and send error if only python2 is found
2021-03-13 16:20:04 +01:00
Markus Blatt
af3c825588
Make sure any python search finds Python3.
...
FindCWrap issues another find_package(PythonInterpret).
By setting the PYTHON_EXECUTABLE variable we make sure it
will find python3
This also fixes the CMake confusions about multiple linker paths
```
Make Warning at cmake/Modules/OpmSatellites.cmake:320 (add_executable):
Cannot generate a safe linker search path for target test_ERft because
files in some directories may conflict with libraries in implicit
directories:
link library [libpython3.7m.so] in /usr/lib/x86_64-linux-gnu may be hidden by files in:
/usr/lib/python3.7/config-3.7m-x86_64-linux-gnu
Some of these libraries may not be found correctly.
```
2021-03-12 16:48:26 +01:00
Markus Blatt
9a25b78b98
Cater for missing FindPython3 in CMake version < 3.12.0
...
For these we need to use the old approach. At least we
now produce an error if only python2 is found.
Needed e.g. for Ubuntu LTS 18.04.
2021-03-12 16:47:27 +01:00
Markus Blatt
504aed72eb
Enable usage of fmtlib on the system.
...
If fmtlib is present on the system we used that one
in the normal mode (not header only). Otherwise we
fallback to the embedded one header only.
2021-03-12 14:47:15 +01:00
Markus Blatt
f8ab960d97
Merge pull request #2346 from blattms/recover-external-cjson-support
...
Recover external cjson library support.
2021-03-12 14:42:44 +01:00
Kai Bao
df0fdb7169
Merge pull request #2349 from GitPaean/using_map_for_numerical_aquifers
...
using std::map for m_aquifers of NumericalAquifers
2021-03-12 13:14:51 +01:00
Kai Bao
e56865cafe
using std::map for m_aquifers of NumericalAquifers
...
to make sure the same order when traversing the m_aquifers during
parallel running.
2021-03-12 10:01:22 +01:00
Markus Blatt
2e0bc4f17a
Recover external cjson library support.
...
This was somehow deactivated when merging opm-parser to opm-common.
2021-03-11 16:21:46 +01:00
Joakim Hove
654a78a541
Merge pull request #2339 from joakim-hove/sched-state-sim-step
...
Sched state sim step
2021-03-11 15:23:02 +01:00
Markus Blatt
c98f74c206
Make imported Python3 targets available downstream
2021-03-11 12:50:48 +01:00
Markus Blatt
974f7da6a1
Use python3 for setup scripts, too
2021-03-11 11:50:27 +01:00
Joakim Hove
fda9601ecc
Merge pull request #2345 from GitPaean/adding_missing_init_pressure
...
adding init_pressure in the serilization of NumericalAquiferCell
2021-03-11 08:43:49 +01:00
Kai Bao
16fd8997fa
adding init_pressure in the serilization of NumericalAquiferCell
...
it was missing.
2021-03-10 23:40:46 +01:00
Bård Skaflestad
2782bff479
Merge pull request #2342 from joakim-hove/gen-source-dep-fixup
...
Gen source dep fixup
Fixes #2340 .
2021-03-10 21:47:03 +01:00
Joakim Hove
56d3d1a7d3
Merge pull request #2335 from totto82/addInjectionTypeChangedEvent
...
Add event for injection type changed
2021-03-10 15:58:59 +01:00
Markus Blatt
164f451124
Explictly search for python3 and use that instead PythonInterpret et al.
...
Otherwise python2 might be found, but OPM needs python3.
2021-03-10 15:57:01 +01:00
Joakim Hove
122f15006c
Check OPM_ENABLE_PYTHON and OPM_ENABLE_EMBEDDED_PYTHON
2021-03-10 15:44:45 +01:00
Joakim Hove
d6aa829197
Avoid spurious dependencies if Python is not enabled
2021-03-10 15:44:43 +01:00
Joakim Hove
f8fb46ed84
Source generator should only optionally generate Python binding code
2021-03-10 15:44:18 +01:00
Joakim Hove
0a5301d949
Merge pull request #2319 from jalvestad/rst_wsegaicd
...
Changes to output Restart data for the WSEGAICD keyword (Eclipse compatible restart file)
2021-03-10 14:59:49 +01:00
Joakim Hove
55fd38d5c9
Merge pull request #2341 from joakim-hove/remove-rst-keyword
...
Remove unneccesary function RestartConfig::getKeyword()
2021-03-10 14:49:31 +01:00
Joakim Hove
90839c0e16
Remove unneccesary function RestartConfig::getKeyword()
2021-03-10 13:23:16 +01:00
Joakim Hove
bfb1b7d7e5
Merge pull request #2337 from joakim-hove/gconinje-guiderate
...
Gconinje guiderate
2021-03-10 13:17:32 +01:00
Joakim Hove
2487feb815
Merge pull request #2331 from bska/enumerate-active-by-columns
...
Add Special Purpose Active Cell Enumeration by Columns
2021-03-10 13:17:10 +01:00
Joakim Hove
e2521495f2
Internalize guide rate when loading GCONINJE keyword
2021-03-10 09:54:50 +01:00
Joakim Hove
6e7d9102c7
Rename enum Group::GuideRateTarget -> Group::GuideRateProdTarget
2021-03-10 09:54:50 +01:00
Joakim Hove
218349a453
Rename GCONINJE guiderate items
2021-03-10 09:54:50 +01:00
Bård Skaflestad
6d18b3b7e6
ActiveIndexByColumn: Remove 'build' Method
...
Do construction work in constructor instead.
Suggested by: [at]joakim-hove
2021-03-10 09:54:14 +01:00
Joakim Hove
d673f2e555
Add member first_in_month and first_in_year to ScheduleState
2021-03-10 09:49:13 +01:00
Joakim Hove
b151c85f6c
Add month_num and year_num members to ScheduleState
2021-03-10 09:26:02 +01:00
Bård Skaflestad
b6b81462d2
Use Sorting to Infer Columnar Active Cell ID
...
This reduces the space overhead of the build stage from "number of
Cartesian cells" to "number of active cells", at the cost of some
increased processing time (sorting vs. linear traversals).
2021-03-10 09:23:23 +01:00
Bård Skaflestad
d2028e4851
Add Special Purpose Active Cell Enumeration by Columns
...
The protocol for outputting an aquifer's active cell IDs to the
restart file requires that the cells be enumerated according to
their column. In particular, the aquifer's notion of a model's
active cells correspond to a cell ordering of the form
for (i = 0; i < Nx; ++i)
for (j = 0; j < Ny; ++j)
for (k = 0; k < Nz; ++k)
use(X(i, j, k))
instead of the common ordering, sometimes referred to as "natural
ordering"
for (k = 0; k < Nz; ++k)
for (j = 0; j < Ny; ++j)
for (i = 0; i < Nx; ++i)
use(X(i, j, k))
which is employed elsewhere.
This commit adds a special purpose mapping facility which will
translate active cell IDs from natural ordering to the columnar
enumeration. The facility is intentionally bare-bones because we
do not expect to use it outside of the restart writing code, and
only in a limited fashion within that context. We will however
consider adding more features if the need arises.
2021-03-10 09:23:23 +01:00
Tor Harald Sandve
456e94d524
Add event for injection type changed
2021-03-10 08:40:03 +01:00
Jostein Alvestad
97fa62e560
correction for maxAbsoluteRate
2021-03-10 08:38:08 +01:00
Joakim Hove
34ddba52d7
Add member sim_step to ScheduleState
2021-03-10 08:08:43 +01:00
Joakim Hove
69c198271f
Merge pull request #2327 from joakim-hove/summary-invalid-fipnum
...
Summary invalid fipnum
2021-03-10 07:32:43 +01:00
Joakim Hove
c4b8598b92
Merge pull request #2338 from bska/internalise-aqudims
...
Partially Internalise AQUDIMS in Runspec
2021-03-10 07:27:45 +01:00
Bård Skaflestad
796318409d
Partially Internalise AQUDIMS in Runspec
...
This commit internalises the items NANAQU (5) and NCAMAX (6) of the
AQUDIMS keyword into a new structure
AquiferDimensions
hooked up to the 'Runspec' class. This is in preparation of adding
restart output for analytic aquifers (Carter-Tracy and Fetkovich).
2021-03-09 22:29:00 +01:00
Joakim Hove
e3b54278a0
Merge pull request #2336 from bska/tidy-aquancon-repr
...
Don't Needlessly Copy AQUANCON Objects
2021-03-09 20:12:13 +01:00
Joakim Hove
b197ac7a3f
Merge pull request #2317 from joakim-hove/parserkeywords-container
...
Add container of builtin keywords
2021-03-09 20:11:33 +01:00
Bård Skaflestad
cab51ed57e
Merge pull request #2334 from joakim-hove/restart-config-testing
...
Use schedule object in testing of restart configuration
2021-03-09 18:04:47 +01:00
Bård Skaflestad
0c2a435b94
Don't Needlessly Copy AQUANCON Objects
...
Return the operator[]() data by reference-to-const instead of as a
freshly created vector object.
While here, also (slightly) reduce the compilation overhead of this
module (and its users) by forward declaring interface types and
moving the actual include statements to the .CPP file.
2021-03-09 16:19:05 +01:00
Jostein Alvestad
f84c42104a
further improvements to the code - segmentType
2021-03-09 15:50:04 +01:00
Jostein Alvestad
01fa2af160
corrections and comments to code to explaing logic
2021-03-09 15:50:02 +01:00
Jostein Alvestad
941de32084
changes to boost test values due to changes in the test-dataset
2021-03-09 15:50:00 +01:00
Jostein Alvestad
e96778c440
changes in test-dataset and initial adaptions to the new data set, plus corrections for ScalingFactor
2021-03-09 15:49:58 +01:00
Jostein Alvestad
8a5a159450
Added changes to output restart data to support WSEGAICD input
2021-03-09 15:49:55 +01:00
Joakim Hove
84d5dbde0e
Make the Builtin class available from Python
2021-03-09 12:22:39 +01:00
Joakim Hove
f584901da4
Add class Builtin with all the compiled keywords
2021-03-09 12:22:39 +01:00
Joakim Hove
0d07a250d8
Use schedule object in testing of restart configuration
2021-03-09 12:19:46 +01:00
Bård Skaflestad
dd7d8748e0
Merge pull request #2333 from joakim-hove/restart-config-testing
...
Use multiline string literals
2021-03-09 09:12:26 +01:00
Joakim Hove
2dbf7ff281
Use multiline string literals
2021-03-09 08:25:36 +01:00
Joakim Hove
1ecf10a6ab
Merge pull request #2332 from joakim-hove/schedule-output-interval
...
Add optional argument to override output interval - EBOS paramstyle
2021-03-09 07:26:02 +01:00
Joakim Hove
298e565862
Merge pull request #2329 from tskille/esmry_fixes
...
Improved robustness for locating multiple result files
2021-03-08 22:10:23 +01:00
Torbjørn Skille
8f123f3519
Improved robustness for locating multiple result files
2021-03-08 19:36:12 +01:00
Joakim Hove
66b6b35925
Merge pull request #2330 from bska/accept-temporary-cartdims
...
Accept Temporary 'Dimension' Arguments in EclipseGrid Constructor
2021-03-08 19:31:25 +01:00
Joakim Hove
9369690615
Add overide output interval argument to RestartConfig
2021-03-08 18:16:42 +01:00
Joakim Hove
9d18afb45e
Add optional argument to override output interval - EBOS paramstyle
2021-03-08 17:43:04 +01:00
Bård Skaflestad
050e2c6c9e
Accept Temporary 'Dimension' Arguments in EclipseGrid Constructor
...
There's no need to require that the client creates an actual,
mutable array object on the stack (or elsewhere) in order to form an
EclipseGrid instance.
This is nevertheless mostly to make it easier to use the COORD/ZCORN
constructor usable in unit tests.
2021-03-08 16:52:34 +01:00
Joakim Hove
18dca82a8b
Handle empty regions in summary region results
2021-03-08 16:29:56 +01:00
Joakim Hove
47f292bd93
Handle undefined fipnum definition in summary keywords like RPR__ABC
2021-03-08 12:30:41 +01:00
Joakim Hove
8a901f2700
Merge pull request #2326 from joakim-hove/summary-add-fp
...
Add fieldprops argument to SummaryConfig constructor
2021-03-08 12:25:13 +01:00
Joakim Hove
9c0b375e60
Merge pull request #2325 from OPM/restart-config-private
...
Hide RestartConfig as private member of Schedule class
2021-03-08 12:24:27 +01:00
Joakim Hove
48b366b1f9
Add fieldprops argument to SummaryConfig constructor
2021-03-08 08:23:01 +01:00
Joakim Hove
b5183b1d76
Hide RestartConfig as private member of Schedule class
2021-03-07 11:27:09 +01:00
Joakim Hove
091c7b21cd
Merge pull request #2323 from joakim-hove/remove-timemap
...
Remove timemap
2021-03-06 13:36:03 +01:00
Joakim Hove
c01a880388
Remove functionality from DynamicState
2021-03-06 07:49:02 +01:00
Joakim Hove
6fb0aa21ec
Remove unused includes
2021-03-06 07:49:02 +01:00
Joakim Hove
fc28ff36f1
Reduce TimeMap usage
2021-03-06 07:49:02 +01:00
Joakim Hove
76231044e3
Merge pull request #2324 from joakim-hove/remove-function
...
Remove function RestartConfig::getRestartFileName()
2021-03-05 17:40:28 +01:00
Joakim Hove
993c6c1725
Remove unused function RestartConfig::getRestartFileName()
2021-03-05 15:45:17 +01:00
Joakim Hove
a713783b48
Merge pull request #2320 from joakim-hove/vfp-uda
...
Handle UDA values for ALQ in WCONPROD / WCONHIST
2021-03-05 12:29:19 +01:00
Joakim Hove
910c37c4e1
Merge pull request #2321 from joakim-hove/icd-maxrate-optional
...
Use std::optional<double> for ICD maximum flow rate
2021-03-05 12:28:49 +01:00
Joakim Hove
4d6ee36708
Merge pull request #2322 from joakim-hove/region-input-error
...
Region input error
2021-03-05 11:12:39 +01:00
Joakim Hove
586d15653b
SummaryConfig: allow region numbers beyond NUMFIP
2021-03-05 08:39:37 +01:00
Joakim Hove
b1877c79e0
Remove extra "," in format message
2021-03-05 07:21:09 +01:00
Joakim Hove
b38d5166ce
Use std::optional<double> for ICD maximum flow rate and scaling
2021-03-04 19:28:48 +01:00
Joakim Hove
3205423fc5
Accept UDA input for ALQ in WCONPROD / WCONHIST
2021-03-04 14:01:28 +01:00
Bård Skaflestad
ab5ad88fef
Merge pull request #2310 from joakim-hove/restart-config-make-time-map
...
Restart config make time map
2021-03-03 18:06:43 +01:00
Joakim Hove
7b896359f6
Part 2: Use Opm::time_point
2021-03-03 15:13:34 +01:00
Joakim Hove
5698883040
Part 1: Add typedef Opm::time_point and from_time_t() + to_time_t()
2021-03-03 15:13:34 +01:00
Joakim Hove
2c0b2281da
namespace TimeService with functions advance and makeUTCTime
2021-03-03 15:09:29 +01:00
Joakim Hove
09dcacf16d
Use ScheduleDeck::size() instead of this->size() while assembling
2021-03-03 15:09:29 +01:00
Joakim Hove
37e29266ea
Remove timemap member from Schedule class
2021-03-03 15:09:29 +01:00
Joakim Hove
dbd57cc326
Schedule class will store restart info
2021-03-03 15:09:29 +01:00
Joakim Hove
c7da5b11cf
Hide TimeMap member in RestartConfig
2021-03-03 15:09:29 +01:00
Joakim Hove
80c5a6979b
Merge pull request #2313 from totto82/drsdt_dyn
...
Add DRSDTCON to allow for convective DRSDT
2021-03-03 12:47:55 +01:00
Joakim Hove
d5639ffeb8
Merge pull request #2316 from joakim-hove/python-ignore-keyword
...
Expose ParseContext::ignore_keyword() in Python
2021-03-03 10:48:01 +01:00
Tor Harald Sandve
ee52a05106
use compile constants instead of strings
2021-03-02 14:30:27 +01:00
Joakim Hove
0c74e9ac7a
Expose ParseContext::ignore_keyword() in Python
2021-03-02 10:24:18 +01:00
Joakim Hove
6d04924966
Merge pull request #2314 from verveerpj/missing_features
...
Add error keys to support the new keyword validation in opm-simulators
2021-02-28 20:59:18 +01:00
Peter Verveer
537d6938e6
Add error keys to support the new keyword validation in opm-simulators
2021-02-26 17:27:37 +01:00
Joakim Hove
778767d205
Merge pull request #2309 from joakim-hove/schedule-testing
...
Remove enforced inline schedule testing
2021-02-25 22:48:06 +01:00
Bård Skaflestad
50dec6bd58
Merge pull request #2296 from alfbr/fix-message
...
Do not print debug message to LOG/PRT file
2021-02-24 23:47:43 +01:00
Alf Birger Rustad
f48c7b79a3
Fix typo
2021-02-24 22:22:48 +01:00
Alf Birger Rustad
e6fc1b522f
Send message to DBG-file
2021-02-24 22:08:13 +01:00
Tor Harald Sandve
9b5ad9cfe8
Add DRSDTCON to allow for convective DRSDT
2021-02-23 12:45:03 +01:00
Bård Skaflestad
3db2e964dd
Merge pull request #2311 from GitPaean/wip_aquifer_init
...
writing aquifer cell and connection information to INIT file
2021-02-22 01:00:44 +01:00
Kai Bao
43b609801d
addressing the review comments for PR OPM/opm-common#2311
2021-02-21 23:15:47 +01:00
Joakim Hove
715bebdb89
Merge pull request #2312 from bska/call-firstrft-once
...
Call Schedule::first_RFT() Once Only
2021-02-20 16:02:16 +01:00
Kai Bao
a38b35d0a0
small refactoring of function writeAquifers in WriteInit
...
splitting the function to be two for better readability.
2021-02-19 22:51:00 +01:00
Kai Bao
088459f74c
removing two unused header files in WriteInit.cpp
2021-02-19 22:25:25 +01:00
Kai Bao
dc2cf4053a
writing aquifer connection to INIT file
2021-02-19 22:25:15 +01:00
Bård Skaflestad
bcf40ea5bd
Call Schedule::first_RFT() Once Only
...
This member function is no longer constant time so it makes sense to
limit the number of calls.
2021-02-19 17:41:24 +01:00
Bård Skaflestad
a1ee2f3b07
Merge pull request #2308 from joakim-hove/rft-fixup
...
Fix check for access to first_RFT()
2021-02-19 12:56:36 +01:00
Joakim Hove
7894de8030
Remove enforced inline schedule testing
2021-02-19 11:51:26 +01:00
Joakim Hove
aadfe009c3
Fix check for access to first_RFT()
2021-02-19 11:34:12 +01:00
Joakim Hove
928ba9f702
Merge pull request #2304 from joakim-hove/rft-sched-state
...
Use SchedState to handle RFT configuration
2021-02-19 10:35:21 +01:00
Joakim Hove
404b7cc38a
Merge pull request #2305 from joakim-hove/guiderate-injector
...
Convert GuideRateTarget::RAT to preferred phase for injectors
2021-02-18 19:56:49 +01:00
Joakim Hove
4e57436773
Use ScheduleState to configure RFT
2021-02-18 19:54:18 +01:00
Joakim Hove
0c9390d93a
Merge pull request #2307 from joakim-hove/restart-config
...
Restart config
2021-02-18 18:44:05 +01:00
Joakim Hove
673d4bc251
Merge pull request #2306 from joakim-hove/rm-dynamicstate
...
Rm dynamicstate
2021-02-18 18:43:36 +01:00
Joakim Hove
b90af1efe0
Remove unused #include
2021-02-18 17:03:40 +01:00
Joakim Hove
956de08c05
Remove forward declaration
2021-02-18 16:59:43 +01:00
Joakim Hove
7e7a409ea4
Make function private
2021-02-18 16:58:17 +01:00
Joakim Hove
7aa8d0565b
Remove class DynamicVector<T>
2021-02-18 16:50:23 +01:00
Joakim Hove
5f95d2622c
Remove unused #include <.../DynamicState> and <.../DynamicVector>
2021-02-18 16:45:56 +01:00
Joakim Hove
803e993e91
Convert GuideRateTarget::RAT to preferred phase for injectors
2021-02-18 10:23:01 +01:00
Bård Skaflestad
17fb887398
Merge pull request #2295 from jalvestad/rst-network
...
Add restart data output for Network option data (keywords NETWORK, BRANPROP NODEPROP)
2021-02-17 14:35:49 +01:00
Jostein Alvestad
dafd605eaa
various code improvements based on Joakims review
2021-02-17 08:59:03 +01:00
Jostein Alvestad
b403e2ae48
corrections to handle the use of network or not and degenrate case
2021-02-17 08:59:01 +01:00
Jostein Alvestad
cece11c727
some corrections and completed unit tests
2021-02-17 08:58:59 +01:00
Jostein Alvestad
895b8af837
first complete version of restart output - no unit tests
...
code improvement plus initial changes on test dataset
removed changes to test-dataset
changes to adapt to changes of Schedule object
Added test data set
changed test data - all in one DATA-file, changed serielizer - vector string
added unit test of INode data
2021-02-17 08:58:55 +01:00
Jostein Alvestad
e3be265625
initial changes to output network data to ECL-compatible restart file
...
first code that runs and outputs the INODE array
Added INODE and parts of IBRAN
added contributions for IBRAN and INOBR
added changes for output of RNODE
initial changes for RBRAN
2021-02-17 08:58:52 +01:00
Bård Skaflestad
ec742e302f
Merge pull request #2303 from joakim-hove/group-and-network
...
Network variables are stored with SummaryState::update_group_var
2021-02-17 00:01:00 +01:00
Joakim Hove
a2061972bc
Merge pull request #2302 from joakim-hove/sched-state-rft-config
...
Use std::optional<>
2021-02-16 22:55:56 +01:00
Joakim Hove
be1de22974
Node variables are stored with SummaryState::update_group_var
2021-02-16 22:28:19 +01:00
Joakim Hove
a43d9245e8
Merge pull request #2301 from joakim-hove/rm-commented-code
...
Remove commented out code
2021-02-16 15:30:47 +01:00
Joakim Hove
e029731197
Use std::optional<> instead of homemade std::pair()
2021-02-16 13:50:27 +01:00
Joakim Hove
b70cdb78da
Remove commented out code
2021-02-16 13:39:29 +01:00
Joakim Hove
261f63503d
Merge pull request #2298 from joakim-hove/vfp-warnings
...
VFP Table updates
2021-02-16 13:37:47 +01:00
Joakim Hove
315c80eedc
Merge pull request #2300 from joakim-hove/remove-aqucon-mult
...
Remove aqucon mult
2021-02-16 13:36:33 +01:00
Joakim Hove
a5f32420f5
Improve error message for reused aquifer cell
2021-02-16 10:45:13 +01:00
Joakim Hove
4535b69e0d
Remove multiplier from aquifer cell
2021-02-16 09:58:51 +01:00
Joakim Hove
84809e8d31
Merge pull request #2297 from joakim-hove/aquconn-combine
...
Implement add and multiply semantics for repeated AQUANCON keywords
2021-02-16 09:47:49 +01:00
Joakim Hove
45bfe8da9f
VFP Table updates
...
- Add member KeywordLocation to vfp tables
- Improve error messages
- Remove array_type typedef - use std::vector<double>
- Use class based enums
- Replace assert(x) -> if (!x) throw
2021-02-16 09:14:43 +01:00
Joakim Hove
18cf79ff8a
Merge pull request #2299 from joakim-hove/fp-allow-invalid
...
FieldProps can return invalid data if allow_unsupported is true
2021-02-16 09:08:32 +01:00
Joakim Hove
e20be57d8b
FieldProps can return invalid data if allow_unsupported is true
2021-02-16 08:34:15 +01:00
Joakim Hove
3032df0739
Implement add and multiply semantics for repeated AQUANCON keywords
2021-02-15 13:11:06 +01:00
Alf Birger Rustad
51d2a90386
Do not print debug message to LOG/PRT file
2021-02-15 10:37:02 +01:00
Joakim Hove
154b8727e1
Merge pull request #2294 from joakim-hove/aquconn
...
Aquconn
2021-02-15 09:19:34 +01:00
Joakim Hove
79375ecc9c
Use face area as default influx coefficient for aquifer connection
2021-02-14 20:55:28 +01:00
Joakim Hove
6b9eea3919
Merge pull request #2293 from joakim-hove/handlercontext-add-wellpi
...
Handle WELPI + ACTIONX
2021-02-14 19:50:28 +01:00
Joakim Hove
36159d8512
Handle WELPI as ACTIONX keyword
2021-02-14 18:57:51 +01:00
Joakim Hove
6ad537fb20
Merge pull request #2292 from joakim-hove/tran-distribute-keys
...
Unconditionally include TRAN? keywords in FieldProps::keys<double>()
2021-02-12 16:58:49 +01:00
Joakim Hove
6fcd31850c
Unconditionally include TRAN? keywords in FieldProps::keys<double>()
2021-02-12 09:59:14 +01:00
Joakim Hove
aa7b619fc7
Merge pull request #2287 from joakim-hove/target-wellpi
...
Store target_wellpi in simple map member of ScheduleState
2021-02-12 09:24:27 +01:00
Joakim Hove
579890177e
Remove prod_index member from Well class
2021-02-11 15:57:42 +01:00
Bård Skaflestad
7c67eccb93
Merge pull request #2288 from tskille/wct_unit
...
change units for water cut vectors
2021-02-11 00:01:35 +01:00
Torbjørn Skille
1256f93f63
change units for water cut vectors
...
using same as for commercial simulator
2021-02-10 21:09:55 +01:00
Joakim Hove
35761f31c1
Store target_wellpi in simple map member of ScheduleState
2021-02-10 21:03:26 +01:00
Joakim Hove
5b195311ee
Merge pull request #2286 from joakim-hove/well-get-index-forward
...
Use template predicate and perfect forwarding
2021-02-10 15:37:50 +01:00
Joakim Hove
20b2531f95
Merge pull request #2285 from joakim-hove/apply-action-wellpi-arg
...
Update Schedulle::applyAction() api with wellpi argument
2021-02-10 14:59:17 +01:00
Joakim Hove
cbf18f3a89
Use template predicate and perfect forwarding
2021-02-10 13:19:32 +01:00
Joakim Hove
6d02754260
Update Schedulle::applyAction() api with wellpi argument
2021-02-10 12:30:49 +01:00
Joakim Hove
df563c0776
Merge pull request #2284 from joakim-hove/well-get-by-insert-index
...
Well get by insert index
2021-02-10 11:06:25 +01:00
Joakim Hove
23c1b15a46
Merge pull request #2283 from joakim-hove/unused-arg-warning
...
Remove unused arguments
2021-02-10 11:01:24 +01:00
Joakim Hove
7a40f31823
Add operator[] to NameOrder class
2021-02-10 09:45:01 +01:00
Joakim Hove
0e3839a6f1
Remove unused arguments
2021-02-10 09:19:39 +01:00
Joakim Hove
b45d40e722
Add Schedule::getWell( well_index, report_step) method
2021-02-10 09:09:53 +01:00
Joakim Hove
aea7de2c29
Add size() method to NameOrder class
2021-02-10 09:09:53 +01:00
Joakim Hove
994703e9db
Merge pull request #2269 from joakim-hove/well-sched-state2
...
Well use SchedState
2021-02-10 09:08:16 +01:00
Joakim Hove
bcffaefa7a
Use ScheduleState for wells++
...
Use SchedueleState for wells, in addition to the members UDQConfig, GasLiftOpt
and GuideRateConfig.
2021-02-10 07:22:46 +01:00
Joakim Hove
0a6bbffea9
Merge pull request #2281 from joakim-hove/use-summarystate-optional-get
...
Use SummaryState::get_well_var(, default) instead of manual check
2021-02-10 07:21:51 +01:00
Joakim Hove
564c207a05
Use SummaryState::get_well_var()
2021-02-09 21:51:26 +01:00
Joakim Hove
2c4ac9d52f
Merge pull request #2252 from GitPaean/new_numerical_aquifer_2
...
Numerical Aquifer continue
2021-02-09 07:22:25 +01:00
Joakim Hove
a64a7ba9d5
Merge pull request #2279 from joakim-hove/action-welpi
...
Export list of WELPI wells from an ACTIONX keyword
2021-02-09 07:20:39 +01:00
Bård Skaflestad
83e6c4d2ca
Merge pull request #2276 from joakim-hove/wellpi
...
Apply WELPI is based on newWellPI and not scaling factor
2021-02-08 23:28:50 +01:00
Kai Bao
e5277221c7
adding more tests in AquiferTests for numerical aquifer
2021-02-08 09:40:25 +01:00
Joakim Hove
c294e1779a
Merge pull request #2280 from joakim-hove/mutable-overloads
...
Add mutable overloads for map_member methods get() and operator()
2021-02-07 23:39:41 +01:00
Joakim Hove
61e9d2ba98
Add mutable overloads for map_member methods get() and operator()
2021-02-07 18:05:40 +01:00
Joakim Hove
759a00538e
Export list of WELPI wells from an ACTIONX keyword
2021-02-07 16:26:58 +01:00
Bård Skaflestad
f880a4fa61
Merge pull request #2278 from joakim-hove/compdat-no-move
...
Avoid use after move
Fixes #2277
2021-02-07 11:29:07 +01:00
Joakim Hove
f9a9361180
Avoid use after move
2021-02-07 07:55:37 +01:00
Kai Bao
8443b991c7
isolate numerical aquifer cells by setting permeability to zero
...
instead of editing transmissiblity directly.
2021-02-05 14:40:38 +01:00
Kai Bao
fc8ca0566d
updating more fieldProps related to numerical aquifer cells
2021-02-05 14:40:38 +01:00
Kai Bao
667f20df70
addressing reviewing comments in OPM/opm-common#2252
2021-02-05 14:40:38 +01:00
Kai Bao
9231c6c25d
adding a few functions for simulator usage
...
return aqufier id and access all the aquifers in NumericalAquifers
2021-02-05 14:40:38 +01:00
Kai Bao
74921e3668
summary support for numerical aquifer keywords
2021-02-05 14:40:38 +01:00
Kai Bao
2da3a2987c
fixing test TESTCP_ACTNUM_AQUNUM in EclipseGridTests
2021-02-05 14:40:38 +01:00
Kai Bao
a1f98d7f2d
creating NNCs to form numerical aquifers
...
Aquifer cells are connected through NNCs to form the aquifer itself. And
the reservoirs cells are connected to the first aquifer cell through
NNCs also.
2021-02-05 14:40:38 +01:00
Kai Bao
398d45ff68
updating some field_props for numerical aquifer cells
...
in the implementation, numerical aquifer cells are some specific grid
cells. At the same time, aquifer keywords can specify these cells with
very different properties, like depth, porosoity, pore volume, SATNUM,
PVTNUM, and so on.
2021-02-05 14:40:38 +01:00
Kai Bao
7628d7e13b
isolating the aquifer cells from the rest of the reservoir
...
by setting the transmissiblity associated with aquifer cells to be zero.
2021-02-05 14:40:38 +01:00
Joakim Hove
e571aca93b
Apply WELPI is based on newWellPI and not scaling factor
2021-02-05 13:02:47 +01:00
Joakim Hove
c9908df914
Merge pull request #2275 from joakim-hove/apply-action-simtime
...
Pass simulation time argument to Schedule::applyAction()
2021-02-05 12:06:44 +01:00
Joakim Hove
39c560e5cc
Pass simulation time argument to Schedule::applyAction()
2021-02-05 09:53:27 +01:00
Joakim Hove
eb736fa9cd
Merge pull request #2273 from joakim-hove/sched-unique
...
Sched unique
2021-02-04 13:52:55 +01:00
Joakim Hove
7a45b23736
Merge pull request #2272 from joakim-hove/remove-udq-constructor
...
Remove UDQParams( Deck ) constructor
2021-02-04 11:12:55 +01:00
Joakim Hove
08cb85e08e
Add temporary disabled Schedule::unique<UDQConfig>() test
2021-02-04 11:11:40 +01:00
Joakim Hove
3bc82e7a96
Add Schedule::unique<T>()
2021-02-04 11:11:40 +01:00
Joakim Hove
1ca611e698
Add const overload to ScheduleState::get<T>()
2021-02-04 11:11:39 +01:00
Joakim Hove
6592e83ed8
Remove UDQParams( Deck ) constructor
2021-02-04 09:22:40 +01:00
Joakim Hove
bf82cde25d
Merge pull request #2270 from joakim-hove/jr-janitor
...
Remove unused arguments
2021-02-03 15:04:16 +01:00
Markus Blatt
1fb9793fa9
Merge pull request #2271 from joakim-hove/sched-block-mutable
...
Make return value from ScheduleDeck::operator[] mutable
2021-02-03 14:05:29 +01:00
Joakim Hove
71aac491c9
Add mutable ScheduleDeck::operator[] overload
2021-02-03 12:07:56 +01:00
Joakim Hove
3936af4f9e
Remove report_step argument from Well::handleWELOPENConnections()
2021-02-03 11:50:25 +01:00
Joakim Hove
d1178bdd38
Remocve report_step argument from Well::handleWPIMULT()
2021-02-03 11:47:39 +01:00
Joakim Hove
29274ed315
Remove report_step argument from Well::handleCOMPLUMP()
2021-02-03 11:46:48 +01:00
Joakim Hove
fa85bc6445
Remove report_step argument from Well::handleCOMPSEGS()
2021-02-03 11:45:18 +01:00
Joakim Hove
5580165fee
Remove report_step argument in Well::updateConnections()
2021-02-03 11:40:38 +01:00
Joakim Hove
4aa0d5ac56
Remove unused method Well::updateConnectionStatus()
2021-02-03 11:31:52 +01:00
Joakim Hove
e7f72ddb8a
Remove unsused argument report_step in Well::updateConnections()
2021-02-03 11:27:10 +01:00
Joakim Hove
a47cdc1b6b
Require Well::updateConnections() force argument
2021-02-03 11:20:09 +01:00
Joakim Hove
509c8a71a0
Remove runtime argument from Schedule::updateWellStatus()
2021-02-03 11:09:17 +01:00
Joakim Hove
8099c868c2
Merge pull request #2268 from joakim-hove/well-status-scalar
...
Well status scalar
2021-02-02 23:03:48 +01:00
Joakim Hove
f308817d5c
Use scalar well Status
2021-02-02 18:06:03 +01:00
Joakim Hove
78521f6f4a
Removed function Well::commitStatus()
2021-02-02 17:36:44 +01:00
Joakim Hove
44388315ae
Removed first_step from WellStatus
2021-02-02 17:27:21 +01:00
Joakim Hove
d25e8555b2
Remove last_step from WellStatus
2021-02-02 17:27:10 +01:00
Joakim Hove
4a7ddeefca
Merge pull request #2265 from totto82/fixMaxGasLiq
...
fix max_gas_liquid_ratio
2021-02-02 10:02:20 +01:00
Bård Skaflestad
763fb0d368
Merge pull request #2266 from bska/recognize-bsoil
...
Recognize BSOIL as a Block Summary Keyword
2021-02-02 09:56:17 +01:00
Bård Skaflestad
14351087ab
Recognise BSOIL as a Block Summary Keyword
2021-02-02 09:22:13 +01:00
Tor Harald Sandve
1ff349150b
fix max_gas_liquid_ratio
2021-02-02 09:18:42 +01:00
Joakim Hove
ea8e391de5
Merge pull request #2261 from joakim-hove/group-sched-state
...
Group sched state
2021-02-02 09:14:04 +01:00
Joakim Hove
e016d357d8
Use ScheduleState to manage groups
2021-02-02 07:25:16 +01:00
Bård Skaflestad
98efacf14f
Merge pull request #2263 from totto82/fixUnitThconr
...
Fix unit THCONR
2021-02-01 18:23:09 +01:00
Joakim Hove
bd22745ec0
Merge pull request #2256 from joakim-hove/vfp-pointer-update
...
Pack only unique VFP tables
2021-02-01 17:06:30 +01:00
Joakim Hove
4015e240b9
Merge pull request #2260 from akva2/fix_clang_template_args
...
fixed: add some type aliases and explicit template parameters
2021-02-01 15:04:57 +01:00
Joakim Hove
5f21fe291f
ScheduleState::get<T> will give compile error for invalid T
2021-02-01 14:50:14 +01:00
Joakim Hove
1893daec8b
Will refuse pointer update with empty pointer
2021-02-01 14:50:14 +01:00
Joakim Hove
1032e16947
Use order independent map==
2021-02-01 14:50:14 +01:00
Joakim Hove
5c72211325
Pack pointers for VFP maps
2021-02-01 14:50:14 +01:00
Joakim Hove
be28004793
Merge pull request #2255 from berland/jsonfixes_ecl_test_suite
...
Fix bugs in keyword definitions
2021-02-01 14:18:26 +01:00
Tor Harald Sandve
39e6b953d8
Fix unit THCONR
2021-02-01 12:48:56 +01:00
Håvard Berland
2de6ab7bc4
Remove size from AQUFET and AQUFETP
2021-02-01 12:17:52 +01:00
Arne Morten Kvarving
2bb214cbfd
fixed: add some type aliases and explicit template parameters
...
clang does not consider default template parameters
when resolving template arguments.
2021-02-01 09:09:01 +01:00
Joakim Hove
47a7f15efc
Merge pull request #2253 from joakim-hove/use-normal-map-groups
...
Use normal map groups
2021-01-30 20:04:13 +01:00
Joakim Hove
38485d9a96
Merge pull request #2259 from joakim-hove/remove-update-ptr
...
Remove ScheduleState::update_ptr method
2021-01-30 20:00:51 +01:00
Joakim Hove
448a548c8a
Remove ScheduleState::update_ptr method
2021-01-30 14:51:36 +01:00
Joakim Hove
982f2a9bed
Use std::unordered_map<> for groups
2021-01-30 14:23:09 +01:00
Joakim Hove
d2398bdf3d
Merge pull request #2258 from joakim-hove/use-well-order
...
Use WellOrder class for wellnames
2021-01-30 10:23:51 +01:00
Joakim Hove
a4c89c0466
Use GroupOrder in Schedule
2021-01-30 10:20:03 +01:00
Joakim Hove
efa08f123f
Implement GroupOrder as standalone class and to ScheduleState
2021-01-30 10:19:49 +01:00
Joakim Hove
9728e5d69b
Use WellOrder class for wellnames
2021-01-30 08:40:51 +01:00
Joakim Hove
e5017ebd69
Merge pull request #2257 from joakim-hove/add-missing-well-order==
...
Add missing WellOrder== in ScheduleState==
2021-01-29 23:08:32 +01:00
Joakim Hove
3a8dfc53d6
Add missing WellOrder== in ScheduleState==
2021-01-29 21:48:01 +01:00
Håvard Berland
131b2ec046
Fix bugs in keyword definitions
...
Uncovered by trying to parse the test suite supplied with Eclipse.
Some missing, some typos, some inconsistencies.
2021-01-29 16:06:20 +01:00
Bård Skaflestad
c17e400e43
Merge pull request #2254 from akva2/janitoring
...
remove unused variable
2021-01-29 15:43:33 +01:00
Arne Morten Kvarving
30d6dd2a94
remove unused variable
2021-01-29 15:03:54 +01:00
Joakim Hove
2cf3feb8d0
Merge pull request #2248 from joakim-hove/update-ptr
...
Use small wrapper to manage shared pointers in ScheduleState
2021-01-29 12:54:37 +01:00
Joakim Hove
acb1284efd
Use small wrapper to manage shared pointers in ScheduleState
2021-01-29 11:42:36 +01:00
Joakim Hove
39720fa3a4
Merge pull request #2251 from joakim-hove/rename-wellorder
...
Rename wellorder
2021-01-29 06:59:05 +01:00
Joakim Hove
86c6028fc9
Merge pull request #2250 from joakim-hove/python-test-fixup
...
Fix bug in python/setup-test.sh.in
2021-01-28 20:42:05 +01:00
Joakim Hove
8da208c0c0
Add derived class GroupNames
2021-01-28 20:04:29 +01:00
Joakim Hove
a4ca61dc4e
Renamed WellOrder -> NameOrder
2021-01-28 19:49:05 +01:00
Joakim Hove
39c72cf45a
Merge pull request #2213 from joakim-hove/use-ordinary-map
...
Use ordinary map for wells
2021-01-28 19:47:51 +01:00
Joakim Hove
7e8bb3846a
Fix bug in python/setup-test.sh.in
2021-01-28 17:20:19 +01:00
Joakim Hove
b1d2e96dea
Use ordinary map for wells
2021-01-28 17:08:43 +01:00
Joakim Hove
3ba858e5a9
Merge pull request #2246 from GitPaean/new_numerical_aquifer
...
numerical aquifers
2021-01-28 11:14:02 +01:00
Joakim Hove
8c80620851
Merge pull request #2249 from joakim-hove/windows-slashes
...
Replace windows path separators in GDFILE keyword
2021-01-28 10:58:05 +01:00
Kai Bao
abbb56c173
addressing review comments for OPM/opm-common#2246
2021-01-27 22:50:50 +01:00
Kai Bao
af882dc483
wip in adding serialize code
2021-01-27 22:49:03 +01:00
Kai Bao
35bc7293f1
adding a test for numerical aquifer
2021-01-27 22:49:03 +01:00
Kai Bao
9f5463afbc
removing the usage of class NumericalAquiferConnections
...
it is just of limited usage and potentially create more confusion.
2021-01-27 22:49:03 +01:00
Kai Bao
e8dc3c19fb
adding numerical aquifer to AquiferConfig
2021-01-27 22:49:03 +01:00
Kai Bao
77b2b107f4
creating class NumericalAquifers
2021-01-27 22:49:03 +01:00
Kai Bao
067b3e11e5
adding NumericalAquiferConnections
2021-01-27 22:49:03 +01:00
Kai Bao
836b5aefd5
adding NumericalAquiferCell
...
it is the cells that makes the numerical aquifer itself.
2021-01-27 22:49:03 +01:00
Joakim Hove
d15a3a918c
Replace windows path separators in GDFILE keyword
2021-01-27 16:15:28 +01:00
Joakim Hove
0882e0361a
Merge pull request #2242 from joakim-hove/vfp-name
...
Vfp name
2021-01-26 16:12:52 +01:00
Joakim Hove
d30b571edd
Merge pull request #2223 from joakim-hove/pack-state
...
Add serialize support for unique elements in ScheduleState
2021-01-26 16:12:23 +01:00
Joakim Hove
c4e6bf0dd8
Add optional methods to get VFP tables
2021-01-26 13:34:16 +01:00
Joakim Hove
a8f3ef088e
Add name() method to VFP tables - for serialization
2021-01-26 13:32:30 +01:00
Joakim Hove
816f87a1d4
Refactor serialization of std::shared_ptr<> members in ScheduleState
2021-01-26 13:26:20 +01:00
Joakim Hove
f70ea18a1a
Merge pull request #2245 from joakim-hove/rename-schedulestate-updates
...
Rename schedulestate updates
2021-01-26 12:58:27 +01:00
Joakim Hove
45d6e362b9
Rename ScheduleState modifiers
2021-01-26 11:21:55 +01:00
Joakim Hove
6e5ec70d6d
Add WellTestConfig::WTESTWell constructor
2021-01-26 11:21:55 +01:00
Joakim Hove
ebb4b22c5a
Merge pull request #2240 from joakim-hove/vfp-reference-wrapper
...
Export VFP tables as reference wrappers instead of pointers
2021-01-26 11:07:33 +01:00
Joakim Hove
3f204ae6df
Merge pull request #2244 from totto82/addConnectionRadiusAndLength
...
Adding connection length and effective radius to the connection
2021-01-26 07:03:49 +01:00
Tor Harald Sandve
434b791442
Adding connection length and effective radius to the connection
2021-01-25 14:10:06 +01:00
Joakim Hove
f6e66a4398
Export VFP tables as reference wrappers instead of pointers
2021-01-25 12:21:56 +01:00
Joakim Hove
471eef05b2
Merge pull request #2227 from joakim-hove/wellname-sort
...
Wells from wellmatcher are sorted by insert order
2021-01-25 12:13:33 +01:00
Joakim Hove
56c7e89bbd
Use WellOrder to construct WellMatcher
2021-01-25 10:20:57 +01:00
Joakim Hove
264a0f4178
Add Wellorder member to ScheduleState and serialize()
2021-01-25 10:20:57 +01:00
Joakim Hove
9f2cb7ec39
Merge pull request #2238 from joakim-hove/wellorder
...
Wellorder
2021-01-25 09:11:23 +01:00
Joakim Hove
95031c7ed8
Merge pull request #2239 from joakim-hove/eclipsestate-error-msg
...
Eclipsestate error msg
2021-01-25 09:10:53 +01:00
Joakim Hove
57ab9d0d95
Make error message stand out more with newlines
2021-01-25 07:21:09 +01:00
Joakim Hove
e06bbf5731
Remove extra ',' in output format - recovers internal message
2021-01-25 07:20:11 +01:00
Joakim Hove
15bd99b44c
Add class WellOrder to keep track of well insert order
2021-01-25 06:50:08 +01:00
Joakim Hove
6b723ea782
Merge pull request #2235 from joakim-hove/alqr
...
Add load for loading summary keywords AL.+
2021-01-24 08:51:13 +01:00
Joakim Hove
87b8b145b0
Add basic parsing support for ALxx summary keywords
2021-01-24 07:18:17 +01:00
Joakim Hove
10421f7430
Merge pull request #2236 from joakim-hove/ehystr
...
Add missing item to EHYSTR keyword
2021-01-23 21:38:32 +01:00
Joakim Hove
24461aa5d0
Merge pull request #2234 from joakim-hove/MSUM_PROBE
...
Add summary keywords of the form MSUMxxx
2021-01-23 21:38:21 +01:00
Joakim Hove
2c0d194f85
Add missing item to EHYSTR keyword
2021-01-23 19:31:28 +01:00
Joakim Hove
03b2066427
Merge pull request #2228 from totto82/CO2STORE
...
add CO2STORE as alias for CO2STOR
2021-01-23 19:08:25 +01:00
Joakim Hove
6566e46457
Add summary keywords of the form MSUMxxx
2021-01-23 18:26:21 +01:00
Tor Harald Sandve
195749d7bf
add CO2STORE as alias for CO2STOR
2021-01-22 14:31:00 +01:00
Joakim Hove
21ce685473
Merge pull request #2224 from totto82/addDiffusion
...
Add support for DIFFC and DIFFUSE
2021-01-21 18:31:19 +01:00
Tor Harald Sandve
c8343d95f6
add support for DIFFC and DIFFUSE
2021-01-21 11:21:05 +01:00
Joakim Hove
30ec56fffe
Merge pull request #2225 from bska/dont-copy-wells
...
Revert to Looping Well Names
2021-01-21 09:01:50 +01:00
Bård Skaflestad
5c1c7881fc
Loop Well Names When Creating xWEL Arrays
...
The well maintains its own insertion index so we don't need to infer
that value from the well object ordering implied by member function
Schedule::getWells()
2021-01-20 16:56:29 +01:00
Bård Skaflestad
7318bc080f
Revert to Looping Well Names
...
The wells maintain their own insertion index, so we do not need to
infer the index from the well name order.
2021-01-20 16:56:29 +01:00
Joakim Hove
af66a6b5f5
Merge pull request #2226 from tskille/tcpu_unit
...
Adding unit SECONDS for summary vector TCPU
2021-01-20 16:35:13 +01:00
Torbjørn Skille
768cbb2c56
Adding unit SECONDS for summary vector TCPU
2021-01-20 15:02:30 +01:00
Joakim Hove
60aeb91a5e
Merge pull request #2221 from joakim-hove/schedule-grid-pointers
...
Use pointers to grid and fieldprops in Schedule construction
2021-01-20 13:20:48 +01:00
Arne Morten Kvarving
09d658cb41
Merge pull request #2216 from dr-robertk/PR/fix-openmp-linking-issue
...
Linking issue when OpenMP is disabled.
2021-01-20 09:06:40 +01:00
Atgeirr Flø Rasmussen
503e527272
Merge pull request #2222 from OPM/revert-2215-use-ordinary-map-groups
...
Revert "Use std::map for groups"
2021-01-19 14:39:06 +01:00
Joakim Hove
ecce98a307
Revert "Use std::map for groups"
2021-01-19 12:40:01 +01:00
Joakim Hove
11b568e8e5
Merge pull request #2215 from joakim-hove/use-ordinary-map-groups
...
Use std::map for groups
2021-01-19 12:35:59 +01:00
Joakim Hove
a01b81d9ec
Use pointers to grid and fieldprops in Schedule construction
2021-01-19 10:27:37 +01:00
Joakim Hove
a24bc9427e
Merge pull request #2220 from joakim-hove/sched-state-python
...
Add very basic Python wrapping for ScheduleState
2021-01-19 10:15:34 +01:00
Joakim Hove
5a8cb5f562
Add very basic Python wrapping for ScheduleState
2021-01-19 09:51:22 +01:00
Joakim Hove
4b89487ef2
Merge pull request #2217 from joakim-hove/add-group-to-group
...
Use names in api for group-group update
2021-01-18 14:39:13 +01:00
Joakim Hove
499f1ce72f
Merge pull request #2219 from joakim-hove/group-remove-define-step
...
Remove member to track create time from Group
2021-01-18 14:38:56 +01:00
Joakim Hove
888a646716
Remove member to track create time from Group
2021-01-18 12:19:54 +01:00
Joakim Hove
a618f39f9b
Use names in api for group-group update
2021-01-18 11:39:07 +01:00
dr-robertk
3c66dcdd4b
[bugfix][OpenMP] #ifdef _OPENMP should be used, otherwise linking errors
...
occur.
2021-01-18 10:34:15 +01:00
Joakim Hove
55cec7dd4d
Use std::map for groups
2021-01-18 09:13:35 +01:00
Joakim Hove
462ab5f44a
Merge pull request #2214 from joakim-hove/use-ordinary-map-commits
...
Use ordinary map commits
2021-01-15 14:31:07 +01:00
Joakim Hove
d3a1f6521f
Change test to check for existence
2021-01-15 12:29:01 +01:00
Joakim Hove
8cd442e5b2
Use full well objects instead of well names
2021-01-15 12:25:27 +01:00
Joakim Hove
bee758bc37
Whitespace
2021-01-15 12:24:12 +01:00
Joakim Hove
7fc9d2bb73
Merge pull request #2212 from joakim-hove/sched-udq-active
...
Sched udq active
2021-01-15 10:24:27 +01:00
Joakim Hove
344972624a
Use ScheduleState to manage UDQActive
2021-01-15 09:19:33 +01:00
Joakim Hove
bc3c3490bb
Merge pull request #2211 from joakim-hove/sched-action
...
Sched action
2021-01-15 09:18:32 +01:00
Joakim Hove
c22b47f994
Use ScheduleState to manage Actionx
2021-01-15 07:51:51 +01:00
Joakim Hove
ccb0ecbea3
Merge pull request #2210 from joakim-hove/sched-vfp
...
Sched vfp
2021-01-15 07:39:34 +01:00
Joakim Hove
d7345edc95
Use ScheduleState to manage VFP tables
2021-01-14 21:28:19 +01:00
Joakim Hove
32dec137a7
Merge pull request #2207 from joakim-hove/sched-rptconfig
...
Sched rptconfig
2021-01-14 11:52:19 +01:00
Joakim Hove
65aab177df
Manage RTPSCHED config in ScheduleState
2021-01-14 10:40:30 +01:00
Joakim Hove
b2bc40206a
Merge pull request #2206 from joakim-hove/sched-static
...
Assemble static schedule information in ScheduleStatic
2021-01-13 13:19:22 +01:00
Joakim Hove
6453844fd6
Merge pull request #2209 from GitPaean/creating_aquifer_helpers
...
creating AquiferHelpers
2021-01-13 13:14:48 +01:00
Kai Bao
13c38b7eb9
creating AquiferHelpers
...
to make function neighborCellInsideReservoirAndActive more reusable.
2021-01-13 11:51:14 +01:00
Joakim Hove
2a95573570
Assemble static schedule information in ScheduleStatic
2021-01-13 11:49:29 +01:00
Joakim Hove
de0615e251
Merge pull request #2205 from joakim-hove/sched-network
...
Manage Network configuration with ScheduleState
2021-01-13 08:04:19 +01:00
Joakim Hove
bd596f06b4
Manage Network configuration with ScheduleState
2021-01-12 21:42:23 +01:00
Joakim Hove
5ab1ae67ec
Merge pull request #2203 from joakim-hove/sched-wlist
...
Sched wlist
2021-01-12 21:14:29 +01:00
Joakim Hove
ad03c1f479
Merge pull request #2188 from jalvestad/actx-paren
...
Changes to Actionx - related data (IACN) due to use of parentheses in the action conditions
2021-01-12 21:13:51 +01:00
Joakim Hove
b6e78fe486
Manage well list with ScheduleState
2021-01-12 20:18:22 +01:00
Joakim Hove
c2e1aeb568
Merge pull request #2202 from joakim-hove/sched-gcon
...
Manage GConSale and GConSump with ScheduleState object
2021-01-12 20:17:44 +01:00
Joakim Hove
ddba87cf99
Manage GConSale and GConSump with ScheduleState object
2021-01-12 18:29:27 +01:00
Joakim Hove
9b150db251
Merge pull request #2201 from joakim-hove/sched-wtest-config
...
Handle well test configuration with ScheduleState
2021-01-12 17:50:27 +01:00
Jostein Alvestad
7056ce3970
removed comment line
2021-01-12 14:31:41 +01:00
Jostein Alvestad
8e4557646d
changes based on reviewer comments to improve/clean code
2021-01-12 14:30:25 +01:00
Joakim Hove
c20417d69b
Handle well test configuration with ScheduleState
2021-01-12 14:02:15 +01:00
Joakim Hove
a2810bdf2e
Merge pull request #2200 from joakim-hove/clamp-chrono
...
Make sure ScheduleState time_points are clamped to std::time_t
2021-01-12 13:58:58 +01:00
Joakim Hove
aebbc56b07
Make sure ScheduleState time_points are clamped to std::time_t
2021-01-12 13:06:04 +01:00
Joakim Hove
c5b226a8c8
Merge pull request #2199 from joakim-hove/sched-global-whistctl-mode
...
Sched global whistctl mode
2021-01-12 12:25:00 +01:00
Jostein Alvestad
4825f291e7
Added unit tests for Actionx data with parentheses
2021-01-12 09:32:10 +01:00
Jostein Alvestad
025ee7b634
changes to Actionx unit test data
2021-01-12 09:32:09 +01:00
Jostein Alvestad
0efb585b4c
some corrections to treatment of parentheses
2021-01-12 09:32:07 +01:00
Jostein Alvestad
3d072baf9e
initial changes for handling parentheses in ACTIONX conditions
2021-01-12 09:32:05 +01:00
Joakim Hove
473f937b8c
Mange global well history control mode in ScheduleState
2021-01-12 09:02:35 +01:00
Joakim Hove
2aeee665d1
Merge pull request #2198 from joakim-hove/sched-message-limits
...
Sched message limits
2021-01-12 09:00:41 +01:00
Joakim Hove
85c8a9b4e7
Use SchduleState to manage MessageLimits
2021-01-11 23:03:46 +01:00
Joakim Hove
30f947b998
Merge pull request #2194 from joakim-hove/sched-events
...
Sched events
2021-01-11 20:24:15 +01:00
Joakim Hove
e445bf738c
Manage events with the ScheduleState machinery
2021-01-11 20:05:46 +01:00
Joakim Hove
e185ddf96b
Merge pull request #2196 from joakim-hove/schedule-debug
...
Schedule debug
2021-01-11 12:11:40 +01:00
Joakim Hove
a8a033314e
Enable Schedule integration-test/debug in jenkins build
2021-01-11 10:03:00 +01:00
Joakim Hove
c8ba2b30b3
Add runtime Schedule integration test - guarded by #ifdef
2021-01-11 09:56:47 +01:00
Joakim Hove
046f5800e4
Merge pull request #2195 from GitPaean/moving_aquifer_folders
...
Moving aquifer folders
2021-01-09 10:34:54 +01:00
Kai Bao
ae8ac08a03
removing x from Aquifer files using chmod
2021-01-08 23:39:38 +01:00
Kai Bao
b9ae495bce
moving Aquifer related to Aquifer folder
2021-01-08 23:17:36 +01:00
Joakim Hove
b802e23f74
Merge pull request #2193 from joakim-hove/sched-rerun
...
Sched rerun
2021-01-08 15:15:38 +01:00
Joakim Hove
b8ef8767e5
Remove grid and fp members from default HandlerContext construction
2021-01-08 14:52:26 +01:00
Joakim Hove
77312b1432
Enable rerun of iteration over Schedule keywords
2021-01-08 10:03:20 +01:00
Joakim Hove
248e6a3c8c
Merge pull request #2191 from joakim-hove/schedule-oilvap
...
Schedule oilvap
2021-01-08 09:21:29 +01:00
Joakim Hove
5f78173afb
Use ScheduleState for oil vaporization properties
2021-01-08 07:39:23 +01:00
Joakim Hove
c49463fe6f
Add class ScheduleTStep
2021-01-07 15:49:46 +01:00
Joakim Hove
f460c67ade
Merge pull request #2189 from joakim-hove/schedule-nupcol
...
Schedule nupcol
2021-01-07 15:48:41 +01:00
Joakim Hove
aedeca0907
Merge pull request #2192 from joakim-hove/cond-open-paren
...
Add Condition::open_paren() and Condition::close_paren()
2021-01-07 13:19:49 +01:00
Joakim Hove
f424aba75d
Internalize nupcol in ScheduleState
2021-01-07 11:57:52 +01:00
Joakim Hove
b652fe794f
Add Condition::open_paren() and Condition::close_paren()
2021-01-07 10:52:02 +01:00
Joakim Hove
f18bbb6c8e
Schedule::create_first() to create and init first ScheduleState
2021-01-07 08:22:08 +01:00
Joakim Hove
167ada2020
Merge pull request #2190 from joakim-hove/schedule-tuning
...
Schedule tuning
2021-01-07 07:49:23 +01:00
Joakim Hove
628293c26a
Manage Tuning object through ScheduleState
2021-01-06 23:13:43 +01:00
Bård Skaflestad
dca842a5c7
Merge pull request #2178 from joakim-hove/add-sched-tstep
...
Add sched tstep
2021-01-06 20:56:06 +01:00
Joakim Hove
aaacdd6c57
Add class ScheduleTStep
2021-01-06 19:08:00 +01:00
Bård Skaflestad
22ac814056
Merge pull request #2183 from joakim-hove/sched-deck
...
Sched deck
2021-01-05 21:46:16 +01:00
Bård Skaflestad
d20b4e0145
Merge pull request #2187 from berland/json_segment1
...
Use consistent names in WSEG* keywords
2021-01-05 21:04:48 +01:00
Joakim Hove
8cd9065b61
Add class ScheduleDeck
2021-01-05 19:36:00 +01:00
Håvard Berland
c07bf30bcf
Use consistent names in WSEG* keywords
...
WSEGAICD and WSEGSICD used SEG1 and SEG2, while all
other WSEG* keywords use SEGMENT1 and SEGMENT2 for the same
item.
2021-01-05 15:00:50 +01:00
Joakim Hove
3fb60785b5
Merge pull request #2186 from joakim-hove/wbp-improvements
...
Wbp improvements
2021-01-05 13:51:34 +01:00
Joakim Hove
1695d75d7a
Better error message if PAvgCalculatorCollection is missing well
2021-01-05 11:36:52 +01:00
Joakim Hove
ff8035fd0e
Merge pull request #2185 from joakim-hove/use-make-shared
...
Use std::make_shared<> instead of new
2021-01-05 09:20:21 +01:00
Joakim Hove
985ea968d8
Use std::make_shared<> instead of new
2021-01-05 08:37:56 +01:00
Joakim Hove
e15a4a5259
Updated WBP calculator to account for PORV
2021-01-05 08:32:38 +01:00
Joakim Hove
c08b62ac9a
Make general WBP calculator public
2021-01-05 07:35:45 +01:00
Joakim Hove
b73a9321aa
Merge pull request #2184 from joakim-hove/timemap-allow-rst
...
Timemap allow rst
2021-01-04 22:13:24 +01:00
Joakim Hove
f1305155e7
Merge pull request #2182 from joakim-hove/wpb-ref-depth
...
Add reference depth member to PAvg and PAvgCalculator
2021-01-04 22:12:19 +01:00
Joakim Hove
df833aaed3
Internalize WPAVEDEP keyword with reference depth for WBP
2021-01-04 18:39:45 +01:00
Joakim Hove
7a4bdd4ab5
Update report number in comment
2021-01-04 11:28:16 +01:00
Joakim Hove
8bc16ab7fe
Rewrite TimeMap::operator[]
...
- Access to the historical period for a restarted run will not be caught.
- Access to underlying timepoint will be based on at()
2021-01-04 11:28:08 +01:00
Joakim Hove
cbd8c85a6e
Merge pull request #2180 from joakim-hove/use-start-time
...
Use start_time instead of invalid time as dummy for restart
2021-01-01 23:20:43 +01:00
Joakim Hove
314587b608
Use start_time instead of invalid time as dummy for restart
2021-01-01 21:43:44 +01:00
Joakim Hove
777f4f9859
Merge pull request #2179 from joakim-hove/multiline-strings
...
Multiline strings
2021-01-01 21:40:51 +01:00
Joakim Hove
cc772aa1df
Use raw string deck input strings
2021-01-01 21:22:12 +01:00
Bård Skaflestad
764065ccf9
Merge pull request #2167 from totto82/addEvents
...
add WELTARG and WEFAC to events
2020-12-21 21:30:54 +01:00
Joakim Hove
5c722e5267
Merge pull request #2177 from bska/no-sfunc-1p
...
Don't Require Saturation Functions for One-Phase Runs
2020-12-21 13:35:10 +01:00
Bård Skaflestad
dde58f8e38
Don't Require Saturation Functions for One-Phase Runs
...
Users should not have to supply synthetic relative permeability or
capillary pressure functions in a single-phase run.
2020-12-21 11:03:08 +01:00
Joakim Hove
824625f121
Merge pull request #2173 from bska/promote-sfunc-family
...
Make Saturation Function Family Available in Runspec
2020-12-18 07:39:49 +01:00
Bård Skaflestad
5816d2dbd2
Push Compatibility Check To Parser Level
...
Leverage the 'prohibits'/'requires' support to enforce earlier
keyword compatibility checks. This plays better with parallel runs.
2020-12-17 21:33:11 +01:00
Bård Skaflestad
1ca668b67c
Make Saturation Function Family Available in Runspec
...
This information is generally useful so we should have a single
source of truth and not have to reimplement the logic every time
we need it.
2020-12-17 21:33:11 +01:00
Bård Skaflestad
f5a61c3382
Merge pull request #2160 from jalvestad/iudq1-rev
...
Revision of AggregateUDQData plus some improvements to SWEL and XCON
2020-12-17 21:31:36 +01:00
Joakim Hove
628ad29da1
Merge pull request #2175 from joakim-hove/remove-porv-warning
...
Remove check and warning for use of porv based WBP calculation
2020-12-17 16:43:26 +01:00
Joakim Hove
93913d64a3
Merge pull request #2119 from jalvestad/glopt
...
Enable eclipse compatible restart for wells with gas lift optimization
2020-12-17 15:56:48 +01:00
Joakim Hove
5484053cd5
Remove check and warning for use of porv based WBP calculation
2020-12-17 15:49:08 +01:00
Bård Skaflestad
2c5403409e
Merge pull request #2172 from bska/relax-eps-requirements
...
Relax EPS Activation Criterion
2020-12-17 10:19:52 +01:00
Bård Skaflestad
ad8209d882
Relax EPS Activation Criterion
...
Existence of certain EPS keywords (SWL, SGCR, others) is sufficient
to activate the end-point scaling option. The deck does not *need*
to have the ENDSCALE keyword in these cases, but it is recommended
that ENDSCALE nevertheless be used.
On the other hand, certain other keywords do require the presence of
ENDSCALE so record this in "requires" clauses.
2020-12-16 17:47:00 +01:00
Joakim Hove
32d9dab412
Merge pull request #2170 from akva2/aquifer_serialize
...
Add serialization for aquifers
2020-12-16 12:38:43 +01:00
Joakim Hove
1e30916130
Merge pull request #2171 from akva2/fix_autoicd_serialize
...
Fix AutoICD serialization
2020-12-16 12:37:53 +01:00
Arne Morten Kvarving
6971705c30
fix indentation
2020-12-16 08:34:43 +01:00
Arne Morten Kvarving
8175a8a18f
implement AutoICD::serializeObject
2020-12-16 08:34:43 +01:00
Arne Morten Kvarving
fc46b310d6
fix AutoICD::serializeOp
2020-12-16 08:34:43 +01:00
Tor Harald Sandve
648030f1d0
add a well efficiency event
2020-12-15 13:34:34 +01:00
Arne Morten Kvarving
40ec45ebf2
add output serialization functions for aquifer
2020-12-15 11:49:48 +01:00
Jostein Alvestad
229950a591
added unit tests for the lift gas optimisation data
2020-12-15 10:53:29 +01:00
Jostein Alvestad
8c174d7f00
initial changes to make unit tests
2020-12-15 10:53:27 +01:00
Jostein Alvestad
df7e8220db
added file for unit-test - not ready yet
2020-12-15 10:53:25 +01:00
Jostein Alvestad
7d784f53ff
added code to write lift gas optimisation data to restart file
2020-12-15 10:53:16 +01:00
Arne Morten Kvarving
11ade04fd6
fixed: initialize members in Aquifer
2020-12-15 09:51:44 +01:00
Jostein Alvestad
e1e0857999
made UDQToken.hpp a public header file
2020-12-14 16:09:06 +01:00
Jostein Alvestad
c2a1218066
some minor improvements - warnings and comments
2020-12-14 15:26:25 +01:00
Jostein Alvestad
8da71d5620
improved code quality, used existing functions where possible
2020-12-14 13:56:02 +01:00
Jostein Alvestad
12598aee05
added more extensive unit tests for iudq[1]
...
Added one test case, cleaned code
Some minor cleaning / corrections
some changes to improve code quality
2020-12-14 13:55:55 +01:00
Jostein Alvestad
768f9958b6
first draft version of new code
2020-12-14 13:55:47 +01:00
Jostein Alvestad
4f1e65e29b
initial temporary changes to improve iudq[1]
...
initial changes to improve iudq[1] for DEFINE
further changes for IUDQ revision
further improvments iudq[1] - top parser tree
further improvments to IUDQ[1] - minus-sign++
first working version of revised UDQ-restart output
additional improvements SWEL, XCON
initial - unfinished changes of rewriting iudq[1]
some minor debug output changes
2020-12-14 13:55:37 +01:00
Joakim Hove
debfc70450
Merge pull request #2169 from joakim-hove/welpi-actionx2
...
Use event_step
2020-12-13 14:01:39 +01:00
Joakim Hove
545a5ecf7b
Use event_step
2020-12-13 09:02:10 +01:00
Bård Skaflestad
9ef5cc2309
Merge pull request #2164 from jalvestad/swel_xconn
...
Changes for SWEL for correct handling of lift gas plus improvements to XCONN
2020-12-11 22:52:18 +01:00
Joakim Hove
5474bc9a90
Merge pull request #2158 from joakim-hove/well-status
...
Manage well status with a shared pointer: To enable/improve runtime updates
2020-12-11 17:10:19 +01:00
Joakim Hove
bd2330df4f
Merge pull request #2166 from joakim-hove/actionx-restart-paren
...
Handle parenthesis in the Actionx::Condition class
2020-12-11 17:01:30 +01:00
Joakim Hove
469cf09d85
Handle parenthesis in the Actionx::Condition class
2020-12-11 14:53:29 +01:00
Tor Harald Sandve
44ebf2f241
add WELTARG and WEFAC to events
2020-12-11 11:35:41 +01:00
Joakim Hove
59f9813e14
Merge pull request #2163 from verveerpj/cylindrical_grid
...
Support cylindrical grids as a spiderweb with corrected volumes
2020-12-10 09:55:33 +01:00
Joakim Hove
a365a2575a
Merge pull request #2165 from joakim-hove/actionx-paren
...
Add test for boolean logic
2020-12-10 09:40:44 +01:00
Joakim Hove
c31ebda702
Add test for boolean logic
2020-12-09 17:34:18 +01:00
Peter Verveer
40940625fc
Bug fix in calculation of depth
2020-12-09 15:51:30 +01:00
Peter Verveer
81c7b53449
Support cylindrical grids as a spiderweb with corrected volumes
2020-12-09 15:51:01 +01:00
Joakim Hove
7541b5e503
Merge pull request #2161 from joakim-hove/update-range
...
Add function DynamicState::update_range()
2020-12-08 22:14:30 +01:00
Joakim Hove
934e031f22
Merge pull request #2162 from akva2/janitoring
...
Some bug fixes
2020-12-08 22:14:15 +01:00
Joakim Hove
cf244a293e
Add time range to WellStatus
2020-12-08 20:01:55 +01:00
Arne Morten Kvarving
c776ede067
fixed: error in comparison operator
2020-12-08 15:52:55 +01:00
Arne Morten Kvarving
4fd58bf2f3
fixed: use fabs, not abs()
...
latter is for ints
2020-12-08 15:52:55 +01:00
Arne Morten Kvarving
c205a11037
fixed: forward struct as struct
2020-12-08 15:52:55 +01:00
Jostein Alvestad
fe9ade9dab
changes to SWEL and XCONN for lift gas optimisation
2020-12-08 14:50:45 +01:00
Joakim Hove
2e832f0fbe
Changes to Well status implementation
...
o The status of a well is maintened as a small object which is managed by a new
std::shared_ptr member in the well objects. The consequence of this is that
several well objects can share the same underlying status object. The
advantage of this is that runtime (i.e. ACTIONX) updates of well status will
affect the correct set of wells.
o The general Schedule::updateWell() will use the DynamicState::upadte_equal()
2020-12-08 09:36:45 +01:00
Joakim Hove
85e2c641d3
Add function DynamicState::update_range()
2020-12-08 09:36:44 +01:00
Markus Blatt
1ef1646fb1
Merge pull request #2159 from joakim-hove/warning-unused
...
Fix warning with unused variable
2020-12-07 12:27:09 +01:00
Joakim Hove
1b76cd1fe6
Fix warning with unused variable
2020-12-06 10:04:49 +01:00
Joakim Hove
e261253683
Merge pull request #2157 from joakim-hove/wbp-porv
...
Add PORV argument when creating PAvgCalculator
2020-12-04 20:31:52 +01:00
Joakim Hove
968aa79468
Merge pull request #2151 from verveerpj/spiderweb
...
Allow use of both DZ and DZV when creating a spiderweb grid
2020-12-04 13:13:57 +01:00
Joakim Hove
135e8c793c
Merge pull request #2154 from joakim-hove/dynamicstate-update
...
Dynamicstate update
2020-12-04 13:13:44 +01:00
Bård Skaflestad
8ada1cc333
Merge pull request #2155 from joakim-hove/handle-welpi-report-step
...
Use argument reportStep + 1 when evaulating WELPI in ACTIONX
2020-12-04 12:54:35 +01:00
Joakim Hove
9809197b5d
Add PORV argument when creating PAvgCalculator
2020-12-04 10:58:27 +01:00
Peter Verveer
b85ab8813e
Allow use of both DZ and DZV when creating a spiderweb grid
2020-12-04 09:44:36 +01:00
Joakim Hove
dbc23dca65
Use argument reportStep + 1 for WELPI ACTIONX events
2020-12-04 09:28:14 +01:00
Joakim Hove
0102d736ac
Merge pull request #2141 from GitPaean/wsegaicd2
...
WSEGAICD
2020-12-04 08:52:16 +01:00
Joakim Hove
0752764ecc
Refactor of DynamicState::update_equal()
2020-12-04 08:10:54 +01:00
Bård Skaflestad
aaff4d1785
Merge pull request #2153 from bska/fix-wpi-shut
...
Summary Test Deck: Open Wells 1, 2, 3, and 6 at First Step
2020-12-04 00:30:20 +01:00
Bård Skaflestad
e1db7cd87e
Summary Test Deck: Open Wells 1, 2, 3, and 6 at First Step
...
This restores 'test_Summary' for WPI vectors.
2020-12-03 22:08:01 +01:00
Kai Bao
c965db78e4
addressing reviewing comments for OPM/opm-common#2141
2020-12-03 21:54:31 +01:00
Kai Bao
f78e0e9c96
adding more accessing functions for AICD class
2020-12-03 15:23:04 +01:00
Kai Bao
540b45b8c7
adding the parsing of WSEGAICD
2020-12-03 15:23:04 +01:00
Bård Skaflestad
971f9d9415
Merge pull request #2150 from joakim-hove/zero-PI-closed-wells
...
The summary calculator should return zero PI for non flowing wells
2020-12-03 15:09:35 +01:00
Joakim Hove
1a2e0ec01e
The summary calculator should return zero PI for non flowing wells
2020-12-03 11:05:10 +01:00
Joakim Hove
acb55a1bff
Merge pull request #2148 from joakim-hove/guard-copt
...
Check that we have the COPT key before accessing it
2020-12-03 09:45:08 +01:00
Joakim Hove
7615088a03
Merge pull request #2146 from joakim-hove/pavg-fixup
...
Pavg fixup
2020-12-03 09:44:56 +01:00
Bård Skaflestad
b573fc0223
Merge pull request #2149 from tskille/gridhead_fix
...
fix gridhead out-of-bounds indexing error in EGrid
2020-12-02 23:18:11 +01:00
Torbjørn Skille
26de5bb9b0
fix gridhead out-of-bounds indexing error in EGrid
2020-12-02 19:06:58 +01:00
Joakim Hove
4c48f9bcf9
Merge pull request #2144 from totto82/alq_default
...
Fix gaslift output
2020-12-02 15:56:35 +01:00
Joakim Hove
19e755e10d
Check that we have the COPT key before accessing it
2020-12-02 15:54:01 +01:00
Joakim Hove
1ca2a0b06b
Merge pull request #2147 from akva2/fix_deckitem_serialize
...
fixed: missing serialization for rsval in DeckItem
2020-12-02 14:06:20 +01:00
Arne Morten Kvarving
fa9dc54bbb
Merge pull request #2132 from tskille/eclio_lgr
...
Eclio lgr
2020-12-02 11:23:08 +01:00
Arne Morten Kvarving
0c11863bb5
fixed: missing serialization for rsval in DeckItem
...
this broke ActionX in parallel
2020-12-02 09:43:22 +01:00
Tor Harald Sandve
1f6dbae5cb
use privious table as default
2020-12-02 09:42:51 +01:00
Joakim Hove
f5cc5bc3f2
Merge pull request #2145 from joakim-hove/improve-error-message
...
Improve error message for connection in inactive cell
2020-12-02 08:29:55 +01:00
Joakim Hove
5b50805c0f
Merge pull request #2143 from joakim-hove/roew-copt
...
Summary keyword ROEW is based on COPT and not WOPT
2020-12-02 08:29:40 +01:00
Joakim Hove
9c6c07c294
Merge pull request #2139 from joakim-hove/actionx-required-summary-variables
...
ACTIONX: Determine required summary keywords
2020-12-02 08:27:33 +01:00
Joakim Hove
e9443b02a7
Merge pull request #2138 from joakim-hove/welpi-get-wells-from-actionx
...
Pass the wells captured from ACTIONX to Schedule::handleWELPI()
2020-12-02 08:27:17 +01:00
Torbjørn Skille
a8461fd121
Updating class ERst
...
- rename member function from getRst -> getRestartData
- adding support for parsing and reading data for LGRs
- a number of member functions made const
- updated python bindings for this class
2020-12-01 23:06:44 +01:00
Torbjørn Skille
a7314ab5a0
Updating class EGrid
...
- now supporting parsing/reading of lgrs
- detect if radial grid is used
- return xyz coordinates also for radial grids
- support for getting nnc data
2020-12-01 20:14:37 +01:00
Torbjørn Skille
e1334adbf6
Adding new class EInit
...
- for parsing and loading data from INIT file
- including functions to support parsing/logading LGR data
2020-12-01 20:14:37 +01:00
Joakim Hove
ab8c6b3d21
Delay exception in WBP calculation
2020-12-01 10:59:31 +01:00
Joakim Hove
de6a067906
Make sure well has been defined before creating PAvgCalculator
2020-12-01 10:32:38 +01:00
Joakim Hove
1ac1582f12
PAvgCalculatorCollection: accept presssure updates in invalid cell
2020-12-01 10:27:44 +01:00
Joakim Hove
38c01e91e1
Improve error message for connection in inactive cell
2020-12-01 08:17:16 +01:00
Joakim Hove
a242b3abfa
Merge pull request #2142 from joakim-hove/cache-parser-keyword
...
Cache parser keyword
2020-12-01 08:11:18 +01:00
Joakim Hove
e52e0914fb
Merge pull request #2118 from joakim-hove/wbp
...
Wbp
2020-11-30 13:17:18 +01:00
Tor Harald Sandve
491d1d1f15
only compute glir for producers
2020-11-30 11:09:06 +01:00
Joakim Hove
53cd73c2d7
PAvgCalculator to calculate WBP? pressures
2020-11-30 10:42:15 +01:00
Tor Harald Sandve
e0f4337a9d
Fix gaslift output
...
Use value from WCONPROD as default. The simulator does not set the alqvalue if gas optimization is not used
Multiply with efficiency factor when accumulation group rates
2020-11-30 10:11:26 +01:00
Joakim Hove
a6215ce107
Summary keyword ROEW is based on COPT and not WOPT
2020-11-29 13:46:26 +01:00
Joakim Hove
a42cd6433a
Hold on to the ParserKeyword instance
2020-11-29 12:59:05 +01:00
Joakim Hove
c045891c4c
Use fmtlib for output message
2020-11-29 12:58:10 +01:00
Joakim Hove
0dd522a105
Merge pull request #2140 from GitPaean/wsegaicd
...
correct the unit for STRENGTH for WSEGAICD
2020-11-28 07:30:16 +01:00
Kai Bao
5b867e135e
removing extra WSEGSICD in keyword_list
2020-11-27 22:53:57 +01:00
Kai Bao
6f4f489d0a
correct the unit for STRENGTH for WSEGAICD
2020-11-27 22:49:21 +01:00
Joakim Hove
e0a9bcc924
ACTIONX: Determine required summary keywords
2020-11-26 20:09:28 +01:00
Joakim Hove
678edf4497
Export static function to check month name validity
2020-11-26 20:09:28 +01:00
Joakim Hove
b6717fd685
Merge pull request #2133 from verveerpj/support_permr_and_permtht
...
Support PERMR and PERMTHT as aliases for PERMX and PERMY
2020-11-26 19:35:46 +01:00
Peter Verveer
479225f170
Add test to check PERMR/PERMTHT
2020-11-26 15:29:57 +01:00
Peter Verveer
3070696070
Support PERMR and PERMTHT aliases for PERMX and PERMY
2020-11-26 15:21:36 +01:00
Joakim Hove
e38252219f
Pass the wells captured from ACTIONX to Schedule::handleWELPI()
2020-11-26 14:51:38 +01:00
Joakim Hove
718faaf43b
Merge pull request #2135 from joakim-hove/inplace-at
...
Make sure original_inplace can be safely accessed
2020-11-26 14:31:26 +01:00
Joakim Hove
f395629dd5
Merge pull request #2131 from jalvestad/swel-cor
...
Correction of SWEL to handle zero rates in WCONHIST and WELOPEN SHUT
2020-11-26 14:07:32 +01:00
Arne Morten Kvarving
15ecabd6e1
Merge pull request #2136 from akva2/test-pypi
...
Some fixes to pypi packaging
2020-11-26 12:15:55 +01:00
Arne Morten Kvarving
edeef07018
remove unused file
2020-11-26 12:07:04 +01:00
Bård Skaflestad
e98872a543
Merge pull request #2137 from akva2/janitoring
...
add explicit defaults to quell warnings
Supersedes and closes #2134
2020-11-26 11:47:56 +01:00
Arne Morten Kvarving
e3a63c294b
add explicit defaults to quell warnings
2020-11-26 11:27:31 +01:00
Joakim Hove
491d816656
Make sure ROEW summary keywords are evaluated last
2020-11-26 10:54:24 +01:00
Joakim Hove
77ec5ffa5d
Make sure original_inplace can be safely accessed
2020-11-26 07:43:00 +01:00
Bård Skaflestad
a3df631aab
Merge pull request #2128 from bska/wpi-smry-output
...
Support Outputting Preferred Phase PI to Summary File
2020-11-26 01:30:36 +01:00
Bård Skaflestad
0422f38d23
WPI Summary Output: Address Review Comments
...
Add an explicit case for 'OIL' and throw an exception if the
"preferred" phase is not supported.
2020-11-25 22:17:52 +01:00
Arne Morten Kvarving
b7fdffa12d
disable building tests in pypi-packages
2020-11-25 12:20:02 +01:00
Arne Morten Kvarving
87698342d8
add export of build results from pypi docker
2020-11-25 11:57:10 +01:00
Arne Morten Kvarving
62bb1bc196
add python3.9 to pypi
2020-11-25 11:57:02 +01:00
Bård Skaflestad
a14c4184a9
Support Outputting Preferred Phase PI to Summary File
...
This commit adds support for outputting the productivity index of
a well's preferred phase at the well and connection levels to the
summary file (keywords 'WPI' and 'CPI').
Update unit tests accordingly.
2020-11-24 16:10:02 +01:00
Bård Skaflestad
a4e05aee47
Recognize Productivity Index Summary Config Node Type
2020-11-24 16:10:02 +01:00
Jostein Alvestad
fa1dbe2e28
rewriting of parts of SWEL code
2020-11-24 15:56:32 +01:00
Joakim Hove
08f8685bd1
Merge pull request #2127 from joakim-hove/summary-rhpv
...
Support summary keyword RHPV
2020-11-24 15:28:29 +01:00
Joakim Hove
9b0b03d6d3
Merge pull request #2126 from joakim-hove/udq-type-cast
...
Udq type cast
2020-11-24 14:28:25 +01:00
Joakim Hove
52df226da9
Merge pull request #2130 from bska/report-size-mismatch
...
Report Element Counts for Solution Vector Size Mismatch
2020-11-24 14:05:26 +01:00
Joakim Hove
ef5c51cee7
RHPV
2020-11-24 12:10:05 +01:00
Joakim Hove
b5012898d8
Merge pull request #2124 from joakim-hove/summary-roew
...
Summary roew
2020-11-24 11:49:11 +01:00
Joakim Hove
fa3b740d1d
UDQ Cast can cast to both lhs type and rhs type
2020-11-24 11:48:17 +01:00
Joakim Hove
74cedd95e2
Add accessor to get UDQ assign objects
2020-11-24 11:48:17 +01:00
Bård Skaflestad
1c726b85c9
Use LIBFMT to Log Restart File Output
...
The library knows how to format 'std::tm{}' objects using format
strings from 'std::strftime()' which means we get month names for
free.
Existing report format:
Restart file written for report step: 4/39. Date: 2018/12/15
New report format:
Restart file written for report step 4/39, date = 15-Dec-2018 00:00:00
2020-11-24 11:29:21 +01:00
Jostein Alvestad
b22334f08a
correction of an unintended change in test_AggregateWellData.cpp
2020-11-24 10:54:58 +01:00
Jostein Alvestad
f2e32fa436
Added unit tests for corrections
2020-11-24 10:49:47 +01:00
Jostein Alvestad
366c0a544b
corrections to SWEL for WCONHIST wells and shut wells
2020-11-23 15:53:45 +01:00
Bård Skaflestad
1fa5f3ce81
Report Element Counts for Solution Vector Size Mismatch
...
This makes it slightly easier to diagnose output errors.
2020-11-23 12:56:40 +01:00
Joakim Hove
12aa1f7c59
Start to implement ROEW
2020-11-23 11:02:02 +01:00
Joakim Hove
60920dd487
Ensure that WOPT is added to SummaryConfig when requesting ROEW
2020-11-23 11:02:02 +01:00
Joakim Hove
f7cb068f66
Add public get for UnitSystem from Schedule
2020-11-23 11:02:02 +01:00
Joakim Hove
8e83deef26
Merge pull request #2123 from joakim-hove/region-cache-wells
...
Add method RegionCache::wells()
2020-11-23 11:00:22 +01:00
Joakim Hove
0ff78a1bd6
Merge pull request #2125 from joakim-hove/serializer-vector
...
Serializer vector
2020-11-23 10:59:10 +01:00
Joakim Hove
174c16058c
Changes in SummaryState deserialize: Use internal variables directly
2020-11-21 09:33:33 +01:00
Joakim Hove
c7e734ab41
Fix bug SummaryState::erase_xxx_var()
2020-11-21 09:33:33 +01:00
Joakim Hove
18d01d1999
Use ordered set for wells and groups member
2020-11-21 09:33:33 +01:00
Joakim Hove
25beb52f68
Add operator== to SummaryState
2020-11-21 09:33:33 +01:00
Joakim Hove
8f65921753
Add put_vector() and get_vector() methods to Serializer
2020-11-21 09:33:33 +01:00
Joakim Hove
3bc490b693
Add method RegionCache::wells()
...
The method RegionCache::wells() will output the wells with the first connection
in region region_id.
2020-11-21 08:58:39 +01:00
Joakim Hove
315d9d30e0
Rename put<K,T> and get<K,T> -> put_map() and get_map()
2020-11-20 15:47:52 +01:00
Joakim Hove
44d9261258
Merge pull request #2122 from joakim-hove/summary-oip
...
Add const Inplace& argument to Summary::eval()
2020-11-20 14:12:34 +01:00
Joakim Hove
7a0b020c43
Add Inplace argument to Summary::eval()
2020-11-20 12:42:30 +01:00
Bård Skaflestad
f190387431
Merge pull request #1522 from bska/output-preferred-phase
...
Restart File: Output Well's Preferred Phase
2020-11-20 00:59:33 +01:00
Bård Skaflestad
2fb768e727
Simplify Preferred Phase Extraction
...
Well::getPreferredPhase() now knows that the preferred phase for
injectors is the injected phase. There is no need to special-case
injectors here.
2020-11-19 17:28:40 +01:00
Bård Skaflestad
c76878520a
Load Well's Preferred Phase from Restart File
2020-11-19 17:28:40 +01:00
Bård Skaflestad
9a669f5400
Restart File: Output Well's Preferred Phase
...
Note: We're missing the 'LIQUID' option (integer value 4) since
Well::getPreferredPhase()
does not return that value.
Also, while here, remove the previously misattributed IWEL[15] item.
This item is the well's preferred phase, not the prediction control.
Finally, don't assign the active control mode to the history control.
That was a mistake.
2020-11-19 17:28:40 +01:00
Joakim Hove
767f77e8c8
Merge pull request #2114 from joakim-hove/summary-oip
...
Add container to hold on to Original in place values
2020-11-19 17:12:51 +01:00
Joakim Hove
20be6aa6d9
Merge pull request #2121 from bska/fix-fmtout-segfault
...
Don't Overrun Formatting Buffer in 'doub_string_ecl'
2020-11-19 16:25:52 +01:00
Joakim Hove
bb3be75dc5
Add container class Inplace to manage aggregated region properties
2020-11-19 16:23:36 +01:00
Joakim Hove
955869e81d
Merge pull request #2085 from joakim-hove/igrp-2
...
AggregateGroupData - refactoring
2020-11-19 16:23:14 +01:00
Bård Skaflestad
cdc1361a03
Don't Overrun Formatting Buffer in 'doub_string_ecl'
...
We would write outside the allocated buffer, and fail to write the
nul terminator, when presented with inputs of very small size
(denormalized numbers in the order of 1.0e-101 or smaller). Switch
to using std::snprintf and expand the buffer size to work around
this problem.
While here, also fix a subtle issue in determining whether or not we
should insert the exponent character 'D' into the formatted output.
Since we add one upon formatting the number, we also need to use a
non-symmetric condition for the 'D' character lest we fail to output
correctly formatted versions of
-2.9440373045442E-100 (=> -0.29440373045442D-99)
-2.9440373045442E+99 (=> -0.29440373045442+100)
2020-11-19 11:46:37 +01:00
Joakim Hove
f2bdde4b73
Minor refactor
2020-11-19 11:42:17 +01:00
Joakim Hove
f64f8fd30e
Remove code which just resets default value -1
2020-11-19 11:42:17 +01:00
Joakim Hove
25731a67dd
Minor refactor of function
2020-11-19 11:42:17 +01:00
Joakim Hove
618595e538
Rewrite branching logic in AggregateGroupData
2020-11-19 11:42:17 +01:00
Joakim Hove
2ae5d6634d
Use std::optional<Group> when searching upwards for control group
2020-11-19 11:42:17 +01:00
Joakim Hove
05814ad90e
Simplified initialization
2020-11-19 11:42:17 +01:00
Joakim Hove
4ca4e865c9
Rename pctl_mode -> active_cmode
2020-11-19 11:42:17 +01:00
Joakim Hove
a65bb1e969
Rename prod_cmode -> deck_cmode
2020-11-19 11:42:17 +01:00
Joakim Hove
ee662f8e38
Store GroupProductionControls in local variable
2020-11-19 11:42:17 +01:00
Joakim Hove
b28ed60b02
Reactor function groupProductionControllable()
2020-11-19 11:42:17 +01:00
Joakim Hove
4e5cc1c94d
Refactor function groupInjectionControllable()
2020-11-19 11:42:17 +01:00
Joakim Hove
2820efc463
Extract assignment of GCONPROD cmode to separate function
2020-11-19 11:42:17 +01:00
Joakim Hove
2b6ffeb068
Refactor IGRP StaticContrib
2020-11-19 11:42:17 +01:00
Joakim Hove
5746c068c5
Add names for group type and level index
2020-11-19 11:42:17 +01:00
Bård Skaflestad
5338a1dd13
Merge pull request #2120 from joakim-hove/summary-store-ref
...
Store references to EclipseState and Schedule in Summary class
2020-11-19 11:00:06 +01:00
Joakim Hove
bd766a0277
Store references to EclipseState and Schedule in Summary class
2020-11-19 07:19:57 +01:00
Tor Harald Sandve
506ce18537
Merge pull request #2012 from osae/kwPVTEXTBO
...
New kw PVTSOL to accomodate an extension of the black oil model.
2020-11-18 14:00:43 +01:00
Joakim Hove
b8179b943d
Merge pull request #2115 from joakim-hove/all-connections-inactive
...
Automatically shut wells with no connections
2020-11-18 06:49:35 +01:00
Joakim Hove
e2cdd4d5e1
Merge pull request #2117 from joakim-hove/summaryconfig-rhpv
...
Load summary keyword RHPV_xxx
2020-11-17 22:20:46 +01:00
Joakim Hove
61c879e8cb
Load summary keyword RHPV_xxx
2020-11-17 15:15:26 +01:00
Joakim Hove
91275cc0a5
Automatically shut wells with no connections
2020-11-17 14:55:48 +01:00
Joakim Hove
785a14dd25
Merge pull request #2116 from akva2/janitoring
...
fixed: initializer list order
2020-11-17 13:28:29 +01:00
Arne Morten Kvarving
ec2294ee77
fixed: initializer list order
2020-11-17 12:21:29 +01:00
Joakim Hove
8ffb918650
Merge pull request #2112 from joakim-hove/udq-update
...
Support UDQ UPDATE
2020-11-17 10:31:47 +01:00
Arne Morten Kvarving
a5a521e295
Merge pull request #2103 from akva2/build_flow_poly
...
build flow_poly on jenkins
2020-11-17 09:49:26 +01:00
Ove Sævareid
e489f1aced
Serialize PvtsolTable.
2020-11-16 20:18:05 +01:00
Ove Sævareid
58aa93dcfe
New kw PVTSOL to accomodate an extension of the back oil model.
2020-11-16 20:18:05 +01:00
Joakim Hove
c46488236a
Merge pull request #2110 from joakim-hove/actionx-welpi
...
Actionx welpi
2020-11-16 18:12:53 +01:00
Joakim Hove
278c2182bd
Handle WELPI keyword in ACTIONX blocks
2020-11-16 16:55:34 +01:00
Joakim Hove
e4ab6c43ce
Merge pull request #2107 from joakim-hove/rrpv
...
Rrpv
2020-11-16 10:37:12 +01:00
Joakim Hove
bd9df4ec54
Merge pull request #2111 from joakim-hove/warnings
...
Warnings
2020-11-16 10:36:08 +01:00
Joakim Hove
ed5ed62203
Parse summary keyword ROEW_xxx
2020-11-16 07:12:59 +01:00
Joakim Hove
b2da0228b1
Support UDQ UPDATE action
2020-11-15 10:03:34 +01:00
Joakim Hove
e0e5ed1f91
Make sure UDQ can use also special summary values like TIME
2020-11-15 10:02:34 +01:00
Joakim Hove
e9e56fc5b5
Remove constructor declaration without implementation
2020-11-15 10:00:36 +01:00
Joakim Hove
25739a846c
Suppress unused warning with (void)
2020-11-13 18:08:24 +01:00
Joakim Hove
7f2c06f5b0
Fix serialization object
2020-11-13 18:03:15 +01:00
Joakim Hove
e35febde59
Merge pull request #2108 from joakim-hove/actionx-gconinje
...
Hanlde GCONINJE in ACTIONX block
2020-11-13 17:48:05 +01:00
Joakim Hove
27883b8a3c
Merge pull request #2105 from GitPaean/aqunum_activating_cells
...
AQUNUM can activate inactive cells
2020-11-13 17:23:14 +01:00
Kai Bao
72d3346ab8
Numerical aquifer cells need to be active
...
even the cells are disabled with ACTNUM
2020-11-13 11:18:48 +01:00
Joakim Hove
e8cb3f37e0
Hanlde GCONINJE in ACTIONX block
2020-11-13 08:48:11 +01:00
Joakim Hove
54cae0f07e
Merge pull request #2095 from joakim-hove/nnc-location
...
Nnc location
2020-11-13 08:26:30 +01:00
Joakim Hove
c3b6da7bc3
Add RRPV as summary variable
2020-11-13 08:20:28 +01:00
Joakim Hove
cfbafc236a
Allow deck_names in ParserKeyword to be interpreted as regexp
2020-11-13 08:19:43 +01:00
Joakim Hove
5c30077cd4
Merge pull request #2101 from joakim-hove/wpave
...
Internalize WPAVE and WWPAVE keywords
2020-11-13 07:00:14 +01:00
Joakim Hove
d4513d214f
Internalize WPAVE and WWPAVE keywords
2020-11-12 23:59:10 +01:00
Joakim Hove
0fdc36d433
Merge pull request #2104 from GitPaean/correcting_aqucon_definition
...
correcting the definition of the keyword AQUCON
2020-11-12 16:19:20 +01:00
Kai Bao
c2b48ed34b
correcting the definition of the keyword AQUCON
...
mostly related to default value.
default_value is used, while it looks like not working.
2020-11-12 14:01:39 +01:00
Arne Morten Kvarving
d6212f4a8b
build flow_poly on jenkins
2020-11-12 11:12:19 +01:00
Bård Skaflestad
893fcbb9fb
Merge pull request #2100 from joakim-hove/intehead51
...
Update INTEHEAD[51] value based on presence of GCONPROD / GCONINJE
2020-11-11 23:44:09 +01:00
Joakim Hove
37b71e8be5
Skip NNCEDIT with multiplier = 1
2020-11-11 19:57:06 +01:00
Joakim Hove
e61e7afcc8
Refactor the NNC input class
...
- The NNC and EDITNNC keywords are internalized in the same class.
- The EDITNNC keyword operations are applied directly to the NNC keywords.
- The nnc vectors are ordered with cell1 < cell2 and ascending order.
- An api has been added to get the KeywordLocation from an NCC
- NNC/EDITNNC which is connected to inactive cell is ignored
2020-11-11 19:57:06 +01:00
Joakim Hove
08f8a381b0
Update INTEHEAD[51] value based on presence of GCONPROD / GCONINJE
2020-11-11 19:56:28 +01:00
Joakim Hove
2374ae2127
Merge pull request #2102 from bska/cxl-support-dynamic-connections
...
CxL: Account for Dynamically Changing Set of Connections
2020-11-11 19:31:15 +01:00
Bård Skaflestad
c157760ac7
CxL: Account for Dynamically Changing Set of Connections
...
This commit adds a new helper function
getCompletionNumberFromGlobalConnectionIndex
which returns an optional<int> containing the completion number of
the connection with the associated global cell index, or nullopt if
no such connection exists. We then reimplement the CxL summary
keywords in terms of this function to handle connections being added
dynamically during the simulation. The connections at the end of
the simulation, from which we configure all connection-related
summary nodes, might not accurately reflect the connections existing
at all times during the simulation.
2020-11-11 16:04:08 +01:00
Joakim Hove
71b5dea35e
Merge pull request #2096 from tskille/io_c0nn
...
Update of EclIO classes.
2020-11-11 08:18:26 +01:00
Torbjørn Skille
9fa90b2687
Update of EclIO classes.
...
- Enables reading of output files generated by simulator IX
- Adding support for EclFile data type C0nn (string with length > 8 characters)
- Update of program summary, now supporting well names with more that 8 characters
- Updates of program convertECL, possible to write output files with IX "format"
- updates of python bindings (EclOutput and EclFile)
2020-11-10 22:02:38 +01:00
Bård Skaflestad
3d928b8a7f
Merge pull request #2099 from bska/fix-oob-indexing
...
Summary: Don't Index Out-of-Bounds During Node Configuration
2020-11-10 11:55:40 +01:00
Bård Skaflestad
f5fb6bc047
Summary: Don't Index Out-of-Bounds During Node Configuration
...
The 'schedule_wells' vector is guaranteed to be empty when we're
configuring the set of summary vectors to report. Don't blindly
access the .front() element.
2020-11-10 11:15:17 +01:00
Joakim Hove
3a1f5bd654
Merge pull request #2077 from joakim-hove/actionx-gliftopt
...
Actionx gliftopt
2020-11-10 09:36:21 +01:00
Joakim Hove
f3d6c3abe4
Support GCONLIFT in ACTIONX
2020-11-09 17:15:17 +01:00
Joakim Hove
7dd50935d1
Refactor ACTIONX testing to use a make_schedule() setup function
2020-11-09 17:15:17 +01:00
Joakim Hove
ada1f9d144
Add Schedule handler overload for GLIFTOPT - to support ACTIONX
2020-11-09 17:15:17 +01:00
Joakim Hove
6aefc2c17a
Add reqiures: ["LIFTOPT"] to GLIFTOPT keyword
2020-11-09 17:14:15 +01:00
Joakim Hove
cddfbb5217
Merge pull request #2075 from joakim-hove/actionx-gconprod
...
Actionx gconprod
2020-11-09 16:40:40 +01:00
Joakim Hove
22bf627d7b
Merge pull request #2098 from joakim-hove/ijk-warning
...
Fix shadow warning
2020-11-09 15:39:48 +01:00
Joakim Hove
f85884db71
Fix shadow warning
2020-11-09 14:41:16 +01:00
Joakim Hove
d896b2ce15
Support GCONPROD in ACTIONX
2020-11-09 14:34:47 +01:00
Joakim Hove
bb905eb545
Merge pull request #2059 from joakim-hove/summary-completion
...
Summary completion
2020-11-09 14:33:10 +01:00
Joakim Hove
5337306a55
Add summary evaluation for CxxxL connection completion keywords
2020-11-09 13:23:02 +01:00
Joakim Hove
523e099580
Add summary evaluation for WxxxL well completion keywords
2020-11-09 13:23:02 +01:00
Joakim Hove
2a6b623dcb
Optionally strip off trailing __XX when looking for summary function
2020-11-09 13:23:02 +01:00
Joakim Hove
1dc6545bab
Trivial white space
2020-11-09 13:23:02 +01:00
Joakim Hove
b9b918defa
Add summary configuration for WxxxL and CxxxL completion keywords
2020-11-09 13:23:02 +01:00
Joakim Hove
e625623e49
Remove WGORL from WELL_PROBE configuration file
2020-11-09 12:47:25 +01:00
Joakim Hove
624ff50628
Merge pull request #2086 from joakim-hove/group-is-field
...
Add method Group::is_field()
2020-11-09 12:47:07 +01:00
Joakim Hove
84a2c3c209
Add method Group::is_field()
2020-11-09 12:46:30 +01:00
Joakim Hove
558cd2c1f7
Merge pull request #2088 from joakim-hove/welltype-injection-phase
...
Add method WellType::injection_phase()
2020-11-09 12:45:34 +01:00
Joakim Hove
c414aa52a9
Merge pull request #2089 from joakim-hove/udq-minus-bugx
...
Udq minus bugx
2020-11-07 14:58:45 +01:00
Joakim Hove
315187b8d6
Merge pull request #2093 from akva2/fix_system_header
...
workaround cmake issue
2020-11-06 11:10:15 +01:00
Arne Morten Kvarving
fac6695d15
workaround cmake issue
...
cmake does not properly interpret the SYSTEM marker in lists of
include directories. this causes issues downstream when using
dunecontrol / the in-tree cmake config files.
2020-11-06 10:16:02 +01:00
Joakim Hove
515a9ef258
Merge pull request #2090 from akva2/bump_version
...
bump version to 2021.04-pre
2020-11-06 09:11:29 +01:00
Arne Morten Kvarving
a194c8a1fc
bump version to 2021.04-pre
2020-11-06 08:57:04 +01:00
Joakim Hove
47543641ee
Testing of negative prefix
2020-11-05 15:38:23 +01:00
Joakim Hove
2b24fba2c5
Merge pull request #2078 from joakim-hove/gliftopt-has
...
Add methods GasLiftOpt::has_well() and GasLiftOpt::has_group()
2020-11-05 12:41:21 +01:00
Joakim Hove
f5631549bf
Merge pull request #2074 from joakim-hove/handlercontext-units
...
Make section and keyword index optional in Schedule handlerContext
2020-11-05 12:40:53 +01:00
Joakim Hove
25dee84f81
Merge pull request #2073 from joakim-hove/summary-completion-commits
...
Summary completion commits
2020-11-05 12:40:06 +01:00
Joakim Hove
ef39f6a817
Merge pull request #2071 from joakim-hove/WWIRT
...
Add summary variable WWIRT
2020-11-05 12:39:45 +01:00
Joakim Hove
a383f55cf5
Add method WellType::injection_phase()
2020-11-05 12:32:24 +01:00
Joakim Hove
c883e738f0
Merge pull request #2087 from OPM/revert-2082-igrp-prod
...
Revert "Igrp prod"
2020-11-05 12:27:02 +01:00
Joakim Hove
57566ad768
Revert "Igrp prod"
2020-11-05 11:15:20 +01:00
Joakim Hove
f16375f5ee
Merge pull request #2082 from joakim-hove/igrp-prod
...
Igrp prod
2020-11-04 15:41:35 +01:00
Joakim Hove
7c1b2ff6b4
Simplified initialization
2020-11-04 14:13:44 +01:00
Joakim Hove
c392c5aaa2
Rename pctl_mode -> active_cmode
2020-11-04 14:13:44 +01:00
Joakim Hove
861be5d672
Rename prod_cmode -> deck_cmode
2020-11-04 14:13:44 +01:00
Joakim Hove
73f550ddb3
Store GroupProductionControls in local variable
2020-11-04 14:13:44 +01:00
Joakim Hove
6402ee098e
Reactor function groupProductionControllable()
2020-11-04 14:13:44 +01:00
Joakim Hove
f32a3badc2
Refactor function groupInjectionControllable()
2020-11-04 14:13:44 +01:00
Joakim Hove
5738e60432
Add method WellType::injection_phase()
2020-11-04 14:13:44 +01:00
Joakim Hove
46bf4e394a
Extract assignment of GCONPROD cmode to separate function
2020-11-04 09:56:09 +01:00
Joakim Hove
ce50cd5d3e
Refactor IGRP StaticContrib
2020-11-04 09:07:47 +01:00
Joakim Hove
f508c23750
Add names for group type and level index
2020-11-04 08:45:24 +01:00
Joakim Hove
d88017def9
Merge pull request #2080 from joakim-hove/rst-commits
...
Rst commits
2020-11-04 07:25:51 +01:00
Joakim Hove
13c60d2008
Attach TUNING_CHANGE event to the correct report step
2020-11-03 21:09:48 +01:00
Joakim Hove
28d1256683
Change message when loading restart date
2020-11-03 21:09:48 +01:00
Joakim Hove
857617c0ef
Cast to avoid warning
2020-11-03 21:09:48 +01:00
Joakim Hove
c392c24b6d
Use named index/offset when assembling group result
2020-11-03 21:09:48 +01:00
Joakim Hove
fd7723ca61
Use const for local variables
2020-11-03 21:09:48 +01:00
Joakim Hove
6324b666c9
White space changes
2020-11-03 21:09:48 +01:00
Joakim Hove
da0ed1450e
RstGroup: use raw values for rates which should enter UDA
2020-11-03 21:09:48 +01:00
Joakim Hove
4d5b4a9815
Add function converting from integer to GuideRateTarget
2020-11-03 20:38:26 +01:00
Joakim Hove
37443b8c38
Merge pull request #2079 from bska/expand-block-probe
...
Recognize Additional Relperm Keywords per Block
2020-11-03 14:37:18 +01:00
Bård Skaflestad
85cbe8c745
Recognize Additional Relperm Keywords per Block
...
The BKROG and BKROW keywords are the two-phase relative permeabilites
for oil in oil/gas and oil/water systems (per block.)
2020-11-03 12:45:00 +01:00
Joakim Hove
6c449a48b1
Merge pull request #2069 from joakim-hove/udq-wlist
...
Udq wlist
2020-11-03 11:22:02 +01:00
Joakim Hove
19090c2827
Add methods GasLiftOpt::has_well() and GasLiftOpt::has_group()
2020-11-03 08:47:15 +01:00
Joakim Hove
064559b9e4
Add UnitSystem member to Schedule class
...
Mkae Section and KeywordIndex members in HandleContext optional.
2020-11-02 21:27:18 +01:00
Bård Skaflestad
1d73d07f19
Merge pull request #2076 from joakim-hove/rm-printf
...
Remove extra printf
2020-11-02 19:19:10 +01:00
Joakim Hove
30bbee6e69
Merge pull request #2072 from alfbr/new-line
...
Added newline where natural.
2020-11-02 16:40:13 +01:00
Joakim Hove
7b8590f7ee
Remove extra printf
2020-11-02 16:37:56 +01:00
Joakim Hove
5316d193ea
White space
2020-11-02 14:44:05 +01:00
Joakim Hove
f3e9a02123
Add additional connection in testdata
2020-11-02 14:44:05 +01:00
Joakim Hove
64b9a49a20
Use multiline string literal for test data
2020-11-02 14:44:05 +01:00
Joakim Hove
f02437cdcb
Use name based lookup in function getijk()
2020-11-02 14:44:05 +01:00
Joakim Hove
7d596e4e41
Make function parseKeyworType() in SummaryConfig public
2020-11-02 14:44:05 +01:00
Joakim Hove
a8f5dc6354
Add SummaryConfig::operator[](const std::size_t index)
2020-11-02 14:12:05 +01:00
Joakim Hove
0805249185
Merge pull request #2070 from joakim-hove/get-completion-connection
...
Get connections from global index
2020-11-02 14:04:05 +01:00
Alf Birger Rustad
a2cfd9a525
Added newline where natural.
2020-11-02 13:43:13 +01:00
Joakim Hove
855decfa56
Add summary variable WWIRT
2020-11-02 10:29:31 +01:00
Joakim Hove
5193cc48c6
Merge pull request #2067 from joakim-hove/group-uda
...
Group uda
2020-11-02 10:05:18 +01:00
Joakim Hove
9844b73bdb
Add functions to get/query connections from global index
2020-11-02 07:57:19 +01:00
Joakim Hove
14df089f14
Use WellMatcher() in Schedule::wellNames()
2020-10-31 09:04:32 +01:00
Joakim Hove
7ef7e3017e
Add class WellMatcher and use it UDQ evaluation
2020-10-30 22:17:59 +01:00
Joakim Hove
9bec2673ad
Explicitly delete UDAValue::operator=()
2020-10-30 17:19:02 +01:00
Joakim Hove
f34f221be8
Properly initialize UDA values for group production and injection
2020-10-30 17:19:02 +01:00
Joakim Hove
d27e31ee84
Merge pull request #2062 from joakim-hove/summary-config-extra
...
Use general datatype for extra data in summary keywords
2020-10-30 17:18:23 +01:00
Joakim Hove
3a8694fee1
Merge pull request #2064 from bska/deferred-welpi-uconv
...
Defer Unit Conversion for WELPI Values
2020-10-30 17:18:06 +01:00
Bård Skaflestad
94af88c3a1
Switch Back to Consuming Strictly SI Convention PI Values
...
Heed advice from [at]joakim-hove to keep client code as close to
strictly SI as possible. We must nevertheless continue to store the
raw (input/output units) requested PI value internally as this is
the only way to ensure that both the client and implementation has
consistent view of the well's preferred phase. This means pushing
the unit conversion into Well::getWellPIScalingFactor().
Thanks to [at]joakim-hove for pointing out that the Well already
maintains an internal UnitSystem data member which makes the process
of converting the PI units trivial.
2020-10-30 15:16:31 +01:00
Bård Skaflestad
354351daee
Record General Event When Processing WELPI
...
This commit ensures that we record a general, Schedule-level
WELL_PRODUCTIVITY_INDEX
event in addition to the well-specific event already recorded when
we encounter a WELPI keyword. We need this information in order to
trigger a PI calculation across all MPI processes in opm-simulators.
2020-10-30 15:16:31 +01:00
Bård Skaflestad
54e2eb5597
Store Raw WELPI in Well::productivity_index
...
This makes the interface less convenient to use, but it is the only
way to guarantee that we have a consistent notion of preferred phase
for injectors. The downside is that the users of
Well::getWellPIScalingFactor()
must convert the argument to raw/input units before calling the
function.
2020-10-30 15:16:31 +01:00
Bård Skaflestad
6f124fb478
Revert "Capture Preferred Phase When Processing WELPI Keyword"
...
There and back again. We don't actually need the preferred phase at
the time of encountering the WELPI request. [at]joakim-hove was
right, the preferred phase of an injector must reflect the state at
the same report step as the WELPI keyword. In other words, if the
injected phase is reset at the same report step as a WELPI keyword,
then the new preferred phase must be that of the new injected phase.
This reverts commit 3eef45e87d .
2020-10-30 15:16:31 +01:00
Bård Skaflestad
038c2bd2e0
Merge pull request #2068 from bska/msw-allconn
...
MSW: Support Connection Results for All Connections
2020-10-30 14:24:22 +01:00
Joakim Hove
279871df05
Add missing #include
2020-10-30 13:36:08 +01:00
Bård Skaflestad
62a39877be
Address Review Comments
...
Add comments on a function and rename a variable.
2020-10-30 11:47:11 +01:00
Bård Skaflestad
14c566d99b
MSW: Support Connection Results for All Connections
...
The current code that aggregates flow rates from connection to
segment levels assumes that the simulator generates connection
results for the open connections only. Relax this restriction as
upcoming work in the context of WELPI will require generating at
least the CTFs even for shut connections.
2020-10-30 11:37:31 +01:00
Joakim Hove
e613a7c31d
Use std::optional<std::string> for fip_region member
2020-10-30 11:30:05 +01:00
Joakim Hove
96f9362f59
Merge pull request #2066 from joakim-hove/rst-pressure-drop-model
...
Load MSW pressure drop model fro restart file
2020-10-30 11:07:58 +01:00
Joakim Hove
78b544afdf
Merge pull request #2063 from joakim-hove/completion-util
...
Add function bool Well::hasCompletion( int )
2020-10-30 10:17:34 +01:00
Joakim Hove
00af07ceed
Load MSW pressure drop model fro restart file
2020-10-29 11:34:56 +01:00
Bård Skaflestad
8d3e419162
Merge pull request #2065 from joakim-hove/meta-error-message
...
Improve error message for unhandled meta summary keyword
2020-10-29 10:25:48 +01:00
Joakim Hove
c83e4820bc
Improve error message for unhandled meta summary keyword
2020-10-29 08:57:25 +01:00
Joakim Hove
ed5d20d90e
Add utility functions to query/get completion data
2020-10-28 16:00:56 +01:00
Joakim Hove
03efa3d2e1
Merge pull request #2060 from goncalvesmachadoc/outtemp
...
add extra thermal summary keywords
2020-10-28 14:26:22 +01:00
Joakim Hove
24a9dbf4c6
Merge pull request #2058 from joakim-hove/rst-commits2
...
Rst commits2
2020-10-28 14:24:59 +01:00
Cintia Goncalves Machado
957d5d3840
add extra thermal summary keywords
2020-10-28 13:28:37 +01:00
Markus Blatt
e5f191ede8
Merge pull request #2038 from blattms/fix-scotch-parmetis
...
[cmake] Use scotch include dir for parmetis bindings of scotch.
2020-10-28 12:28:50 +01:00
Joakim Hove
1f7ec57895
Use named constants in IGRP access
2020-10-27 20:50:12 +01:00
Joakim Hove
92bf4a96ea
Separately load active and requested group control from restart file
...
Use named constants for access to IGRP vector
2020-10-27 20:48:03 +01:00
Joakim Hove
30a897e89d
Merge pull request #2047 from joakim-hove/gconprod-item10
...
Blank string is default rate in GCONPROD
2020-10-27 19:50:14 +01:00
Joakim Hove
e5519c456c
Merge pull request #2050 from joakim-hove/udq-cast-error
...
Improve error message for invalid udq_cast()
2020-10-27 19:49:51 +01:00
Joakim Hove
a90feb6bb7
Blank string is default rate in GCONPROD
2020-10-27 18:51:36 +01:00
Joakim Hove
d301274e89
Improve warning for UDQ missing unit
2020-10-27 18:50:47 +01:00
Joakim Hove
4f02dc5173
Add try catch block around UDQ eval
2020-10-27 18:50:47 +01:00
Joakim Hove
82afbf070c
Improve error message for invalid udq_cast()
2020-10-27 18:50:47 +01:00
Joakim Hove
0f28d7c199
Merge pull request #2051 from joakim-hove/improve-udq-error-message
...
Improve error message for failed udq
2020-10-27 18:28:28 +01:00
Joakim Hove
404e2b095e
Merge pull request #2048 from joakim-hove/thp-uda
...
Thp uda
2020-10-27 18:26:59 +01:00
Joakim Hove
2a41058eda
Merge pull request #2039 from joakim-hove/rst-tstep
...
Allow restart date to be at a TSTEP
2020-10-27 18:24:08 +01:00
Joakim Hove
9011ca0e78
Merge pull request #2049 from joakim-hove/udq-leading-sign
...
Udq leading sign
2020-10-27 17:05:02 +01:00
Joakim Hove
716b4d3bf1
Remove special casing of leading '-' in UDQ parsing
2020-10-27 14:17:12 +01:00
Joakim Hove
e9dadcf93e
Extract leading sign when extract UDQ factor
2020-10-27 14:17:12 +01:00
Joakim Hove
0994a1a2fe
Add sign member to UDQASTNode and implement operator*
2020-10-27 14:17:12 +01:00
Joakim Hove
524e211247
Merge pull request #2056 from joakim-hove/udq-extra-ficup
...
Store extra summary parameters from UDQ and restart in common map
2020-10-27 14:16:02 +01:00
Atgeirr Flø Rasmussen
3c1e3b5a30
Merge pull request #2054 from joakim-hove/groups-active-cmode
...
Rename group production control mode variable
2020-10-27 11:52:42 +01:00
Joakim Hove
8e44859c48
Merge pull request #2055 from bska/fix-wpil-smry
...
Don't Treat WPIL as Completion Keyword
2020-10-27 08:53:50 +01:00
Joakim Hove
5cb8dfdca0
Store extra summary parameters from UDQ and restart in common map
2020-10-27 08:50:56 +01:00
Bård Skaflestad
509b15a243
Don't Treat WPIL as Completion Keyword
...
WPIL is the productivity index of liquid (water + oil).
2020-10-27 00:07:38 +01:00
Joakim Hove
45c784f8d8
Add Group active_cmode
2020-10-26 21:01:16 +01:00
Joakim Hove
a81eb8f9d4
Use Group::gconprod_cmode() in AggregateGroupData
2020-10-26 20:47:09 +01:00
Joakim Hove
8e0928cc9d
Rename group production control mode variable
2020-10-26 18:46:48 +01:00
Bård Skaflestad
e38b8f5812
Merge pull request #2053 from joakim-hove/fglir
...
Summary function glir should sum over all argument wells
2020-10-26 15:57:02 +01:00
Joakim Hove
70353f496d
Allow restart date to be at a TSTEP
2020-10-26 15:10:10 +01:00
Joakim Hove
908eebb7ed
Summary function glir should sum over all argument wells
2020-10-26 15:06:00 +01:00
Joakim Hove
548bed1dc8
Improve error message for failed udq
2020-10-26 11:57:09 +01:00
Joakim Hove
cab2e29724
Merge pull request #2044 from joakim-hove/include-udq-summary
...
Include udq summary
2020-10-26 11:18:56 +01:00
Joakim Hove
c1a65ef7da
Merge pull request #2046 from joakim-hove/udqdefine-location
...
Udqdefine location
2020-10-26 10:31:32 +01:00
Joakim Hove
de51e3e3a4
Check that UDQ value is numeric before comparing with zero
2020-10-25 19:16:50 +01:00
Joakim Hove
604cbef5dc
USe fmt::format() for error message
2020-10-25 19:12:51 +01:00
Joakim Hove
eb208ffb78
Remove unused UDQDefine constructor
2020-10-24 12:48:43 +02:00
Joakim Hove
5e6c6be3b8
Add location member to UDQDefine
2020-10-24 12:47:55 +02:00
Joakim Hove
508b4e6f96
Scan UDQ expressions to extract required summary keywords
2020-10-24 10:15:58 +02:00
Joakim Hove
5c1604c5f2
Merge pull request #2045 from joakim-hove/include-udq-summary-commits
...
Include udq summary commits
2020-10-24 10:15:30 +02:00
Bård Skaflestad
9fc6948e05
Merge pull request #2042 from joakim-hove/well-reperf
...
Changes to well reference depth
2020-10-23 16:49:08 +02:00
Joakim Hove
3fa4c4bbb1
Publish function SummaryConfig::parseKeywordType()
2020-10-23 16:05:55 +02:00
Joakim Hove
b53acbc6a7
Add functionality to extract required summary keys from UDQConfig
2020-10-23 16:05:55 +02:00
Joakim Hove
faa1e7dc4d
Add function to return pointers to all unique UDQConfig objects
2020-10-23 16:05:55 +02:00
Joakim Hove
b4388ba203
Merge pull request #2040 from joakim-hove/udq-left-assoc
...
Ensure that division is left assosiative in UDQ parser
2020-10-23 16:04:45 +02:00
Joakim Hove
b9bd1598d7
Changes to well reference depth
...
1. The well reference depth should *not* be updated when new connections are
added with COMPDAT.
2. The well reference depth should be recalculated when the well is updated with
the WELSPECS keyword.
2020-10-23 15:25:38 +02:00
Joakim Hove
58e859fb11
Merge pull request #2043 from joakim-hove/eclipsegrid-remove-test
...
Remove not interesting test code
2020-10-22 20:23:47 +02:00
Joakim Hove
0a0f30133d
Remove not interesting test code
2020-10-22 18:52:05 +02:00
Joakim Hove
7a21769ca1
Merge pull request #2041 from akva2/janitoring
...
quell unused parameter warning
2020-10-22 17:22:24 +02:00
Arne Morten Kvarving
be84d23da4
quell unused parameter warning
2020-10-22 14:53:25 +02:00
Joakim Hove
80a023794e
Ensure that division is left assosiative in UDQ parser
2020-10-22 14:40:32 +02:00
Joakim Hove
4a806533db
Merge pull request #1915 from goncalvesmachadoc/addSpyderwebGrid
...
add Spiderweb grid
2020-10-22 14:08:01 +02:00
Joakim Hove
d9a7d6326f
Merge pull request #2033 from joakim-hove/rst-group-commits
...
Rst group commits
2020-10-22 09:25:56 +02:00
Joakim Hove
f6077809c7
Init GuideRateModel from restart file
2020-10-22 08:18:47 +02:00
Joakim Hove
5a91c73b8e
Merge pull request #2035 from joakim-hove/igrp-guide-rate
...
Igrp guide rate
2020-10-22 08:06:56 +02:00
Joakim Hove
0894f7e774
Merge pull request #2032 from joakim-hove/MULTIREG
...
Multireg
2020-10-22 08:06:37 +02:00
Joakim Hove
ee7f50a51d
Merge pull request #2037 from joakim-hove/udq-define-order
...
Make sure UDQ define statements are evaluated in definition order
2020-10-21 17:32:55 +02:00
Markus Blatt
8951ff3130
[cmake] Use scotch include dir for parmetis bindings of scotch.
...
The parmetis.h distributed via the parmetis binding of scotch
with Ubuntu 18.04 (libscotchparmetis-dev) includes the header
scotch.h located in /usr/include/scotch/. Therefore our check
of the include file failed. With this commit we check the
parmetis.h header another time with the scotch include path added.
Now parmetis is found on my Ubuntu.
2020-10-21 14:36:39 +02:00
Joakim Hove
85f7380721
Merge pull request #2030 from joakim-hove/default-group
...
Use optional - and default to self - for reinj and voidage groups
2020-10-21 13:58:07 +02:00
Joakim Hove
413a16157c
Make sure UDQ define statements are evaluated in definition order
2020-10-21 13:49:07 +02:00
Joakim Hove
ba4082b2b9
Merge pull request #2034 from joakim-hove/udq-assign-define
...
Udq assign define
2020-10-21 11:45:41 +02:00
Joakim Hove
3f2e41ba99
Add member guide_rate_def to Group object loaded from restart file
2020-10-21 10:31:44 +02:00
Joakim Hove
c8efb7fd3b
Use named constants when saving GuideRate defintion to IGRP
2020-10-21 09:47:16 +02:00
Joakim Hove
67f24bd3a7
When loading from restart: set wells active control also for SHUT
2020-10-20 22:48:08 +02:00
Joakim Hove
5c6fa9cc51
Add Group update events after loading from restart file
2020-10-20 22:46:28 +02:00
Joakim Hove
2bc338e87f
Add functions converting integer group control modes to enum
2020-10-20 22:44:01 +02:00
Joakim Hove
b72460f0c8
Remove unused members from rst header class
2020-10-20 22:43:49 +02:00
Joakim Hove
2289ba165b
Update SummaryState in UDQContext
2020-10-20 22:22:21 +02:00
Joakim Hove
313f576e37
Ensure that UDQDefine::eval returns nodes with correct name
2020-10-20 20:45:59 +02:00
Joakim Hove
5ff65747f3
Rename summary variable in test
2020-10-20 20:02:19 +02:00
Joakim Hove
ab43f54076
Export undefined value from UDQState
2020-10-20 19:44:15 +02:00
Joakim Hove
bf2f049a4b
Merge pull request #2031 from bska/schedule-apply-wellpi
...
Apply WELPI CTF Scaling at Schedule Level
2020-10-20 12:05:05 +02:00
Bård Skaflestad
ab51949909
Address Code Review Comments
...
Use more complete object name and fix up a comment.
2020-10-20 11:14:03 +02:00
Joakim Hove
158c7376d7
Add test for MULTIREG and COPYREG keywords
2020-10-20 08:22:42 +02:00
Joakim Hove
eb7cb2f94a
Bug in COPYEREG keyword - look up wrong item
2020-10-20 08:22:22 +02:00
Bård Skaflestad
91bb168ee5
Fix Shadowing Type Alias
...
The local 'WellPI' type alias shadowed the name of the test.
2020-10-19 21:16:55 +02:00
Bård Skaflestad
5b4a1c0bad
Remove WELL_CONNECTIONS_UPDATED Event
...
With the introduction of Schedule::applyWellProdIndexScaling(), this
special-purpose event type is no longer needed and only causes
confusion.
2020-10-19 19:16:17 +02:00
Bård Skaflestad
26ef5d01a2
Apply WELPI CTF Scaling at Schedule Level
...
This commit adds a new member function
applyWellProdIndexScaling(well_name, report_step, scalingFactor)
which applies WELPI-based CTF scaling (by scalingFactor) for all
pertinent report steps from 'report_step' and until the end of the
simulation run. We use the 'scalingApplicable' array to communicate
connection eligibility between report steps and only apply the
scaling if the internal connections pointers differ between report
steps.
2020-10-19 19:16:16 +02:00
Bård Skaflestad
cfa5dd80cc
Enable Applying WELPI CTF Scaling Across Time Direction
...
This commit adds a new in/out parameter, scalingApplicable, to the
applyWellProdIndexScaling functions. This parameter carries time
(history) information on whether or not a particular connection is
eligible for WELPI-based CTF scaling. Entries are marked ineligible
(false) and left untouched on subsequent calls if the corresponding
connection is ineligible at any point--e.g., as a result of new
COMPDAT entries.
This ability enables implementing WELPI CTF scaling at the Schedule
level which is the only level that has sufficient time information
to identify all the unique Well/WellConnections object combinations.
2020-10-19 19:16:15 +02:00
Bård Skaflestad
338a48708a
Add Special Predicate to Check if Two Wells Have Same Connections
...
This commit adds a new special purpose predicate member function
bool Well::hasSameConnectionsPointers
which checks if the internal WellConnections pointers of two Well
objects (*this and the input argument) point to the same object.
This, in turn, enables identifying when to apply dynamic WELPI CTF
scaling across the time direction the internalized connection
information.
2020-10-19 19:16:15 +02:00
Bård Skaflestad
dabf988aa7
Split WELPI Application Into Two Parts
...
First part, implemented in a new member function
Well::getWellPIScalingFactor
calculates a CTF scaling factor from stored WELPI information and a
dynamically calculated well-level PI value. The second part, using
the original name applyWellProdIndexScaling, applies an externally
calculate CTF scaling factor to all eligble connections.
This is needed to enable applying multiple scalings across the time
direction. Update unit tests accordingly.
2020-10-19 19:16:12 +02:00
Joakim Hove
452c222f71
Merge pull request #2018 from bska/preferred-is-injected
...
Use Injected Phase as Preferred Phase for Injectors
2020-10-19 18:03:52 +02:00
Joakim Hove
d545359395
Use optional - and default to self - for reinj and voidage groups
2020-10-19 17:07:00 +02:00
Bård Skaflestad
641b9fb4b1
Merge pull request #2029 from joakim-hove/udq-function-rename
...
Renamed UDQ functions: MIN -> UDQ_MIN and MAX -> UDQ_MAX
2020-10-19 14:28:44 +02:00
Joakim Hove
63e0eb385a
Renamed UDQ functions: MIN -> UDQ_MIN and MAX -> UDQ_MAX
2020-10-19 13:09:40 +02:00
Bård Skaflestad
3eef45e87d
Capture Preferred Phase When Processing WELPI Keyword
...
This is to handle the case of an injector changing its injected (and
therefore preferred) phase (e.g., in WCONINJE or WCONINJH) at the
same report step as a WELPI CTF rescaling, but logically after the
WELPI action is applied.
For instance, this happens in the following setup:
WCONINJH
INJ2 WATER OPEN 5500 /
/
DATES
1 'JAN' 2020 /
/
WELPI
'INJ2' 0.1E5 /
/
WCONINJH
INJ2 GAS OPEN 701627 /
/
DATES
1 'FEB' 2020 /
/
In this case, the WELPI for 'INJ2' is supposed to be interpreted as
the water-phase PI (preferred phase is 'WATER' when we read WELPI),
but since the injecting phase is reset to 'GAS' at the same report
step we risk misinterpreting the PI as pertaining to the 'GAS' phase
when calculating the well's effective/dynamic PI in the simulator if
we just use Well::getPreferredPhase().
Switch the the well's input PI from an optional<double> to an
optional<struct> that captures both the input PI value (SI units)
and the preferred phase when processing the WELPI data. Provide a
way to query that information from the simulator and update unit
tests accordingly.
2020-10-19 11:09:00 +02:00
Bård Skaflestad
f84858279f
WELPI: Don't Inadvertently Overwrite Scaling Eligiblity
...
Since the Well stores a pointer to its connections, rather than the
connections themselves, we must take care not change the existing
state of the connections' WELPI eligibility flag. Do the update
check on a copy of the connections instead of the real connections.
Pointy Hat: [at]bska
2020-10-19 11:08:59 +02:00
Bård Skaflestad
f718cc1adc
Injectors: Ensure "Preferred" Phase is "Injected" Phase
...
This needed to correctly interpret WELPI values when wells switch
from injecting Water to injecting Gas or the other way around.
2020-10-19 11:08:59 +02:00
Arne Morten Kvarving
ebc562887c
Merge pull request #2028 from atgeirr/silence-warning
...
Silence shadowing warnings.
2020-10-19 10:32:52 +02:00
Atgeirr Flø Rasmussen
fd59f1685a
Silence shadowing warnings.
2020-10-19 09:06:38 +02:00
Joakim Hove
fd1cc74f74
Merge pull request #2026 from joakim-hove/multflt-messages
...
Message limits for MULTFLT and Tracer
2020-10-16 16:02:09 +02:00
Joakim Hove
b05680f76b
Merge pull request #2023 from joakim-hove/alq-dimension
...
Alq dimension
2020-10-16 14:27:43 +02:00
Joakim Hove
64165f072a
Rename summary function -> glir
2020-10-16 12:16:33 +02:00
Joakim Hove
8ffc4b85b0
Add a comment warning in Summary evaluation of WGLIR
2020-10-16 12:16:33 +02:00
Joakim Hove
134834cefa
Pass VFP ALQ type to enable unit conversion for ALQ values
2020-10-16 12:16:33 +02:00
Joakim Hove
3e02a48c10
Convert VFP dimensions without parsing dimension string
2020-10-16 12:16:33 +02:00
Joakim Hove
2644e3bd78
Add test (safety belt) for VFP dimension conversion
2020-10-16 12:16:33 +02:00
Joakim Hove
d004bfdc76
Merge pull request #2025 from joakim-hove/udq-allow-missing-well
...
Udq allow missing well
2020-10-16 12:16:01 +02:00
Joakim Hove
c696cee549
Limit the number of messages emitted while loading tracer tables
2020-10-16 11:27:33 +02:00
Joakim Hove
0587e11112
Limit the number of MULTFLT messages
2020-10-16 11:27:33 +02:00
Joakim Hove
9c49468f46
Create small utility class InfoLogger
2020-10-16 11:27:33 +02:00
Joakim Hove
d9f260dd51
Add utility KeywordLocation::format()
2020-10-16 11:27:33 +02:00
Joakim Hove
9ea86a9bbc
Remove unused function
2020-10-16 11:27:33 +02:00
Joakim Hove
451eefbda5
UDQContext - differentiate between missing well and invalid variable
2020-10-16 11:24:21 +02:00
Joakim Hove
c11d2eee37
Merge pull request #2024 from joakim-hove/summary-state-has-well-var
...
Add SummaryState functions has_well_var() and has_group_var()
2020-10-16 11:23:12 +02:00
Joakim Hove
78c07a4e2a
Merge pull request #2022 from joakim-hove/fmwia-fixup
...
Count of abondoned wells should handle both STOP and SHUT
2020-10-16 11:22:37 +02:00
Joakim Hove
0cdfdca0f7
Add SummaryState functions has_well_var() and has_group_var()
2020-10-15 13:01:52 +02:00
Joakim Hove
a2f72f0953
Count of abondoned wells should handle both STOP and SHUT
2020-10-14 16:08:11 +02:00
Joakim Hove
6e82f3cb7a
Merge pull request #2021 from joakim-hove/no-wells-message
...
No wells message
2020-10-14 14:23:24 +02:00
Joakim Hove
7f8578ea96
Merge pull request #2020 from joakim-hove/fmwia
...
Fmwia
2020-10-14 14:22:38 +02:00
Joakim Hove
21d44c09e0
Merge pull request #2019 from joakim-hove/vfpprod-dimension
...
Dimension string does not accept space
2020-10-14 12:15:49 +02:00
Joakim Hove
e3959c5fa1
Implement number of abondoned injectors: FMWIA
2020-10-14 08:43:03 +02:00
Joakim Hove
2d036144cc
Raise OpmInputError for unbalanced quotes
2020-10-14 08:40:10 +02:00
Joakim Hove
2ebc15e8d4
Fix message format for invalid wellname pattern
2020-10-14 08:15:07 +02:00
Joakim Hove
dd34f2d831
Maintain whether a well has ever injected
2020-10-14 00:39:48 +02:00
Joakim Hove
e1698f7be8
Rename test well RFT -> RFTP
2020-10-14 00:12:50 +02:00
Joakim Hove
47c4f5c2e0
Dimension string does not accept space
2020-10-13 22:19:49 +02:00
Joakim Hove
d0416d963d
Merge pull request #2017 from joakim-hove/rst-commits
...
Rst commits
2020-10-13 15:12:21 +02:00
Joakim Hove
53fe0f2d11
Add guide rate delay and damping to rst header class
2020-10-13 13:11:04 +02:00
Joakim Hove
ead5a19209
Extract update of guide rate model into separate function
2020-10-13 09:52:33 +02:00
Joakim Hove
94c697ccd0
Load boolean flag to indicate whether group control is active
2020-10-13 09:52:33 +02:00
Joakim Hove
60c406397b
Merge pull request #2015 from bska/record-new-connstructure
...
Record Event if WellConnections Change
2020-10-12 18:24:54 +02:00
Bård Skaflestad
6f20858d73
Record Event if WellConnections Change
...
This is different from COMPLETION_CHANGE which is unconditionally
recorded when processing COMPDAT. This event is recorded only when
the Well's internal WellConnections structure actually changes and
informs clients that they may need to rerun any dynamic WELPI
scaling. Such scaling will not be automatically forwarded onto the
new WellConnections structure.
This is arguably a hack.
2020-10-12 15:10:28 +02:00
Bård Skaflestad
5852270035
Merge pull request #2014 from bska/fix-oob-indexing
...
Ensure *HEAD Arrays Have Sufficient Size
2020-10-12 14:52:38 +02:00
Bård Skaflestad
810a93ba87
Ensure *HEAD Arrays Have Sufficient Size
...
The regression test program depends on this.
2020-10-12 13:49:53 +02:00
Bård Skaflestad
b0b8523b2a
Merge pull request #2013 from joakim-hove/schedule-msg
...
Schedule msg
2020-10-12 11:47:47 +02:00
Bård Skaflestad
6708273616
Merge pull request #2007 from joakim-hove/rst-cmp
...
Use restart object in regression testing
2020-10-12 11:47:09 +02:00
Joakim Hove
206243c78d
Compare string and integere members from well using RestartIO data
2020-10-12 10:11:07 +02:00
Joakim Hove
8f90bf9387
Refactor the log messages emitted while creating the Schedule object
...
A maximum of N dates keywords are printed to stdout, afterwards logging will
only go to PRT file
2020-10-12 09:59:04 +02:00
Joakim Hove
db052055b2
Merge pull request #2011 from joakim-hove/grid-msg
...
Grid msg
2020-10-10 10:30:36 +02:00
Joakim Hove
32ac90cb5e
Add messages about grid creation
2020-10-10 08:30:48 +02:00
Joakim Hove
36e03cf6b9
Use ParserKeyword::prohibits for COORD / GDFILE / ZCORN
2020-10-10 08:30:48 +02:00
Joakim Hove
fa65ce92d8
Allow loading of RstState for restart files without wells
2020-10-09 15:32:45 +02:00
Bård Skaflestad
79ad189d65
Merge pull request #2008 from joakim-hove/schedule-error-msg
...
Schedule error msg
2020-10-09 12:30:01 +02:00
Joakim Hove
d3a44ca543
Add proper error message for ill formed dates keyword
2020-10-09 11:40:15 +02:00
Joakim Hove
b273ef389a
Make sure strings are joined - remove ","
2020-10-09 11:23:41 +02:00
Joakim Hove
c6068f4e17
Merge pull request #2006 from joakim-hove/keyword-interaction
...
Keyword interaction
2020-10-08 17:48:28 +02:00
Joakim Hove
a8b510334e
Merge pull request #2002 from bska/welpi
...
Add Support Infrastructure for WELPI Feature
2020-10-08 17:48:03 +02:00
Bård Skaflestad
70ef0858f7
Store WELPI Scaling Eligibility as Per-Connection Flag
...
Greatly simplifies logic in container class (WellConnection).
Suggested by: [at]joakim-hove
2020-10-08 11:19:04 +02:00
Bård Skaflestad
f384269133
Represent Assigned PI as an optional<>
...
Suggested by: [at]joakim-hove
2020-10-08 11:19:04 +02:00
Bård Skaflestad
a077847f69
Create Fully Non-Defaulted Serialization Test Objects
...
Suggested by [at]akva2.
2020-10-08 11:19:03 +02:00
Bård Skaflestad
fa7d8bc28c
Add Support Infrastructure for WELPI Feature
...
This commit adds logic implementing the static parts of the WELPI
keyword. We internalize the keyword data, record appropriate events
and provide hooks for dynamically adjusting the per-connection
transmissibility factor (Connection::CF()) when those events occur.
We implement support at three levels
- WellConnections:
Add new public member functions prepareWellPIScaling and
applyWellPIScaling which, respectively, creates bookkeeping
data to track those connections which are subject to CF scaling
and actually applies that CF scaling.
- Well:
Add new data member 'productivity_index' which holds the 'WELPI'
data value from the input keyword (converted to SI) and new
member functions updateWellProductivityIndex and
applyWellProdIndexScaling. The first follows the 'update*'
protocol (return 'true' if state change) and assigns new values
to 'productivity_index' while the second uses the stored PI
value and a dynamically calculated effective PI value to rescale
the pertinent connections' CF value.
- Schedule:
Add new member function handleWELPI which internalizes the WELPI
keyword and its data and records WELPI events for subsequent
playback in the simulator layer.
Also add a set of unit tests to exercise the new features at all
levels.
2020-10-08 11:19:03 +02:00
Bård Skaflestad
de5e3d90cd
Miscellaneous Cleanup Changes
...
In particular, include standard library headers as needed, fix
function declarations (operator<<() for Well::WellProductionProperties),
and make a few helper functions 'static' to avoid warnings of the
form "no previous declaration for".
For the Schedule's keyword handlers, also switch to storing member
function pointers directly instead of std::function objects. This
saves space and does not incur function pointer conversions. Use
std::invoke to call those handlers to avoid having to spell out the
'->*' operator.
2020-10-08 11:19:03 +02:00
Bård Skaflestad
36e3a25782
Use Explicit Powers of Two for Events Enumerators
...
Suggested by [at]joakim-hove
2020-10-08 11:19:03 +02:00
Bård Skaflestad
cc22c3bcf3
Remove Duplicated Logic in filterConnections
...
The Schedule::filterConnections() member function contained three
copies of the same loop, possibly as a result of earlier conflict
resolution. Remove two of those loops.
2020-10-08 11:19:03 +02:00
Joakim Hove
732f19d2a2
Merge pull request #2003 from joakim-hove/rst-group2
...
Establish group <-> group relationship when loading from restartfile
2020-10-08 10:59:15 +02:00
Joakim Hove
7b19d9a20a
Add prohibits relation DX <-> DXV and DY <-> DYV
2020-10-08 08:45:23 +02:00
Joakim Hove
bb7941b754
Add keyword requires relationship between TRACERKM and PARTTRAC
2020-10-08 08:40:36 +02:00
Joakim Hove
0dcb31cae5
Use Group constructor when loading from restart file
2020-10-08 08:15:32 +02:00
Joakim Hove
fa24394f69
Establish group <-> group relationship when loading from restartfile
2020-10-08 08:13:17 +02:00
Joakim Hove
cc4f8faa4c
Merge pull request #2005 from bska/wellconnections-empty
...
Add Convenience Predicate WellConnections::empty
2020-10-08 08:05:15 +02:00
Bård Skaflestad
a5a18fea9e
Add Convenience Predicate WellConnections::empty
...
Replace expressions comparing size() to 0 with calls to empty().
2020-10-07 22:29:18 +02:00
Bård Skaflestad
e2da49d028
Merge pull request #2004 from joakim-hove/rst-wellopen
...
Rst wellopen
2020-10-07 21:37:44 +02:00
Joakim Hove
f02ecb472f
Store Value::Shut == -1000 for shut wells in IWEL
2020-10-07 18:38:46 +02:00
Joakim Hove
956dce6be6
rebase fixup
2020-10-07 18:30:38 +02:00
Joakim Hove
00d5421153
Load well status from IWEL when loading restart file
2020-10-07 18:28:11 +02:00
Joakim Hove
a33fd2483f
Updates to well control mode reported in IWEL
...
With this commit the IWEL[ActWCtrl] is assigned a value independently of the
wells OPEN / SHUT status.
With this PR the index enum value Status is used instead of the previously used
item11. Also numerical constants are introduced for eclipse status values for
Shut, Stop, Open and Auto.
2020-10-07 18:28:11 +02:00
Joakim Hove
23faea7b81
Merge pull request #1996 from wito/required-keywords
...
Required and Prohibited Keywords
2020-10-07 09:06:42 +02:00
Joakim Hove
efbfbaa90c
Merge pull request #1999 from joakim-hove/rst-cmode
...
Rst cmode
2020-10-07 09:05:58 +02:00
Atgeirr Flø Rasmussen
de5e91c80c
Merge pull request #2001 from atgeirr/silence-warnings
...
Fix struct/class warning.
2020-10-06 19:32:35 +02:00
Peter Verveer
7e64686b77
Remove or disable tests for RADIAL.
...
These failed due to replacing support for RADIAL by SPIDER.
2020-10-06 18:26:13 +02:00
Atgeirr Flø Rasmussen
a56eb48b85
Fix struct/class warning.
2020-10-06 15:54:11 +02:00
Joakim Hove
20e253a27a
Merge pull request #1997 from joakim-hove/group-constructor
...
Add Group constructor based on RstGroup
2020-10-06 14:52:31 +02:00
Bård Skaflestad
7823045b02
Merge pull request #1995 from bska/prepare-dynamic-ctf
...
Summary/Restart: Get CTF From Simulator
2020-10-06 14:32:07 +02:00
Joakim Hove
1ec834dd71
Add Group constructor based on RstGroup
2020-10-06 13:16:33 +02:00
Williham Williham Totland
90d980a4f6
Adds manipulation of the ParseContext to tests.
2020-10-06 09:58:46 +02:00
Bård Skaflestad
b1abbe831a
Merge pull request #2000 from akva2/janitoring
...
fixed: anonymize globals to avoid shadowing warnings
2020-10-06 08:54:51 +02:00
Arne Morten Kvarving
62c067f462
fixed: anonymize globals to avoid shadowing warnings
2020-10-06 08:23:11 +02:00
Bård Skaflestad
d65b83c28b
Rename Top-Level Loop Function
...
Suggested by [at]joakim-hove
2020-10-05 23:34:01 +02:00
Bård Skaflestad
4956e880a4
Summary/Restart: Get CTF From Simulator
...
This commit switches to getting the output files' connection
transmissibility factor from Opm::data::Connection instead of
Opm::Connection. This is in preparation for implementing the WELPI
feature, in which the CTFs are occasionally adjusted based on the
dynamic simulation state.
2020-10-05 23:34:01 +02:00
Bård Skaflestad
e92d6138f8
Refactor Connection Loop Function
...
In particular, split out the connection loop from the well loop, and
don't make a copy of the wells when we already have a Schedule
object and a "sim_step".
2020-10-05 23:34:01 +02:00
Bård Skaflestad
33d09936c3
Merge pull request #1719 from GitPaean/aquifer_keywords
...
adding aquifer summary keywords
2020-10-05 22:49:32 +02:00
Kai Bao
5c33c39495
addressing reviewing comments for OPM/opm-common#1719
...
using std::any_of instead of std::find_if
2020-10-05 20:55:06 +02:00
Joakim Hove
be898b5534
Merge pull request #1989 from wito/tablemanager-exceptions
...
Implements OpmInputError in TableManager
2020-10-05 17:02:42 +02:00
Joakim Hove
f9a52791a4
Load Water and gas Injection cmode from restart file
2020-10-05 15:23:09 +02:00
Joakim Hove
96fdb150b1
Use named index WInjCMode and GInjCMode
2020-10-05 15:23:02 +02:00
Joakim Hove
001b399d42
Change order of is_field() test
2020-10-05 15:13:37 +02:00
Joakim Hove
acfd917aab
Add production control mode for restart group
2020-10-05 15:06:04 +02:00
Joakim Hove
08f41d4fa2
Add named index ProdCMode for IGRP
2020-10-05 15:06:01 +02:00
Williham Williham Totland
91e863e674
Resolves issue where test data was missing for Eclipse300.
2020-10-05 13:52:09 +02:00
Williham Williham Totland
7aba0cd976
Implements required and prohibited keywords.
2020-10-05 13:34:35 +02:00
Bård Skaflestad
fcdc57d92b
Merge pull request #1994 from joakim-hove/rst-alq
...
Small Changes in restart <-> Schedule interaction
2020-10-05 13:07:15 +02:00
Williham Williham Totland
bd3242fe05
Adds getters/setters for required and prohibited keywords.
2020-10-05 11:37:18 +02:00
Williham Williham Totland
f610ce28a2
Adds test data.
2020-10-05 11:20:56 +02:00
Williham Williham Totland
c43600337b
Throws exception with nesting, and generalises tests to account for same.
2020-10-05 11:06:19 +02:00
Joakim Hove
b9b55bb9b0
Early return in productionGroup()
2020-10-05 10:44:38 +02:00
Joakim Hove
ce463e6020
Extract functions for production and injection when creating IGRP
2020-10-05 10:44:33 +02:00
Joakim Hove
296538c724
Minor rewrite for checking group type
2020-10-05 09:31:02 +02:00
Williham Williham Totland
d0c5fa042c
Adjusts the defaultMessage format string.
2020-10-05 09:26:25 +02:00
Williham Williham Totland
7a8347f1ab
Unifies interface of OpmInputError::OpmInputError()
2020-10-05 08:26:51 +02:00
Kai Bao
aa639869be
adding the development to test ANALYTICAL_AQUIFERS
2020-10-05 07:37:13 +02:00
Williham Williham Totland
690fa8259c
Resolves an issue where the keyword information would not be reflected in the error message.
2020-10-05 07:28:07 +02:00
Williham Williham Totland
fca1764d7a
Resolves #1975 .
2020-10-05 07:28:07 +02:00
Joakim Hove
0f21752a7e
Add test for unsupported keyword in FieldProps operations
2020-10-05 07:28:07 +02:00
Williham Williham Totland
3af6fac35d
Adds a standard-format exception message to OpmInputError.
2020-10-05 07:28:07 +02:00
Williham Williham Totland
65f45b60a8
Extends OpmInputError to support multiple KeywordLocations.
2020-10-05 07:28:07 +02:00
Williham Williham Totland
0f8dec9ac3
Changes TableManager to throw OpmInputError where context permits.
2020-10-05 07:28:07 +02:00
Kai Bao
31e5c494a8
adding aquifer keywords to the summary_ALL test in SummaryConfigTests
2020-10-05 00:28:11 +02:00
Kai Bao
995316e97c
handling unknown aquifer in SUMMARY section
2020-10-05 00:27:28 +02:00
Joakim Hove
47715ae7ae
Move function in source file
2020-10-04 16:01:37 +02:00
Joakim Hove
f8d988d1dd
Rename variable gseqIndex -> insert_index
2020-10-04 16:01:22 +02:00
Joakim Hove
aa54bc67de
Load group->parent_group when loading from restart file
2020-10-04 16:00:50 +02:00
Joakim Hove
5b3a76172b
Store parent_group index when loading restart group
2020-10-04 16:00:15 +02:00
Joakim Hove
c2522fd5ce
Create symbol for IGRP parent group index
2020-10-04 15:59:53 +02:00
Joakim Hove
007ef0e94f
Load well alq value when loading from restart file
2020-10-04 15:33:20 +02:00
Joakim Hove
528548ebce
Set predictionMode for Injection and Production objects
2020-10-04 15:33:18 +02:00
Joakim Hove
00cb2c195d
Merge pull request #1993 from alfbr/remove-supported
...
Remove confusing message
2020-10-04 09:34:03 +02:00
Alf Birger Rustad
2dee1070ef
Remove confusing message
2020-10-03 17:17:13 +02:00
Kai Bao
e86e8796ec
adding a small test for aquifer keywords
2020-10-02 22:32:23 +02:00
Kai Bao
2c0456da8a
fixing the keyword generation for ALL related to Aquifer keywords
2020-10-02 22:27:47 +02:00
Joakim Hove
b9b6033854
Merge pull request #1987 from joakim-hove/arrraydimchecker-fixup
...
Fix bug in ArradDimChecker message
2020-10-02 18:20:54 +02:00
Joakim Hove
26bc6cb2ea
Merge pull request #1980 from joakim-hove/time-keyword-info-logging
...
Time keyword info logging
2020-10-02 18:20:12 +02:00
Joakim Hove
574547a824
Merge pull request #1985 from joakim-hove/create-grid-info
...
Create grid info
2020-10-02 18:19:45 +02:00
Bård Skaflestad
99b2920e5e
Merge pull request #1990 from bska/fix-oob-alq-indexing
...
ALQ Rate: Don't Index Into Empty Vector
2020-10-02 17:41:49 +02:00
Bård Skaflestad
447efffdfa
ALQ Rate: Don't Index Into Empty Vector
...
The list of "schedule" wells is empty in at least one case-when
we're configuring the SMSPEC nodes. Don't blindly assume that there
is always a non-empty sequence of wells.
2020-10-02 16:30:08 +02:00
Tor Harald Sandve
8210bcde34
Merge pull request #1968 from hakonhagland/wglir
...
Add support for WGLIR.
2020-10-02 14:48:18 +02:00
Kai Bao
6093a80dff
fixing the compilation due to interface change
2020-10-02 14:09:01 +02:00
Kai Bao
fd773423b0
adding the following aquifer summary keywords
...
AAQR, AAQT, AAQP
2020-10-02 13:18:51 +02:00
Joakim Hove
1529509efb
Improve error message: WELLDIMS item 4 can be wells/groups
2020-10-02 12:18:52 +02:00
Joakim Hove
1206570da5
Edit msg
2020-10-02 10:30:37 +02:00
Williham Williham Totland
4c016660d8
Logs simulation time advance information (level: info).
2020-10-02 10:30:37 +02:00
Joakim Hove
b3050cfbf5
Fix bug in ArradDimChecker message
2020-10-02 10:03:45 +02:00
Joakim Hove
0ab50fbc95
Merge pull request #1977 from wito/test-warning-noise-fix
...
Test Compilation Warning Noise Fix
2020-10-02 07:56:14 +02:00
Markus Blatt
2f96b9404f
Merge pull request #1986 from joakim-hove/remove-template-args
...
Remove leftover template<...>
2020-10-01 21:07:58 +02:00
Joakim Hove
c0336d5eb7
Remove leftover template<...>
2020-10-01 16:59:50 +02:00
Joakim Hove
963ab6515a
Add info message for grid creation
2020-10-01 15:30:19 +02:00
Joakim Hove
54088db22f
Update warning for MULTREGT in EDIT section
2020-10-01 15:30:19 +02:00
Joakim Hove
3d0ff98865
Add log message for Fault construction
2020-10-01 15:30:19 +02:00
Joakim Hove
5fe9b6476e
Use this->
2020-10-01 15:30:19 +02:00
Joakim Hove
ad993fb82c
Add log info message for tracer loading
2020-10-01 15:30:19 +02:00
Joakim Hove
27687ecc9e
Initialize tracer configuration in initialization list
2020-10-01 15:30:19 +02:00
Joakim Hove
2d2d25fbec
Add log message for Aquifer creation / initialization
2020-10-01 15:30:19 +02:00
Joakim Hove
ac39fa099b
Use fmt::format for message
2020-10-01 15:30:19 +02:00
Joakim Hove
96ce078dfd
Merge pull request #1983 from joakim-hove/private-fmt
...
Mkae sure fmtlib is not a dependency in the public api
2020-10-01 15:24:15 +02:00
Joakim Hove
fbf88e8ce1
Merge pull request #1984 from joakim-hove/remove-value
...
Remove homemade optional - use std::optional
2020-10-01 15:23:55 +02:00
Joakim Hove
6dc84b67df
Remove homemade optional - use std::optional
2020-10-01 13:53:58 +02:00
Joakim Hove
0475ccdb77
Merge pull request #1978 from joakim-hove/schedule-skriprest-refactor
...
Changes in schedule iterate section for restarts
2020-10-01 07:47:50 +02:00
Joakim Hove
5f45f20be6
Merge pull request #1982 from blattms/fix-some-valgrind-warnings
...
Fix some warnings when running with valgrinds MPI wrapper.
2020-09-30 19:43:30 +02:00
Markus Blatt
d99aa0d497
Fix some warnings when running with valgrinds MPI wrapper.
...
It warns whenever uninitialized data is sent.
2020-09-30 18:26:48 +02:00
Joakim Hove
8c351440e8
Mkae sure fmtlib is not a dependency in the public api
2020-09-30 18:17:57 +02:00
Joakim Hove
26f91f0ce0
Merge pull request #1981 from akva2/janitoring
...
Some janitoring
2020-09-30 14:45:11 +02:00
Arne Morten Kvarving
f2d80014ab
anonymize unused parameter
2020-09-30 10:09:15 +02:00
Arne Morten Kvarving
27dc014244
remove unused variables
2020-09-30 10:09:08 +02:00
Joakim Hove
42f1278db3
Changes in restart TimeMap and Schedule::iterateSection
...
This commit changes two aspects of restarts where well and group information is
assembled from the restart file:
o We require the restart date to be present in the Schedule file as a DATES
keyword.
o SKIPREST behavior is implemented unconditionally for restarts with restart
files, even if the SKIPREST keyword is not present.
2020-09-29 23:00:16 +02:00
Joakim Hove
1ae7026a4b
Merge pull request #1946 from joakim-hove/parsecontext-opm-error
...
Parsecontext opm error
2020-09-29 22:15:04 +02:00
Håkon Hægland
7db5d2fd5c
Added WGLIR to SummaryConfigTests.cpp
2020-09-29 15:52:28 +02:00
Joakim Hove
8e247ca6e8
Use new ParseCOntext signature
2020-09-29 15:37:14 +02:00
Joakim Hove
2a812ab7ce
Use OpmInputError
2020-09-29 15:37:14 +02:00
Joakim Hove
a44b174b6b
Remove info messages from Schedule
2020-09-29 15:37:14 +02:00
Alf Birger Rustad
a86cfd21d8
Shortened reading line to make more space for path
2020-09-29 15:37:14 +02:00
Joakim Hove
0512ab88b4
ParseContext will throw OpmInputError
2020-09-29 15:37:14 +02:00
Håkon Hægland
ce4f2a157b
Fixed typo in operator==()
2020-09-29 15:33:59 +02:00
Håkon Hægland
56ab32035a
Added support for ALQ in the serialization.
...
Added support for ALQ in operator==() and Rates::read().
2020-09-29 15:33:59 +02:00
Håkon Hægland
7a4c5cd1c1
Changed "rate" to "gas_surface_rate"
2020-09-29 15:33:59 +02:00
Håkon Hægland
124097abdc
Added FGLIR and GGLIR.
2020-09-29 15:33:59 +02:00
Håkon Hægland
ae6ea4699e
Added WGLIR to SummaryConfig.cpp
2020-09-29 15:33:59 +02:00
Håkon Hægland
10a9a5707c
Add support for WGLIR.
...
Add support for summary output of WGLIR (lift gas injection rate).
2020-09-29 15:33:59 +02:00
Williham Williham Totland
6d2f8cca5c
Adds type information to integer literals.
2020-09-29 13:54:21 +02:00
Joakim Hove
e01400fa18
Add KeywordLocation argument to ParseContext::handleError()
2020-09-29 09:56:07 +02:00
Joakim Hove
94b4c509b1
Add KeywordLocation argument to UDQ parser
2020-09-29 09:56:07 +02:00
Joakim Hove
e8423d3b25
Merge pull request #1969 from wito/keyword-handler-try-catch
...
Exception Catch and Release
2020-09-29 09:54:41 +02:00
Joakim Hove
751e25ff97
Merge pull request #1963 from joakim-hove/tran-calc-condense
...
Tran calc condense
2020-09-29 09:34:28 +02:00
Joakim Hove
a8e3ecef7d
Merge pull request #1974 from totto82/fixRocktab
...
Set number of columns in ROCKTAB to three
2020-09-29 06:57:48 +02:00
Bård Skaflestad
d55d05e552
Merge pull request #1884 from goncalvesmachadoc/outputProdEnergy
...
Add WEPT and WEPR to Summary
2020-09-28 21:52:53 +02:00
Joakim Hove
8848fde48e
Collapse multi record operations on TRAN in one operation
...
The main content of this commit is that for keywords with multiple TRAN
modifications like
MULTIPLY
TRANX 1.50 1 10 1 10 1 1 /
TRANX 2.50 1 10 1 10 2 2 /
/
The different operations are collapes to one entry in tran calculator.
This commit also explicitly throws a std::logic_error() exception if TRAN
manipulations are attempted with the OPERATE keyword or one of the region
keywords ADDREG, MULTIREG, EQUALREG or OPERATER.
2020-09-28 21:44:21 +02:00
Tor Harald Sandve
fc7ccd1603
Set number of columns in ROCKTAB to three
...
Throw if unsuppored directional and stress option is used
2020-09-28 20:54:19 +02:00
Joakim Hove
de61bdefff
Merge pull request #1972 from asnyv/rtemp
...
UNTESTED: Added size: 1 to RTEMP and RTEMPA
2020-09-28 18:32:31 +02:00
Joakim Hove
8e8ba14397
Merge pull request #1973 from bska/uconv-static-tables-size-check
...
Unit Conversion Tables: Add Size Consistency Checking
2020-09-28 18:14:28 +02:00
Joakim Hove
f331add35b
Merge pull request #1966 from joakim-hove/tran-calc-init
...
Tran calc init
2020-09-28 16:55:07 +02:00
Joakim Hove
5fbf725ea8
Merge pull request #1970 from blattms/make-tran-mod-tests-run
...
Make transmissibility modifier tests run
2020-09-28 16:54:08 +02:00
Williham Williham Totland
f5a3ab2cee
Removes (stated) support for named arguments in OpmInputError::format due to UTR test failure.
2020-09-28 16:04:35 +02:00
Cintia Goncalves Machado
76a04c8e48
rebasing
2020-09-28 15:59:20 +02:00
Bård Skaflestad
b7418b419e
Unit Conversion Tables: Add Size Consistency Checking
...
This commit adds a minimum amount of compile-time size checking for
the various arrays that go into defining the conversion factors and
unit strings. Using static_assert() we guarantee that the arrays at
least have the expected size lest the translation unit fail to
compile.
2020-09-28 15:37:28 +02:00
Asgeir Nyvoll
74c3bf82fb
Added size: 1 to RTEMP and RTEMPA
2020-09-28 14:27:22 +02:00
Bård Skaflestad
8d89d277cd
Warn about network nodes without networks.
2020-09-28 14:05:40 +02:00
Joakim Hove
4b8b35e0f0
only warn about unknown summary nodes.
2020-09-28 14:04:39 +02:00
Williham Williham Totland
f76a71cbee
Simplifies logging of error using formatException().
2020-09-28 13:30:15 +02:00
Cintia Goncalves Machado
e23e229fda
addCumToSummaryState
2020-09-28 13:21:19 +02:00
Cintia Goncalves Machado
4e3f5cd0ca
addWTICHEA
2020-09-28 13:21:19 +02:00
Cintia Goncalves Machado
5032d28a0f
addWTPCHEA
2020-09-28 13:21:19 +02:00
Cintia Goncalves Machado
af1043612a
addWEIs
2020-09-28 13:21:19 +02:00
Cintia Goncalves Machado
72efad2a8f
finalizeSummary
2020-09-28 13:21:19 +02:00
Cintia Goncalves Machado
dd4de4130a
addEnergyRatetoUnitSystem
2020-09-28 13:21:19 +02:00
Cintia Goncalves Machado
4a721cffbb
addWEPTandWEPRtoSummary
2020-09-28 13:21:18 +02:00
Williham Williham Totland
805300dd49
Adds some documentation to OpmInputError.hpp.
2020-09-28 13:16:45 +02:00
Williham Williham Totland
9a66acbb5d
Extends OpmInputError to be initialisable from an existing exception.
2020-09-28 13:16:45 +02:00
Williham Williham Totland
742c90cabc
Extends Opm::OpmInputError::OpmInputError() to accept additional format arguments.
2020-09-28 13:16:45 +02:00
Williham Williham Totland
7cb15bd64d
Adds missing test_OpmInputError_format.cpp
2020-09-28 13:16:44 +02:00
Williham Williham Totland
2900da4489
Allow Opm::OpmInputError::format() to accept additional arguments.
...
This removes the need to call `fmt::format()` multiple times on a string, thus eliminating error-prone multi-level escapes when formatting strings.
2020-09-28 13:16:44 +02:00
Williham Williham Totland
05c3d997ac
Catches and logs exceptions in Opm::Schedule::handleNormalKeyword()
2020-09-28 13:16:44 +02:00
Joakim Hove
3036441c8c
Merge pull request #1967 from joakim-hove/throw-opm-error
...
Throw opm error
2020-09-28 12:50:36 +02:00
Joakim Hove
a4038b3d9e
Wrap SummaryConfig construction in try catch
2020-09-28 11:29:27 +02:00
Joakim Hove
5b6e9f7c92
Wrap Schedule construction in try catch
2020-09-28 09:22:56 +02:00
Joakim Hove
1168e616cd
Wrap EclipseState construction in try catch
2020-09-27 23:24:30 +02:00
Joakim Hove
c1ea966548
Add static function OpmInputError::format()
2020-09-27 22:14:53 +02:00
Joakim Hove
8c2ed38cf4
Parse differentiates between OpmInputError and std::exception
2020-09-27 22:00:37 +02:00
Joakim Hove
8e55f3138b
Add multi record test
2020-09-27 10:16:32 +02:00
Joakim Hove
d57d9ea18f
Utility function for operation dependent SI conversion
2020-09-27 10:16:32 +02:00
Joakim Hove
6de1067c45
Make sure to initialize FieldProps::keyword_info for assignment
2020-09-27 10:16:32 +02:00
Joakim Hove
b95fbc4919
Rewrite test to iterate over cartesian coordinates
2020-09-27 10:16:32 +02:00
Joakim Hove
42c711210e
Remove stale struct FieldPropsManager::Meminfo
2020-09-27 10:16:32 +02:00
Joakim Hove
6ee4e5ce9a
Merge pull request #1962 from wito/schedule-keyword-cleanup
...
Various Code Consistency Changes in Schedule.
2020-09-27 10:16:10 +02:00
Joakim Hove
66a9138006
Merge pull request #1965 from joakim-hove/rsm-cmp-eps
...
Increase the epsilon used for comparing summary and rsm files
2020-09-25 23:28:38 +02:00
Joakim Hove
ac4157a66c
Increase the epsilon used for comparing summary and rsm files
2020-09-25 22:08:05 +02:00
Bård Skaflestad
83cfe4b50c
Merge pull request #1964 from wito/iterator-reference-fix
...
Range Variable Correction
2020-09-25 18:22:44 +02:00
Williham Williham Totland
6a8f3e16c0
Corrects range variable to a reference.
2020-09-25 16:20:22 +02:00
Williham Williham Totland
2e8e613722
Makes use of braces consistent within if-else sections.
2020-09-25 15:10:23 +02:00
Williham Williham Totland
e8595a6076
Various whitespace fixes.
2020-09-25 15:07:20 +02:00
Williham Williham Totland
24296bf7ee
Extracts variables that depend only on record to the outer loop.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
e0344b828d
Consts variables.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
29bfdd00bf
Extracts access that depend only on record to the outer loop.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
cd93de5e12
Extracts variables that only depend on record to outer loop.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
ad03a50536
Improves consistency of well_names phrase.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
c19221eab8
Removes temporary variable name.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
fab78873f2
Removes extraneous scope block.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
461d8815a0
Normalises all occurences of size_t to std::size_t
2020-09-25 15:06:08 +02:00
Williham Williham Totland
1de3a84a53
Documents use of the keyword handler dispatcher.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
56e8750d9e
Removes extraneous scope blocks.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
51a8d35788
Normalises if and for clause whitespace.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
d5cd8cf78e
Removes extraneous scope blocks.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
6d6b10a9fa
Normalises indentation and whitespace.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
c17824cead
Removes using namespace shortcuts.
2020-09-25 15:06:08 +02:00
Williham Williham Totland
0d962fc585
Removes some unnecessary includes.
2020-09-25 15:06:08 +02:00
Atgeirr Flø Rasmussen
fbe723a874
Merge pull request #1952 from joakim-hove/cir-negative
...
Cir negative
2020-09-25 14:06:22 +02:00
Joakim Hove
ab68722eca
Merge pull request #1960 from wito/schedule-keyword-handlers
...
Moves keyword handlers from Schedule.cpp to KeywordHandlers.cpp
2020-09-25 13:45:05 +02:00
Joakim Hove
629b561f75
Merge pull request #1957 from totto82/salinity
...
Add keyword SALINITY with unit molality
2020-09-25 12:28:19 +02:00
Williham Williham Totland
86eb1bf94e
Renames handleEXIT to applyEXIT.
2020-09-25 10:12:55 +02:00
Williham Williham Totland
5c49832cd1
Extracts keyword handlers into KeywordHandlers.cpp
2020-09-25 10:02:52 +02:00
Joakim Hove
003537ea77
Merge pull request #1959 from akva2/janitoring
...
add missing initializer to quell warning
2020-09-25 09:52:52 +02:00
Tor Harald Sandve
dfdb844d69
add SALINITY. Unit is molality [mol/kg] for all unit systems
2020-09-25 09:39:11 +02:00
Arne Morten Kvarving
617440485f
remove unused variable
2020-09-25 09:21:09 +02:00
Arne Morten Kvarving
99a6fc30a1
throw to avoid no return value warning
2020-09-25 09:20:57 +02:00
Arne Morten Kvarving
50de318947
add missing initializer to quell warning
2020-09-25 09:18:46 +02:00
Joakim Hove
b6f192b7f2
Merge pull request #1958 from joakim-hove/smry-cmp-verbose
...
Add error message when comparing summary and rsm files
2020-09-25 08:50:32 +02:00
Joakim Hove
2985072083
Add error message when comparing summary and rsm files
2020-09-24 16:45:59 +02:00
Bård Skaflestad
3db68b0731
Merge pull request #1955 from jalvestad/rstfile-imp-v3t
...
Handle WSEGITER keyword data and WELSEGS keyword item 6 for Eclipse compatible restart file
2020-09-24 14:49:34 +02:00
Jostein Alvestad
1b488037e1
added / changed comments to well.hpp to clarify their meaning
2020-09-24 14:37:10 +02:00
Joakim Hove
b9f95089b9
Merge pull request #1949 from joakim-hove/error-prepare
...
Error prepare
2020-09-24 07:33:22 +02:00
Joakim Hove
c7d8d17bf0
Merge pull request #1938 from bska/support-nonmonotone-bo
...
Support Non-Monotonic Saturated Oil FVF in PVTO
2020-09-24 07:19:45 +02:00
Bård Skaflestad
1dd1b71095
PVTO: Switch to Using {fmt} Backend for Formatting
...
This commit switches the custom diagnostic message formatting based
on std::ostringstream to using a formatter implemented in terms of
the fmt::format function. This removes the custom indentation from
earlier. Note that we output at most four records to the console,
including a message limit notification if applicable, and that this
limit is currently not adjustable by the user. We do on the other
hand output all flipped records to the .PRT file.
New Example Diagnostic Output:
* To the Console
Warning: Non-Monotonic Oil Formation Volume Factor Detected in Keyword PVTO, PVTNUM=1
In /path/to/PVTO.INCL line 6
Record 9: FVF 1.234 at RS 123.456 is not greater than FVF 2.345 at RS 121.212
Record 10: FVF 1.233 at RS 123.457 is not greater than FVF 1.234 at RS 123.456
Record 11: FVF 1.233 at RS 123.460 is not greater than FVF 1.233 at RS 123.457
Report limit reached, see PRT-file for additional records.
* In the PRT File (Unlimited Records)
Warning: Non-Monotonic Oil Formation Volume Factor Detected in Keyword PVTO, PVTNUM=1
In /path/to/PVTO.INCL line 6
Record 9: FVF 1.234 at RS 123.456 is not greater than FVF 2.345 at RS 121.212
Record 10: FVF 1.233 at RS 123.457 is not greater than FVF 1.234 at RS 123.456
Record 11: FVF 1.233 at RS 123.460 is not greater than FVF 1.233 at RS 123.457
Record 12: FVF 1.233 at RS 123.461 is not greater than FVF 1.233 at RS 123.460
Record 13: FVF 1.233 at RS 123.470 is not greater than FVF 1.233 at RS 123.461
The length of each 'Record' line is 78 characters as of this change
(assuming METRIC conventions, FIELD conventions not tested). The
length of the 'In ...' line depends on the number of characters in
the full filepath.
2020-09-24 00:43:03 +02:00
Bård Skaflestad
db07a19c68
PVTO: Relax Requirement that Saturated FVF be Strictly Increasing
...
Such cases do happen in real field models and we should diagnose the
existence of non-increasing BO as a function of RS, but we should
not terminate the simulation run.
2020-09-24 00:43:02 +02:00
Bård Skaflestad
1311afb261
PVTO: Add Means of Identifying Non-Monotonic Saturated FVFs
...
This commit introduces a way of diagnosing an uncommon but possible
issue in the PVTO table. If the formation volume factor (BO) in the
saturated table (record 1 of each subtable) does not increase
monotonically as a function of the dissolved gas/oil ratio (RS),
then there is a risk that the simulation run will have convergence
problems.
We add a special purpose member function
PvtoTable::nonMonotonicSaturatedFVF
which checks for this condition and returns a vector records for
which the condition is true. The new member function
TableManager::checkPVTOMonotonicity
then collates these records into a formatted string which is printed
to the console and the .PRT file.
Example Diagnostic Output:
Warning: Non-Monotonic Oil Formation Volume Factor Detected
* PVTO [PVTNUM = 1]
Record 9: FVF 1.23 at RS 123 is not greater than FVF 2.34 at RS 120
Record 10: FVF 1.22 at RS 125 is not greater than FVF 1.23 at RS 123
Record 11: FVF 1.21 at RS 125 is not greater than FVF 1.22 at RS 125
2020-09-24 00:43:02 +02:00
Bård Skaflestad
b5b1588a17
PVTXTable: Fix Documentation
...
In particular, refer to "pvtnum" instead of "satnum". While here,
also include a number of headers that are needed for idempotency.
2020-09-24 00:43:02 +02:00
Joakim Hove
4114302055
Merge pull request #1954 from akva2/mark_libfmt_system
...
changed: mark libfmt headers as system to avoid warnings
2020-09-23 23:06:45 +02:00
Joakim Hove
2e20dc5d43
Merge pull request #1923 from totto82/co2storage
...
Add CO2STOR keyword in Runspec section
2020-09-23 14:36:18 +02:00
Joakim Hove
7d226bf600
Merge pull request #1926 from joakim-hove/udq-in-actionx
...
Udq in actionx
2020-09-23 14:35:01 +02:00
Arne Morten Kvarving
70d13b7427
changed: mark libfmt headers as system to avoid warnings
2020-09-23 14:05:50 +02:00
Joakim Hove
341d14519b
Allow negative injection rates for completions
2020-09-23 13:17:55 +02:00
Arne Morten Kvarving
ef412cd759
added: put a GPMaint instance in Group's serializeObject()
...
now the serialization is tested.
2020-09-23 13:04:10 +02:00
Jostein Alvestad
dc97e71350
various updates of unit tests
2020-09-23 13:03:21 +02:00
Jostein Alvestad
2efa272f6e
removed comments
2020-09-23 13:03:19 +02:00
Jostein Alvestad
e8803220ca
added changes to account for WSEGITER parameters to the Ecl-rst-file
2020-09-23 13:03:18 +02:00
Jostein Alvestad
772cc7b265
initial changes to add WSEGITER keyw-data to restart file
2020-09-23 13:03:16 +02:00
Jostein Alvestad
9a2410ddb2
corrections to IWEL for pressure loss model and multiphase model
2020-09-23 13:03:14 +02:00
Joakim Hove
6eb9eb8414
Merge pull request #1950 from joakim-hove/deckoutput-dont-split
...
Special case output of UDQ and ACTIONX keywords - no split
2020-09-23 12:29:42 +02:00
Joakim Hove
9887cc01af
Merge pull request #1882 from bska/add-guiderate-restart
...
Unconditionally Output Guiderates to Restart File
2020-09-23 12:00:27 +02:00
Joakim Hove
aefa3cd9d2
Support defining new UDQ keywords inside ACTIONX block
2020-09-23 11:30:09 +02:00
Joakim Hove
59b59ce3ee
Add location member to Welldims class
2020-09-23 11:06:03 +02:00
Bård Skaflestad
7875aedd7f
Required Vectors: Simplify Well/Group Loop Bodies
...
Pass along the set of category-specific "extra" vectors to
'makeEntities' to avoid repeating the "extra" calls at each of the
well, group, and field levels.
2020-09-22 22:23:05 +02:00
Bård Skaflestad
e57c98d475
Output Guiderate Values to Restart File
...
This commit ensures that we also always output guiderate values to
the restart file. Always calculating these summary quantities we
leverage the restart output support added in commit 317d1ba14 (i.e.,
in PR #1792 ).
2020-09-22 22:23:05 +02:00
Markus Blatt
d60a91c3dd
Merge pull request #1932 from blattms/tran-calculator-2
...
Adds a calculator for modifying transmissibilities.
2020-09-22 19:56:12 +02:00
Joakim Hove
b184b0e9e5
Merge pull request #1942 from joakim-hove/opm-error
...
Opm error
2020-09-22 18:01:14 +02:00
Tor Harald Sandve
f3e209b740
Add CO2STOR keyword in Runspec section
2020-09-22 14:53:35 +02:00
Joakim Hove
0bbcee1cc8
Merge pull request #1944 from bska/nodepress-summary-output-2
...
Add Support for 'GPR' (Network Node Pressure) Summary Keyword
2020-09-22 14:44:14 +02:00
Joakim Hove
d300e54700
Special case output of UDQ and ACTIONX keywords - no split
2020-09-22 14:22:06 +02:00
Joakim Hove
719af02142
Add custom exception OpmInputError
2020-09-22 13:48:26 +02:00
Joakim Hove
f604f94e89
Document format placeholders in KeywordLocation
2020-09-22 12:38:09 +02:00
Bård Skaflestad
2d3432a9e0
Summary: Add Support for 'GPR' (Network Node Pressure) Keyword
...
This commit adds an evaluation function for the GPR summary vector.
We assume that the actual value is calculated elsewhere and passed
in unchanged from the caller of Summary::eval(). We therefore need
only convert the value to output units and hook this procedure up to
the table of known output functions.
Add a simple unit test for demonstration.
2020-09-22 10:08:44 +02:00
Bård Skaflestad
d46628e8a1
Summary Config: Recognize Subset of Node-Level Keywords
...
This commit adds support for recognizing a small subset of the
summary quantities that are reported at the node level of an
extended network--especially the 'GPR' keyword.
Briefly, we add a new 'Node' config category and a processor for
this category which knows about the distinction between nodes and
groups. It uses member function ExtNetwork::node_names() to produce
configuration nodes whose named entity is the node rather than a
group. Deriving this list of node names across all timesteps is
potentially expensive, so perform this operation at most once and
pass the result into the processor from the SummaryConfig
constructor.
Add a simple unit test for demonstration purposes.
2020-09-22 10:08:44 +02:00
Bård Skaflestad
4aab3ca7d0
Parse Context: Add Context for Missing Network Node
...
Will be used in SummaryConfig for reporting the case of node-level
summary output being requested for unknown/missing network nodes.
2020-09-22 10:08:44 +02:00
Joakim Hove
11d5128cbf
Use KeywordLocation instead of passing keyword and filename separately
2020-09-22 09:55:45 +02:00
Joakim Hove
fe2f5ee185
Keep track of maximum size of RawRecord
2020-09-22 09:55:45 +02:00
Joakim Hove
0530b9b1a3
Merge pull request #1943 from wito/schedule-keyword-functions
...
Schedule Keyword Handler Dispatch
2020-09-22 09:32:47 +02:00
Markus Blatt
57dde8051d
Merge pull request #1945 from blattms/fix-fmtlib
...
Also remove fmtlib from opm-common-prereqs.cmake
2020-09-22 07:53:25 +02:00
Williham Williham Totland
7a7920f3e7
Implements a new dispatcher for keywords in Schedule.
2020-09-21 19:22:11 +02:00
Markus Blatt
396bfbbcd2
Also remove fmtlib from opm-common-prereqs.cmake
...
Otherwise the user still needs to have an installed version on the system
in addition.
2020-09-21 15:46:01 +02:00
Joakim Hove
ee4ac770af
Merge pull request #1941 from joakim-hove/rm-sim-container
...
Remove unused class SimulationDataContainer
2020-09-21 11:15:36 +02:00
Atgeirr Flø Rasmussen
045f527c5d
Merge pull request #1940 from bska/nodepress-summary-output
...
Prepare for Outputting Network Node Pressure to Summary File
2020-09-21 09:21:59 +02:00
Joakim Hove
79ae4c7935
Remove unused class SimulationDataContainer
2020-09-21 08:18:51 +02:00
Bård Skaflestad
dbfd013cf4
Add Means of Retrieving Node Names from Extended Network
...
This commit adds a new member function
ExtNetwork::node_names() const
which collects the names (std::string) of all nodes in a network.
The immediate use case is creating summary config nodes for network
level quantities specified without explicit lists of nodes, e.g.,
GPR
/
Add a simple unit test for demonstration.
2020-09-20 17:46:01 +02:00
Bård Skaflestad
6ea0e73512
Prepare for Creating Network-Level Summary Output
...
This commit adds a level of indirection to the existing group-level
data (active controls and guiderates), and adds a new 'NodeData'
level to the 'data::' protocol for transporting values from the
simulator to the output layer.
Update all call sites and users accordingly.
2020-09-20 17:46:01 +02:00
Markus Blatt
9343165bee
Move factored out stuff to FieldProps namespace.
...
- FieldData
- ScalarOperation
- TranCalculator
- keywords
2020-09-18 16:20:33 +02:00
Joakim Hove
ac40c65f64
Merge pull request #1933 from joakim-hove/throw-same
...
Rethrow the same exception
2020-09-18 15:28:05 +02:00
Joakim Hove
b8c4a2ed83
Merge pull request #1937 from joakim-hove/embed-fmtlib
...
Embed fmtlib
2020-09-18 15:26:44 +02:00
Joakim Hove
b09db0325d
Use fmtlib for string formatting in opmhash
2020-09-18 11:23:43 +02:00
Joakim Hove
4e5aed45d7
Embed fmtlib source code
2020-09-18 11:23:30 +02:00
Joakim Hove
3004e14e9a
Remove use fmtlib package from build system
2020-09-18 11:19:41 +02:00
Joakim Hove
f9d43e738a
Merge pull request #1936 from akva2/fix_packaging_libfmt
...
fix packaging files for libfmt
2020-09-18 10:14:05 +02:00
Arne Morten Kvarving
86d166756a
fix packaging files for libfmt
2020-09-18 08:21:13 +02:00
Joakim Hove
f51533907f
Merge pull request #1935 from bska/final-runsum-only
...
Don't Write RSM File for Substeps
2020-09-18 07:22:17 +02:00
Bård Skaflestad
50e4f9439b
Don't Write RSM File for Substeps
...
If the last report step happens to be split into multiple substeps
(e.g., convergence problems or TUNING settings &c), then we will
write the RSM file for each substep which will slow down the
process. This commit explicitly ensures that we don't output the
RSM file unless it is the last substep of the final report step.
2020-09-18 01:43:20 +02:00
Markus Blatt
951bd69522
Allow access to field data assoicated with TranCalculator.
...
We need this in opm-simulators where we need to query the
FieldProperties associated with the TranCalculator (e.g. TRANX0). Previously,
this were listed by FieldPropertiesManager::keys() but calling
get_int_field_data with the keyword would raise an exception resulting
in a deadlock.
This commit allows passing true as an additional argument to prevent
this (it gets passed to all functions called). This allows for running
with edited transmissibilities in parallel.
2020-09-17 22:20:36 +02:00
Markus Blatt
98f0b36b21
indclude algoritm header in FieldData.hpp
...
needed for std::find_first_of.
2020-09-17 20:23:58 +02:00
Joakim Hove
629da97d61
Rethrow the same exception
2020-09-17 18:54:31 +02:00
Markus Blatt
d3d91c2a08
Added ADD modifier for TranCalculator.
2020-09-17 16:40:10 +02:00
Markus Blatt
e6893caa89
Added support for MINVALUE to calculator.
2020-09-17 16:33:31 +02:00
Markus Blatt
7bdf49f15e
Fixes MAXVALUE modifyer for transmissibility.
2020-09-17 16:26:06 +02:00
Markus Blatt
5ea65651ac
Fix test for MAXVALUE.
2020-09-17 16:02:25 +02:00
Joakim Hove
403fd09e69
Merge pull request #1930 from joakim-hove/fmtlib
...
Add build dependency on fmtlib
2020-09-17 15:40:39 +02:00
Joakim Hove
9e7c808524
Add libfmt dependencies to package specifications
2020-09-17 15:31:16 +02:00
Joakim Hove
bafdbc35cc
Add dependency to header only fmtlib
2020-09-17 14:57:40 +02:00
Markus Blatt
6a81e4bb63
Complete checks for TransCalculator.
2020-09-17 12:54:15 +02:00
Markus Blatt
d83790164d
make tran_active non-throwing.
2020-09-17 12:54:15 +02:00
Markus Blatt
3a6cd37db1
Make apply_tran and deserialize_tran accessible as free functions.
...
In the simulator we are using different datastructures to hold them.
Hence we need to be able to apply and deserialize there.
2020-09-17 12:29:37 +02:00
Markus Blatt
e9be39d666
Add access for int and double FieldData.
...
This is needed for communication in the simulator. Previously,
that just used the data (std::vector), but the TranCaclulator
also needs the value_status to correctly. Hence this needs
to be communicated, too.
2020-09-17 11:46:17 +02:00
Markus Blatt
967f63479d
Move FieldData to its own header for usage from simulator.
...
We need to refactor to make FieldData accessible from the simulator
for running in parallel with the TranCalculator.
2020-09-17 11:46:17 +02:00
Markus Blatt
1bb4c937a2
Move TranCalculator to its own header.
...
We need to refactor to make FieldData accessible from the simulator
for running in parallel with the TranCalculator.
2020-09-17 11:46:17 +02:00
Markus Blatt
16b946b199
Move keywords to their own header file.
...
We need to refactor to make FieldData accessible from the simulator
for running in parallel with the TranCalculator.
2020-09-17 11:46:17 +02:00
Joakim Hove
519e65d32c
Add documentation
2020-09-17 11:46:17 +02:00
Joakim Hove
8499c9d1cd
Add tran_active() query function
2020-09-17 11:46:17 +02:00
Joakim Hove
4bd9b7212f
Add serialization of FieldProps TRAN calculators
2020-09-17 11:46:17 +02:00
Joakim Hove
ecee4a7d36
Adds a calculator for modifying field properties in the edit section.
...
Previously modifications were applied directly to the field
properties. Unfortunately, for unset TRANX this resulted in
modifying 1.0 even if the simulator is calculating
transmissibilities itself. This was one of the reasons
why we got wrong results (others are in the simulator code).
Now these operations recorded in a calculator which can later be
applied to compressed arrays using apply_tran.
2020-09-17 11:40:56 +02:00
Bård Skaflestad
0935aae02c
Merge pull request #1929 from bska/capture-raw-sfunc-vals
...
Saturation Functions: Add Means of Retrieving Select Function Values
2020-09-17 11:02:22 +02:00
Bård Skaflestad
df1f03e4a8
SatFunc: Add Means of Retrieving Select Function Values
...
This commit introduces a new helper structure, RawFunctionValues,
which collects unscaled saturation function values that are needed
for vertical scaling of saturation functions using keywords such as
KRO, KRORG, KRGR, PCW
and their hysteretic and directional counterparts. We also
introduce a new helper function, getRawFunctionValues, which
extracts those values from the function tables in TableManager.
Add a set of unit tests to exercise the new feature.
2020-09-17 08:33:42 +02:00
Bård Skaflestad
07780a793f
Field Props Test: Fix Minor Compiler Warnings
...
In particular, fix a few instances of "signed vs. unsigned"
comparisons, one "no previous declaration for", and include the
<algorithm> header for std::find().
2020-09-17 08:16:37 +02:00
Bård Skaflestad
7a2350bc3c
Merge pull request #1922 from joakim-hove/dynamicstate-update-equal
...
Dynamicstate update equal
2020-09-17 08:03:29 +02:00
Bård Skaflestad
fb93e08ef0
Merge pull request #1928 from hakonhagland/liftopt_4
...
Add get method for LIFTOPT item 4.
2020-09-17 08:00:51 +02:00
Bård Skaflestad
60f6c26456
Merge pull request #1924 from joakim-hove/keyword-location
...
Keyword location
2020-09-16 23:35:09 +02:00
Bård Skaflestad
9765ba9d3f
Merge pull request #1927 from joakim-hove/add-timestep
...
Unconditionally add "TIMESTEP" to SummaryState
2020-09-16 23:24:38 +02:00
Håkon Hægland
672eb6e689
Add get method for LIFTOPT item 4.
2020-09-16 21:20:58 +02:00
Joakim Hove
c334245d08
Unconditionally add "TIMESTEP" to SummaryState
2020-09-16 19:33:04 +02:00
Joakim Hove
0d85293fcc
Merge pull request #1925 from akva2/fix_nupcol_serialization
...
fixed: serialization nupcol in Runspec
2020-09-16 17:12:03 +02:00
Joakim Hove
b61f87ddaa
Add message function to KeywordLocation
2020-09-16 15:14:44 +02:00
Arne Morten Kvarving
08df29c991
fixed: serialization nupcol in Runspec
...
also add it to comparison operator
2020-09-16 14:59:26 +02:00
Joakim Hove
d283f1858f
Add keyword member to KeyworLocation
2020-09-16 14:24:06 +02:00
Joakim Hove
bef5a4c27b
Renamed class Location -> KeywordLocation
2020-09-16 14:06:54 +02:00
Joakim Hove
a023d4b437
DynamicState::find will return std::optional<std::size_t>
2020-09-16 11:59:03 +02:00
Joakim Hove
e03a97b539
DynamicState::update_equal() will return index of next value
2020-09-16 09:55:09 +02:00
Atgeirr Flø Rasmussen
891fda8e79
Merge pull request #1921 from akva2/implement_node_serialize_object
...
fixed: implement Node::serializeObject
2020-09-16 09:42:10 +02:00
Joakim Hove
ae8dc1a770
Merge pull request #1920 from totto82/scaleAlq
...
scaling of the Alq values
2020-09-16 09:27:59 +02:00
Arne Morten Kvarving
37fcfe4379
fixed: implement Node::serializeObject
2020-09-16 08:57:06 +02:00
Tor Harald Sandve
ca2dfc6136
scaling of the Alq values
2020-09-16 07:56:05 +02:00
Bård Skaflestad
867fed3288
Merge pull request #1880 from bska/fix-gr-calc
...
Refactor Damping Factor Implementation
2020-09-15 15:11:36 +02:00
Bård Skaflestad
245a3aa09e
GuideRate: Add Test Case for Revised get() Implementation
2020-09-15 10:15:11 +02:00
Bård Skaflestad
8a87914740
Don't Repeatedly Calculate Same Guiderate Value
...
Doing so works reduces the impact of the damping factor.
2020-09-15 10:15:10 +02:00
Bård Skaflestad
7649df53a2
GuideRate: Revise Damping Factor Implementation
...
This commit centralises the way we incorporate damping factors (item
10 of the GUIDERAT keyword) into the calculation of group/well guide
rates. In particular, we create a structure that manages both the
current and the previous (damped) guiderate values and ensures that
the new guiderate value is
GR_p = f*GR_p' + (1 - f)*GR_p^{n-1}
with GR_p' denoting the "raw" guiderate value calculated directly
from potential rates at the current timelevel (n). GR_p^{n-1} is
the damped-and previously used-guiderate value from timelevel n-1.
Finally 'f' denotes the damping factor. This is the same approach
used previously, but with some small changes to exclude zero-valued
guiderates.
We furthermore remove one of the early returns in GuideRate::get().
There is no need to return the nominated phase's guiderate value if
the model phase rate is very low and doing so produces incorrect
water guiderates for the OPL5 well in the MOD4_GRP test case.
2020-09-15 10:15:10 +02:00
Bård Skaflestad
3080b9c7f6
RateVector: Forward 'eval' Calls to GuideRateModel::Target Overload
...
Avoids having to repeat the implementation for wells and groups.
2020-09-15 10:15:08 +02:00
Bård Skaflestad
a4d07b5c57
Merge pull request #1918 from joakim-hove/internalize-summary-region
...
Make sure R__xxx keywords are recognized in Summary writer
2020-09-15 09:08:32 +02:00
Joakim Hove
03f9a73f43
Make sure R__xxx keywords are recognized in Summary writer
2020-09-14 23:05:03 +02:00
Bård Skaflestad
98ec42f472
Merge pull request #1874 from totto82/fixwsaltunit
...
Fix unit for salt concentration in WSALT
2020-09-14 15:40:48 +02:00
Bård Skaflestad
764149182d
Merge pull request #1917 from akva2/janitoring
...
Some janitoring
2020-09-14 13:26:09 +02:00
Arne Morten Kvarving
518c219838
remove unused variable
2020-09-14 12:23:31 +02:00
Arne Morten Kvarving
80b98934c3
add missing initializers
2020-09-14 12:13:04 +02:00
Arne Morten Kvarving
2c2f848c54
remove unused function
2020-09-14 12:05:34 +02:00
Joakim Hove
5557debd9c
Merge pull request #1916 from joakim-hove/summary-config-keywords
...
Add method SummaryConfig::keywords( pattern )
2020-09-14 10:55:27 +02:00
Joakim Hove
791726398e
Fix warning
2020-09-14 09:17:53 +02:00
Joakim Hove
db64c858d1
Add method SummaryConfig::keywords( pattern )
2020-09-14 09:17:53 +02:00
Tor Harald Sandve
02031a00e6
add salinity to unitSystem
2020-09-14 08:22:21 +02:00
Tor Harald Sandve
32a47bf79a
Fix unit for salt concentration in WSALT
2020-09-14 08:22:21 +02:00
Cintia Goncalves Machado
296fa9ed51
updateSpider
2020-09-11 14:49:33 +02:00
Cintia Goncalves Machado
2ca0985057
addSpiderweb
2020-09-10 17:01:13 +02:00
Joakim Hove
20a6a522dc
Merge pull request #1891 from joakim-hove/summary-region
...
Add basic support for xxx_REG summary keywords
2020-09-10 09:23:33 +02:00
Joakim Hove
c3f94834c3
Add wildcard matching of keywords in SummaryConfig
2020-09-10 08:23:42 +02:00
Joakim Hove
dad067835c
RegionCache object can manage multiple fip regions
2020-09-10 08:23:42 +02:00
Joakim Hove
d5a21427b4
Add fip_region to summary context argument
2020-09-10 08:23:42 +02:00
Joakim Hove
3587c0c6b7
Add fip_region member to SummaryNode
2020-09-10 08:23:42 +02:00
Joakim Hove
5976efa953
Add fip regioin name to summaryconfig node
2020-09-10 08:23:42 +02:00
Bård Skaflestad
53ce21cf9e
Merge pull request #1911 from joakim-hove/udq-assign
...
Udq assign
2020-09-09 23:29:09 +02:00
Bård Skaflestad
d4ae7e706d
Merge pull request #1905 from joakim-hove/fp-global2
...
Enable some support for global keywords
2020-09-09 23:26:51 +02:00
Joakim Hove
03d387c12d
Enable global storage for keywords
2020-09-09 21:41:08 +02:00
Joakim Hove
5a060910a3
Differentiate better between UDQ ASSIGN and UDQ DEFINE
...
A quite typical situation is that a UDQ keyword is first initialized with UDQ
ASSIGN statement, and then subsequently a formula for updates every timestep is
entered with UDQ DEFINE:
UDQ
ASSIGN FU_VAR1 0 /
DEFINE FU_VAR1 FU_VAR1 + 1 /
/
Then the assign statement should be run once, and the define formula should be
evaluated for every subsequent timestep.
2020-09-09 21:39:29 +02:00
Bård Skaflestad
49460edf39
Merge pull request #1914 from joakim-hove/add-timestep
...
Add TIMESTEP as context variable in summary eval
2020-09-09 21:19:31 +02:00
Joakim Hove
fc1e245ea4
Add TIMESTEP as context variable in summary eval
2020-09-09 19:42:42 +02:00
Bård Skaflestad
5553b36c7d
Merge pull request #1912 from joakim-hove/fmwpa
...
Add functionality for FMWPA - number of abondoned wells
2020-09-09 18:26:43 +02:00
Joakim Hove
a4d8379687
Support abondoned well keyword FMWPA in Summary
2020-09-09 17:10:53 +02:00
Joakim Hove
943e3a656d
Request FMWPA output in test deck
2020-09-09 16:44:57 +02:00
Joakim Hove
8c2d74f348
Change to msim: set rates explicitly to zero for closed wells
2020-09-09 16:44:57 +02:00
Bård Skaflestad
eb5787fd54
Merge pull request #1913 from joakim-hove/first-production
...
First production
2020-09-09 16:15:58 +02:00
Joakim Hove
2f3ba50ca6
Add boolean flag to indicate whether a well has been an open producer
2020-09-09 15:07:55 +02:00
Joakim Hove
660d5ae3a7
Fix error message
2020-09-09 15:06:51 +02:00
Joakim Hove
c82be02ef8
Merge pull request #1910 from joakim-hove/udq-misc
...
Udq misc
2020-09-08 11:05:21 +02:00
Joakim Hove
fa70d457f3
Merge pull request #1909 from atgeirr/remove-unused-function
...
The distribute_toplayer() is unused.
2020-09-08 10:58:56 +02:00
Joakim Hove
4a9ec1403e
UDQ: get from an unknown summary variable throws std::out_of_range
2020-09-08 08:23:45 +02:00
Joakim Hove
aeb55ec72e
Pass global process parameters as mutable value
2020-09-08 08:23:45 +02:00
Joakim Hove
8d11a04033
Add report_step argument to UDQConfig::eval()
2020-09-08 08:23:45 +02:00
Atgeirr Flø Rasmussen
859182f7f0
The distribute_toplayer() is unused.
...
Note that there is still a member function of the same name.
2020-09-07 15:51:35 +02:00
Bård Skaflestad
b22304b7ba
Merge pull request #1906 from joakim-hove/correct-default
...
Fieldprops: Correct default
2020-09-06 18:30:46 +02:00
Bård Skaflestad
05dde86f55
Merge pull request #1908 from joakim-hove/udq-fixup
...
Udq fixup
2020-09-06 18:22:12 +02:00
Joakim Hove
7969dfd721
Fix bug with init/create of FIP keywords
2020-09-05 13:54:17 +02:00
Joakim Hove
42fcb4507f
FieldProps::get_global<T> will fill with correct default value
2020-09-05 11:52:22 +02:00
Joakim Hove
0a9babfa9a
Move get_global functionality down to FieldProps
2020-09-05 11:52:01 +02:00
Joakim Hove
109a87e4ee
Update user_defined regexp to allow '?U_?'
2020-09-05 11:46:41 +02:00
Joakim Hove
1bb96ffed2
Set up default stdout logging for msim simulator
2020-09-05 11:33:03 +02:00
Joakim Hove
c7308381d0
Merge pull request #1907 from joakim-hove/remove-designated
...
Remove use of designated initializer
2020-09-05 11:32:47 +02:00
Joakim Hove
4d29b2921a
Remove use of designated initializer
2020-09-05 10:41:52 +02:00
Joakim Hove
1989eac79d
Merge pull request #1900 from joakim-hove/fp-global
...
Reorganize field properties metadata
2020-09-05 08:46:49 +02:00
Joakim Hove
a765cd26ea
Reorganised metadata for field properties
2020-09-04 14:31:40 +02:00
Bård Skaflestad
1b7fab4bd1
Merge pull request #1904 from joakim-hove/box-global-list
...
Box global list
2020-09-03 23:51:08 +02:00
Joakim Hove
ae049a927f
Add accessor method for *all* cells in a Box
2020-09-03 21:12:29 +02:00
Joakim Hove
a5bb313394
Remove unused index member from Box class
2020-09-03 16:49:29 +02:00
Bård Skaflestad
da1c2d3c8b
Merge pull request #1903 from joakim-hove/change-default
...
Changed default value of WSEGITER::MAX_WELL_ITERATIONS
2020-09-03 14:14:23 +02:00
Joakim Hove
c54a57d593
Changed default value of WSEGITER::MAX_WELL_ITERATIONS
2020-09-03 13:11:18 +02:00
Atgeirr Flø Rasmussen
1cdebaef30
Merge pull request #1902 from atgeirr/fix-missing-include
...
Add missing <string> include.
2020-09-03 11:29:22 +02:00
Atgeirr Flø Rasmussen
873ad61e23
Add missing <string> include.
2020-09-03 10:41:20 +02:00
Bård Skaflestad
f8f5987aff
Merge pull request #1901 from akva2/missing_boost_include
...
fixed: add missing include for boost version
2020-09-03 10:02:07 +02:00
Arne Morten Kvarving
40c2c00d58
fixed: add missing include for boost version
2020-09-03 09:20:49 +02:00
Bård Skaflestad
ae91ede665
Merge pull request #1871 from bska/add-guiderate-summary
...
Add Guiderate Summary Output
2020-09-03 09:20:36 +02:00
Bård Skaflestad
084aa69641
Add Guiderate Summary Output
...
This commit adds support for outputting the guiderate summary
vectors
[GW][OGWV]PGR, [GW][GW]IGR
under the assumption that the values are fully calculated at another
level and that we therefore only need to extract the numerical
values and convert the rate units to output conventions. We assume
that such values are communicated to the summary output layer by
means of a 'GuideRateValue' object.
The assumption of values already being calculated leads to a small
change in the 'need_wells()' function. We're now able to exclude
guiderate values at the group level from those vectors that require
setting up a well vector. This is a (tiny) performance improvement.
2020-09-03 01:04:15 +02:00
Bård Skaflestad
746bb15681
Merge pull request #1887 from joakim-hove/udq-undefined
...
Udq undefined
2020-09-03 00:50:26 +02:00
Joakim Hove
11e70ca779
Handle undefined UDQ expressions
2020-09-02 23:03:03 +02:00
Bård Skaflestad
a74855f74b
Merge pull request #1899 from joakim-hove/serialize-empty-string
...
Handle empty strings in serializer
2020-09-02 09:37:53 +02:00
Joakim Hove
e99e2c5e82
Handle empty strings in serializer
2020-09-02 07:49:04 +02:00
Bård Skaflestad
015d8ff923
Merge pull request #1898 from akva2/janitoring
...
Some janitoring
2020-09-01 18:02:01 +02:00
Arne Morten Kvarving
efedbffe63
let compiler deal with copy-ellusion
2020-09-01 15:28:12 +02:00
Arne Morten Kvarving
39db643dd3
quell warning with boost >= 1.71
...
header was relocated
2020-09-01 15:25:44 +02:00
Arne Morten Kvarving
44f29eb4f7
add explicit copy-constructors
...
implicitly generated copy constructors are deprecated in C++11,
if the class already has an assignment operator.
quells warnings with modern gcc/clang.
2020-09-01 15:25:44 +02:00
Arne Morten Kvarving
acad356e2d
remove unused variable
2020-09-01 15:25:44 +02:00
Joakim Hove
076bc3107b
Merge pull request #1896 from joakim-hove/add-udq-state
...
Add UDQState argument to output writer
2020-09-01 15:07:14 +02:00
Joakim Hove
8b23b572cd
Merge pull request #1895 from joakim-hove/serializer
...
Serializer class
2020-09-01 14:15:52 +02:00
Joakim Hove
3b0e795e0b
Add UDQState argument to output writer
2020-09-01 13:18:59 +02:00
Joakim Hove
4b3304730c
Serializer class: SummaryState & UDQState
2020-09-01 13:15:42 +02:00
Joakim Hove
432f666768
Merge pull request #1897 from joakim-hove/add-wsegiter
...
Add wsegiter
2020-09-01 13:11:20 +02:00
Joakim Hove
53f78a02fe
Internalize WSEGITER settings in Tuning implementation
2020-08-31 18:24:09 +02:00
Joakim Hove
71ba9ae6fd
Remove DynamicState<..> access to Tuning class
2020-08-31 17:25:40 +02:00
Joakim Hove
24b66d8bb4
Merge pull request #1889 from joakim-hove/udq-state
...
Udq state
2020-08-31 07:35:14 +02:00
Bård Skaflestad
bb8c1f192f
Merge pull request #1894 from GitPaean/code_compatibility
...
rewriting a for loop for intel compilers
2020-08-28 12:29:48 +02:00
Kai Bao
1927e305ed
rewriting a for loop for intel compilers
2020-08-28 11:37:04 +02:00
Joakim Hove
0161f50255
Add UDQState
2020-08-27 17:25:51 +02:00
Joakim Hove
8b2363b940
Merge pull request #1885 from joakim-hove/udq-uadd
...
Correctly parse and handle UADD / UMUL / UMIN / UMAX set operations
2020-08-27 17:11:25 +02:00
Joakim Hove
7894a21749
Merge pull request #1892 from joakim-hove/fp-fipxxx
...
Allow FIPxxx keywords in FieldProps manager
2020-08-27 17:11:05 +02:00
Joakim Hove
8b718ef0e1
Merge pull request #1890 from joakim-hove/extract-udq-eval
...
Remove call to udq::eval() from Summary::eval()
2020-08-27 17:09:28 +02:00
Joakim Hove
168aa5602d
Make sure DEFINE statements are evaluated in input order
2020-08-27 15:24:32 +02:00
Joakim Hove
718e00ca1f
Correctly parse and handle UADD / UMUL / UMIN / UMAX set operations
2020-08-27 15:24:32 +02:00
Joakim Hove
1cf069c837
Merge pull request #1886 from joakim-hove/udq-tokens
...
Fix UDQ parsing for mix of '*' and *
2020-08-27 15:22:25 +02:00
Joakim Hove
76e8805d92
Merge pull request #1893 from joakim-hove/remove-require-fipnum
...
Remove function SummaryConfig::requireFIPNUM
2020-08-27 13:56:36 +02:00
Joakim Hove
dee69e78c3
Remove function SummaryConfig::requireFIPNUM
2020-08-27 11:55:17 +02:00
Joakim Hove
e00516842c
Allow FIPxxx keywords in FieldProps manager
2020-08-26 08:52:12 +02:00
Joakim Hove
b9ca9c3d47
Remove call to udq::eval() from Summary::eval()
2020-08-25 16:27:46 +02:00
Bård Skaflestad
98c9ce7abd
Merge pull request #1888 from joakim-hove/udq-scalar-optional
...
Use std::optional<double> in UDQScalar
2020-08-24 09:35:13 +02:00
Joakim Hove
9ccc9a72e4
Use std::optional<double> in UDQScalar
2020-08-24 06:59:11 +02:00
Joakim Hove
6c2563c5a5
Fix tokenizer bug with mix of '*' and *
...
The token '*' should be interpreted as all wells/groups for a variable like WOPR
or GGPR, whereas the naked * is a multiplication sign. This commit fixes a bug
where the all wells/groups token '*' would be incorrectly interpreted as a
multiplication sign.
2020-08-23 08:31:15 +02:00
Joakim Hove
f608487772
Merge pull request #1883 from bska/use-wmctl-rstval
...
Restart Wells: Use IWEL WMCTL Values as Switch Cases
2020-08-20 15:30:57 +02:00
Bård Skaflestad
af362fa4cf
Restart Wells: Use IWEL WMCTL Values as Switch Cases
...
These are (marginally) easier to understand than their raw integer
values. While here, also insert the missing 'GRUP' case for
producers.
2020-08-20 13:43:12 +02:00
Bård Skaflestad
a92c8ca6e0
Merge pull request #1870 from jalvestad/group-udq-actx_ph2
...
Corrections and improvements to Eclipse compatible restart file output
2020-08-19 12:30:01 +02:00
Bård Skaflestad
501db1003d
Merge pull request #1876 from joakim-hove/rptrst-solution
...
Correctly handle RPTRST in SOLUTION section
2020-08-18 11:08:31 +02:00
Jostein Alvestad
b624facaf2
minor corrections of comments
2020-08-18 11:07:57 +02:00
Jostein Alvestad
156c934993
minor comment corrections
2020-08-18 11:07:54 +02:00
Jostein Alvestad
c525546489
correct some logical tests determining IGRP
2020-08-18 11:07:52 +02:00
Joakim Hove
106c0881ee
Correctly handle RPTRST in SOLUTION section
2020-08-18 10:48:50 +02:00
Joakim Hove
effe70876f
Merge pull request #1879 from berland/weconcmf
...
Add support for parsing E300 kw WECONCMF
2020-08-18 00:10:34 +02:00
Bård Skaflestad
8e1f8099b2
Merge pull request #1878 from berland/wcutback-fix
...
Add GLR_LIMIT to WCUTBACK
Fixes #1878
2020-08-17 12:56:45 +02:00
Håvard Berland
b1b04d3dec
Add GLR_LIMIT to WCUTBACK, solving bug #1877
...
Also add dimensions to all relevant fields.
2020-08-17 11:41:19 +02:00
Håvard Berland
ab047eca6a
Add support for parsing E300 kw WECONCMF
2020-08-17 11:05:09 +02:00
Joakim Hove
c84b95ed85
Merge pull request #1875 from joakim-hove/tlmixpar
...
Implement TLMIXPAR as dedicated vector of struct - not table
2020-08-14 12:56:39 +02:00
Joakim Hove
d358d94f58
Merge pull request #1806 from goncalvesmachadoc/salt
...
finalizeSaltTables
2020-08-14 12:55:49 +02:00
Cintia Goncalves Machado
f8c53e0f9b
Merge pull request #2 from joakim-hove/salt
...
Salt
2020-08-14 09:51:33 +02:00
Joakim Hove
748c3975fb
Fix salt table tests
2020-08-13 18:44:04 +02:00
Joakim Hove
66ddbd7842
Remove trailing whitespace
2020-08-13 18:44:04 +02:00
Joakim Hove
1b851f03cb
Implement TLMIXPAR as dedicated vector of struct - not table
2020-08-12 14:47:21 +02:00
Markus Blatt
c438c58af3
Merge pull request #1873 from blattms/require-compiled-source
...
Require test source code to compile and fix test for dune-geometry (>2.7)
2020-08-11 10:34:09 +02:00
Markus Blatt
7c30586fde
Only compile code if non-empty code was submitted for DUNE/OPM.
...
Also make the search fail if the compilation fails.
2020-08-11 00:53:45 +02:00
Markus Blatt
d5388ba653
Fix compile check for dune-geometry from DUNE>2.7
...
Dune::Geometry::makeQuadrilateral() is deprecated since 2.6 and has recently
been removed. We are using now using Dune::GeometryTypes::quadrilateral
2020-08-11 00:25:23 +02:00
Joakim Hove
a0e20e8d3e
Merge pull request #1647 from joakim-hove/json
...
Add build and write functionality to JsonObject
2020-08-10 15:40:56 +02:00
Joakim Hove
747fd8f897
Add build and write functionality to Json object
2020-08-10 09:41:51 +02:00
Joakim Hove
3b352a5d3b
Merge pull request #1866 from joakim-hove/use-std-stringview
...
Use std stringview
2020-08-05 13:10:28 +02:00
Joakim Hove
3e1411bf87
Replace opm implementation of string_view with std::string_view
2020-08-04 11:40:41 +02:00
Joakim Hove
ffe86d361b
Merge pull request #1868 from bska/transport-guiderate-values
...
Output: Transport Guiderate Values to Output Layer
2020-07-31 08:08:40 +02:00
Bård Skaflestad
f55d0fa57c
Output: Transport Guiderate Values to Output Layer
...
This commit introduces datamembers of type
Opm::data::GuideRateValue
to the Opm::data::Well and Opm::data::GroupData structures.
Collectively, these datamembers enable transporting guiderate values
calculated elsewhere--e.g., in the opm-simulators module--to the
output layer for final processing and output to the summary and/or
the restart files.
We support outputting both production and injection guiderate values
at the group level. Guiderate values at the well level are
interpreted as production or injection according to the well type.
2020-07-19 19:07:23 +02:00
Joakim Hove
bdd74b33b2
Merge pull request #1867 from joakim-hove/enable-python
...
Update PYTHONPATH in enable-python.sh
2020-07-15 13:06:32 +02:00
Joakim Hove
52d69dfd0d
Update PYTHONPATH in enable-python.sh
2020-07-15 10:16:21 +02:00
Joakim Hove
349e964586
Merge pull request #1865 from bska/add-copyright
...
GuideRateValue: Insert Copyright Notice
2020-07-10 18:55:39 +02:00
Bård Skaflestad
32fa286f8e
GuideRateValue: Insert Copyright Notice
...
Missed in commit 4f7d41ee1 .
Pointy Hat: [at]bska.
2020-07-10 17:52:38 +02:00
Joakim Hove
52801f1e57
Merge pull request #1859 from bska/add-guiderate-value
...
Output: Add Container for Transporting Guiderate Values
2020-07-10 13:24:02 +02:00
Bård Skaflestad
4f7d41ee10
Output: Add Container for Transporting Guiderate Values
...
This commit introduces a container
Opm::data::GuideRateValue
that packages a 'std::array' and 'std::bitset' into that array.
This container is intended as the main vehicle for transporting
per-phase guiderate values (Oil, Gas, Water, and Resvoir Voidage
Volume supported initially) calculated by the simulator to the
output layer. We support the serialization operations read and
write in order to plug into the collective communications layer used
in the simulator.
Add unit tests to exercise the new container.
2020-07-09 16:44:15 +02:00
Bård Skaflestad
dc3dd89e09
Merge pull request #1864 from joakim-hove/actionx-wlist
...
Actionx wlist
2020-07-09 15:57:54 +02:00
Joakim Hove
f500adba24
ACTIONX will handle WLIST well arguments
2020-07-09 15:16:33 +02:00
Joakim Hove
f4f993586a
Add method WListManager::wells() which can do WLIST wildcards
2020-07-09 15:12:54 +02:00
Joakim Hove
17c61e1853
Add missing compile guards
2020-07-09 15:12:54 +02:00
Bård Skaflestad
3eab28f9b0
Merge pull request #1863 from joakim-hove/WLIST-updates
...
Update WLIST to handle WLIST and well pattern arguments
2020-07-09 14:58:31 +02:00
Joakim Hove
d096a5fda6
Update WLIST to handle WLIST and well pattern arguments
2020-07-08 08:12:28 +02:00
Bård Skaflestad
643ff6e777
Merge pull request #1857 from joakim-hove/accept-long-keywords
...
Fix handling of too long 8 characters keywords like GUIDERATE
2020-07-05 19:58:44 +02:00
Bård Skaflestad
1c92fb3fea
Merge pull request #1860 from joakim-hove/add-groupvalues-member
...
Add data::GroupValues member to RestartValue
2020-07-05 19:26:41 +02:00
Joakim Hove
305b2a166a
Add data::GroupValues member to RestartValue
2020-07-03 16:40:42 +02:00
Joakim Hove
1019187a4e
Merge pull request #1858 from joakim-hove/igrp-fix-refactor
...
Igrp fix refactor
2020-07-03 09:08:46 +02:00
Joakim Hove
0321c003eb
Merge pull request #1853 from bska/prepare-guiderate-smry
...
Make Structure for Per-Group Summary Data from Simulator
2020-07-02 21:37:33 +02:00
Joakim Hove
4e223eae4a
Fix handling of too long 8 characters keywords like GUIDERATE
2020-07-02 14:23:45 +02:00
Joakim Hove
012c1a2b40
Use named constants to look up in INTEHEAD
2020-07-02 11:40:30 +02:00
Bård Skaflestad
68b4f38464
Make Structure for Per-Group Summary Data from Simulator
...
This commit adds a level of indirection to the current per-group
summary quantities that is directly assigned by the simulator. In
particular, introduce a new structure named
GroupData
that contains a 'GroupConstraints' object and make the per-group
values into 'map<string, GroupData>' rather than the current
'map<string, GroupConstraints>'. This is in preparation of adding
support for reporting group-level production/injection guiderates
(Gx[IP]GR) to the summary file.
Update tests and APIs accordingly.
2020-07-02 10:57:46 +02:00
Joakim Hove
c7b93797b6
Merge pull request #1852 from joakim-hove/python-wellnames
...
Add python wrapper for Schedule::wellNames( const std::string& )
2020-07-02 09:50:57 +02:00
Joakim Hove
34bc004171
Merge pull request #1854 from bska/remove-unused-variable
...
UDQDefine: Suppress 'Unused Variable' Warning
2020-07-02 00:55:22 +02:00
Bård Skaflestad
adf90e3410
UDQDefine: Suppress 'Unused Variable' Warning
...
Assign 'stod' result to a 'std::ignore' object to maintain the
'token_size' side effect without creating an otherwise unused value
of type 'double'. While here, also put the 'next_token' helper into
an anonymous namespace to avoid generating warnings of the form
no previous declaration for ...
2020-07-01 22:49:49 +02:00
Joakim Hove
d6a3cdb986
Merge pull request #1832 from CeetronSolutions/python-pypi-cleanup
...
Python pypi package work
2020-07-01 13:34:26 +02:00
Joakim Hove
ab821b90a5
Add python wrapper for Schedule::wellNames( const std::string& )
2020-07-01 11:01:12 +02:00
Joakim Hove
29a946eb9a
Merge pull request #1846 from joakim-hove/udq-sign-bug
...
Udq sign bug
2020-07-01 10:47:04 +02:00
Gaute Lindkvist
f7b080b7b6
Fix remaining double use of python/python and opm/opm folders in Python package generation
2020-07-01 03:25:11 -04:00
Bård Skaflestad
0ad97351c6
Merge pull request #1849 from totto82/addBrineOutput
...
add brine output
2020-06-30 17:08:07 +02:00
Gaute Lindkvist
c24d7f7798
Remove static python flags from generate-pypi script
2020-06-30 10:55:23 -04:00
Tor Harald Sandve
42e55ec342
Add brine output
2020-06-30 16:19:16 +02:00
Joakim Hove
9fd29db2de
Add case with literal in scientific form
2020-06-30 13:04:49 +02:00
Joakim Hove
f09b534e1d
Hack around UDQ parser which does not accept leading '-'
2020-06-30 13:01:00 +02:00
Joakim Hove
fc4511d365
Fix UDQParsing code to handle numerical values on scientific form
2020-06-30 12:51:59 +02:00
Bård Skaflestad
89cbb9ae24
Merge pull request #1847 from joakim-hove/use-sumstate-group-function
...
Use SummaryState::has_group_var() / SummaryState::get_group_var()
2020-06-30 11:46:05 +02:00
Joakim Hove
962b6f8150
Use SummaryState::get_group_var() / SummaryState::has_group_var() II
2020-06-30 11:26:08 +02:00
Joakim Hove
c663805694
Refactored UDQ token split code
2020-06-30 10:35:23 +02:00
Joakim Hove
d30b63508d
Quote item in error message
2020-06-30 09:48:23 +02:00
Joakim Hove
8ad0c99c1d
Make sure UDQ quote_split does not append empty string
2020-06-30 09:37:42 +02:00
Joakim Hove
7fce7a2c9c
Bug in UDQ tokenizer
2020-06-30 08:40:06 +02:00
Bård Skaflestad
0c35431a2f
Merge pull request #1844 from joakim-hove/use-sumstate-group-function
...
Use SumState::has_group_var() / SumState::get_group_var()
2020-06-29 21:09:34 +02:00
Bård Skaflestad
64ae1a8dea
Merge pull request #1834 from totto82/addPolymerOutput
...
Add output for polymer production
2020-06-29 17:06:53 +02:00
Joakim Hove
3e828e8578
Use SummaryState::has_group_var() / SummaryState::get_group_var()
2020-06-29 16:18:37 +02:00
Joakim Hove
eb48fb709a
Add SummaryState::get_xxx() overloads with a default argument
2020-06-29 14:14:49 +02:00
Tor Harald Sandve
8c14eac213
add polymer density to the unit system
2020-06-29 13:53:42 +02:00
Bård Skaflestad
a067352ce0
Merge pull request #1843 from joakim-hove/restart-recover-udq
...
Recover UDQ values from restart file
2020-06-25 16:41:20 +02:00
Joakim Hove
1704a35a92
Recover UDQ values from restart file
2020-06-25 16:18:59 +02:00
Gaute Lindkvist
3acc26558b
Use file COPY instead of configure for straight copy in CMakeLists.txt
2020-06-25 09:52:43 -04:00
Gaute Lindkvist
a624d6c690
Remove static python flags from generate-pypi script
2020-06-25 09:26:38 -04:00
Gaute Lindkvist
27fdb0654d
Revert "Support building Python module statically"
...
This reverts commit d3b4f41acf .
2020-06-25 09:26:12 -04:00
Joakim Hove
efc2e7aa92
Merge pull request #1841 from joakim-hove/use-restart-groups
...
Use Schedule::restart_groups()
2020-06-25 14:19:31 +02:00
Joakim Hove
e65880aafb
Use Schedule::restart_groups()
2020-06-25 14:18:19 +02:00
Tor Harald Sandve
13f07fdfef
Polymer output
...
Change polymer production output from volume -> mass
Polymer injection rates are read from the simulator and not computed based on the water rate and the polymer injection concentration given in the schedule
2020-06-25 10:57:11 +02:00
Bård Skaflestad
2876751fe2
Merge pull request #1839 from joakim-hove/eval-udq
...
Eval udq
2020-06-24 14:15:27 +02:00
Bård Skaflestad
1a0b3b418c
Merge pull request #1836 from joakim-hove/restartview
...
Restartview
2020-06-24 14:13:17 +02:00
Bård Skaflestad
c07aec9c68
Merge pull request #1838 from joakim-hove/schedule-restart-group
...
Schedule restart group
2020-06-24 13:56:32 +02:00
Joakim Hove
cbe9bf2470
RestartView::hasKeyword: fix when <T> is not present at all
2020-06-24 12:59:43 +02:00
Joakim Hove
f6d160db32
Add convenience method Schedule::restart_groups()
2020-06-24 12:53:09 +02:00
Bård Skaflestad
feaadb4f6f
Merge pull request #1837 from joakim-hove/udq-named-constant
...
Udq named constant
2020-06-24 10:58:09 +02:00
Joakim Hove
633bbb6007
Introduce named constant for UDQ default value in restart files
2020-06-24 01:08:36 +02:00
Joakim Hove
c06708ebd0
Add std::string specialization in RestartView
2020-06-24 01:06:15 +02:00
Joakim Hove
ae5c6fe53e
Made eval_udq into method UDQConfig::eval()
2020-06-24 01:05:59 +02:00
Joakim Hove
9ed3f223ea
Merge pull request #1840 from joakim-hove/udq-whitespace
...
Remove trailing whitespace
2020-06-24 01:05:21 +02:00
Joakim Hove
ad023d224b
Remove trailing whitespace
2020-06-23 15:55:05 +02:00
Tor Harald Sandve
27e6e0735f
Add output for polymer production
2020-06-23 09:57:36 +02:00
Atgeirr Flø Rasmussen
e719812e9b
Merge pull request #1833 from bska/disable-debug-output
...
Group Data: Conditionally Enable Debug Output
2020-06-22 22:17:36 +02:00
Bård Skaflestad
8e9e0b0977
Group Data: Conditionally Enable Debug Output
...
This commit switches the group control debug output to std::cout
into a conditional mode that is controlled by a file-wide PP symbol
ENABLE_GCNTL_DEBUG_OUTPUT
that we set to zero here. This allows the developers to turn on
additional debug output when needed without confusing those who are
not actively working on the feature.
2020-06-22 17:35:42 +02:00
Gaute Lindkvist
474d4a90dc
Add more metadata to setup.py for pypi page
2020-06-19 14:56:12 +02:00
Atgeirr Flø Rasmussen
3cda13c7a2
Merge pull request #1831 from akva2/fix_missing_config_h_include
...
fixed: include config.h for HAVE_OPENMP
2020-06-19 14:55:49 +02:00
Gaute Lindkvist
29bb9f05be
Add simple pypi howto
2020-06-19 13:38:55 +02:00
Cintia Goncalves Machado
784abc7069
deleteSolidPhasefromPhases
2020-06-19 13:31:33 +02:00
Joakim Hove
ae28999d5b
Merge pull request #1829 from akva2/janitoring
...
Some janitoring
2020-06-19 13:09:12 +02:00
Arne Morten Kvarving
4bc00663ea
fixed: include config.h for HAVE_OPENMP
2020-06-19 12:55:04 +02:00
Arne Morten Kvarving
970d6339dd
fixed: forward struct as struct
2020-06-19 11:52:12 +02:00
Arne Morten Kvarving
d7bdb448f5
add some trivial checks to avoid unused variable warnings
2020-06-19 09:43:48 +02:00
Arne Morten Kvarving
841124a47d
mark variable maybe_unused to avoid compiler warnings
...
unused without openmp
2020-06-19 09:43:34 +02:00
Atgeirr Flø Rasmussen
146e5930e2
Merge pull request #1828 from joakim-hove/remove-unused
...
Remove unused variable
2020-06-19 06:54:51 +02:00
Joakim Hove
216a220ee8
Remove unused variable
2020-06-18 22:34:24 +02:00
Arne Morten Kvarving
29010dd7e3
Merge pull request #1823 from joakim-hove/action-state
...
Add class Action::State to keep track of ACTIONX count
2020-06-18 19:15:17 +02:00
Joakim Hove
dd1591f1a2
Use Action::State object to keep track of actions being run
2020-06-18 16:45:39 +02:00
Joakim Hove
f54245f1ca
Add class Action::State to keep track of ACTIONX count
2020-06-18 16:45:39 +02:00
Joakim Hove
7d856b4933
Add id member to ActionX objects
2020-06-18 16:45:39 +02:00
Gaute Lindkvist
16505b421a
Rename package to lowercase 'opm' instead of 'Opm'
2020-06-18 10:32:05 -04:00
Gaute Lindkvist
5515422d02
Add docker files and scripts for creating cross-distro PyPI packages
2020-06-18 10:32:05 -04:00
Bård Skaflestad
2123884655
Merge pull request #1408 from jalvestad/extend_udq_actx_rst
...
Changes to extend and improve the ECL-compatible restart
2020-06-18 16:29:52 +02:00
Cintia Goncalves Machado
6ab09afb0c
fixPermFactTest
2020-06-18 16:23:41 +02:00
Bård Skaflestad
35100cc8bb
Merge pull request #1827 from akva2/janitoring
...
anonymize to quell unused parameter warning
2020-06-18 09:50:08 +02:00
Arne Morten Kvarving
8d3680c7b5
anonymize to quell unused parameter warning
2020-06-18 08:27:48 +02:00
Joakim Hove
986f0acad7
Merge pull request #1826 from akva2/add_missing_initializer
...
fixed: add missing initializer
2020-06-17 15:44:22 +02:00
Joakim Hove
0edc9acc48
Merge pull request #1825 from joakim-hove/gpmaint-serialize-fix
...
Fix: bug in serializer function for GPMaint class
2020-06-17 15:29:43 +02:00
Arne Morten Kvarving
643b8b179d
fixed: add missing initializer
2020-06-17 14:32:42 +02:00
Joakim Hove
3478263de9
Fix: bug in serializer function for GPMaint class
2020-06-17 12:45:23 +02:00
Gaute Lindkvist
cbd23e71ef
Add generation of a setup-package.sh script for creating PyPI-packages
2020-06-16 13:08:33 +02:00
Gaute Lindkvist
9ed75f030b
Rename python/python folder to python/opm
...
This makes bdist_wheel find and add the library binary files.
2020-06-16 13:08:33 +02:00
Gaute Lindkvist
e3bb9a3151
README.md file skeleton for Python package
2020-06-16 13:08:33 +02:00
Gaute Lindkvist
85f8c7b37d
Add more metadata to Python setup.py
2020-06-16 13:08:33 +02:00
Gaute Lindkvist
6db3ccf36f
Add link flags to Python setup.py
2020-06-16 13:08:33 +02:00
Gaute Lindkvist
f67bce1dd8
Add link directories to Python setup.py
2020-06-16 12:52:34 +02:00
Markus Blatt
8c6cd2f10f
Merge pull request #1810 from blattms/support-pinch-nogap
...
Support querying GAP/NOGAP mode for Pinch form EclipseGrid.
2020-06-15 17:27:15 +02:00
Jostein Alvestad
0679d2b233
corrections to SGRP - index error > 0.
2020-06-15 09:55:46 +02:00
Jostein Alvestad
7d3df69416
Corrected an errors and a misprint
2020-06-15 09:55:44 +02:00
Jostein Alvestad
1751120b79
corrected logic error in AggregateWellData.cpp
2020-06-15 09:55:42 +02:00
Jostein Alvestad
c846716044
add variable to hold min value of nonzero uda
2020-06-15 09:55:40 +02:00
Jostein Alvestad
fea794ee17
further corrections of unit tests and code clean up
2020-06-15 09:55:38 +02:00
Jostein Alvestad
862b7b7591
clean up code - correct unit tests
2020-06-15 09:55:36 +02:00
Jostein Alvestad
ec976db684
correction for lift quantity well-data
...
corrections to IUAD and IUAP
various improvements of E100 compatible restart file
add debug output
additonal debug print
corrected loop placement for active prod/inj wells
remove debug print and clean up code
2020-06-15 09:55:34 +02:00
Joakim Hove
985cb279ff
Allow negative rates when evaluating UDA values
...
corrections to iwel[10] open/shut flag
further corrections SWEL for handling udq-restarts correctly
further changes to get correct SWEL in ECL-Restart file
added comment to clarify change
correction to group sequence and group controls for EclRST-file
changes to correct IGRP[NWGMAX+5]
corrected compile errors/warnings
further minor code corrections
initial changes to include group current Prod/inj Constraint in summary file
further changes to currentsStatusGroupControl to Summary output
further corrections and additions of Field current controls
further corrections for IGRP
minor corrections to code style
corrections for tests
changes to correct test_AggregateWellData
a few more initial changes for next version of igrp/sgrp
changes to igrp & sgrp according to tests
changes to handle special conditions at report step 0
corrections due to changes in Summary.cpp
changes to improve code quality and robustness
Add default value to igrp[nwgmax+5]
corrections and code improvements base on testing
corrections to handling of GCONINJE
further corrections for IGRP
even further corrections IGRP
changes to correct SGRP
correction to IGRP defaults
corrections to SWEL and IGRP
further corrections for IGRP
removed some comments
2020-06-15 09:55:27 +02:00
Bård Skaflestad
88414fd1fc
Merge pull request #1822 from joakim-hove/use-hours
...
Use 'HOURS' as time unit in LAB unit summary files
2020-06-13 12:27:01 +02:00
Joakim Hove
1dc3a67cf1
Use 'HOURS' as time unit in LAB unit summary files
2020-06-13 07:46:47 +02:00
Joakim Hove
84aa2f77f3
Merge pull request #1820 from joakim-hove/udq-nan-values
...
UDQSet will check for nan values
2020-06-12 13:49:24 +02:00
Joakim Hove
0841e4f398
Merge pull request #1797 from joakim-hove/GPMAINT
...
Add code to internalize GPMAINT keyword in Group objects
2020-06-12 12:19:20 +02:00
Joakim Hove
10b2b2ac48
Add caching of well and group names in SummaryState
2020-06-12 12:07:04 +02:00
Joakim Hove
082820380d
Ensure that all values in UDQSet are finite
2020-06-12 09:12:55 +02:00
Joakim Hove
213c6fb6ad
Add function SummaryState::update_udq() to add variables from UDQSet
2020-06-12 09:12:55 +02:00
Joakim Hove
90d1d992e5
Ensure that evaluated UDQSet have the correct name
2020-06-12 09:12:55 +02:00
Joakim Hove
172c0b1aa6
Make sure invalid UDQ values are deleted from SummaryState
2020-06-12 09:12:55 +02:00
Joakim Hove
669918547a
Add del() method to SummaryState
2020-06-12 09:12:55 +02:00
Joakim Hove
b07bd377cd
Merge pull request #1819 from joakim-hove/aicd
...
Aicd
2020-06-12 09:12:18 +02:00
Atgeirr Flø Rasmussen
e08a3666e3
Merge pull request #1818 from atgeirr/fix-nupcol-runspec
...
Handle NUPCOL in RUNSPEC correctly
2020-06-11 20:50:30 +02:00
Bård Skaflestad
be57558804
Merge pull request #1630 from bska/new-rst-tags
...
New Solution Vector Tag for Restart File Output
2020-06-11 17:09:42 +02:00
Bård Skaflestad
a4a04ebf51
Restart Tag System: Introduce Tag for OPM Extended Vectors
...
This is intended to supersede the RESTART_AUXILIARY tag. There is
no practical difference between vectors that are needed for restart
and vectors that are not needed for restart. They all go into the
SOLUTION section of a restart file.
Vectors tagged as RESTART_OPM_EXTENDED will not be output unless the
user does requests OPM-extended restart files.
2020-06-11 14:31:53 +02:00
Bård Skaflestad
4fcd85526a
Solution Output: Refactor Stages Out to Helper Functions
...
Mostly to reduce the level of complexity of the 'writeSolution'
function. While here, also ensure that we never write solution data
outside the STARTSOL/ENDSOL demarcations. Even if we emit vectors
that are not known to ECLIPSE, we should not write them outside of
the SOLUTION section.
2020-06-11 14:31:53 +02:00
Joakim Hove
224911bd10
Add implementation for autonomous ICD: AutoICD
2020-06-11 11:38:29 +02:00
Joakim Hove
73a244ceda
Templated internalizing of WSEGSICD keyword
2020-06-11 11:38:29 +02:00
Joakim Hove
4c100d0bd5
Update json scheme to ensure that WSEGSICD is subset of WSEGAICD
2020-06-11 11:38:29 +02:00
Joakim Hove
0f032d6fca
Merge pull request #1801 from joakim-hove/icd-variant
...
Use std::variant<> to hold ICD alternatives
2020-06-11 11:31:58 +02:00
Joakim Hove
6090470045
Add code to internalize GPMAINT keyword in Group objects
2020-06-11 09:40:55 +02:00
Atgeirr Flø Rasmussen
0c6d1c31d7
Implement and use Runspec::nupcol().
2020-06-11 07:44:49 +02:00
Bård Skaflestad
9396d44379
Merge pull request #1770 from bska/add-tolcrit
...
Add Support for TOLCRIT to Sat-Func Field Properties
2020-06-10 19:19:07 +02:00
Joakim Hove
dae980ddd5
Hide away templated convert function
2020-06-10 16:36:33 +02:00
Bård Skaflestad
f61882ce69
Critical Saturation: Refactor Helper Functions
...
In particular, add two new helper functions
crit_sat_increasing_KR
crit_sat_decreasing_KR
which identify the critical saturations under the assumption of a
relative permeability curve that increases viz decreases as a
function of the specified phase saturation. Those helpers in turn
call a wrapper around std::lower_bound() and std::distance() to
affect the actual table scan.
Reimplement the 'critical_*()' helper functions in terms of
crit_sat_*_KR() to remove duplicated logic.
2020-06-10 14:33:01 +02:00
Bård Skaflestad
abec96a387
Sat-Func Initializers: Add TOLCRIT Support
...
This commit makes the 'critical_*()' helper functions aware of the
TOLCRIT feature. We now consider a phase to be immobile at a one
saturation value if its relative permeability at that saturation is
less than or equal to TOLCRIT. TOLCRIT mirrors E100's default value
of 1.0e-6 unless otherwise specified in the PROPS section.
All table scanners are implemented in terms of the expression
std::lower_bound(begin, end, tolcrit, predicate)
which ultimately returns the first position in [begin, end) for
which
predicate(*iter, tolcrit)
is false. Using predicate = std::greater<>{} thus determines the
first position in the sequence for which the elements is less than
or equal to 'tolcrit'. Similarly, a predicate equivalent to '<='
returns the first position for which the elements is strictly
greater than 'tolcrit'.
Add a set of unit tests to demonstrate and exercise the new feature.
2020-06-10 14:33:01 +02:00
Bård Skaflestad
bcdc8bb119
Table Output: Revise TOLCRIT Interpretation
...
This commit switches the previous interpretation of notionally zero
relative permeability in Flow's .INIT-file output. We now treat all
relative permeability values less than *or equal to* TOLCRIT as
zero.
This change is for increased ECLIPSE compatibility.
2020-06-10 14:33:01 +02:00
Bård Skaflestad
83429bf908
Sat-Func Initializers: Pass TOLCRIT to Table-Scanning Layer
...
This is a pure API change. The TOLCRIT value is not yet used as
part of determining the critical saturations.
While here, also add a unit test for getRawTableEndPoints() and
update the existing sat-func property unit tests to explicitly pass
TOLCRIT = 0 in preparation of adding actual TOLCRIT support.
2020-06-10 14:33:01 +02:00
Bård Skaflestad
83af852efe
Capture SatFunc Controls In FieldProps
...
This is in preparation of threading the TOLCRIT value-defaulted or
not-through to the end-point scanning code.
2020-06-10 14:33:01 +02:00
Bård Skaflestad
f0f3764b89
Sat-Func Initializers: Expose RawTableEndPoints to Caller
...
This commit requires that the callers of satfunc::init() calculate
the raw table end-points. That, in turn, enables callers to cache
those end-point values to avoid repeated calculations.
Add a new member, m_rtep, to FieldProps to act as such a cache to
take advantage of the new ability.
2020-06-10 14:33:01 +02:00
Gaute Lindkvist
d3b4f41acf
Support building Python module statically
2020-06-10 14:30:38 +02:00
Gaute Lindkvist
a2d52dcc0b
Add versioning to python/setup.py
2020-06-10 14:30:38 +02:00
Gaute Lindkvist
2f6d4a8f84
Improve string comparison in install.py to remove warning
2020-06-10 14:08:38 +02:00
Atgeirr Flø Rasmussen
80f6a5d1ed
Add failing test for NUPCOL in RUNSPEC.
2020-06-10 13:17:04 +02:00
Bård Skaflestad
6a742a20fd
Merge pull request #1705 from GitPaean/segment_keywords_regreesion_test
...
attempting to adding segment summary keywords for regression test
2020-06-10 12:40:41 +02:00
Joakim Hove
8320b89d90
Merge pull request #1817 from akva2/disable_warnings_flag
...
add a cmake flag to disable warnings
2020-06-10 11:13:06 +02:00
Kai Bao
405e3e1add
attempting to adding segment summary keywords for regression test
2020-06-10 10:39:45 +02:00
Joakim Hove
afd5c3153a
Use value based semantics for Segment -> valve
2020-06-10 06:35:03 +02:00
Joakim Hove
b1250c2f7a
Use std::variant<> to hold ICD alternatives
2020-06-10 06:35:03 +02:00
Arne Morten Kvarving
64cbbdde65
add a cmake flag to disable warnings
2020-06-09 15:11:44 +02:00
Joakim Hove
b73f4aa5dc
Merge pull request #1811 from joakim-hove/rst-segment-connection-refactor
...
Reshuffle segments and connections after restart
2020-06-09 07:08:37 +02:00
Joakim Hove
9faa824258
Merge pull request #1814 from OPM/fix/include-required-header
...
[parser] include required header
2020-06-09 07:04:56 +02:00
Joakim Hove
630a4a85ec
Merge pull request #1816 from bska/empty-default-udq-ustr
...
SMSPEC: Emit Empty Unit String if UDQ Unit Undefined
2020-06-09 07:04:00 +02:00
Bård Skaflestad
adcb9c54b8
SMSPEC: Emit Empty Unit String if UDQ Unit Undefined
...
This is guided by ECLIPSE.
2020-06-08 23:19:26 +02:00
Bård Skaflestad
e129f74304
Merge pull request #1815 from tskille/issue_with_esmry
...
fixing invalid write in src/opm/io/eclipse/ESmry.cpp
2020-06-08 22:17:35 +02:00
Torbjørn Skille
947d3fec99
fixing invalid write in src/opm/io/eclipse/ESmry.cpp
2020-06-08 20:33:10 +02:00
Bernd Flemisch
27e310d436
[parser] include required header
2020-06-08 15:23:52 +02:00
Atgeirr Flø Rasmussen
229a619a85
Merge pull request #1812 from akva2/move_timestamp
...
changed: move build timestamp to separate header
2020-06-08 12:52:19 +02:00
Arne Morten Kvarving
1d3843cef1
changed: move build timestamp to separate header
...
to avoid rebuilds for things only needing project versions
2020-06-08 10:06:03 +02:00
Joakim Hove
7a88808ccb
Add Segment::updateValve() overload which does not take length arg
2020-06-07 09:09:26 +02:00
Joakim Hove
31b6baa676
Reshuffle segments and connections after restart
2020-06-07 09:09:15 +02:00
Joakim Hove
0daac0b9e3
Merge pull request #1804 from joakim-hove/segment-perf-length
...
Segment perf length
2020-06-05 11:05:24 +02:00
Joakim Hove
5b51c57a5e
Update SpiralICD scaling factor during initialization
2020-06-05 08:00:53 +02:00
Joakim Hove
bf3f8e1b08
Merge pull request #1809 from joakim-hove/refactor-compsegs
...
Refactor COMPSEGS handling
2020-06-04 22:58:01 +02:00
Markus Blatt
23dd41ba38
Support querying GAP/NOGAP mode for Pinch form EclipseGrid.
...
While we currently only support GAP and do not need this,
we will need it eventually to support NOGAP in the simulator.
2020-06-04 20:19:51 +02:00
Joakim Hove
6b468787c8
Refactor COMPSEGS handling
...
When handling the COMPSEGS keyword the connections are updated with segment
number and the segments are updated with total perforated length. The new
Compsegs::processCOMPSEGS() function will create new updated copies of both
WellSegments and WellConnections.
2020-06-04 16:57:40 +02:00
Joakim Hove
5b0045d4a5
Merge pull request #1808 from joakim-hove/sicd-refactor-step0
...
Sicd refactor step0
2020-06-04 15:58:08 +02:00
Joakim Hove
6e60ebfc74
Merge pull request #1807 from akva2/fix_invalid_deref
...
fixed: reorder logging and update call
2020-06-04 14:50:53 +02:00
Arne Morten Kvarving
c620d392d2
fixed: reorder logging and update call
...
the update call can invalidate the reference since the underlying
smart pointer is replaced, and when there are no remaining references,
it is deleted.
2020-06-04 13:16:18 +02:00
Cintia Goncalves Machado
628afd7abe
finalizeSaltTables
2020-06-04 11:43:59 +02:00
Joakim Hove
1b2fc9a7fa
Add new function to calculate total perforated length for segment
2020-06-03 08:28:53 +02:00
Joakim Hove
dcec08767d
Add member perf_length to Segment class
2020-06-03 08:28:53 +02:00
Joakim Hove
7b33ab4519
Merge pull request #1805 from hakonhagland/glift_setters
...
Added some getters for LIFTOPT.
2020-06-02 11:00:54 +02:00
Håkon Hægland
f7d2631a57
Added const keyword to getters.
...
The access method should be marked as const so to make the compiler
aware that they should not modify the state of the object.
2020-06-02 09:20:54 +02:00
Håkon Hægland
c6d49a4b44
Added some getters for LIFTOPT.
...
Added getters for gaslift_increment() and min_eco_gradient() in
the Opm::GasLiftOpt class.
2020-06-02 07:21:01 +02:00
Bård Skaflestad
475dde4bb1
Merge pull request #1803 from joakim-hove/all-shut-message
...
All shut message
2020-06-01 23:37:17 +02:00
Joakim Hove
998b555662
Move message "All connections shut -> shut well"
2020-06-01 20:02:06 +02:00
Joakim Hove
80bd81c892
Remove commented out code
2020-06-01 08:59:38 +02:00
Bård Skaflestad
f7b2bb4a07
Merge pull request #1802 from atgeirr/clang-is-not-gcc
...
Ensure clang uses the normal standard headers.
2020-05-29 16:26:20 +02:00
Atgeirr Flø Rasmussen
937747323d
Ensure clang uses the normal standard headers.
...
Clang defines __GNUC__ to 4, as that represents its level of
support for the GNU C dialect. The gcc compiler does not provide
a macro indicating the compiler separately from the dialect supported.
We must therefore use the __clang__ macro to avoid false positives.
2020-05-29 14:31:37 +02:00
Atgeirr Flø Rasmussen
1a1bb29a13
Merge pull request #1800 from atgeirr/bump-version
...
Bump version number
2020-05-29 13:34:28 +02:00
Joakim Hove
ccf3f150f2
Merge pull request #1798 from joakim-hove/aicd
...
Rename SpiralICD -> SICD
2020-05-29 07:24:38 +02:00
Joakim Hove
4fbfe3b8ec
Merge pull request #1799 from joakim-hove/halvor_opm_restart
...
Halvor opm restart
2020-05-28 17:41:59 +02:00
Atgeirr Flø Rasmussen
f783282f49
Bump version number
2020-05-28 16:50:26 +02:00
Joakim Hove
4e7ac10320
Explicitly mark const overload in Python binding
2020-05-28 16:21:14 +02:00
hnil
7db2cc0c2e
add new function to make input and output definitions uniform for example for forward runs
2020-05-28 16:08:34 +02:00
hnil
2c04ada035
added unification of inputoutput
2020-05-28 16:08:34 +02:00
hnil
e3d39a8b64
changes to be able to set request for restart. Also change the parallel restart to read uniform output
2020-05-28 16:08:34 +02:00
Markus Blatt
0352258f22
Merge pull request #1796 from blattms/require-disabled-packages
...
Send error for required but disabled packages.
2020-05-28 11:48:01 +02:00
Joakim Hove
7df0577a58
Rename SpiralICD -> SICD
2020-05-28 11:03:24 +02:00
Bård Skaflestad
49e2099436
Merge pull request #1795 from bska/thp-restart-support
...
Add Restart I/O Support for Well's THP
2020-05-20 15:07:56 +02:00
Markus Blatt
9452796c57
Send error for required but disabled packages.
...
When using CMAKE_DISABLE_FIND_PACKAGE_<name>=ON for a required package
CMake did not issue an errors since we never trigger the find_package
call. With this commit we now check whether such package is required
and send an error.
2020-05-20 14:55:52 +02:00
Bård Skaflestad
c71ffd1415
Add Restart I/O Support for Well's THP
...
This commit adds support for saving and restoring a well's THP
quantitiy. We put the THP into the summary facility's list of
"required restart quantities" and pick up the value converted to
output units from the SummaryState.
On restart we restore the THP value to internal (SI) units and
transport the value to the simulator in data::Well::thp. While
here, also add the THP value to the RstWell object although
currently not strictly needed in that context.
2020-05-19 22:20:55 +02:00
Bård Skaflestad
88f8313568
Merge pull request #1793 from OPM/fix/add-missing-includes
...
add some missing includes
2020-05-19 21:35:57 +02:00
Bård Skaflestad
7194463033
Merge pull request #1794 from OPM/fix/designated-initializer
...
avoid designated initializer error
2020-05-19 21:34:44 +02:00
Bernd Flemisch
283da4d2b6
[test] avoid designated initializer error
2020-05-19 13:03:45 +02:00
Bernd Flemisch
54f08156ad
add some missing includes
2020-05-19 12:59:22 +02:00
Bård Skaflestad
0d9eda9b76
Merge pull request #1792 from bska/restart-guiderate-locations
...
Restart: Prepare to Output Well/Group Guide Rates
2020-05-18 23:43:11 +02:00
Bård Skaflestad
317d1ba14e
Restart: Prepare to Output Well/Group Guide Rates
...
This commit identifies vector items in XWEL and XGRP that hold guide
rate values at the well and group levels, and adds functionality to
output those values to the restart file. We do not identify such
value at the FIELD level. As with other summary-like quantities, we
expect to pick up the fully converted values from a SummaryState
object.
Calculating and storing the guide rate quantities in SummaryState is
the subject of future work.
2020-05-18 21:56:57 +02:00
Joakim Hove
598f0e9056
Merge pull request #1791 from joakim-hove/group-index-offset
...
Fix group number used in IUAP restart array
2020-05-18 17:37:52 +02:00
Bård Skaflestad
6f45df5e93
Merge pull request #1790 from joakim-hove/network-vfp0
...
When defining branch properties: vfp == 0 should delete branch
2020-05-16 00:46:58 +02:00
Joakim Hove
0aa5fd9f09
Fix group number used in IUAP restart array
2020-05-15 16:26:57 +02:00
Bård Skaflestad
5560f43a8c
Merge pull request #1782 from hnil/abs_convergence
...
changed rootfinders to return also when absolute tolerance is less th…
2020-05-15 15:19:33 +02:00
Joakim Hove
66acfb5249
When defining branch properties: vfp == 0 should delete branch
2020-05-15 14:21:44 +02:00
Joakim Hove
d1babffa8b
Merge pull request #1789 from joakim-hove/udqactive-gconprod
...
Make sure the UDQ usage in GCONPROD is recorded
2020-05-15 13:17:02 +02:00
hnil
47df32ef1a
fixed the tolerance also in RegulaFalsiBisection
2020-05-15 08:55:38 +02:00
Joakim Hove
fd5a42801f
Make sure the UDQ usage in GCONPROD is recorded
2020-05-15 08:27:52 +02:00
Atgeirr Flø Rasmussen
7cff27c801
Merge pull request #1788 from atgeirr/fix-missing-openmp
...
Let make_lodsmry also work without OpenMP.
2020-05-14 19:11:51 +02:00
Atgeirr Flø Rasmussen
28f3df5259
Let make_lodsmry also work without OpenMP.
2020-05-14 16:58:51 +02:00
Bård Skaflestad
162e0b53cd
Merge pull request #1787 from atgeirr/add-missing-include
...
Add missing <array> include.
2020-05-14 15:43:45 +02:00
Atgeirr Flø Rasmussen
1593df2a32
Add missing <array> include.
2020-05-14 13:45:46 +02:00
Bård Skaflestad
3a8ea856bc
Merge pull request #1785 from tskille/lod_esmry
...
Lod esmry
2020-05-14 10:55:19 +02:00
Torbjørn Skille
c430eeb374
Adding support for LODSMRY file
...
> implemented for unified and multiple, and for formatted and binary summary files
> avaliable/used only when loadBaserun is false (default)
2020-05-14 07:39:23 +02:00
Torbjørn Skille
9766e0ebb3
using file handling functions from stdio.h for lod in ESmry
...
> improved read efficiency compared with fstream routines
Also fixed bug with lod for formatted unified summary when number of vectors larger than max block size
2020-05-11 21:39:57 +02:00
Bård Skaflestad
0756cd93ad
Merge pull request #1783 from joakim-hove/fp-operate-maxlim
...
Fp operate maxlim
2020-05-11 21:21:55 +02:00
Bård Skaflestad
355fb2aabb
Merge pull request #1784 from joakim-hove/guderate-def-init
...
Initialize group production guide_rate to Target::NONE
2020-05-11 19:04:40 +02:00
Joakim Hove
ebdffa2abb
Ensure correct SI conversion for the scalar data in OPERATE keyword
2020-05-11 15:45:01 +02:00
Joakim Hove
ce368bb850
Initialize groups GuideRate target to NONE
2020-05-11 12:53:37 +02:00
Joakim Hove
9065bf2390
Remove dummy/unit dimension for NTG
2020-05-11 12:15:09 +02:00
hnil
ded8ef1a66
changed rootfinders to return also when absolute tolerance is less than prescribed, not only when function value is less than tolerance.
2020-05-10 22:32:01 +02:00
Joakim Hove
55620ac254
Merge pull request #1781 from joakim-hove/gtnode-bug
...
Bug: pointer -> to stack variable - fix with parent *name*
2020-05-08 09:20:52 +02:00
Joakim Hove
64fb589ec6
Use string based parent *name* in GTNode instead of pointer
2020-05-07 20:08:39 +02:00
Joakim Hove
310bd82b8b
Merge pull request #1778 from joakim-hove/gas-lift-opt
...
Internalize keywords for Gas Lift Optimization
2020-05-07 20:07:58 +02:00
Joakim Hove
e05e6f83ea
Merge pull request #1772 from atgeirr/fix-starttime-actionx
...
Fix start-time of ACTIONX actions.
2020-05-07 18:38:26 +02:00
Joakim Hove
18cd60cd86
Merge pull request #1780 from berland/solvdirs-size
...
Add size to SOLVDIRS json
2020-05-07 16:33:23 +02:00
Joakim Hove
7fe89422e2
Internalize keywords for gas lift optimization
2020-05-07 16:29:42 +02:00
Håvard Berland
8346941b92
Add size to SOLVDIRS json
2020-05-07 15:35:49 +02:00
Joakim Hove
b311cef875
Merge pull request #1776 from joakim-hove/zwel-fix
...
Make sure the action name is only added to ZWEL when it is true
2020-05-07 11:04:18 +02:00
Bård Skaflestad
3065218e6d
Merge pull request #1779 from joakim-hove/fixup-network
...
Fix: integrate ExtNetwork instance in Schedule serialization
2020-05-07 09:56:00 +02:00
Joakim Hove
ea14bf2298
Fix: integrate ExtNetwork instance in Schedule serialization
2020-05-06 21:10:52 +02:00
Joakim Hove
3c879dd5dc
ActionResult will not access wells if overall false
2020-05-06 12:48:38 +02:00
Joakim Hove
dc9ba1dc56
Minor white space cleanup
2020-05-05 19:13:32 +02:00
Joakim Hove
c073ad2d8b
Make sure Action result is checked before wells are considered
2020-05-05 19:03:22 +02:00
Joakim Hove
352cc5797b
Make sure the action name is only added to ZWEL when it is true
2020-05-05 18:00:29 +02:00
Bård Skaflestad
26cdff10fc
Merge pull request #1775 from totto82/fixSolvent
...
Allow for mixing of SOF2 from familiy 2 and family 1 for 3p + solvent
2020-05-05 15:14:44 +02:00
Tor Harald Sandve
c73c83d317
Allow for mixing of SOF2 from familiy 2 and family 1 for 3p solvent models
2020-05-05 11:52:30 +02:00
Atgeirr Flø Rasmussen
5e985cfaf3
Fix start-time of ACTIONX actions.
2020-05-05 10:09:09 +02:00
Joakim Hove
94ab966c1b
Merge pull request #1774 from atgeirr/fix-actionx-testcase
...
Remove group list in test file
2020-05-05 09:11:44 +02:00
Atgeirr Flø Rasmussen
3cb39f8bd4
We do not handle lists of groups.
...
Addressed by removing such a list (replace with the single
group matching pattern) in a test case.
2020-05-05 08:28:10 +02:00
Joakim Hove
f8e7c4eee0
Merge pull request #1773 from joakim-hove/group-level-report
...
Group level report
2020-05-04 21:46:53 +02:00
Williham Williham Totland
5e981cc74b
Corrects all_nodes implementation.
2020-05-04 18:29:48 +02:00
Williham Williham Totland
54ced2e368
Implements Group Level report.
2020-05-04 18:29:48 +02:00
Williham Williham Totland
8af0d505cf
Implements GTNode::level and GTNode::all_nodes.
2020-05-04 18:29:08 +02:00
Joakim Hove
c22a7e5b46
Merge pull request #1765 from wito/group-hierarchy-report
...
Implementing Group Hierarchy Report
2020-05-04 18:27:33 +02:00
Joakim Hove
44af497f8a
Merge pull request #1771 from joakim-hove/welspecs-report-refactor
...
Use proper Connection::perf_range() when creating WELSPECS MSW report
2020-05-04 12:19:23 +02:00
Joakim Hove
c8e81f32fb
Merge pull request #1763 from joakim-hove/weltarg-uda
...
Weltarg uda
2020-05-04 11:54:19 +02:00
Joakim Hove
afc7f5d2f2
Use proper Connection::perf_range() when creating WELSPECS MSW report
2020-05-04 10:46:32 +02:00
Joakim Hove
9b370dcad1
Merge pull request #1739 from wito/welspecs-report-refactor
...
Add Unit System awareness to WELSPECS reports
2020-05-04 10:46:20 +02:00
Joakim Hove
35dc429aa4
Sort IUAD output vectr on UDQ input index
2020-05-04 10:23:16 +02:00
Joakim Hove
5c2a8b9fc4
Update UDQActive when UDA is used in WELTARG
2020-05-04 10:23:00 +02:00
Joakim Hove
9a4c8f754e
Change type of new value argument in WELTARG to UDA
2020-05-04 08:29:34 +02:00
Håvard Berland
f6318ee271
WELTARG keyword can have UDA-data in E100
2020-05-04 08:29:34 +02:00
Joakim Hove
ef77be1508
Refactor ScheduleTests to use fixture function
2020-05-04 08:29:34 +02:00
Joakim Hove
4fa0c93ff7
Merge pull request #1759 from joakim-hove/rename-segdist
...
Connection - Segment interaction implemented with optional pair
2020-05-01 08:52:03 +02:00
Bård Skaflestad
021d946a96
Merge pull request #1769 from joakim-hove/is-udq-regexp
...
Update regexp to allow for digits in UDQ name
2020-04-30 16:32:17 +02:00
Joakim Hove
8b70e42e0f
Connection - Segment interaction implemented with optional pair
2020-04-30 14:54:21 +02:00
Joakim Hove
94defc8a08
Merge pull request #1768 from atgeirr/add-missing-include
...
Add missing include statement.
2020-04-30 12:28:19 +02:00
Joakim Hove
29dd594d48
Update regexp to allow for digits in UDQ name
2020-04-30 12:10:34 +02:00
Joakim Hove
b8ab03b22b
Merge pull request #1767 from joakim-hove/remove-unused-include
...
Remove #include which is not needed
2020-04-30 12:03:39 +02:00
Atgeirr Flø Rasmussen
b9cdaafed3
Add missing include statement.
2020-04-30 11:55:32 +02:00
Williham Williham Totland
87ca9077ea
Implements group hierarchy data subreport.
2020-04-30 10:27:12 +02:00
Joakim Hove
57cfeeb854
Remove #include which is not needed
2020-04-30 10:23:44 +02:00
Joakim Hove
e4c6cc3de0
Merge pull request #1764 from akva2/fix_focal_packaging
...
changed: remove multiarch-support predepends
2020-04-30 10:21:15 +02:00
Williham Williham Totland
4663e49e23
Group hierarchy report interface.
2020-04-30 09:33:06 +02:00
Arne Morten Kvarving
58269dd675
changed: remove multiarch-support predepends
...
no longer required in ubuntu bionic, and breaks ubuntu focal,
and in any case it is support by both platforms.
2020-04-30 09:12:50 +02:00
Bård Skaflestad
fc69eb7b72
Merge pull request #1746 from joakim-hove/network
...
Network
2020-04-29 17:00:54 +02:00
Joakim Hove
c7008d329a
Add class ExtNetwork for extended networks
2020-04-29 15:45:18 +02:00
Bård Skaflestad
27b348b013
Merge pull request #1749 from bska/fix-krgr
...
Fix Default Value Initializers for Field Properties KR*R
2020-04-29 14:32:58 +02:00
Bård Skaflestad
79bb8386d3
Sat-Func Initializers: Add End-Point Unit Tests
...
Exercises the initializers for SW{L,CR,U}, SO{W,G}CR, SG{L,CR,U}, as
well as the function values KRW, KRWR, KRG, KRGR, KRO, KRORW, KRORG
and capillary pressure function values PCW and PCG.
Example data from region one (1) of
opm-tests/model1/include/sattab_basemod1.sattab
Example phrased both as family I (S*OF) and as family II (S*FN, SOF3).
2020-04-29 13:33:51 +02:00
Bård Skaflestad
146be0aa21
SOGCR: Pull SGOF Handling Into Initializer
...
This is in any case needed to calculate correct KRGR default values
in runs using family I saturation function keywords (S*OF) and also
removes the need to apply the special 'subtract_swl' operation in
this case. Overall this is a simplification of the code since we
now have all saturation end-points available when initializing
saturation function field properties.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
137ef7a17b
Sat-Func Initializers: Use RawTableEndPoints for KRGR
...
This commit reimplements the findKrgr helper function in terms of
the RawTableEndPoints aggregate. In particular, this commit aims to
underscore the fact that KRGR is the relative permeability of gas at
the displacing saturation
1 - Socr - Swco
This fact is hopefully more apparent in this revised than the
existing implementation since we now rely explicitly on evaluating
the 'KrgColumn' at an index derived from looking up that saturation
value in the pertinent saturation column.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
c8048021d1
Sat-Func Initializers: Use RawTableEndPoints for KRWR
...
This commit reimplements the findKrwr helper function in terms of
the RawTableEndPoints aggregate. In particular, this commit aims to
underscore the fact that KRWR is the relative permeability of water
at the displacing saturation
1 - Socr - Sgco
This fact is hopefully more apparent in this revised than the
existing implementation since we now rely explicitly on evaluating
the 'KrwColumn' at an index derived from looking up that saturation
value in the pertinent saturation column.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
58764a6ec6
Sat-Func Initializers: Use RawTableEndPoints for KRORW
...
This commit reimplements the findKrorw helper function in terms of
the RawTableEndPoints aggregate. In particular, this commit aims to
underscore the fact that KRORW is the relative permeability of oil
in the Oil/Water system at the displacing saturation
1 - Swcr - Sgco
This fact is hopefully more apparent in this revised than the
existing implementation since we now rely explicitly on evaluating
the 'KrowColumn' at an index derived from looking up that saturation
value in the pertinent saturation column.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
b17b4c1375
Sat-Func Initializers: Use RawTableEndPoints for KRORG
...
This commit reimplements the findKrorg helper function in terms of
the RawTableEndPoints aggregate. In particular, this commit aims to
underscore the fact that KRORG is the relative permeability of oil
in the Oil/Gas system at the displacing saturation
1 - Sgcr - Swco
This fact is hopefully more apparent in this revised than the
existing implementation since we now rely explicitly on evaluating
the 'KrogColumn' at an index derived from looking up that saturation
value in the pertinent saturation column.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
3817524f52
Sat-Func Initializers: Adjust Whitespace and Fix a Variable Name
...
The name 'max_krw' reflects the actual value better than the
existing name 'krwr'.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
f6cfadd62f
Sat-Func Initializers: Use Precalculated Endpoints Where Possible
2020-04-29 13:33:51 +02:00
Bård Skaflestad
af34e083c2
Sat-Func Initializers: Include <algorithm> and <iterator>
...
Needed to bring in declarations of std::distance, std::reverse, and
std::upper_bound.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
2984cca164
Sat-Func Properties: Provide All Raw Endpoints to All Initializers
...
This is in preparation of fixing the initializers for the KR*R
properties. The default values here generally depend on critical
and connate saturations of other phases extracted from the raw input
table values. This commit therefore creates an aggregate structure
RawTableEndPoints
that collects the connate gas and water saturations, the full set of
critical saturations, and the maximum gas and water saturations from
all input tables (meaning for all regions and drainage/imbibition
regime designators). Each *Endpoint() function furthermore gets a
new parameter of this type to preserve a uniform signature.
Note that we currently calculate the complete set of these endpoints
for each call to satfunc::init(), but may choose to expose this
structure to the caller at a later time in order to reduce the
overhead of these repeated calculations.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
6615030fab
Sat-Func Region Apply: Remove 'ACTNUM' Pointer
...
We always call these functions on all active cells so there's no
need to have checks for ACTNUM-like cell subsets.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
a4fc7ab05d
Sat-func Region Apply: Split Region ID Check out to Helper
...
Mostly to reduce cognitive load when reading the *Apply() functions'
implementations.
2020-04-29 13:33:51 +02:00
Bård Skaflestad
8f64405ace
Reduce Saturation Function Initialization API
...
The individual property initialization functions aren't used
directly anymore. Put them in an anonymous namespace in the
implementation file so that no client can take their address. This
is in preparation of adding TOLCRIT support.
2020-04-29 13:33:51 +02:00
Markus Blatt
eeb63d8694
Merge pull request #1758 from blattms/mark-openmp-as-prereq
...
Mark OpenMP as prerequisite for opm-common
2020-04-29 12:57:02 +02:00
Williham Williham Totland
cb8ddfd8aa
Minor style consistency tweaks.
2020-04-29 11:30:30 +02:00
Joakim Hove
8201728973
Merge pull request #1760 from joakim-hove/python-package-path
...
Python files should go in $PREFIX/dist-packages on debian
2020-04-29 10:49:20 +02:00
Williham Williham Totland
77a0ee13ac
Implements perf range.
2020-04-29 10:15:23 +02:00
Joakim Hove
512c2e4c1e
Python files should go in $PREFIX/dist-packages on debian
2020-04-29 10:03:08 +02:00
Williham Williham Totland
a4111fa672
Projects the unit system from the callsite.
2020-04-29 08:40:17 +02:00
Williham Williham Totland
78c19a3aba
Minor style tweaks.
2020-04-29 08:33:26 +02:00
Williham Williham Totland
fbe9d0dec2
Refactors number formatting.
2020-04-29 08:33:26 +02:00
Williham Williham Totland
305b4b21a7
Implements unit conversion for connection factor.
2020-04-29 08:33:26 +02:00
Williham Williham Totland
5e5aadb4ea
Adds unit conversions.
2020-04-29 08:33:26 +02:00
Williham Williham Totland
84ff359b64
Minor formatting tweaks.
2020-04-29 08:33:24 +02:00
Williham Williham Totland
40a8651d68
Adds units to table definitions.
2020-04-29 08:32:31 +02:00
Williham Williham Totland
e365ca3f7d
Projects the context into header printing.
2020-04-29 08:32:31 +02:00
Williham Williham Totland
a62fdad192
Reworks projection of the unit system.
2020-04-29 08:32:31 +02:00
Joakim Hove
6be2217935
Merge pull request #1757 from joakim-hove/remove-unused-function
...
Remove unused function from Group output data
2020-04-28 17:18:54 +02:00
Joakim Hove
9956492730
Remove unused function from Group output data
2020-04-28 16:17:43 +02:00
Joakim Hove
ad536b718b
Merge pull request #1754 from blattms/find-zoltan-only-with-mpi
...
[CMake] Find Zoltan only if MPI is available.
2020-04-28 14:50:08 +02:00
Markus Blatt
a87e6f281d
Quietly searcg for OpenMP in opm-common-prereqs.cmake
2020-04-28 12:58:39 +02:00
Markus Blatt
bb185a23ce
Mark OpenMP as prerequisite for opm-common
...
to automatically trigger find_package(OpenMP) in downstream
modules (e.g. Dumux)
2020-04-28 11:35:16 +02:00
Joakim Hove
f7bbf92e3a
Merge pull request #1752 from joakim-hove/remove-keywords
...
Suggestion: Remove unsupported E300 keywords
2020-04-27 19:21:15 +02:00
Bård Skaflestad
a89d053cae
Merge pull request #1743 from bska/grppot-eff-fac-aware
...
Summary Output: Make Group Potentials Aware of Efficiency Factors
2020-04-27 16:55:08 +02:00
Joakim Hove
1758439c03
Merge pull request #1753 from blattms/fix-openmp-for-newer-cmake-master
...
Use OpenMP::OpenMP_CXX taget when linking libopmcommon
2020-04-27 16:08:35 +02:00
Markus Blatt
b6dd398c32
Find Zoltan only if MPI is available.
...
Otherwise we experience compilation errors if OPM is configured with
deactivated MPI and activated and found dune-alugrid (cpmpile error
that mpi.h is not found). This commit fixes this for me.
2020-04-27 16:00:49 +02:00
Markus Blatt
0ebe62a1d5
Use OpenMP::OpenMP_CXX target when linking libopmcommon
...
This should allow downstream to automatically use the correct
compile and linke flags for CMake > 3.9. For older versions
we fall back to the old approach.
Closes #1751
2020-04-27 12:54:18 +02:00
Bård Skaflestad
96a2350bf3
Summary Output: Make Group Potentials Aware of Efficiency Factors
...
As with all rate-like quantities, the *EFAC values affect the group
tree level above the level where the factor is applied
2020-04-27 10:56:48 +02:00
Joakim Hove
41803f5291
Remove unsupported E300 keywords
2020-04-27 10:33:45 +02:00
Joakim Hove
7468499855
Merge pull request #1750 from OPMUSER/master
...
Update to Water Vaporization Keywords to be Consistent
2020-04-27 09:40:25 +02:00
Bård Skaflestad
0eeb3243fb
Merge pull request #1737 from joakim-hove/rsm-fixup
...
Small fixes to RSM output
2020-04-27 08:53:38 +02:00
OPMUSER
8a0e0c823c
Add PVTGW, PVTGWO and RWGSALT
...
Will also add to Missing Features.
2020-04-27 13:45:35 +08:00
Joakim Hove
fa70f4dce1
Use ESmry::loadData() to preload all summary vectors
2020-04-27 07:04:45 +02:00
Joakim Hove
a92894f4d4
Small fixes to RSM output
...
- MAI -> MAY
- Update text header with simulation time and flow version
- Make sure the YEARS column is always the first column on page 1
2020-04-27 07:04:45 +02:00
OPMUSER
800d98c038
Update keyword_list.cmake with PERMFACT
...
Update keyword_list.cmake with PERMFACT
2020-04-27 12:51:55 +08:00
OPMUSER
297f90a88a
Rename PERMRED to PERMFACT
...
As per TNO rename PERMRED to PERMFACT to match documentation.
2020-04-27 12:32:17 +08:00
Bård Skaflestad
67b2d5c185
Merge pull request #1748 from tskille/esmry_improvements
...
improved efficiency when opening summary files.
2020-04-26 23:03:02 +02:00
Torbjørn Skille
43f1739dfa
improved efficiency when opening summary files.
...
> loading only arrays that is used (DIMENS, RESTART, KEYWORDS, NUMS and UNITS)
> smspec file now only loading arrays once (twice before)
2020-04-26 18:24:01 +02:00
Bård Skaflestad
a78aa78248
Merge pull request #1747 from akva2/fix_int_abs
...
fixed: do not use integer abs
2020-04-26 13:39:00 +02:00
Arne Morten Kvarving
751a1c28fa
fixed: do not use integer abs
2020-04-26 12:32:27 +02:00
Bård Skaflestad
380f85ed7e
Merge pull request #1732 from joakim-hove/welspecs-report-refactor
...
Welspecs report refactor
2020-04-26 00:09:26 +02:00
Joakim Hove
7a2539b1f2
Merge pull request #1742 from joakim-hove/pr-keywords
...
Add keyword PRVD
2020-04-25 21:39:36 +02:00
Joakim Hove
c6b367e51e
Merge pull request #1745 from bska/wellgraph-handle-dashed-names
...
Wellgraph: Quote Names to Transparently Handle Dashes
2020-04-25 21:20:14 +02:00
Bård Skaflestad
24ab7e5ff4
Wellgraph: Quote Names to Transparently Handle Dashes
...
This way, the dot(1) program won't generate errors like
Badly delimited number 1_ splits into two tokens
when presented with a well name like 'INJE-1_N'.
2020-04-25 16:21:30 +02:00
Bård Skaflestad
775bce0b2f
Merge pull request #1744 from atgeirr/add-wellgraph
...
Add 'wellgraph' utility program.
2020-04-25 14:24:50 +02:00
Atgeirr Flø Rasmussen
3d9a12efcb
Add 'wellgraph' utility program.
2020-04-25 12:37:21 +02:00
Joakim Hove
7d2262e022
Merge pull request #1738 from joakim-hove/summary-YEARS
...
Summary years
2020-04-24 16:34:31 +02:00
Joakim Hove
e0df1cd470
Add keyword PRVD
2020-04-24 14:51:46 +02:00
Joakim Hove
162fcfc73b
Merge pull request #1740 from OPMUSER/master
...
Create HMMULTSG
2020-04-24 14:47:21 +02:00
Joakim Hove
6264bab6b0
Summary compare ESmry and ERsm - looser tolerance
2020-04-24 14:42:42 +02:00
OPMUSER
2189a7efcd
Update keyword_list.cmake
2020-04-24 18:53:39 +08:00
OPMUSER
8dff4ecef1
Create HMMULTSG
...
Create HMMULTSG definition
2020-04-24 17:45:26 +08:00
Joakim Hove
5781350bd4
Unconditionally add YEARS to summary output
2020-04-24 10:19:53 +02:00
Joakim Hove
4f0fa5c21a
Introduce time unit ecl_years == 365.25 days
2020-04-24 10:19:53 +02:00
Williham Williham Totland
06f32f3d37
Projects unit type into columns.
2020-04-24 09:49:18 +02:00
Joakim Hove
b6c1e8a27e
Refactor WELSPECS reports
2020-04-24 07:34:22 +02:00
Joakim Hove
1e77c1510d
Merge pull request #1733 from joakim-hove/branches
...
Add method WellSegments::branches()
2020-04-23 22:28:51 +02:00
Bård Skaflestad
e57d11fe38
Merge pull request #1735 from joakim-hove/branch-segments-fixup
...
Segment sorting - check if already in order
2020-04-23 10:22:36 +02:00
Joakim Hove
f3d2b95896
Segment sorting - check if already in order
2020-04-23 06:44:53 +02:00
Bård Skaflestad
cd8b32acac
Merge pull request #1734 from joakim-hove/connections-empty
...
Update connections should hanlde empty list
2020-04-22 20:02:10 +02:00
Joakim Hove
b26b4c2c77
Update connections should hanlde empty list
2020-04-22 17:33:30 +02:00
Joakim Hove
e7f750da83
Add method WellSegments::branches()
2020-04-22 17:03:03 +02:00