IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity
27,342 Commits 23 Branches 244 Tags 636 MiB
96d28f2f02
Commit Graph

27342 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Robert Fewell
cc5029bb4d Disable saving the gtk_accel_map 
It seems that it only saves the loaded map entries and if the original
accelelerator-map file has commented out entries they are lost.
 2023-03-18 10:58:07 +00:00
Robert Fewell
6a3013046f Change gnc_add_accelerator_keys_for_menu 
To allow the menu short cuts to be changed by the use of an
accelerator-map file, this function adds scanning the gtk accelerator
map and if any changes are found updates the GMenuModel, GMenuItem
 2023-03-18 10:58:07 +00:00
Robert Fewell
e8b0d4dd87 Change gnc_menubar_model_update_item to also update accelerator keys 2023-03-18 10:58:07 +00:00
Robert Fewell
0098b047d5 Only add the accelerator key to the menu item once 2023-03-18 10:58:07 +00:00
Robert Fewell
85f462feb5 On a Mac, some keyboard short cuts are missing 
Sync the menu bar after the menus have been updated.
 2023-03-18 10:58:02 +00:00
John Ralls
207b105b9c Merge Brian Rater's '798570' into maint. 2023-03-17 13:09:36 -07:00
Richard Cohen
24f52d9b17 Remove incorrect operator!= for GncItem 
It's better to use the default std::pair implementation

- spotted by clang-tidy bugprone-suspicious-string-compare
- will always return false, because type is the same

Also,
- remove redundant "using GncItem ..."
 2023-03-17 16:50:17 +00:00
Richard Cohen
b5f3f99035 Fix incorrect use of remove_if() 
- spotted by clang-tidy bugprone
- probably no visible effects because of uniqueness, and other checks

libgnucash/engine/gnc-optiondb.cpp:149:5: warning: this call will remove at most one item even when multiple items should be removed [bugprone-inaccurate-erase]
    m_options.erase(std::remove_if(m_options.begin(), m_options.end(),
    ^

libgnucash/engine/gnc-optiondb.cpp:358:5: warning: the value returned by this function should be used [bugprone-unused-return-value]
    std::remove_if(m_callbacks.begin(), m_callbacks.end(),
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libgnucash/engine/gnc-optiondb.cpp:358:5: note: cast the expression to void to silence this warning
 2023-03-17 16:50:11 +00:00
BLR
372a36eeb9 798570 Budget totals for income, expenses and remaining to budget incorrect when increasing the number of periods. 2023-03-17 09:13:47 -04:00
John Ralls
b4b8431984 Bug 798778 - GnuCashquits abruptly when attempting to edit options… 
for certain reports.

Those reports being ones using complex options, apparently because
the callbacks weren't protected from Guile's garbage collector.

So replace the anyway ugly hack of a void* with a std::any wrapping
a class holding a std::unique_ptr with a custom deleter. The
constructor calls scm_gc_protect_object on the SCM containing the
callback and the custom deleter calls scm_gc_unprotect_object. The
copy constructor, required for std::any, makes a new std::unique_ptr
and calls scm_gc_protect_object again ensuring that the protect and
unprotect calls are symmetrical.

Meanwhile std::any hides the Guile dependency from all the classes
that don't need to know about it. The only ugliness is that there's
no good place to put a common implementation of SCNCallbackWrapper so it's
repeated in gnc-optiondb.i and dialog-options.cpp.
 2023-03-16 17:50:06 -07:00
John Ralls
144b6ae090 Merge Richard Cohen's 'fix-gnc-gui-debug-crash' into master. 2023-03-16 14:01:53 -07:00
J0kWang
898f9a6e59 Eliminate translation ambiguity 
Eliminate translation ambiguity of "For"
 2023-03-16 13:58:51 -07:00
John Ralls
047dad29c2 Merge Richard Cohen's 'show-log-window-should-show-the-window' into master. 2023-03-16 11:30:12 -07:00
John Ralls
68ece42440 Merge Richard Cohen's 'replace-deprecated-gdk-screen-width-height' into master. 2023-03-16 10:01:39 -07:00
Christopher Lam
ef0c9deb7f [dialog-file-access] plug a char* leak 2023-03-16 23:18:47 +08:00
Richard Cohen
8e9c65c1eb Fix regression: Actions > Online Actions > Show log window 
.. does nothing

Action activate needs to change the state

Note that there is another bug (also present in maint) where the
menu entry does nothing the first time it is clicked
 2023-03-16 14:38:47 +00:00
Richard Cohen
f826240488 Always enable deprecation warnings for glib & gtk 
- Remove WARN_DEPRECATED_GLIB/GTK
 2023-03-16 13:39:21 +00:00
Christopher Lam
dd0d65d861 [1/2] [gnc-filepath-utils.cpp] gnc_filename_is_backup|datafile 
uses std::regex to test filename
 2023-03-16 18:01:09 +08:00
Robert Fewell
f6d013847d Fix copy-paste error in gnc-plugin-page-account-tree.ui 2023-03-16 09:28:39 +00:00
Christopher Lam
267aa4bf42 [dialog-file-access] g_free a char* in FileAccessWindow struct 2023-03-15 21:26:04 +08:00
Richard Cohen
30586ac3e6 Push -Wno-error=deprecated-declarations from C*_FLAGS down to the target 2023-03-15 10:34:14 +00:00
Richard Cohen
e6a072e906 Replace deprecated gdk_screen_width/height 2023-03-15 09:40:50 +00:00
Richard Cohen
f38526c091 Remove some unnecessary null checks before g_free 2023-03-15 09:40:50 +00:00
Richard Cohen
b46d81e5e0 Correct some DEBUG messages 2023-03-15 09:40:50 +00:00
Richard Cohen
252b169414 Refactor: Extract method set_window_geometry() 2023-03-15 09:40:50 +00:00
Richard Cohen
1c496c4bd5 Fix crash with --log gnc.gui=debug 
gnc_main_window_update_one_menu_action() will try to print
data.action_name
 2023-03-15 09:39:38 +00:00
Geert Janssens
1f0a69a804 Properly parse plus signs while importing numbers 
Silly copy/paste error.
 2023-03-15 08:58:07 +01:00
John Ralls
3d1ad8581b Bug 798787 - gnc-register-owner-option currently broken 
Use the right option type now that it works right.
 2023-03-14 16:11:39 -07:00
John Ralls
5de35f97c8 Fix gnc_owner_get_owner so that it sets the owner type. 
Using the instance's QofIdType.
 2023-03-14 16:11:39 -07:00
John Ralls
a44b3664e2 [c++options] Implement GncOptionGncOwnerValue class. 
GncOwners aren't QofInstances and have limited lifetimes so an option
must hold its own, wrapped in std::unique_ptr for memory management.
 2023-03-14 16:11:39 -07:00
John Ralls
8db8105850 [c++options] Warn when an option variant type's set_value isn't found. 2023-03-14 16:11:39 -07:00
BLR
4cc766b07a budget totals for one period would be wrong when increasing the number of periods. 2023-03-14 13:52:06 -04:00
John Ralls
83829e6513 Merge branch 'maint' 2023-03-14 10:43:45 -07:00
John Ralls
1020bde89c Fix crashes in test-engine on Arch Linux. 
Root cause is mutating a list while it's iterating. We're able to
protect it in two cases, have to copy it in xaccTransScrubGainsDate.
 2023-03-14 10:33:39 -07:00
Christopher Lam
52a713e009 Fix GtkCellRenderer* leak in price import 2023-03-14 20:43:08 +08:00
Geert Janssens
f9ebbf60d1 Fix price import file loading 2023-03-14 12:44:01 +01:00
Christopher Lam
6db868ab64 Refactor std::any_of into lambda 
Rewrite 16cc218097 to avoid the lambda accessing external variable
is_req_column_type
 2023-03-14 18:18:56 +08:00
John Ralls
be88133b15 Merge branch 'maint' 2023-03-13 21:31:44 -07:00
John Ralls
946fbb12c5 Merge latest translations from Weblate into maint. 2023-03-13 21:23:55 -07:00
John Ralls
21ae99dedd Merge latest translations from weblate into master. 2023-03-13 21:17:24 -07:00
Wellington Terumi Uemura
ba9878f16a
Translation update by Wellington Terumi Uemura <wellingtonuemura@gmail.com> using Weblate 
po/pt_BR.po: 100.0% (5401 of 5401 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Portuguese (Brazil))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pt_BR/
 2023-03-14 04:46:23 +01:00
Arve Eriksson
008261f596
Translation update by Arve Eriksson <031299870@telia.com> using Weblate 
po/sv.po: 99.8% (5486 of 5494 strings; 8 fuzzy)
22 failing checks (0.4%)
Translation: GnuCash/Program-beta (Swedish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/sv/
 2023-03-14 04:46:17 +01:00
Wellington Terumi Uemura
7c9900d620
Translation update by Wellington Terumi Uemura <wellingtonuemura@gmail.com> using Weblate 
po/pt_BR.po: 92.5% (5084 of 5494 strings; 270 fuzzy)
123 failing checks (2.2%)
Translation: GnuCash/Program-beta (Portuguese (Brazil))
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/pt_BR/
 2023-03-14 04:46:16 +01:00
J0kWang
7352c72d1b
Translation update by J0kWang <lianjiefly@gmail.com> using Weblate 
po/zh_CN.po: 93.1% (5118 of 5494 strings; 256 fuzzy)
156 failing checks (2.8%)
Translation: GnuCash/Program-beta (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/zh_Hans/
 2023-03-13 20:02:41 +01:00
Jaime Marquínez Ferrándiz
4d5c75e776
Translation update by Jaime Marquínez Ferrándiz <jaime.marquinez.ferrandiz@fastmail.net> using Weblate 
po/es.po: 99.6% (5475 of 5494 strings; 1 fuzzy)
12 failing checks (0.2%)
Translation: GnuCash/Program-beta (Spanish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/es/
 2023-03-13 20:02:40 +01:00
Guille Lopez
12ef1fdd2b
Translation update by Guille Lopez <willelopz@gmail.com> using Weblate 
po/es.po: 99.6% (5475 of 5494 strings; 1 fuzzy)
12 failing checks (0.2%)
Translation: GnuCash/Program-beta (Spanish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/es/
 2023-03-13 20:02:40 +01:00
Jaime Marquínez Ferrándiz
defa2719c5
Translation update by Jaime Marquínez Ferrándiz <jaime.marquinez.ferrandiz@fastmail.net> using Weblate 
po/es.po: 99.4% (5466 of 5494 strings; 3 fuzzy)
12 failing checks (0.2%)
Translation: GnuCash/Program-beta (Spanish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/es/
 2023-03-13 20:02:40 +01:00
Guille Lopez
b3aaea5661
Translation update by Guille Lopez <willelopz@gmail.com> using Weblate 
po/es.po: 99.4% (5466 of 5494 strings; 3 fuzzy)
12 failing checks (0.2%)
Translation: GnuCash/Program-beta (Spanish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/es/
 2023-03-13 20:02:40 +01:00
Pedro Albuquerque
bbfbf7e31e
Translation update by Pedro Albuquerque <pmra@gmx.com> using Weblate 
po/pt.po: 100.0% (5494 of 5494 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program-beta (Portuguese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/pt/
 2023-03-13 20:02:40 +01:00
Guille Lopez
f39a678e4b
Translation update by Guille Lopez <willelopz@gmail.com> using Weblate 
po/es.po: 99.1% (5446 of 5494 strings; 11 fuzzy)
12 failing checks (0.2%)
Translation: GnuCash/Program-beta (Spanish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/program-beta/es/
 2023-03-13 20:02:40 +01:00