Commit Graph

27511 Commits

Author SHA1 Message Date
John Ralls
43b161c28b [stock-txn-asst] Add comments explaining workings. 2023-06-10 18:24:07 -07:00
John Ralls
f4ac1f40fe [stock-txn-asst] Extract page classes for StockAssistantView. 2023-06-10 18:24:07 -07:00
John Ralls
fdfa8353dd [stock-txn-asst] Extract StockTransactionEntry classes. 2023-06-10 18:24:07 -07:00
John Ralls
b3b071e011 [stock-txn-asst] StockAssistantModel variable names
Rename member variables with m_ prefix, remove this-> from
in-class references to those variables.
2023-06-10 18:24:07 -07:00
John Ralls
cebc7198f2 [stock-txn-asst] Reformat StockAssistantModel
Moving the ctor and dtor to immediately after the variables and
moving the longer function defs out of the class decl.
2023-06-10 18:24:07 -07:00
John Ralls
925999e070 [stock-txn-asst] Refactor check_page into a constructor.
Because it is one.
2023-06-10 18:24:07 -07:00
John Ralls
4ebc028740 [stock-txn-asst] Refactor gtest-assistant-stock-transaction.cpp
For better readability. Removes gratuitous parameterized test
suite because the StockAssistantModel is stateful and can't
use easyTestCases when it and the book are re-created for
each instance, as is the case when the easyTestCases is passed
as a parameter set to a test suite.

Also replaced the shared_ptr<QofBook> with a unique_ptr.
2023-06-10 18:24:07 -07:00
John Ralls
74f707bfa7 [asst-stock-trans] StockAssistantModel instance variable names
Should start with m_. Also designating them with this-> isn't
idiomatic or necessary, and long functions shouldn't be defined
in the class/struct body.
2023-06-10 18:24:07 -07:00
John Ralls
6d36d1d7ee [asst-stock-trans] Rename primary callbacks to clarify their purpose. 2023-06-10 18:24:07 -07:00
Christopher Lam
0d9dd3b789 [assistant-stock-transaction] support additional txn_types 2023-06-10 18:24:07 -07:00
Christopher Lam
55046f22d2 reduce number of bools in txn_type info: fees_capitalize 2023-06-10 18:24:07 -07:00
Christopher Lam
d67f0b3c99 reduce number of bools in txn_type info: input_new_balance
input_new_balance merged into stock_amount FieldMask
2023-06-10 18:24:07 -07:00
Christopher Lam
d92d5b4bd2 test suite for assistant-stock-transaction.cpp 2023-06-10 18:24:03 -07:00
Christopher Lam
f36e5d56ed [assistant-stock-transaction] refactor using MVC 2023-06-10 18:21:00 -07:00
John Ralls
9b95419608 Fix glib include. 2023-05-11 11:56:23 -07:00
John Ralls
d696f0cfcb Bug 798885 - Accented character in folder name on Account Export (bis)
Pass a boost::filesystem's c_str() rv to the ofstream constructor to
keep libstdc++ from transcoding it back to UTF8 and creating a broken
name or failing to match the directory name. Implemented in
gnc-filepath-utils to avoid spreading the boost::filesystem dependency
throughout the code base.

See https://github.com/boostorg/filesystem/issues/181 for why other
approaches don't work.
2023-05-08 13:35:21 -07:00
John Ralls
73337cff5a Merge updated gnucash.pot. 2023-05-05 15:07:17 -07:00
John Ralls
a6b295178f Merge latest translations from weblate. 2023-05-05 15:00:25 -07:00
Szia Tomi
b3b7b598b2
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/hu.po: 68.8% (3788 of 5502 strings; 626 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2023-05-05 23:59:18 +02:00
John Ralls
6be654c77d Bug 798597 - The word "Separators" needs two separate versions
Use "Character-separated" when it's a choice between that and fixed
field width and "Select Separator Character" when it's a heading.
2023-05-05 14:58:52 -07:00
John Ralls
5fda252444 Bug 798839 - Edit -> Preferences string not translatable (bis) 2023-05-05 13:51:53 -07:00
John Ralls
1b3c693d7d Bug 798862 - Merge identical strings (bis)
Ensure similar strings are identical and use double line view instead
of double line mode.
2023-05-05 12:57:58 -07:00
John Ralls
4e99731241 Merge latest translations from Weblate. 2023-05-05 12:32:20 -07:00
cjh
0eecebfef7
Translation update by cjh <cjh@cjh0613.com> using Weblate
po/zh_CN.po: 94.1% (5179 of 5502 strings; 201 fuzzy)
81 failing checks (1.4%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: cjh <cjh@cjh0613.com>
2023-05-05 21:30:17 +02:00
Szia Tomi
95670ea5bc
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/hu.po: 68.8% (3788 of 5502 strings; 626 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/hu.po: 68.8% (3788 of 5502 strings; 626 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/glossary/hu.po: 100.0% (216 of 216 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2023-05-05 21:30:16 +02:00
Kaligula
4228ed0bf5
Translation update by Kaligula <kaligula.dev@gmail.com> using Weblate
po/pl.po: 69.9% (3850 of 5502 strings; 1111 fuzzy)
317 failing checks (5.7%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Co-authored-by: Kaligula <kaligula.dev@gmail.com>
2023-05-05 21:30:15 +02:00
Milo Ivir
1b5ec4d457
Translation update by Milo Ivir <mail@milotype.de> using Weblate
po/hr.po: 97.4% (5363 of 5502 strings; 40 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Croatian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hr/

Co-authored-by: Milo Ivir <mail@milotype.de>
2023-05-05 21:30:14 +02:00
mocsa
eb75cd2ef3
Translation update by mocsa <csaba@feltoltve.hu> using Weblate
po/hu.po: 68.8% (3788 of 5502 strings; 626 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 68.8% (3787 of 5502 strings; 627 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 68.4% (3764 of 5502 strings; 638 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 67.9% (3741 of 5502 strings; 651 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: mocsa <csaba@feltoltve.hu>
2023-05-05 21:30:13 +02:00
Pedro Albuquerque
5defc901f8
Translation update by Pedro Albuquerque <pmra@gmx.com> using Weblate
po/pt.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Portuguese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pt/

Co-authored-by: Pedro Albuquerque <pmra@gmx.com>
2023-05-05 21:30:13 +02:00
Geert Janssens
84b64233d7 Bug 798899 - Gnucash crashes during CSV import when using a template if the destination account is changed from one used in the template 2023-05-03 16:38:05 +02:00
John Ralls
43eb36c311 Release GnuCash 5.1 2023-04-30 09:10:10 -07:00
YOSHINO Yoshihito
450a634f81 Fix Encoding on wrong line. 2023-04-30 09:10:10 -07:00
John Ralls
0ecafc93ed Correct CMake distribution.
Remove deleted gnc-fq-helper.1 and gnc-fq-dump.1 doc dependencies.
Add csv-exp/test to Dist.

add csv-exp/test
2023-04-30 09:10:10 -07:00
John Ralls
bb423e4484 Merge CrfzdPQM6's 'b_betterCurrencyBudgetReporting' into stable. 2023-04-29 12:04:45 -07:00
Daniel Johnson
04b0317119 Demonstrate fx handling in budget report 2023-04-29 12:01:36 -07:00
John Ralls
df878c6a3d Merge Maarten Bosmans's 'memleak-fixes' into stable. 2023-04-29 11:54:41 -07:00
Maarten Bosmans
71802b5627 [test] Fix memory leak in test-gnc-quotes
When the commodity table is registered, the current book will get
a default table assigned.  When later setting the table explicitly
using qof_book_set_data() the exisiting table gets overwritten and
is thus leaked.

There is no way of removing or freeing a currency table from a book,
so the best we can do here is to set our own table on the book before
calling gnc_commodity_table_register().
2023-04-29 11:52:12 -07:00
Maarten Bosmans
6be682b645 Store allocated temporaries in a variable so they can be freed
If a function that returns an allocated pointer is passed directly into
something that does not take ownership of the pointer, the allocation is
leaked.  This can be fixed by assigning the pointer to a new variable
and freeing it after operation on the memory.
2023-04-29 11:51:43 -07:00
John Ralls
168765cf77 Merge latest translations from Weblate. 2023-04-29 11:02:34 -07:00
YOSHINO Yoshihito
313d3ebe12
Translation update by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate
po/ja.po: 89.8% (4941 of 5502 strings; 225 fuzzy)
433 failing checks (7.8%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 89.7% (4939 of 5502 strings; 227 fuzzy)
435 failing checks (7.9%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 89.7% (4938 of 5502 strings; 228 fuzzy)
435 failing checks (7.9%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 89.5% (4929 of 5502 strings; 235 fuzzy)
436 failing checks (7.9%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Co-authored-by: YOSHINO Yoshihito <yy.y.ja.jp@gmail.com>
2023-04-29 19:53:51 +02:00
mocsa
cdd59d79d2
Translation update by mocsa <csaba@feltoltve.hu> using Weblate
po/hu.po: 67.9% (3741 of 5502 strings; 651 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 67.9% (3740 of 5502 strings; 651 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by mocsa <csaba@feltoltve.hu> using Weblate

po/hu.po: 67.9% (3739 of 5502 strings; 651 fuzzy)
25 failing checks (0.4%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: mocsa <csaba@feltoltve.hu>
2023-04-29 19:53:51 +02:00
Andi Chandler
bb68845e94
Translation update by Andi Chandler <andi@gowling.com> using Weblate
po/en_GB.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (English (United Kingdom))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/en_GB/

Co-authored-by: Andi Chandler <andi@gowling.com>
2023-04-29 19:53:51 +02:00
Arve Eriksson
ca87cc774f
Translation update by Arve Eriksson <031299870@telia.com> using Weblate
po/sv.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Swedish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/sv/

Co-authored-by: Arve Eriksson <031299870@telia.com>
2023-04-29 19:53:50 +02:00
Yuri Chornoivan
c904428916
Translation update by Yuri Chornoivan <yurchor@ukr.net> using Weblate
po/uk.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Ukrainian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/uk/

Co-authored-by: Yuri Chornoivan <yurchor@ukr.net>
2023-04-29 19:53:50 +02:00
gallegonovato
0a8fa48336
Translation update by gallegonovato <fran-carro@hotmail.es> using Weblate
po/es.po: 100.0% (5502 of 5502 strings; 0 fuzzy)
2 failing checks (0.1%)
Translation: GnuCash/Program (Spanish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/es/

Co-authored-by: gallegonovato <fran-carro@hotmail.es>
2023-04-29 19:53:50 +02:00
Robert Fewell
5582e4793a Change the preference option 'Future transactions after blank transaction'
With the use of reverse sort, the preference option needs changing, use
'Placement of future transactions' with appropriate tooltip changes.
2023-04-29 10:49:02 -07:00
Robert Fewell
f3991639c8 Change tooltip for 'Blank Transaction' in register
Change the tooltip to mention moving to the blank transaction.
2023-04-29 10:49:02 -07:00
Robert Fewell
5663efa113 Add the blank transaction at top of register
When the register is sorted in reverse order, add the blank transaction
at the top of the register.
2023-04-29 10:48:52 -07:00
John Ralls
98776629eb Merge Kazuki Nishikawa's 'fix-ime-segv' into stable. 2023-04-29 10:41:47 -07:00
Kazuki Nishikawa
30da2b9a93 Prevent infinite recursion from gnucash_item_edit_focus_out.
When I try to use IME (e.g. fcitx) to narrow down a combo box,
infinite recursion occurs via `popup_set_focus` and GnuCash falls down
in SIGSEGV.

ref: https://github.com/Gnucash/gnucash/pull/1610#issuecomment-1528080452
2023-04-29 10:40:45 -07:00